[INFO] crate gcollections 1.4.0 is already in cache [INFO] extracting crate gcollections 1.4.0 into work/ex/clippy-test-run/sources/stable/reg/gcollections/1.4.0 [INFO] extracting crate gcollections 1.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gcollections/1.4.0 [INFO] validating manifest of gcollections-1.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gcollections-1.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gcollections-1.4.0 [INFO] finished frobbing gcollections-1.4.0 [INFO] frobbed toml for gcollections-1.4.0 written to work/ex/clippy-test-run/sources/stable/reg/gcollections/1.4.0/Cargo.toml [INFO] started frobbing gcollections-1.4.0 [INFO] finished frobbing gcollections-1.4.0 [INFO] frobbed toml for gcollections-1.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gcollections/1.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gcollections-1.4.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/gcollections/1.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 19a6dd83a00d825b3082b5e1db13e7e756ae73911e3e77086c26b0276e8af022 [INFO] running `"docker" "start" "-a" "19a6dd83a00d825b3082b5e1db13e7e756ae73911e3e77086c26b0276e8af022"` [INFO] [stderr] Checking trilean v1.0.1 [INFO] [stderr] Checking bit-set v0.2.0 [INFO] [stderr] Checking gcollections v1.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/libgcollections/ops/lattice.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | test_id: test_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `test_id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/libgcollections/ops/lattice.rs:116:9 [INFO] [stderr] | [INFO] [stderr] 116 | data_a: data_a, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `data_a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/libgcollections/ops/lattice.rs:117:9 [INFO] [stderr] | [INFO] [stderr] 117 | data_b: data_b, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `data_b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/libgcollections/ops/lattice.rs:118:9 [INFO] [stderr] | [INFO] [stderr] 118 | expected_entailment: expected_entailment, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `expected_entailment` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/libgcollections/ops/lattice.rs:119:9 [INFO] [stderr] | [INFO] [stderr] 119 | expected_join: expected_join, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `expected_join` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/libgcollections/ops/lattice.rs:120:9 [INFO] [stderr] | [INFO] [stderr] 120 | expected_meet: expected_meet [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `expected_meet` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/libgcollections/ops/lattice.rs:220:11 [INFO] [stderr] | [INFO] [stderr] 220 | let e = a.clone().join(b.clone()).join(c.clone()); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/libgcollections/ops/lattice.rs:223:11 [INFO] [stderr] | [INFO] [stderr] 223 | let f = d.clone().join(c.clone()); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/libgcollections/ops/lattice.rs:226:11 [INFO] [stderr] | [INFO] [stderr] 226 | let g = a.clone().join(a.clone()); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/libgcollections/ops/lattice.rs:227:11 [INFO] [stderr] | [INFO] [stderr] 227 | let h = b.clone().join(b.clone()); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/libgcollections/ops/lattice.rs:256:11 [INFO] [stderr] | [INFO] [stderr] 256 | let e = a.clone().meet(b.clone()).meet(c.clone()); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/libgcollections/ops/lattice.rs:259:11 [INFO] [stderr] | [INFO] [stderr] 259 | let f = d.clone().meet(c.clone()); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/libgcollections/ops/lattice.rs:262:11 [INFO] [stderr] | [INFO] [stderr] 262 | let g = a.clone().meet(a.clone()); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/libgcollections/ops/lattice.rs:263:11 [INFO] [stderr] | [INFO] [stderr] 263 | let h = b.clone().meet(b.clone()); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/libgcollections/wrappers/bit_set.rs:23:12 [INFO] [stderr] | [INFO] [stderr] 23 | BitSet{bs: bs} [INFO] [stderr] | ^^^^^^ help: replace it with: `bs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/libgcollections/wrappers/btree_set.rs:22:14 [INFO] [stderr] | [INFO] [stderr] 22 | BTreeSet{ts: ts} [INFO] [stderr] | ^^^^^^ help: replace it with: `ts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/libgcollections/wrappers/hash_set.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | HashSet{hs: hs} [INFO] [stderr] | ^^^^^^ help: replace it with: `hs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/libgcollections/wrappers/optional.rs:55:7 [INFO] [stderr] | [INFO] [stderr] 55 | value: value [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/libgcollections/wrappers/vector.rs:28:7 [INFO] [stderr] | [INFO] [stderr] 28 | vec: vec [INFO] [stderr] | ^^^^^^^^ help: replace it with: `vec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/libgcollections/wrappers/vector_deque.rs:33:7 [INFO] [stderr] | [INFO] [stderr] 33 | deque: deque [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `deque` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/libgcollections/queue.rs:28:7 [INFO] [stderr] | [INFO] [stderr] 28 | seq: seq, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `seq` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/libgcollections/stack.rs:27:7 [INFO] [stderr] | [INFO] [stderr] 27 | seq: seq, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `seq` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/libgcollections/ops/lattice.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | test_id: test_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `test_id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/libgcollections/ops/lattice.rs:116:9 [INFO] [stderr] | [INFO] [stderr] 116 | data_a: data_a, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `data_a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/libgcollections/ops/lattice.rs:117:9 [INFO] [stderr] | [INFO] [stderr] 117 | data_b: data_b, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `data_b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/libgcollections/ops/lattice.rs:118:9 [INFO] [stderr] | [INFO] [stderr] 118 | expected_entailment: expected_entailment, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `expected_entailment` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/libgcollections/ops/lattice.rs:119:9 [INFO] [stderr] | [INFO] [stderr] 119 | expected_join: expected_join, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `expected_join` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/libgcollections/ops/lattice.rs:120:9 [INFO] [stderr] | [INFO] [stderr] 120 | expected_meet: expected_meet [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `expected_meet` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/libgcollections/ops/lattice.rs:220:11 [INFO] [stderr] | [INFO] [stderr] 220 | let e = a.clone().join(b.clone()).join(c.clone()); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/libgcollections/ops/lattice.rs:223:11 [INFO] [stderr] | [INFO] [stderr] 223 | let f = d.clone().join(c.clone()); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/libgcollections/ops/lattice.rs:226:11 [INFO] [stderr] | [INFO] [stderr] 226 | let g = a.clone().join(a.clone()); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/libgcollections/ops/lattice.rs:227:11 [INFO] [stderr] | [INFO] [stderr] 227 | let h = b.clone().join(b.clone()); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/libgcollections/ops/lattice.rs:256:11 [INFO] [stderr] | [INFO] [stderr] 256 | let e = a.clone().meet(b.clone()).meet(c.clone()); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/libgcollections/ops/lattice.rs:259:11 [INFO] [stderr] | [INFO] [stderr] 259 | let f = d.clone().meet(c.clone()); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/libgcollections/ops/lattice.rs:262:11 [INFO] [stderr] | [INFO] [stderr] 262 | let g = a.clone().meet(a.clone()); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/libgcollections/ops/lattice.rs:263:11 [INFO] [stderr] | [INFO] [stderr] 263 | let h = b.clone().meet(b.clone()); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/libgcollections/wrappers/bit_set.rs:23:12 [INFO] [stderr] | [INFO] [stderr] 23 | BitSet{bs: bs} [INFO] [stderr] | ^^^^^^ help: replace it with: `bs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/libgcollections/wrappers/btree_set.rs:22:14 [INFO] [stderr] | [INFO] [stderr] 22 | BTreeSet{ts: ts} [INFO] [stderr] | ^^^^^^ help: replace it with: `ts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/libgcollections/wrappers/hash_set.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | HashSet{hs: hs} [INFO] [stderr] | ^^^^^^ help: replace it with: `hs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/libgcollections/wrappers/optional.rs:55:7 [INFO] [stderr] | [INFO] [stderr] 55 | value: value [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/libgcollections/wrappers/vector.rs:28:7 [INFO] [stderr] | [INFO] [stderr] 28 | vec: vec [INFO] [stderr] | ^^^^^^^^ help: replace it with: `vec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/libgcollections/wrappers/vector_deque.rs:33:7 [INFO] [stderr] | [INFO] [stderr] 33 | deque: deque [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `deque` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/libgcollections/queue.rs:28:7 [INFO] [stderr] | [INFO] [stderr] 28 | seq: seq, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `seq` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/libgcollections/stack.rs:27:7 [INFO] [stderr] | [INFO] [stderr] 27 | seq: seq, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `seq` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/libgcollections/ops/lattice.rs:159:43 [INFO] [stderr] | [INFO] [stderr] 159 | self.assert_expected("a.entail(b)", ab.clone(), expected, ""); [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `ab` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/libgcollections/wrappers/bit_set.rs:35:3 [INFO] [stderr] | [INFO] [stderr] 35 | / fn deref<'a>(&'a self) -> &'a StdBitSet { [INFO] [stderr] 36 | | &self.bs [INFO] [stderr] 37 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/libgcollections/wrappers/bit_set.rs:42:3 [INFO] [stderr] | [INFO] [stderr] 42 | / fn deref_mut<'a>(&'a mut self) -> &'a mut StdBitSet { [INFO] [stderr] 43 | | &mut self.bs [INFO] [stderr] 44 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/libgcollections/wrappers/optional.rs:72:3 [INFO] [stderr] | [INFO] [stderr] 72 | / fn deref<'a>(&'a self) -> &'a Option { [INFO] [stderr] 73 | | &self.value [INFO] [stderr] 74 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/libgcollections/wrappers/optional.rs:79:3 [INFO] [stderr] | [INFO] [stderr] 79 | / fn deref_mut<'a>(&'a mut self) -> &'a mut Option { [INFO] [stderr] 80 | | &mut self.value [INFO] [stderr] 81 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/libgcollections/wrappers/optional.rs:192:32 [INFO] [stderr] | [INFO] [stderr] 192 | if other.is_empty() || self != other.as_ref().unwrap() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(self - other.as_ref().unwrap()).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 203 | primitive_optional_difference_operation!(i8,u8,i16,u16,i32,u32,i64,u64,isize,usize,f32,f64,bool,char); [INFO] [stderr] | ------------------------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/libgcollections/wrappers/optional.rs:192:32 [INFO] [stderr] | [INFO] [stderr] 192 | if other.is_empty() || self != other.as_ref().unwrap() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 203 | primitive_optional_difference_operation!(i8,u8,i16,u16,i32,u32,i64,u64,isize,usize,f32,f64,bool,char); [INFO] [stderr] | ------------------------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/libgcollections/wrappers/optional.rs:192:32 [INFO] [stderr] | [INFO] [stderr] 192 | if other.is_empty() || self != other.as_ref().unwrap() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(self - other.as_ref().unwrap()).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 203 | primitive_optional_difference_operation!(i8,u8,i16,u16,i32,u32,i64,u64,isize,usize,f32,f64,bool,char); [INFO] [stderr] | ------------------------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/libgcollections/wrappers/optional.rs:192:32 [INFO] [stderr] | [INFO] [stderr] 192 | if other.is_empty() || self != other.as_ref().unwrap() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 203 | primitive_optional_difference_operation!(i8,u8,i16,u16,i32,u32,i64,u64,isize,usize,f32,f64,bool,char); [INFO] [stderr] | ------------------------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/libgcollections/queue.rs:45:3 [INFO] [stderr] | [INFO] [stderr] 45 | / fn deref<'a>(&'a self) -> &'a S { [INFO] [stderr] 46 | | &self.seq [INFO] [stderr] 47 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/libgcollections/queue.rs:52:3 [INFO] [stderr] | [INFO] [stderr] 52 | / fn deref_mut<'a>(&'a mut self) -> &'a mut S { [INFO] [stderr] 53 | | &mut self.seq [INFO] [stderr] 54 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/libgcollections/stack.rs:43:3 [INFO] [stderr] | [INFO] [stderr] 43 | / fn deref<'a>(&'a self) -> &'a S { [INFO] [stderr] 44 | | &self.seq [INFO] [stderr] 45 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/libgcollections/stack.rs:50:3 [INFO] [stderr] | [INFO] [stderr] 50 | / fn deref_mut<'a>(&'a mut self) -> &'a mut S { [INFO] [stderr] 51 | | &mut self.seq [INFO] [stderr] 52 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `gcollections`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/libgcollections/ops/lattice.rs:159:43 [INFO] [stderr] | [INFO] [stderr] 159 | self.assert_expected("a.entail(b)", ab.clone(), expected, ""); [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `ab` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/libgcollections/wrappers/bit_set.rs:35:3 [INFO] [stderr] | [INFO] [stderr] 35 | / fn deref<'a>(&'a self) -> &'a StdBitSet { [INFO] [stderr] 36 | | &self.bs [INFO] [stderr] 37 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/libgcollections/wrappers/bit_set.rs:42:3 [INFO] [stderr] | [INFO] [stderr] 42 | / fn deref_mut<'a>(&'a mut self) -> &'a mut StdBitSet { [INFO] [stderr] 43 | | &mut self.bs [INFO] [stderr] 44 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/libgcollections/wrappers/optional.rs:72:3 [INFO] [stderr] | [INFO] [stderr] 72 | / fn deref<'a>(&'a self) -> &'a Option { [INFO] [stderr] 73 | | &self.value [INFO] [stderr] 74 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/libgcollections/wrappers/optional.rs:79:3 [INFO] [stderr] | [INFO] [stderr] 79 | / fn deref_mut<'a>(&'a mut self) -> &'a mut Option { [INFO] [stderr] 80 | | &mut self.value [INFO] [stderr] 81 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/libgcollections/wrappers/optional.rs:192:32 [INFO] [stderr] | [INFO] [stderr] 192 | if other.is_empty() || self != other.as_ref().unwrap() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(self - other.as_ref().unwrap()).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 203 | primitive_optional_difference_operation!(i8,u8,i16,u16,i32,u32,i64,u64,isize,usize,f32,f64,bool,char); [INFO] [stderr] | ------------------------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/libgcollections/wrappers/optional.rs:192:32 [INFO] [stderr] | [INFO] [stderr] 192 | if other.is_empty() || self != other.as_ref().unwrap() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 203 | primitive_optional_difference_operation!(i8,u8,i16,u16,i32,u32,i64,u64,isize,usize,f32,f64,bool,char); [INFO] [stderr] | ------------------------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/libgcollections/wrappers/optional.rs:192:32 [INFO] [stderr] | [INFO] [stderr] 192 | if other.is_empty() || self != other.as_ref().unwrap() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(self - other.as_ref().unwrap()).abs() < error` [INFO] [stderr] ... [INFO] [stderr] 203 | primitive_optional_difference_operation!(i8,u8,i16,u16,i32,u32,i64,u64,isize,usize,f32,f64,bool,char); [INFO] [stderr] | ------------------------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/libgcollections/wrappers/optional.rs:192:32 [INFO] [stderr] | [INFO] [stderr] 192 | if other.is_empty() || self != other.as_ref().unwrap() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 203 | primitive_optional_difference_operation!(i8,u8,i16,u16,i32,u32,i64,u64,isize,usize,f32,f64,bool,char); [INFO] [stderr] | ------------------------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/libgcollections/wrappers/primitives.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | for ref i in -2i32..10 { [INFO] [stderr] | ^^^^^ --------- help: try: `let i = &-2i32..10;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/libgcollections/wrappers/primitives.rs:104:11 [INFO] [stderr] | [INFO] [stderr] 104 | for ref j in -10..10 { [INFO] [stderr] | ^^^^^ ------- help: try: `let j = &-10..10;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/libgcollections/queue.rs:45:3 [INFO] [stderr] | [INFO] [stderr] 45 | / fn deref<'a>(&'a self) -> &'a S { [INFO] [stderr] 46 | | &self.seq [INFO] [stderr] 47 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/libgcollections/queue.rs:52:3 [INFO] [stderr] | [INFO] [stderr] 52 | / fn deref_mut<'a>(&'a mut self) -> &'a mut S { [INFO] [stderr] 53 | | &mut self.seq [INFO] [stderr] 54 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/libgcollections/stack.rs:43:3 [INFO] [stderr] | [INFO] [stderr] 43 | / fn deref<'a>(&'a self) -> &'a S { [INFO] [stderr] 44 | | &self.seq [INFO] [stderr] 45 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/libgcollections/stack.rs:50:3 [INFO] [stderr] | [INFO] [stderr] 50 | / fn deref_mut<'a>(&'a mut self) -> &'a mut S { [INFO] [stderr] 51 | | &mut self.seq [INFO] [stderr] 52 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `gcollections`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "19a6dd83a00d825b3082b5e1db13e7e756ae73911e3e77086c26b0276e8af022"` [INFO] running `"docker" "rm" "-f" "19a6dd83a00d825b3082b5e1db13e7e756ae73911e3e77086c26b0276e8af022"` [INFO] [stdout] 19a6dd83a00d825b3082b5e1db13e7e756ae73911e3e77086c26b0276e8af022