[INFO] crate gbas 0.1.0 is already in cache [INFO] extracting crate gbas 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/gbas/0.1.0 [INFO] extracting crate gbas 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gbas/0.1.0 [INFO] validating manifest of gbas-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gbas-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gbas-0.1.0 [INFO] finished frobbing gbas-0.1.0 [INFO] frobbed toml for gbas-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/gbas/0.1.0/Cargo.toml [INFO] started frobbing gbas-0.1.0 [INFO] finished frobbing gbas-0.1.0 [INFO] frobbed toml for gbas-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gbas/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gbas-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/gbas/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b06513492e9a721069a79832a421fdcc57dcd5a501b66784ae7bb1b05e7aae2a [INFO] running `"docker" "start" "-a" "b06513492e9a721069a79832a421fdcc57dcd5a501b66784ae7bb1b05e7aae2a"` [INFO] [stderr] Checking gbas v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/backend/object/resolve.rs:90:44 [INFO] [stderr] | [INFO] [stderr] 90 | for (i, chunk) in (&object.chunks).into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/backend/object/resolve.rs:110:40 [INFO] [stderr] | [INFO] [stderr] 110 | for (i, chunk) in (&object.chunks).into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `backend::object::context::SymbolTable` [INFO] [stderr] --> src/backend/object/context.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | / pub fn new() -> SymbolTable { [INFO] [stderr] 58 | | SymbolTable { [INFO] [stderr] 59 | | symbols: Vec::new(), [INFO] [stderr] 60 | | names: HashMap::new(), [INFO] [stderr] 61 | | sizes: Vec::new(), [INFO] [stderr] 62 | | } [INFO] [stderr] 63 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 5 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/backend/object/resolve.rs:90:44 [INFO] [stderr] | [INFO] [stderr] 90 | for (i, chunk) in (&object.chunks).into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/backend/object/resolve.rs:110:40 [INFO] [stderr] | [INFO] [stderr] 110 | for (i, chunk) in (&object.chunks).into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/backend/mod.rs:202:47 [INFO] [stderr] | [INFO] [stderr] 202 | test_diagnostic_for_out_of_range_byte(i8::min_value() as i32 - 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(i8::min_value())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/backend/mod.rs:203:47 [INFO] [stderr] | [INFO] [stderr] 203 | test_diagnostic_for_out_of_range_byte(u8::max_value() as i32 + 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(u8::max_value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/diagnostics.rs:417:20 [INFO] [stderr] | [INFO] [stderr] 417 | range: BufRange::from(4..11), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider removing `BufRange::from()`: `4..11` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/diagnostics.rs:428:21 [INFO] [stderr] | [INFO] [stderr] 428 | let range = BufRange::from(12..20); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `BufRange::from()`: `12..20` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/frontend/semantics/directive.rs:162:22 [INFO] [stderr] | [INFO] [stderr] 162 | fn mk_byte(byte: &i32) -> backend::Item<()> { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/frontend/semantics/directive.rs:166:22 [INFO] [stderr] | [INFO] [stderr] 166 | fn mk_word(word: &i32) -> backend::Item<()> { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/frontend/semantics/instruction/mod.rs:589:83 [INFO] [stderr] | [INFO] [stderr] 589 | .map(|(mnemonic, nullary)| ((*mnemonic, vec![]), Instruction::Nullary(nullary.clone()))) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*nullary` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/frontend/semantics/instruction/mod.rs:841:43 [INFO] [stderr] | [INFO] [stderr] 841 | vec![A, A, A].into_iter().map(|a| literal(a)), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove closure as shown: `literal` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/frontend/semantics/mod.rs:489:19 [INFO] [stderr] | [INFO] [stderr] 489 | args: Vec, Self::Span)>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/frontend/semantics/mod.rs:683:17 [INFO] [stderr] | [INFO] [stderr] 683 | body.borrow().iter().cloned().collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_cloned_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/frontend/syntax/ast.rs:119:38 [INFO] [stderr] | [INFO] [stderr] 119 | TokenRef::Name(name) => *self.names.get(&name).unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.names[&name]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/frontend/syntax/lexer.rs:357:5 [INFO] [stderr] | [INFO] [stderr] 357 | / fn assert_eq_tokens<'a>(src: &'a str, expected_without_eof: impl Borrow<[Token]>) { [INFO] [stderr] 358 | | let mut expected: Vec<_> = expected_without_eof.borrow().iter().cloned().collect(); [INFO] [stderr] 359 | | expected.push(Eof); [INFO] [stderr] 360 | | assert_eq!( [INFO] [stderr] ... | [INFO] [stderr] 363 | | ) [INFO] [stderr] 364 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/frontend/syntax/lexer.rs:358:36 [INFO] [stderr] | [INFO] [stderr] 358 | let mut expected: Vec<_> = expected_without_eof.borrow().iter().cloned().collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/frontend/mod.rs:572:30 [INFO] [stderr] | [INFO] [stderr] 572 | Ok(MockTokenized(self.files.get(filename).unwrap().clone())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.files[filename]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/frontend/mod.rs:582:23 [INFO] [stderr] | [INFO] [stderr] 582 | (&self.0).into_iter().cloned() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/frontend/mod.rs:611:37 [INFO] [stderr] | [INFO] [stderr] 611 | tokens.map(|(t, _)| t.into()).collect(), [INFO] [stderr] | ^^^^^^^^ help: consider removing `.into()`: `t` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/span.rs:121:20 [INFO] [stderr] | [INFO] [stderr] 121 | range: BufRange::from(0..4), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `BufRange::from()`: `0..4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/span.rs:125:20 [INFO] [stderr] | [INFO] [stderr] 125 | range: BufRange::from(5..10), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider removing `BufRange::from()`: `5..10` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/span.rs:132:24 [INFO] [stderr] | [INFO] [stderr] 132 | range: BufRange::from(0..10), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider removing `BufRange::from()`: `0..10` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.80s [INFO] running `"docker" "inspect" "b06513492e9a721069a79832a421fdcc57dcd5a501b66784ae7bb1b05e7aae2a"` [INFO] running `"docker" "rm" "-f" "b06513492e9a721069a79832a421fdcc57dcd5a501b66784ae7bb1b05e7aae2a"` [INFO] [stdout] b06513492e9a721069a79832a421fdcc57dcd5a501b66784ae7bb1b05e7aae2a