[INFO] crate gate_build 0.6.2 is already in cache
[INFO] extracting crate gate_build 0.6.2 into work/ex/clippy-test-run/sources/stable/reg/gate_build/0.6.2
[INFO] extracting crate gate_build 0.6.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gate_build/0.6.2
[INFO] validating manifest of gate_build-0.6.2 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of gate_build-0.6.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing gate_build-0.6.2
[INFO] finished frobbing gate_build-0.6.2
[INFO] frobbed toml for gate_build-0.6.2 written to work/ex/clippy-test-run/sources/stable/reg/gate_build/0.6.2/Cargo.toml
[INFO] started frobbing gate_build-0.6.2
[INFO] finished frobbing gate_build-0.6.2
[INFO] frobbed toml for gate_build-0.6.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gate_build/0.6.2/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting gate_build-0.6.2 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/gate_build/0.6.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] c35828317bcc5f4ce407ddba25f8f886004f5afd162e1dfc0fe46571e7db7cfa
[INFO] running `"docker" "start" "-a" "c35828317bcc5f4ce407ddba25f8f886004f5afd162e1dfc0fe46571e7db7cfa"`
[INFO] [stderr]     Checking png v0.9.0
[INFO] [stderr]     Checking image v0.15.0
[INFO] [stderr]     Checking gate_build v0.6.2 (/opt/crater/workdir)
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/atlas.rs:58:5
[INFO] [stderr]    |
[INFO] [stderr] 58 |     image_names
[INFO] [stderr]    |     ^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/atlas.rs:57:23
[INFO] [stderr]    |
[INFO] [stderr] 57 |     let image_names = regions.drain(..).map(|(name, _)| name).collect();
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/atlas.rs:58:5
[INFO] [stderr]    |
[INFO] [stderr] 58 |     image_names
[INFO] [stderr]    |     ^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/atlas.rs:57:23
[INFO] [stderr]    |
[INFO] [stderr] 57 |     let image_names = regions.drain(..).map(|(name, _)| name).collect();
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/html/mod.rs:15:21
[INFO] [stderr]    |
[INFO] [stderr] 15 | pub const GATE_JS: &'static str = include_str!("gate.js");
[INFO] [stderr]    |                    -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/html/mod.rs:16:24
[INFO] [stderr]    |
[INFO] [stderr] 16 | pub const INDEX_HTML: &'static str = include_str!("index.html");
[INFO] [stderr]    |                       -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/html/mod.rs:15:21
[INFO] [stderr]    |
[INFO] [stderr] 15 | pub const GATE_JS: &'static str = include_str!("gate.js");
[INFO] [stderr]    |                    -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/html/mod.rs:16:24
[INFO] [stderr]    |
[INFO] [stderr] 16 | pub const INDEX_HTML: &'static str = include_str!("index.html");
[INFO] [stderr]    |                       -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/rect_packer/bit_grid.rs:32:20
[INFO] [stderr]    |
[INFO] [stderr] 32 |         for row in 0..(self.height - height + 1) {
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=self.height - height`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/rect_packer/bit_grid.rs:33:24
[INFO] [stderr]    |
[INFO] [stderr] 33 |             for col in 0..(self.width - width + 1) {
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=self.width - width`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/rect_packer/mod.rs:54:9
[INFO] [stderr]    |
[INFO] [stderr] 54 |         (0..(log_ceil_pow_2(max_dim) + 1))
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0..=log_ceil_pow_2(max_dim))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/rect_packer/bit_grid.rs:32:20
[INFO] [stderr]    |
[INFO] [stderr] 32 |         for row in 0..(self.height - height + 1) {
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=self.height - height`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/rect_packer/bit_grid.rs:33:24
[INFO] [stderr]    |
[INFO] [stderr] 33 |             for col in 0..(self.width - width + 1) {
[INFO] [stderr]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=self.width - width`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/atlas.rs:88:21
[INFO] [stderr]    |
[INFO] [stderr] 88 |         let alpha = pixel[3] as f64 / 255.;
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^ help: try: `f64::from(pixel[3])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `color_index` is only used to index `pixel`.
[INFO] [stderr]   --> src/atlas.rs:89:28
[INFO] [stderr]    |
[INFO] [stderr] 89 |         for color_index in 0..3 {
[INFO] [stderr]    |                            ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 89 |         for <item> in pixel.iter_mut().take(3) {
[INFO] [stderr]    |             ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/atlas.rs:90:43
[INFO] [stderr]    |
[INFO] [stderr] 90 |             pixel[color_index] = (alpha * pixel[color_index] as f64).round() as u8
[INFO] [stderr]    |                                           ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(pixel[color_index])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/rect_packer/mod.rs:54:9
[INFO] [stderr]    |
[INFO] [stderr] 54 |         (0..(log_ceil_pow_2(max_dim) + 1))
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0..=log_ceil_pow_2(max_dim))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/atlas.rs:170:12
[INFO] [stderr]     |
[INFO] [stderr] 170 |     result.unwrap_or(vec![(name, image)])
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![(name, image)])`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/atlas.rs:88:21
[INFO] [stderr]    |
[INFO] [stderr] 88 |         let alpha = pixel[3] as f64 / 255.;
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^ help: try: `f64::from(pixel[3])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `color_index` is only used to index `pixel`.
[INFO] [stderr]   --> src/atlas.rs:89:28
[INFO] [stderr]    |
[INFO] [stderr] 89 |         for color_index in 0..3 {
[INFO] [stderr]    |                            ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 89 |         for <item> in pixel.iter_mut().take(3) {
[INFO] [stderr]    |             ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/atlas.rs:90:43
[INFO] [stderr]    |
[INFO] [stderr] 90 |             pixel[color_index] = (alpha * pixel[color_index] as f64).round() as u8
[INFO] [stderr]    |                                           ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(pixel[color_index])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/asset_packer.rs:174:64
[INFO] [stderr]     |
[INFO] [stderr] 174 |         let music_enum = gen_asset_enum("MusicId", &self.music.unwrap_or(vec![]));
[INFO] [stderr]     |                                                                ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/asset_packer.rs:175:66
[INFO] [stderr]     |
[INFO] [stderr] 175 |         let sounds_enum = gen_asset_enum("SoundId", &self.sounds.unwrap_or(vec![]));
[INFO] [stderr]     |                                                                  ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/asset_packer.rs:217:8
[INFO] [stderr]     |
[INFO] [stderr] 217 |     if ids.len() == 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `ids.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/atlas.rs:170:12
[INFO] [stderr]     |
[INFO] [stderr] 170 |     result.unwrap_or(vec![(name, image)])
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![(name, image)])`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/asset_packer.rs:174:64
[INFO] [stderr]     |
[INFO] [stderr] 174 |         let music_enum = gen_asset_enum("MusicId", &self.music.unwrap_or(vec![]));
[INFO] [stderr]     |                                                                ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/asset_packer.rs:175:66
[INFO] [stderr]     |
[INFO] [stderr] 175 |         let sounds_enum = gen_asset_enum("SoundId", &self.sounds.unwrap_or(vec![]));
[INFO] [stderr]     |                                                                  ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/asset_packer.rs:217:8
[INFO] [stderr]     |
[INFO] [stderr] 217 |     if ids.len() == 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `ids.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 13.62s
[INFO] running `"docker" "inspect" "c35828317bcc5f4ce407ddba25f8f886004f5afd162e1dfc0fe46571e7db7cfa"`
[INFO] running `"docker" "rm" "-f" "c35828317bcc5f4ce407ddba25f8f886004f5afd162e1dfc0fe46571e7db7cfa"`
[INFO] [stdout] c35828317bcc5f4ce407ddba25f8f886004f5afd162e1dfc0fe46571e7db7cfa