[INFO] crate gapbuf 0.1.2 is already in cache [INFO] extracting crate gapbuf 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/gapbuf/0.1.2 [INFO] extracting crate gapbuf 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gapbuf/0.1.2 [INFO] validating manifest of gapbuf-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gapbuf-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gapbuf-0.1.2 [INFO] finished frobbing gapbuf-0.1.2 [INFO] frobbed toml for gapbuf-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/gapbuf/0.1.2/Cargo.toml [INFO] started frobbing gapbuf-0.1.2 [INFO] finished frobbing gapbuf-0.1.2 [INFO] frobbed toml for gapbuf-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gapbuf/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gapbuf-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/gapbuf/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a1471043bc9ecbb0c5bc8f4c8877c8b69a71ec339609b9ed2db950f7266e3ad1 [INFO] running `"docker" "start" "-a" "a1471043bc9ecbb0c5bc8f4c8877c8b69a71ec339609b9ed2db950f7266e3ad1"` [INFO] [stderr] Checking gapbuf v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/gap_buffer.rs:409:9 [INFO] [stderr] | [INFO] [stderr] 409 | / let offset; [INFO] [stderr] 410 | | if self.gap() <= index { [INFO] [stderr] 411 | | self.set_gap(index); [INFO] [stderr] 412 | | offset = self.cap - self.len() + index; [INFO] [stderr] ... | [INFO] [stderr] 416 | | offset = index; [INFO] [stderr] 417 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let offset = if self.gap() <= index { ..; self.cap - self.len() + index } else { ..; index };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/tests.rs:605:13 [INFO] [stderr] | [INFO] [stderr] 605 | t: t, [INFO] [stderr] | ^^^^ help: replace it with: `t` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/tests.rs:606:13 [INFO] [stderr] | [INFO] [stderr] 606 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/tests.rs:607:13 [INFO] [stderr] | [INFO] [stderr] 607 | is_panic: is_panic, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `is_panic` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/gap_buffer.rs:409:9 [INFO] [stderr] | [INFO] [stderr] 409 | / let offset; [INFO] [stderr] 410 | | if self.gap() <= index { [INFO] [stderr] 411 | | self.set_gap(index); [INFO] [stderr] 412 | | offset = self.cap - self.len() + index; [INFO] [stderr] ... | [INFO] [stderr] 416 | | offset = index; [INFO] [stderr] 417 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let offset = if self.gap() <= index { ..; self.cap - self.len() + index } else { ..; index };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/benches.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `gapbuf`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> tests/tests.rs:814:5 [INFO] [stderr] | [INFO] [stderr] 814 | buf[4]; [INFO] [stderr] | ^^^^^^^ help: replace it with: `buf;4;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "a1471043bc9ecbb0c5bc8f4c8877c8b69a71ec339609b9ed2db950f7266e3ad1"` [INFO] running `"docker" "rm" "-f" "a1471043bc9ecbb0c5bc8f4c8877c8b69a71ec339609b9ed2db950f7266e3ad1"` [INFO] [stdout] a1471043bc9ecbb0c5bc8f4c8877c8b69a71ec339609b9ed2db950f7266e3ad1