[INFO] crate game-of-life 0.1.0 is already in cache [INFO] extracting crate game-of-life 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/game-of-life/0.1.0 [INFO] extracting crate game-of-life 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/game-of-life/0.1.0 [INFO] validating manifest of game-of-life-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of game-of-life-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing game-of-life-0.1.0 [INFO] finished frobbing game-of-life-0.1.0 [INFO] frobbed toml for game-of-life-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/game-of-life/0.1.0/Cargo.toml [INFO] started frobbing game-of-life-0.1.0 [INFO] finished frobbing game-of-life-0.1.0 [INFO] frobbed toml for game-of-life-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/game-of-life/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting game-of-life-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/game-of-life/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 416eb7b585b70abebdfd06eaf91459468dbf90549ef71a00281718936fdc2dc4 [INFO] running `"docker" "start" "-a" "416eb7b585b70abebdfd06eaf91459468dbf90549ef71a00281718936fdc2dc4"` [INFO] [stderr] Compiling glutin v0.10.1 [INFO] [stderr] Compiling gl v0.7.0 [INFO] [stderr] Checking piston2d-graphics v0.24.0 [INFO] [stderr] Checking pistoncore-input v0.20.0 [INFO] [stderr] Checking image v0.18.0 [INFO] [stderr] Checking wayland-sys v0.9.10 [INFO] [stderr] Checking wayland-client v0.9.10 [INFO] [stderr] Checking pistoncore-window v0.30.0 [INFO] [stderr] Checking wayland-protocols v0.9.10 [INFO] [stderr] Checking wayland-kbd v0.9.1 [INFO] [stderr] Checking pistoncore-event_loop v0.35.0 [INFO] [stderr] Checking wayland-window v0.8.0 [INFO] [stderr] Checking winit v0.8.3 [INFO] [stderr] Checking piston v0.35.0 [INFO] [stderr] Checking piston2d-opengl_graphics v0.50.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.43.0 [INFO] [stderr] Checking game-of-life v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/life.rs:177:10 [INFO] [stderr] | [INFO] [stderr] 177 | loc: loc [INFO] [stderr] | ^^^^^^^^ help: replace it with: `loc` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/life.rs:203:10 [INFO] [stderr] | [INFO] [stderr] 203 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/life.rs:204:10 [INFO] [stderr] | [INFO] [stderr] 204 | y: y [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/life.rs:213:10 [INFO] [stderr] | [INFO] [stderr] 213 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/life.rs:214:10 [INFO] [stderr] | [INFO] [stderr] 214 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/life.rs:215:10 [INFO] [stderr] | [INFO] [stderr] 215 | gl: gl, [INFO] [stderr] | ^^^^^^ help: replace it with: `gl` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/life.rs:177:10 [INFO] [stderr] | [INFO] [stderr] 177 | loc: loc [INFO] [stderr] | ^^^^^^^^ help: replace it with: `loc` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/life.rs:203:10 [INFO] [stderr] | [INFO] [stderr] 203 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/life.rs:204:10 [INFO] [stderr] | [INFO] [stderr] 204 | y: y [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/life.rs:213:10 [INFO] [stderr] | [INFO] [stderr] 213 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/life.rs:214:10 [INFO] [stderr] | [INFO] [stderr] 214 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/life.rs:215:10 [INFO] [stderr] | [INFO] [stderr] 215 | gl: gl, [INFO] [stderr] | ^^^^^^ help: replace it with: `gl` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/life.rs:20:26 [INFO] [stderr] | [INFO] [stderr] 20 | pub const WINDOW_TITLE: &'static str = "Conway's Game of Life"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/life.rs:117:10 [INFO] [stderr] | [INFO] [stderr] 117 | / match neighbor { [INFO] [stderr] 118 | | Neighbor::Block(blk) => live.push(blk), [INFO] [stderr] 119 | | _ => {} [INFO] [stderr] 120 | | } [INFO] [stderr] | |__________^ help: try this: `if let Neighbor::Block(blk) = neighbor { live.push(blk) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/life.rs:129:10 [INFO] [stderr] | [INFO] [stderr] 129 | / match neighbor { [INFO] [stderr] 130 | | Neighbor::Location(loc) => dead.push(loc), [INFO] [stderr] 131 | | _ => {} [INFO] [stderr] 132 | | } [INFO] [stderr] | |__________^ help: try this: `if let Neighbor::Location(loc) = neighbor { dead.push(loc) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/life.rs:224:7 [INFO] [stderr] | [INFO] [stderr] 224 | / match button { [INFO] [stderr] 225 | | &Button::Mouse(button) => self.mouse_press(button), [INFO] [stderr] 226 | | _ => {} [INFO] [stderr] 227 | | } [INFO] [stderr] | |_______^ help: try this: `if let &Button::Mouse(button) = button { self.mouse_press(button) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/life.rs:224:7 [INFO] [stderr] | [INFO] [stderr] 224 | / match button { [INFO] [stderr] 225 | | &Button::Mouse(button) => self.mouse_press(button), [INFO] [stderr] 226 | | _ => {} [INFO] [stderr] 227 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 224 | match *button { [INFO] [stderr] 225 | Button::Mouse(button) => self.mouse_press(button), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/life.rs:231:7 [INFO] [stderr] | [INFO] [stderr] 231 | / match button { [INFO] [stderr] 232 | | &Button::Keyboard(key) => self.key_release(window, key), [INFO] [stderr] 233 | | &Button::Mouse(button) => self.mouse_release(button), [INFO] [stderr] 234 | | _ => { } [INFO] [stderr] 235 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 231 | match *button { [INFO] [stderr] 232 | Button::Keyboard(key) => self.key_release(window, key), [INFO] [stderr] 233 | Button::Mouse(button) => self.mouse_release(button), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/life.rs:339:32 [INFO] [stderr] | [INFO] [stderr] 339 | pub fn update(&mut self, _: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/life.rs:20:26 [INFO] [stderr] | [INFO] [stderr] 20 | pub const WINDOW_TITLE: &'static str = "Conway's Game of Life"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/life.rs:117:10 [INFO] [stderr] | [INFO] [stderr] 117 | / match neighbor { [INFO] [stderr] 118 | | Neighbor::Block(blk) => live.push(blk), [INFO] [stderr] 119 | | _ => {} [INFO] [stderr] 120 | | } [INFO] [stderr] | |__________^ help: try this: `if let Neighbor::Block(blk) = neighbor { live.push(blk) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/life.rs:129:10 [INFO] [stderr] | [INFO] [stderr] 129 | / match neighbor { [INFO] [stderr] 130 | | Neighbor::Location(loc) => dead.push(loc), [INFO] [stderr] 131 | | _ => {} [INFO] [stderr] 132 | | } [INFO] [stderr] | |__________^ help: try this: `if let Neighbor::Location(loc) = neighbor { dead.push(loc) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/life.rs:224:7 [INFO] [stderr] | [INFO] [stderr] 224 | / match button { [INFO] [stderr] 225 | | &Button::Mouse(button) => self.mouse_press(button), [INFO] [stderr] 226 | | _ => {} [INFO] [stderr] 227 | | } [INFO] [stderr] | |_______^ help: try this: `if let &Button::Mouse(button) = button { self.mouse_press(button) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/life.rs:224:7 [INFO] [stderr] | [INFO] [stderr] 224 | / match button { [INFO] [stderr] 225 | | &Button::Mouse(button) => self.mouse_press(button), [INFO] [stderr] 226 | | _ => {} [INFO] [stderr] 227 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 224 | match *button { [INFO] [stderr] 225 | Button::Mouse(button) => self.mouse_press(button), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/life.rs:231:7 [INFO] [stderr] | [INFO] [stderr] 231 | / match button { [INFO] [stderr] 232 | | &Button::Keyboard(key) => self.key_release(window, key), [INFO] [stderr] 233 | | &Button::Mouse(button) => self.mouse_release(button), [INFO] [stderr] 234 | | _ => { } [INFO] [stderr] 235 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 231 | match *button { [INFO] [stderr] 232 | Button::Keyboard(key) => self.key_release(window, key), [INFO] [stderr] 233 | Button::Mouse(button) => self.mouse_release(button), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/life.rs:339:32 [INFO] [stderr] | [INFO] [stderr] 339 | pub fn update(&mut self, _: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 39.64s [INFO] running `"docker" "inspect" "416eb7b585b70abebdfd06eaf91459468dbf90549ef71a00281718936fdc2dc4"` [INFO] running `"docker" "rm" "-f" "416eb7b585b70abebdfd06eaf91459468dbf90549ef71a00281718936fdc2dc4"` [INFO] [stdout] 416eb7b585b70abebdfd06eaf91459468dbf90549ef71a00281718936fdc2dc4