[INFO] crate game-2048 0.5.1 is already in cache [INFO] extracting crate game-2048 0.5.1 into work/ex/clippy-test-run/sources/stable/reg/game-2048/0.5.1 [INFO] extracting crate game-2048 0.5.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/game-2048/0.5.1 [INFO] validating manifest of game-2048-0.5.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of game-2048-0.5.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing game-2048-0.5.1 [INFO] finished frobbing game-2048-0.5.1 [INFO] frobbed toml for game-2048-0.5.1 written to work/ex/clippy-test-run/sources/stable/reg/game-2048/0.5.1/Cargo.toml [INFO] started frobbing game-2048-0.5.1 [INFO] finished frobbing game-2048-0.5.1 [INFO] frobbed toml for game-2048-0.5.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/game-2048/0.5.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting game-2048-0.5.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/game-2048/0.5.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 32c99685b09b815dabf1f2faa8eb9e71f61cc842b40f90c2bfe1aa7a38280bd6 [INFO] running `"docker" "start" "-a" "32c99685b09b815dabf1f2faa8eb9e71f61cc842b40f90c2bfe1aa7a38280bd6"` [INFO] [stderr] Checking matrix_display v0.3.0 [INFO] [stderr] Checking game-2048 v0.5.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/board.rs:15:17 [INFO] [stderr] | [INFO] [stderr] 15 | Board { colour_theme: colour_theme } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `colour_theme` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/display.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / write!(out, [INFO] [stderr] 11 | | "2048-rs [pierrec.tech]{num:>pad$}\r\n", [INFO] [stderr] 12 | | num = score, [INFO] [stderr] 13 | | pad = 11) [INFO] [stderr] | |____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/board.rs:15:17 [INFO] [stderr] | [INFO] [stderr] 15 | Board { colour_theme: colour_theme } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `colour_theme` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/display.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / write!(out, [INFO] [stderr] 11 | | "2048-rs [pierrec.tech]{num:>pad$}\r\n", [INFO] [stderr] 12 | | num = score, [INFO] [stderr] 13 | | pad = 11) [INFO] [stderr] | |____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'rand::sample': renamed to seq::sample_iter [INFO] [stderr] --> src/board.rs:3:24 [INFO] [stderr] | [INFO] [stderr] 3 | use rand::{thread_rng, sample}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'rand::sample': renamed to seq::sample_iter [INFO] [stderr] --> src/board.rs:57:22 [INFO] [stderr] | [INFO] [stderr] 57 | let mut fw = sample(&mut rng, 1..256, 17); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'rand::sample': renamed to seq::sample_iter [INFO] [stderr] --> src/board.rs:3:24 [INFO] [stderr] | [INFO] [stderr] 3 | use rand::{thread_rng, sample}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'rand::sample': renamed to seq::sample_iter [INFO] [stderr] --> src/board.rs:57:22 [INFO] [stderr] | [INFO] [stderr] 57 | let mut fw = sample(&mut rng, 1..256, 17); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: floating-point types cannot be used in patterns [INFO] [stderr] --> src/board.rs:22:22 [INFO] [stderr] | [INFO] [stderr] 22 | 1_f64 => (".".to_string(), col), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(illegal_floating_point_literal_pattern)] on by default [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #41620 [INFO] [stderr] [INFO] [stderr] warning: floating-point types cannot be used in patterns [INFO] [stderr] --> src/board.rs:22:22 [INFO] [stderr] | [INFO] [stderr] 22 | 1_f64 => (".".to_string(), col), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #41620 [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/game.rs:70:19 [INFO] [stderr] | [INFO] [stderr] 70 | .map(|mut row| { [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/algorithm.rs:101:15 [INFO] [stderr] | [INFO] [stderr] 101 | let ret = data.clone() [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 101 | let ret = &(*data).clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 101 | let ret = &[i32]::clone(data) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `fw` [INFO] [stderr] --> src/board.rs:59:18 [INFO] [stderr] | [INFO] [stderr] 59 | for i in 0..17 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 59 | for (i, ) in fw.iter().enumerate().take(17) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/board.rs:59:18 [INFO] [stderr] | [INFO] [stderr] 59 | for i in 0..17 { [INFO] [stderr] | ^^^^^ help: try replacing the loop by: `fireworks.colour_theme[..17].clone_from_slice(&fw[..17])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: unused return value of `std::iter::Iterator::collect` that must be used [INFO] [stderr] --> src/game.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | / self.data [INFO] [stderr] 69 | | .chunks_mut(4) [INFO] [stderr] 70 | | .map(|mut row| { [INFO] [stderr] 71 | | let (new_row, new_score) = match dir { [INFO] [stderr] ... | [INFO] [stderr] 86 | | }) [INFO] [stderr] 87 | | .collect::>(); [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: if you really need to exhaust the iterator, consider `.for_each(drop)` instead [INFO] [stderr] [INFO] [stderr] warning: you are collect()ing an iterator and throwing away the result. Consider using an explicit for loop to exhaust the iterator [INFO] [stderr] --> src/game.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | / self.data [INFO] [stderr] 69 | | .chunks_mut(4) [INFO] [stderr] 70 | | .map(|mut row| { [INFO] [stderr] 71 | | let (new_row, new_score) = match dir { [INFO] [stderr] ... | [INFO] [stderr] 86 | | }) [INFO] [stderr] 87 | | .collect::>(); [INFO] [stderr] | |________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_collect [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/game.rs:74:27 [INFO] [stderr] | [INFO] [stderr] 74 | _ => (row.iter().cloned().collect::>(), 0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_cloned_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/game.rs:106:9 [INFO] [stderr] | [INFO] [stderr] 106 | / let mut value = 1; [INFO] [stderr] 107 | | if rand::random::() % 10 == 1 { [INFO] [stderr] 108 | | value = 2; [INFO] [stderr] 109 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let value = if rand::random::() % 10 == 1 { 2 } else { 1 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:53:21 [INFO] [stderr] | [INFO] [stderr] 53 | / match game.status() { [INFO] [stderr] 54 | | game::GameStatus::Ongoing => { [INFO] [stderr] 55 | | changed = game.up(); [INFO] [stderr] 56 | | } [INFO] [stderr] 57 | | _ => (), [INFO] [stderr] 58 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 53 | if let game::GameStatus::Ongoing = game.status() { [INFO] [stderr] 54 | changed = game.up(); [INFO] [stderr] 55 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:61:21 [INFO] [stderr] | [INFO] [stderr] 61 | / match game.status() { [INFO] [stderr] 62 | | game::GameStatus::Ongoing => { [INFO] [stderr] 63 | | changed = game.down(); [INFO] [stderr] 64 | | } [INFO] [stderr] 65 | | _ => (), [INFO] [stderr] 66 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 61 | if let game::GameStatus::Ongoing = game.status() { [INFO] [stderr] 62 | changed = game.down(); [INFO] [stderr] 63 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:69:21 [INFO] [stderr] | [INFO] [stderr] 69 | / match game.status() { [INFO] [stderr] 70 | | game::GameStatus::Ongoing => { [INFO] [stderr] 71 | | changed = game.left(); [INFO] [stderr] 72 | | } [INFO] [stderr] 73 | | _ => (), [INFO] [stderr] 74 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 69 | if let game::GameStatus::Ongoing = game.status() { [INFO] [stderr] 70 | changed = game.left(); [INFO] [stderr] 71 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:77:21 [INFO] [stderr] | [INFO] [stderr] 77 | / match game.status() { [INFO] [stderr] 78 | | game::GameStatus::Ongoing => { [INFO] [stderr] 79 | | changed = game.right(); [INFO] [stderr] 80 | | } [INFO] [stderr] 81 | | _ => (), [INFO] [stderr] 82 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 77 | if let game::GameStatus::Ongoing = game.status() { [INFO] [stderr] 78 | changed = game.right(); [INFO] [stderr] 79 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: floating-point types cannot be used in patterns [INFO] [stderr] --> src/board.rs:22:22 [INFO] [stderr] | [INFO] [stderr] 22 | 1_f64 => (".".to_string(), col), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(illegal_floating_point_literal_pattern)] on by default [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #41620 [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `game-2048`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: floating-point types cannot be used in patterns [INFO] [stderr] --> src/board.rs:22:22 [INFO] [stderr] | [INFO] [stderr] 22 | 1_f64 => (".".to_string(), col), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #41620 [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/game.rs:70:19 [INFO] [stderr] | [INFO] [stderr] 70 | .map(|mut row| { [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/algorithm.rs:101:15 [INFO] [stderr] | [INFO] [stderr] 101 | let ret = data.clone() [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 101 | let ret = &(*data).clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 101 | let ret = &[i32]::clone(data) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `fw` [INFO] [stderr] --> src/board.rs:59:18 [INFO] [stderr] | [INFO] [stderr] 59 | for i in 0..17 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 59 | for (i, ) in fw.iter().enumerate().take(17) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/board.rs:59:18 [INFO] [stderr] | [INFO] [stderr] 59 | for i in 0..17 { [INFO] [stderr] | ^^^^^ help: try replacing the loop by: `fireworks.colour_theme[..17].clone_from_slice(&fw[..17])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: unused return value of `std::iter::Iterator::collect` that must be used [INFO] [stderr] --> src/game.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | / self.data [INFO] [stderr] 69 | | .chunks_mut(4) [INFO] [stderr] 70 | | .map(|mut row| { [INFO] [stderr] 71 | | let (new_row, new_score) = match dir { [INFO] [stderr] ... | [INFO] [stderr] 86 | | }) [INFO] [stderr] 87 | | .collect::>(); [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: if you really need to exhaust the iterator, consider `.for_each(drop)` instead [INFO] [stderr] [INFO] [stderr] warning: you are collect()ing an iterator and throwing away the result. Consider using an explicit for loop to exhaust the iterator [INFO] [stderr] --> src/game.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | / self.data [INFO] [stderr] 69 | | .chunks_mut(4) [INFO] [stderr] 70 | | .map(|mut row| { [INFO] [stderr] 71 | | let (new_row, new_score) = match dir { [INFO] [stderr] ... | [INFO] [stderr] 86 | | }) [INFO] [stderr] 87 | | .collect::>(); [INFO] [stderr] | |________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_collect [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/game.rs:74:27 [INFO] [stderr] | [INFO] [stderr] 74 | _ => (row.iter().cloned().collect::>(), 0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_cloned_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/game.rs:106:9 [INFO] [stderr] | [INFO] [stderr] 106 | / let mut value = 1; [INFO] [stderr] 107 | | if rand::random::() % 10 == 1 { [INFO] [stderr] 108 | | value = 2; [INFO] [stderr] 109 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let value = if rand::random::() % 10 == 1 { 2 } else { 1 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:53:21 [INFO] [stderr] | [INFO] [stderr] 53 | / match game.status() { [INFO] [stderr] 54 | | game::GameStatus::Ongoing => { [INFO] [stderr] 55 | | changed = game.up(); [INFO] [stderr] 56 | | } [INFO] [stderr] 57 | | _ => (), [INFO] [stderr] 58 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 53 | if let game::GameStatus::Ongoing = game.status() { [INFO] [stderr] 54 | changed = game.up(); [INFO] [stderr] 55 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:61:21 [INFO] [stderr] | [INFO] [stderr] 61 | / match game.status() { [INFO] [stderr] 62 | | game::GameStatus::Ongoing => { [INFO] [stderr] 63 | | changed = game.down(); [INFO] [stderr] 64 | | } [INFO] [stderr] 65 | | _ => (), [INFO] [stderr] 66 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 61 | if let game::GameStatus::Ongoing = game.status() { [INFO] [stderr] 62 | changed = game.down(); [INFO] [stderr] 63 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:69:21 [INFO] [stderr] | [INFO] [stderr] 69 | / match game.status() { [INFO] [stderr] 70 | | game::GameStatus::Ongoing => { [INFO] [stderr] 71 | | changed = game.left(); [INFO] [stderr] 72 | | } [INFO] [stderr] 73 | | _ => (), [INFO] [stderr] 74 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 69 | if let game::GameStatus::Ongoing = game.status() { [INFO] [stderr] 70 | changed = game.left(); [INFO] [stderr] 71 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:77:21 [INFO] [stderr] | [INFO] [stderr] 77 | / match game.status() { [INFO] [stderr] 78 | | game::GameStatus::Ongoing => { [INFO] [stderr] 79 | | changed = game.right(); [INFO] [stderr] 80 | | } [INFO] [stderr] 81 | | _ => (), [INFO] [stderr] 82 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 77 | if let game::GameStatus::Ongoing = game.status() { [INFO] [stderr] 78 | changed = game.right(); [INFO] [stderr] 79 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `game-2048`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "32c99685b09b815dabf1f2faa8eb9e71f61cc842b40f90c2bfe1aa7a38280bd6"` [INFO] running `"docker" "rm" "-f" "32c99685b09b815dabf1f2faa8eb9e71f61cc842b40f90c2bfe1aa7a38280bd6"` [INFO] [stdout] 32c99685b09b815dabf1f2faa8eb9e71f61cc842b40f90c2bfe1aa7a38280bd6