[INFO] crate galvanic-assert 0.8.7 is already in cache [INFO] extracting crate galvanic-assert 0.8.7 into work/ex/clippy-test-run/sources/stable/reg/galvanic-assert/0.8.7 [INFO] extracting crate galvanic-assert 0.8.7 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/galvanic-assert/0.8.7 [INFO] validating manifest of galvanic-assert-0.8.7 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of galvanic-assert-0.8.7 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing galvanic-assert-0.8.7 [INFO] finished frobbing galvanic-assert-0.8.7 [INFO] frobbed toml for galvanic-assert-0.8.7 written to work/ex/clippy-test-run/sources/stable/reg/galvanic-assert/0.8.7/Cargo.toml [INFO] started frobbing galvanic-assert-0.8.7 [INFO] finished frobbing galvanic-assert-0.8.7 [INFO] frobbed toml for galvanic-assert-0.8.7 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/galvanic-assert/0.8.7/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting galvanic-assert-0.8.7 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/galvanic-assert/0.8.7:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4b7db41c22efac5bf16e2b336bcbf854d06647c45eef28e79a3efaac1a608a55 [INFO] running `"docker" "start" "-a" "4b7db41c22efac5bf16e2b336bcbf854d06647c45eef28e79a3efaac1a608a55"` [INFO] [stderr] Checking galvanic-assert v0.8.7 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:386:13 [INFO] [stderr] | [INFO] [stderr] 386 | assertion: assertion, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `assertion` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:387:13 [INFO] [stderr] | [INFO] [stderr] 387 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:388:13 [INFO] [stderr] | [INFO] [stderr] 388 | line: line, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:389:13 [INFO] [stderr] | [INFO] [stderr] 389 | error_msg: error_msg [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `error_msg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matchers/combinators.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | matcher: matcher, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `matcher` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matchers/combinators.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | matcher: matcher, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `matcher` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matchers/combinators.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | matcher: matcher, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `matcher` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matchers/combinators.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | matcher: matcher, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `matcher` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matchers/collection.rs:570:9 [INFO] [stderr] | [INFO] [stderr] 570 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matchers/collection.rs:571:9 [INFO] [stderr] | [INFO] [stderr] 571 | value: value [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matchers/collection.rs:641:9 [INFO] [stderr] | [INFO] [stderr] 641 | key: key [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matchers/collection.rs:694:9 [INFO] [stderr] | [INFO] [stderr] 694 | key: key [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:386:13 [INFO] [stderr] | [INFO] [stderr] 386 | assertion: assertion, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `assertion` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:387:13 [INFO] [stderr] | [INFO] [stderr] 387 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:388:13 [INFO] [stderr] | [INFO] [stderr] 388 | line: line, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:389:13 [INFO] [stderr] | [INFO] [stderr] 389 | error_msg: error_msg [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `error_msg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matchers/combinators.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | matcher: matcher, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `matcher` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matchers/combinators.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | matcher: matcher, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `matcher` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matchers/combinators.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | matcher: matcher, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `matcher` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matchers/combinators.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | matcher: matcher, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `matcher` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matchers/collection.rs:570:9 [INFO] [stderr] | [INFO] [stderr] 570 | key: key, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matchers/collection.rs:571:9 [INFO] [stderr] | [INFO] [stderr] 571 | value: value [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matchers/collection.rs:641:9 [INFO] [stderr] | [INFO] [stderr] 641 | key: key [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/matchers/collection.rs:694:9 [INFO] [stderr] | [INFO] [stderr] 694 | key: key [INFO] [stderr] | ^^^^^^^^ help: replace it with: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:309:9 [INFO] [stderr] | [INFO] [stderr] 309 | / match result { [INFO] [stderr] 310 | | &MatchResult::Matched {..} => true, [INFO] [stderr] 311 | | &MatchResult::Failed {..} => false [INFO] [stderr] 312 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 309 | match *result { [INFO] [stderr] 310 | MatchResult::Matched {..} => true, [INFO] [stderr] 311 | MatchResult::Failed {..} => false [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `MatchResultBuilder` [INFO] [stderr] --> src/lib.rs:326:5 [INFO] [stderr] | [INFO] [stderr] 326 | / pub fn new() -> MatchResultBuilder { [INFO] [stderr] 327 | | MatchResultBuilder { [INFO] [stderr] 328 | | matcher_name: "_unknown_".to_owned() [INFO] [stderr] 329 | | } [INFO] [stderr] 330 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 320 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:407:9 [INFO] [stderr] | [INFO] [stderr] 407 | / if let &mut Expectation::Failed { .. } = self { [INFO] [stderr] 408 | | eprintln!("{}", self); [INFO] [stderr] 409 | | if !std::thread::panicking() { [INFO] [stderr] 410 | | panic!("Some expectations failed.") [INFO] [stderr] 411 | | } [INFO] [stderr] 412 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 407 | if let Expectation::Failed { .. } = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:418:9 [INFO] [stderr] | [INFO] [stderr] 418 | / match self { [INFO] [stderr] 419 | | &Expectation::Failed { ref assertion, ref file, ref line, ref error_msg } => { [INFO] [stderr] 420 | | write!(f, "Expectation '{}' failed, originating from {}:{}\n\t{}", [INFO] [stderr] 421 | | assertion, file, line, error_msg [INFO] [stderr] ... | [INFO] [stderr] 424 | | _ => write!(f, "The expectation has been satisfied") [INFO] [stderr] 425 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 418 | match *self { [INFO] [stderr] 419 | Expectation::Failed { ref assertion, ref file, ref line, ref error_msg } => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/matchers/collection.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | for ref element in actual.into_iter() { [INFO] [stderr] | ^^^^^^^^^^^ ------------------ help: try: `let element = &actual.into_iter();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/matchers/collection.rs:226:16 [INFO] [stderr] | [INFO] [stderr] 226 | if let None = self.expected_to_contain.iter().position(|e| e == element) { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 227 | | builder.failed_because( [INFO] [stderr] 228 | | &format!("{:?} does not contain: {:?}", self.expected_to_contain, element) [INFO] [stderr] 229 | | ) [INFO] [stderr] 230 | | } else { builder.matched() } [INFO] [stderr] | |____________________________________- help: try this: `if self.expected_to_contain.iter().position(|e| e == element).is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:309:9 [INFO] [stderr] | [INFO] [stderr] 309 | / match result { [INFO] [stderr] 310 | | &MatchResult::Matched {..} => true, [INFO] [stderr] 311 | | &MatchResult::Failed {..} => false [INFO] [stderr] 312 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 309 | match *result { [INFO] [stderr] 310 | MatchResult::Matched {..} => true, [INFO] [stderr] 311 | MatchResult::Failed {..} => false [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `MatchResultBuilder` [INFO] [stderr] --> src/lib.rs:326:5 [INFO] [stderr] | [INFO] [stderr] 326 | / pub fn new() -> MatchResultBuilder { [INFO] [stderr] 327 | | MatchResultBuilder { [INFO] [stderr] 328 | | matcher_name: "_unknown_".to_owned() [INFO] [stderr] 329 | | } [INFO] [stderr] 330 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 320 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:407:9 [INFO] [stderr] | [INFO] [stderr] 407 | / if let &mut Expectation::Failed { .. } = self { [INFO] [stderr] 408 | | eprintln!("{}", self); [INFO] [stderr] 409 | | if !std::thread::panicking() { [INFO] [stderr] 410 | | panic!("Some expectations failed.") [INFO] [stderr] 411 | | } [INFO] [stderr] 412 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 407 | if let Expectation::Failed { .. } = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:418:9 [INFO] [stderr] | [INFO] [stderr] 418 | / match self { [INFO] [stderr] 419 | | &Expectation::Failed { ref assertion, ref file, ref line, ref error_msg } => { [INFO] [stderr] 420 | | write!(f, "Expectation '{}' failed, originating from {}:{}\n\t{}", [INFO] [stderr] 421 | | assertion, file, line, error_msg [INFO] [stderr] ... | [INFO] [stderr] 424 | | _ => write!(f, "The expectation has been satisfied") [INFO] [stderr] 425 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 418 | match *self { [INFO] [stderr] 419 | Expectation::Failed { ref assertion, ref file, ref line, ref error_msg } => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/matchers/collection.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | for ref element in actual.into_iter() { [INFO] [stderr] | ^^^^^^^^^^^ ------------------ help: try: `let element = &actual.into_iter();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/matchers/collection.rs:226:16 [INFO] [stderr] | [INFO] [stderr] 226 | if let None = self.expected_to_contain.iter().position(|e| e == element) { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 227 | | builder.failed_because( [INFO] [stderr] 228 | | &format!("{:?} does not contain: {:?}", self.expected_to_contain, element) [INFO] [stderr] 229 | | ) [INFO] [stderr] 230 | | } else { builder.matched() } [INFO] [stderr] | |____________________________________- help: try this: `if self.expected_to_contain.iter().position(|e| e == element).is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `==` [INFO] [stderr] --> tests/expectations.rs:30:42 [INFO] [stderr] | [INFO] [stderr] 30 | let e = get_expectation_for!(1 == 1); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::eq_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `==` [INFO] [stderr] --> tests/expectations.rs:35:42 [INFO] [stderr] | [INFO] [stderr] 35 | let e = get_expectation_for!(1 == 1); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `==` [INFO] [stderr] --> tests/expectations.rs:42:43 [INFO] [stderr] | [INFO] [stderr] 42 | let e1 = get_expectation_for!(1 == 1); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `==` [INFO] [stderr] --> tests/expectations.rs:44:43 [INFO] [stderr] | [INFO] [stderr] 44 | let e2 = get_expectation_for!(1 == 1, otherwise "failed"); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `!=` [INFO] [stderr] --> tests/expectations.rs:51:42 [INFO] [stderr] | [INFO] [stderr] 51 | let e = get_expectation_for!(1 != 1); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `!=` [INFO] [stderr] --> tests/expectations.rs:57:42 [INFO] [stderr] | [INFO] [stderr] 57 | let e = get_expectation_for!(1 != 1); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `!=` [INFO] [stderr] --> tests/expectations.rs:63:43 [INFO] [stderr] | [INFO] [stderr] 63 | let e1 = get_expectation_for!(1 != 1); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `!=` [INFO] [stderr] --> tests/expectations.rs:64:43 [INFO] [stderr] | [INFO] [stderr] 64 | let e2 = get_expectation_for!(1 != 1, otherwise "failed"); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `!=` [INFO] [stderr] --> tests/expectations.rs:71:43 [INFO] [stderr] | [INFO] [stderr] 71 | let e1 = get_expectation_for!(1 != 1); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `==` [INFO] [stderr] --> tests/expectations.rs:72:43 [INFO] [stderr] | [INFO] [stderr] 72 | let e2 = get_expectation_for!(1 == 1); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] warning: unused comparison that must be used [INFO] [stderr] --> tests/expectations.rs:91:42 [INFO] [stderr] | [INFO] [stderr] 91 | let e = get_expectation_for!(1 == 1, panics); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] [INFO] [stderr] warning: statement with no effect [INFO] [stderr] --> tests/expectations.rs:91:21 [INFO] [stderr] | [INFO] [stderr] 91 | let e = get_expectation_for!(1 == 1, panics); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::no_effect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `==` [INFO] [stderr] --> tests/expectations.rs:91:42 [INFO] [stderr] | [INFO] [stderr] 91 | let e = get_expectation_for!(1 == 1, panics); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] warning: unused comparison that must be used [INFO] [stderr] --> tests/expectations.rs:101:42 [INFO] [stderr] | [INFO] [stderr] 101 | let e = get_expectation_for!(1 == 1, does not panic); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: statement with no effect [INFO] [stderr] --> tests/expectations.rs:101:21 [INFO] [stderr] | [INFO] [stderr] 101 | let e = get_expectation_for!(1 == 1, does not panic); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `==` [INFO] [stderr] --> tests/expectations.rs:101:42 [INFO] [stderr] | [INFO] [stderr] 101 | let e = get_expectation_for!(1 == 1, does not panic); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `==` [INFO] [stderr] --> tests/expectations.rs:136:26 [INFO] [stderr] | [INFO] [stderr] 136 | expect_that!(1 == 1); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `==` [INFO] [stderr] --> tests/expectations.rs:141:26 [INFO] [stderr] | [INFO] [stderr] 141 | expect_that!(1 == 1); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `==` [INFO] [stderr] --> tests/expectations.rs:142:26 [INFO] [stderr] | [INFO] [stderr] 142 | expect_that!(1 == 1, otherwise "failed"); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `!=` [INFO] [stderr] --> tests/expectations.rs:149:26 [INFO] [stderr] | [INFO] [stderr] 149 | expect_that!(1 != 1); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `!=` [INFO] [stderr] --> tests/expectations.rs:155:26 [INFO] [stderr] | [INFO] [stderr] 155 | expect_that!(1 != 1); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `!=` [INFO] [stderr] --> tests/expectations.rs:156:26 [INFO] [stderr] | [INFO] [stderr] 156 | expect_that!(1 != 1, otherwise "failed"); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `!=` [INFO] [stderr] --> tests/expectations.rs:162:26 [INFO] [stderr] | [INFO] [stderr] 162 | expect_that!(1 != 1); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `==` [INFO] [stderr] --> tests/expectations.rs:163:26 [INFO] [stderr] | [INFO] [stderr] 163 | expect_that!(1 == 1); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] warning: unused comparison that must be used [INFO] [stderr] --> tests/expectations.rs:178:26 [INFO] [stderr] | [INFO] [stderr] 178 | expect_that!(1 == 1, panics); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: statement with no effect [INFO] [stderr] --> tests/expectations.rs:178:13 [INFO] [stderr] | [INFO] [stderr] 178 | expect_that!(1 == 1, panics); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `==` [INFO] [stderr] --> tests/expectations.rs:178:26 [INFO] [stderr] | [INFO] [stderr] 178 | expect_that!(1 == 1, panics); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] warning: unused comparison that must be used [INFO] [stderr] --> tests/expectations.rs:187:26 [INFO] [stderr] | [INFO] [stderr] 187 | expect_that!(1 == 1, does not panic); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: statement with no effect [INFO] [stderr] --> tests/expectations.rs:187:13 [INFO] [stderr] | [INFO] [stderr] 187 | expect_that!(1 == 1, does not panic); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `==` [INFO] [stderr] --> tests/expectations.rs:187:26 [INFO] [stderr] | [INFO] [stderr] 187 | expect_that!(1 == 1, does not panic); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: aborting due to 22 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `galvanic-assert`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused arithmetic operation that must be used [INFO] [stderr] --> tests/core_matchers.rs:34:26 [INFO] [stderr] | [INFO] [stderr] 34 | assert_that!(&1+1, panics); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] [INFO] [stderr] warning: statement with no effect [INFO] [stderr] --> tests/core_matchers.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | assert_that!(&1+1, panics); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::no_effect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused arithmetic operation that must be used [INFO] [stderr] --> tests/core_matchers.rs:45:22 [INFO] [stderr] | [INFO] [stderr] 45 | assert_that!(&1+1, does not panic); [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: statement with no effect [INFO] [stderr] --> tests/core_matchers.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | assert_that!(&1+1, does not panic); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> tests/core_matchers.rs:236:23 [INFO] [stderr] | [INFO] [stderr] 236 | assert_that!(&3.14, close_to(3.14, 0.001)); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> tests/core_matchers.rs:236:38 [INFO] [stderr] | [INFO] [stderr] 236 | assert_that!(&3.14, close_to(3.14, 0.001)); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> tests/core_matchers.rs:242:41 [INFO] [stderr] | [INFO] [stderr] 242 | assert_that!(&2.2, close_to(3.14, 0.001)), [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> tests/core_matchers.rs:256:13 [INFO] [stderr] | [INFO] [stderr] 256 | let foo = Foo {}; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> tests/core_matchers.rs:280:17 [INFO] [stderr] | [INFO] [stderr] 280 | let foo = Foo { x: 12, y: 23.4 }; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> tests/core_matchers.rs:289:17 [INFO] [stderr] | [INFO] [stderr] 289 | let foo = Foo { x: 12, y: 23.4 }; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> tests/core_matchers.rs:297:17 [INFO] [stderr] | [INFO] [stderr] 297 | let foo = Foo { x: 12, y: 23.4 }; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> tests/core_matchers.rs:311:17 [INFO] [stderr] | [INFO] [stderr] 311 | let bar = Bar(12, 23.4); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> tests/core_matchers.rs:317:17 [INFO] [stderr] | [INFO] [stderr] 317 | let bar = Bar(12, 23.4); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `galvanic-assert`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "4b7db41c22efac5bf16e2b336bcbf854d06647c45eef28e79a3efaac1a608a55"` [INFO] running `"docker" "rm" "-f" "4b7db41c22efac5bf16e2b336bcbf854d06647c45eef28e79a3efaac1a608a55"` [INFO] [stdout] 4b7db41c22efac5bf16e2b336bcbf854d06647c45eef28e79a3efaac1a608a55