[INFO] crate galois_2p8 0.1.1 is already in cache [INFO] extracting crate galois_2p8 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/galois_2p8/0.1.1 [INFO] extracting crate galois_2p8 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/galois_2p8/0.1.1 [INFO] validating manifest of galois_2p8-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of galois_2p8-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing galois_2p8-0.1.1 [INFO] finished frobbing galois_2p8-0.1.1 [INFO] frobbed toml for galois_2p8-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/galois_2p8/0.1.1/Cargo.toml [INFO] started frobbing galois_2p8-0.1.1 [INFO] finished frobbing galois_2p8-0.1.1 [INFO] frobbed toml for galois_2p8-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/galois_2p8/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting galois_2p8-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/galois_2p8/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e430e1e7b51358bb8579c2f402209259e1a38f7e55c69132a3e54e2a098f0853 [INFO] running `"docker" "start" "-a" "e430e1e7b51358bb8579c2f402209259e1a38f7e55c69132a3e54e2a098f0853"` [INFO] [stderr] Checking galois_2p8 v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/field.rs:783:13 [INFO] [stderr] | [INFO] [stderr] 783 | mult_table: mult_table, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `mult_table` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/field.rs:784:13 [INFO] [stderr] | [INFO] [stderr] 784 | div_table: div_table, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `div_table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/field.rs:785:13 [INFO] [stderr] | [INFO] [stderr] 785 | exp_table: exp_table, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `exp_table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/field.rs:1041:13 [INFO] [stderr] | [INFO] [stderr] 1041 | exp_table: exp_table, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `exp_table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/field.rs:1042:13 [INFO] [stderr] | [INFO] [stderr] 1042 | log_table: log_table, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `log_table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/field.rs:1045:13 [INFO] [stderr] | [INFO] [stderr] 1045 | mult_table: mult_table, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `mult_table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/field.rs:1046:13 [INFO] [stderr] | [INFO] [stderr] 1046 | div_table: div_table, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `div_table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/field.rs:783:13 [INFO] [stderr] | [INFO] [stderr] 783 | mult_table: mult_table, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `mult_table` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/field.rs:784:13 [INFO] [stderr] | [INFO] [stderr] 784 | div_table: div_table, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `div_table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/field.rs:785:13 [INFO] [stderr] | [INFO] [stderr] 785 | exp_table: exp_table, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `exp_table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/field.rs:1041:13 [INFO] [stderr] | [INFO] [stderr] 1041 | exp_table: exp_table, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `exp_table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/field.rs:1042:13 [INFO] [stderr] | [INFO] [stderr] 1042 | log_table: log_table, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `log_table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/field.rs:1045:13 [INFO] [stderr] | [INFO] [stderr] 1045 | mult_table: mult_table, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `mult_table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/field.rs:1046:13 [INFO] [stderr] | [INFO] [stderr] 1046 | div_table: div_table, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `div_table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/field.rs:1088:13 [INFO] [stderr] | [INFO] [stderr] 1088 | return *self.pexp_table.offset(log_src + log_scale); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `*self.pexp_table.offset(log_src + log_scale)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/field.rs:1103:13 [INFO] [stderr] | [INFO] [stderr] 1103 | return *self.pexp_table.offset(exp_offset); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `*self.pexp_table.offset(exp_offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/field.rs:1119:13 [INFO] [stderr] | [INFO] [stderr] 1119 | return *self.pexp_table.offset(scale_log + x as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `*self.pexp_table.offset(scale_log + x as isize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/field.rs:173:19 [INFO] [stderr] | [INFO] [stderr] 173 | pub fn to_u16(&self) -> u16 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/field.rs:210:25 [INFO] [stderr] | [INFO] [stderr] 210 | pub fn is_primitive(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/field.rs:211:9 [INFO] [stderr] | [INFO] [stderr] 211 | / match PRIMITIVES.binary_search(self) { [INFO] [stderr] 212 | | Ok(_) => true, [INFO] [stderr] 213 | | Err(_) => false [INFO] [stderr] 214 | | } [INFO] [stderr] | |_________^ help: try this: `PRIMITIVES.binary_search(self).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/field.rs:341:27 [INFO] [stderr] | [INFO] [stderr] 341 | let dst_ptr = dst.offset(i as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `dst.add(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/field.rs:342:27 [INFO] [stderr] | [INFO] [stderr] 342 | let src_ptr = src.offset(i as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `src.add(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `div_table`. [INFO] [stderr] --> src/field.rs:700:14 [INFO] [stderr] | [INFO] [stderr] 700 | for i in 0..32 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 700 | for in div_table.iter_mut().take(32) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: bit mask could be simplified with a call to `trailing_zeros` [INFO] [stderr] --> src/field.rs:726:27 [INFO] [stderr] | [INFO] [stderr] 726 | } else if prod & 0x0f == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `prod.trailing_zeros() >= 4` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::verbose_bit_mask)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#verbose_bit_mask [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/field.rs:905:18 [INFO] [stderr] | [INFO] [stderr] 905 | *dst.offset(i as isize) = 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `dst.add(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: you probably are missing some parameter in your format string [INFO] [stderr] --> src/field.rs:1071:28 [INFO] [stderr] | [INFO] [stderr] 1071 | None => panic!("Polynomial {:?} is not primitive") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::panic_params)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#panic_params [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/field.rs:1166:31 [INFO] [stderr] | [INFO] [stderr] 1166 | let dst_ptr = dst.offset(i as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `dst.add(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/field.rs:1234:28 [INFO] [stderr] | [INFO] [stderr] 1234 | let mut left_working = left as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(left)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/field.rs:1238:20 [INFO] [stderr] | [INFO] [stderr] 1238 | ret ^= right as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(right)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> examples/sbox.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/field.rs:1088:13 [INFO] [stderr] | [INFO] [stderr] 1088 | return *self.pexp_table.offset(log_src + log_scale); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `*self.pexp_table.offset(log_src + log_scale)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/field.rs:1103:13 [INFO] [stderr] | [INFO] [stderr] 1103 | return *self.pexp_table.offset(exp_offset); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `*self.pexp_table.offset(exp_offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/field.rs:1119:13 [INFO] [stderr] | [INFO] [stderr] 1119 | return *self.pexp_table.offset(scale_log + x as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `*self.pexp_table.offset(scale_log + x as isize)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/field.rs:173:19 [INFO] [stderr] | [INFO] [stderr] 173 | pub fn to_u16(&self) -> u16 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/field.rs:210:25 [INFO] [stderr] | [INFO] [stderr] 210 | pub fn is_primitive(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/field.rs:211:9 [INFO] [stderr] | [INFO] [stderr] 211 | / match PRIMITIVES.binary_search(self) { [INFO] [stderr] 212 | | Ok(_) => true, [INFO] [stderr] 213 | | Err(_) => false [INFO] [stderr] 214 | | } [INFO] [stderr] | |_________^ help: try this: `PRIMITIVES.binary_search(self).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/field.rs:341:27 [INFO] [stderr] | [INFO] [stderr] 341 | let dst_ptr = dst.offset(i as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `dst.add(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/field.rs:342:27 [INFO] [stderr] | [INFO] [stderr] 342 | let src_ptr = src.offset(i as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `src.add(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `div_table`. [INFO] [stderr] --> src/field.rs:700:14 [INFO] [stderr] | [INFO] [stderr] 700 | for i in 0..32 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 700 | for in div_table.iter_mut().take(32) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: bit mask could be simplified with a call to `trailing_zeros` [INFO] [stderr] --> src/field.rs:726:27 [INFO] [stderr] | [INFO] [stderr] 726 | } else if prod & 0x0f == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `prod.trailing_zeros() >= 4` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::verbose_bit_mask)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#verbose_bit_mask [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/field.rs:905:18 [INFO] [stderr] | [INFO] [stderr] 905 | *dst.offset(i as isize) = 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `dst.add(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: you probably are missing some parameter in your format string [INFO] [stderr] --> src/field.rs:1071:28 [INFO] [stderr] | [INFO] [stderr] 1071 | None => panic!("Polynomial {:?} is not primitive") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::panic_params)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#panic_params [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/field.rs:1166:31 [INFO] [stderr] | [INFO] [stderr] 1166 | let dst_ptr = dst.offset(i as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `dst.add(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/field.rs:1234:28 [INFO] [stderr] | [INFO] [stderr] 1234 | let mut left_working = left as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(left)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/field.rs:1238:20 [INFO] [stderr] | [INFO] [stderr] 1238 | ret ^= right as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(right)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `found_inverse` [INFO] [stderr] --> src/field_tests.rs:89:14 [INFO] [stderr] | [INFO] [stderr] 89 | for i in 1..=255 { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 89 | for (i, ) in found_inverse.iter().enumerate().take(255 + 1).skip(1) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `dst`. [INFO] [stderr] --> src/field_multiword_tests.rs:46:14 [INFO] [stderr] | [INFO] [stderr] 46 | for i in lower_len..dst.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 46 | for in dst.iter().skip(lower_len) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `src`. [INFO] [stderr] --> src/field_multiword_tests.rs:364:14 [INFO] [stderr] | [INFO] [stderr] 364 | for i in 0..src.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 364 | for in &src { [INFO] [stderr] | ^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `src`. [INFO] [stderr] --> src/field_multiword_tests.rs:427:14 [INFO] [stderr] | [INFO] [stderr] 427 | for i in 0..src.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 427 | for in &src { [INFO] [stderr] | ^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.07s [INFO] running `"docker" "inspect" "e430e1e7b51358bb8579c2f402209259e1a38f7e55c69132a3e54e2a098f0853"` [INFO] running `"docker" "rm" "-f" "e430e1e7b51358bb8579c2f402209259e1a38f7e55c69132a3e54e2a098f0853"` [INFO] [stdout] e430e1e7b51358bb8579c2f402209259e1a38f7e55c69132a3e54e2a098f0853