[INFO] crate galil-seiferas 0.1.5 is already in cache [INFO] extracting crate galil-seiferas 0.1.5 into work/ex/clippy-test-run/sources/stable/reg/galil-seiferas/0.1.5 [INFO] extracting crate galil-seiferas 0.1.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/galil-seiferas/0.1.5 [INFO] validating manifest of galil-seiferas-0.1.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of galil-seiferas-0.1.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing galil-seiferas-0.1.5 [INFO] finished frobbing galil-seiferas-0.1.5 [INFO] frobbed toml for galil-seiferas-0.1.5 written to work/ex/clippy-test-run/sources/stable/reg/galil-seiferas/0.1.5/Cargo.toml [INFO] started frobbing galil-seiferas-0.1.5 [INFO] finished frobbing galil-seiferas-0.1.5 [INFO] frobbed toml for galil-seiferas-0.1.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/galil-seiferas/0.1.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting galil-seiferas-0.1.5 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/galil-seiferas/0.1.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 95286abd3a06c590dc289b9a5c23541d6672dfdafda3fa687e726ec423ecf1da [INFO] running `"docker" "start" "-a" "95286abd3a06c590dc289b9a5c23541d6672dfdafda3fa687e726ec423ecf1da"` [INFO] [stderr] Compiling semver v0.1.20 [INFO] [stderr] Checking defmac v0.1.3 [INFO] [stderr] Checking unchecked-index v0.2.2 [INFO] [stderr] Checking macro-attr v0.2.0 [INFO] [stderr] Checking matches v0.1.8 [INFO] [stderr] Checking rawslice v0.1.0 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking galil-seiferas v0.1.5 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:185:39 [INFO] [stderr] | [INFO] [stderr] 185 | let next_hrp = Some(Hrp { period: period, len: prefix_length }); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `period` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] Checking odds v0.3.1 [INFO] [stderr] Compiling rustc_version v0.1.7 [INFO] [stderr] Checking rand v0.3.23 [INFO] [stderr] Checking quickcheck v0.4.1 [INFO] [stderr] Compiling newtype_derive v0.1.6 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:185:39 [INFO] [stderr] | [INFO] [stderr] 185 | let next_hrp = Some(Hrp { period: period, len: prefix_length }); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `period` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/lib.rs:427:64 [INFO] [stderr] | [INFO] [stderr] 427 | assert_matches!(decompose(s), (_, _, Some(Hrp { period: 2, len: _ }))); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `Hrp { period: 2, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/lib.rs:441:49 [INFO] [stderr] | [INFO] [stderr] 441 | assert_matches!(hrp, Some(Hrp { period: 10, len: _ })); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Hrp { period: 10, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/test_util.rs:27:22 [INFO] [stderr] | [INFO] [stderr] 27 | 'outer: for i in 0..n - m + 1 { [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `0..=n - m` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:89:14 [INFO] [stderr] | [INFO] [stderr] 89 | for i in 0..data.len() + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `0..=data.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> tests/quick.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | #[macro_use] extern crate quickcheck; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> tests/quick.rs:141:22 [INFO] [stderr] | [INFO] [stderr] 141 | for _ in 0..((repeat % 5) + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=(repeat % 5)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> tests/quick.rs:301:12 [INFO] [stderr] | [INFO] [stderr] 301 | if b.len() == 0 { return TestResult::discard() } [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `b.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> tests/quick.rs:310:12 [INFO] [stderr] | [INFO] [stderr] 310 | if b.len() == 0 { return TestResult::discard() } [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `b.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [optimized + debuginfo] target(s) in 8.86s [INFO] running `"docker" "inspect" "95286abd3a06c590dc289b9a5c23541d6672dfdafda3fa687e726ec423ecf1da"` [INFO] running `"docker" "rm" "-f" "95286abd3a06c590dc289b9a5c23541d6672dfdafda3fa687e726ec423ecf1da"` [INFO] [stdout] 95286abd3a06c590dc289b9a5c23541d6672dfdafda3fa687e726ec423ecf1da