[INFO] crate galemu 0.2.2 is already in cache [INFO] extracting crate galemu 0.2.2 into work/ex/clippy-test-run/sources/stable/reg/galemu/0.2.2 [INFO] extracting crate galemu 0.2.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/galemu/0.2.2 [INFO] validating manifest of galemu-0.2.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of galemu-0.2.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing galemu-0.2.2 [INFO] finished frobbing galemu-0.2.2 [INFO] frobbed toml for galemu-0.2.2 written to work/ex/clippy-test-run/sources/stable/reg/galemu/0.2.2/Cargo.toml [INFO] started frobbing galemu-0.2.2 [INFO] finished frobbing galemu-0.2.2 [INFO] frobbed toml for galemu-0.2.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/galemu/0.2.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting galemu-0.2.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/galemu/0.2.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 43bfd5ee5baaae8877d63831f8964dc887180dd6941ee5f4237483aad64b8ecb [INFO] running `"docker" "start" "-a" "43bfd5ee5baaae8877d63831f8964dc887180dd6941ee5f4237483aad64b8ecb"` [INFO] [stderr] Checking galemu v0.2.2 (/opt/crater/workdir) [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/lib.rs:282:30 [INFO] [stderr] | [INFO] [stderr] 282 | let &mut Bound { limiter:_, ref mut inner } = &mut self; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `Bound { ref mut inner, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/lib.rs:282:30 [INFO] [stderr] | [INFO] [stderr] 282 | let &mut Bound { limiter:_, ref mut inner } = &mut self; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `Bound { ref mut inner, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:472:9 [INFO] [stderr] | [INFO] [stderr] 472 | fn commit<'s>(me: Bound<'s, Self>); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:473:9 [INFO] [stderr] | [INFO] [stderr] 473 | fn abort<'s>(me: Bound<'s, Self>); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:377:13 [INFO] [stderr] | [INFO] [stderr] 377 | / $v fn new<$lt>(value: $Inner<$lt>) -> $crate::Bound<$lt, Self> { [INFO] [stderr] 378 | | use std::{ mem::{self, ManuallyDrop}, cell::UnsafeCell }; [INFO] [stderr] 379 | | [INFO] [stderr] 380 | | let cell = ManuallyDrop::new(UnsafeCell::new(value)); [INFO] [stderr] ... | [INFO] [stderr] 386 | | } [INFO] [stderr] 387 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 476 | / create_gal_wrapper_type!{ [INFO] [stderr] 477 | | /// Wraps `Transaction` erasing it's lifetime. [INFO] [stderr] 478 | | /// [INFO] [stderr] 479 | | /// This can only be used through a `Bound<'a, TransWrap>` instance, [INFO] [stderr] ... | [INFO] [stderr] 482 | | struct TransWrap(Transaction<'a>); [INFO] [stderr] 483 | | } [INFO] [stderr] | |_____- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:412:34 [INFO] [stderr] | [INFO] [stderr] 412 | $v fn into_inner<'s>(me: Bound<'s, Self>) -> $Inner<'s> { [INFO] [stderr] | ^^ [INFO] [stderr] ... [INFO] [stderr] 476 | / create_gal_wrapper_type!{ [INFO] [stderr] 477 | | /// Wraps `Transaction` erasing it's lifetime. [INFO] [stderr] 478 | | /// [INFO] [stderr] 479 | | /// This can only be used through a `Bound<'a, TransWrap>` instance, [INFO] [stderr] ... | [INFO] [stderr] 482 | | struct TransWrap(Transaction<'a>); [INFO] [stderr] 483 | | } [INFO] [stderr] | |_____- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:495:9 [INFO] [stderr] | [INFO] [stderr] 495 | / fn commit<'s>(me: Bound<'s, Self>) { [INFO] [stderr] 496 | | let trans = TransWrap::into_inner(me); [INFO] [stderr] 497 | | trans.conn.count += 10; [INFO] [stderr] 498 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:500:9 [INFO] [stderr] | [INFO] [stderr] 500 | / fn abort<'s>(me: Bound<'s, Self>) { [INFO] [stderr] 501 | | let trans = TransWrap::into_inner(me); [INFO] [stderr] 502 | | trans.conn.count += 3; [INFO] [stderr] 503 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.32s [INFO] running `"docker" "inspect" "43bfd5ee5baaae8877d63831f8964dc887180dd6941ee5f4237483aad64b8ecb"` [INFO] running `"docker" "rm" "-f" "43bfd5ee5baaae8877d63831f8964dc887180dd6941ee5f4237483aad64b8ecb"` [INFO] [stdout] 43bfd5ee5baaae8877d63831f8964dc887180dd6941ee5f4237483aad64b8ecb