[INFO] crate gaia 0.2.1 is already in cache [INFO] extracting crate gaia 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/gaia/0.2.1 [INFO] extracting crate gaia 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gaia/0.2.1 [INFO] validating manifest of gaia-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of gaia-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing gaia-0.2.1 [INFO] finished frobbing gaia-0.2.1 [INFO] frobbed toml for gaia-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/gaia/0.2.1/Cargo.toml [INFO] started frobbing gaia-0.2.1 [INFO] finished frobbing gaia-0.2.1 [INFO] frobbed toml for gaia-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gaia/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting gaia-0.2.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/gaia/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1e44f5034f4d4ab131b2e2f9595665ee0dae3a42a13731c3b5d6c0402bdd76f0 [INFO] running `"docker" "start" "-a" "1e44f5034f4d4ab131b2e2f9595665ee0dae3a42a13731c3b5d6c0402bdd76f0"` [INFO] [stderr] Checking quaternion v0.3.1 [INFO] [stderr] Checking fps_counter v0.2.0 [INFO] [stderr] Compiling gl v0.10.0 [INFO] [stderr] Checking cgmath v0.15.0 [INFO] [stderr] Checking png v0.11.0 [INFO] [stderr] Checking num-rational v0.2.1 [INFO] [stderr] Checking nalgebra v0.16.13 [INFO] [stderr] Checking gfx_core v0.8.3 [INFO] [stderr] Checking pistoncore-input v0.20.0 [INFO] [stderr] Checking geo v0.4.13 [INFO] [stderr] Checking piston2d-graphics v0.26.0 [INFO] [stderr] Checking piston3d-cam v0.3.0 [INFO] [stderr] Checking num v0.2.0 [INFO] [stderr] Checking gaia_quadtree v0.1.7 [INFO] [stderr] Checking wayland-window v0.13.3 [INFO] [stderr] Checking image v0.18.0 [INFO] [stderr] Checking geojson v0.8.1 [INFO] [stderr] Checking pistoncore-window v0.31.0 [INFO] [stderr] Checking collision v0.12.0 [INFO] [stderr] Checking winit v0.10.0 [INFO] [stderr] Checking pistoncore-event_loop v0.36.0 [INFO] [stderr] Checking gaia_assetgen v0.3.2 [INFO] [stderr] Checking piston v0.36.0 [INFO] [stderr] Checking glutin v0.12.2 [INFO] [stderr] Checking pistoncore-glutin_window v0.45.3 [INFO] [stderr] Checking gfx v0.17.1 [INFO] [stderr] Checking gfx_device_gl v0.15.5 [INFO] [stderr] Checking piston-gfx_texture v0.31.0 [INFO] [stderr] Checking gfx_glyph v0.9.1 [INFO] [stderr] Checking spade v1.6.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.50.0 [INFO] [stderr] Checking geo v0.6.3 [INFO] [stderr] Checking piston_window v0.77.0 [INFO] [stderr] Checking gfx_draping v0.3.0 [INFO] [stderr] Checking gaia v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/render/terrain.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/render/terrain.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/render/polygon.rs:149:60 [INFO] [stderr] | [INFO] [stderr] 149 | * Matrix4::from_nonuniform_scale(2.0, 1.0, (max_z - min_z)); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/render/polygon.rs:250:5 [INFO] [stderr] | [INFO] [stderr] 250 | return t * 0.03; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `t * 0.03` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/render/polygon.rs:149:60 [INFO] [stderr] | [INFO] [stderr] 149 | * Matrix4::from_nonuniform_scale(2.0, 1.0, (max_z - min_z)); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/render/polygon.rs:250:5 [INFO] [stderr] | [INFO] [stderr] 250 | return t * 0.03; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `t * 0.03` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/render/terrain.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | / pub fn render>( [INFO] [stderr] 57 | | &mut self, [INFO] [stderr] 58 | | encoder: &mut gfx::Encoder, [INFO] [stderr] 59 | | target: gfx::handle::RenderTargetView, [INFO] [stderr] ... | [INFO] [stderr] 89 | | encoder.draw(&slice, &self.pso, &data); [INFO] [stderr] 90 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/render/polygon.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | / pub fn render>( [INFO] [stderr] 94 | | &mut self, [INFO] [stderr] 95 | | encoder: &mut gfx::Encoder, [INFO] [stderr] 96 | | target: gfx::handle::RenderTargetView, [INFO] [stderr] ... | [INFO] [stderr] 244 | | .unwrap(); [INFO] [stderr] 245 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/render/polygon.rs:126:43 [INFO] [stderr] | [INFO] [stderr] 126 | batch.1 = batch.1.min(metadata.min_elevation as f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(metadata.min_elevation)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/render/polygon.rs:127:43 [INFO] [stderr] | [INFO] [stderr] 127 | batch.2 = batch.2.max(metadata.max_elevation as f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(metadata.max_elevation)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/render/polygon.rs:146:37 [INFO] [stderr] | [INFO] [stderr] 146 | let translate_x = 2.0 * offset as f32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f32::from(offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/render/polygon.rs:152:17 [INFO] [stderr] | [INFO] [stderr] 152 | color[0] as f32 / 255.0, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f32::from(color[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/render/polygon.rs:153:17 [INFO] [stderr] | [INFO] [stderr] 153 | color[1] as f32 / 255.0, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f32::from(color[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/render/polygon.rs:154:17 [INFO] [stderr] | [INFO] [stderr] 154 | color[2] as f32 / 255.0, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f32::from(color[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/render/polygon.rs:155:17 [INFO] [stderr] | [INFO] [stderr] 155 | color[3] as f32 / 255.0, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f32::from(color[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/render/polygon.rs:177:55 [INFO] [stderr] | [INFO] [stderr] 177 | 2.0 * (point.coordinates[0] + offset as f32), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f32::from(offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/render/polygon.rs:185:44 [INFO] [stderr] | [INFO] [stderr] 185 | let (width, height) = (width as f32, height as f32); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f32::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/render/polygon.rs:185:58 [INFO] [stderr] | [INFO] [stderr] 185 | let (width, height) = (width as f32, height as f32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f32::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/render/mod.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | / pub fn render< [INFO] [stderr] 53 | | C: gfx::CommandBuffer, [INFO] [stderr] 54 | | Matrix: Into>, [INFO] [stderr] 55 | | Vector: Into>, [INFO] [stderr] ... | [INFO] [stderr] 118 | | Ok(()) [INFO] [stderr] 119 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/render/mod.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | mvp.clone(), [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `mvp` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/tile_chooser.rs:24:6 [INFO] [stderr] | [INFO] [stderr] 24 | ) -> (u8, Vec<(Tile, Vec)>, Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/tile_chooser.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | width = width / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `width /= 2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x` [INFO] [stderr] --> src/tile_chooser.rs:98:25 [INFO] [stderr] | [INFO] [stderr] 98 | let a = (x + 0) + (y + 0) * ELEVATION_TILE_SIZE; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `y` [INFO] [stderr] --> src/tile_chooser.rs:98:35 [INFO] [stderr] | [INFO] [stderr] 98 | let a = (x + 0) + (y + 0) * ELEVATION_TILE_SIZE; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x` [INFO] [stderr] --> src/tile_chooser.rs:99:25 [INFO] [stderr] | [INFO] [stderr] 99 | let b = (x + 0) + (y + 1) * ELEVATION_TILE_SIZE; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `y` [INFO] [stderr] --> src/tile_chooser.rs:100:35 [INFO] [stderr] | [INFO] [stderr] 100 | let c = (x + 1) + (y + 0) * ELEVATION_TILE_SIZE; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/render/terrain.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | / pub fn render>( [INFO] [stderr] 57 | | &mut self, [INFO] [stderr] 58 | | encoder: &mut gfx::Encoder, [INFO] [stderr] 59 | | target: gfx::handle::RenderTargetView, [INFO] [stderr] ... | [INFO] [stderr] 89 | | encoder.draw(&slice, &self.pso, &data); [INFO] [stderr] 90 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/render/polygon.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | / pub fn render>( [INFO] [stderr] 94 | | &mut self, [INFO] [stderr] 95 | | encoder: &mut gfx::Encoder, [INFO] [stderr] 96 | | target: gfx::handle::RenderTargetView, [INFO] [stderr] ... | [INFO] [stderr] 244 | | .unwrap(); [INFO] [stderr] 245 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/render/polygon.rs:126:43 [INFO] [stderr] | [INFO] [stderr] 126 | batch.1 = batch.1.min(metadata.min_elevation as f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(metadata.min_elevation)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/render/polygon.rs:127:43 [INFO] [stderr] | [INFO] [stderr] 127 | batch.2 = batch.2.max(metadata.max_elevation as f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(metadata.max_elevation)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/render/polygon.rs:146:37 [INFO] [stderr] | [INFO] [stderr] 146 | let translate_x = 2.0 * offset as f32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f32::from(offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/render/polygon.rs:152:17 [INFO] [stderr] | [INFO] [stderr] 152 | color[0] as f32 / 255.0, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f32::from(color[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/render/polygon.rs:153:17 [INFO] [stderr] | [INFO] [stderr] 153 | color[1] as f32 / 255.0, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f32::from(color[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/render/polygon.rs:154:17 [INFO] [stderr] | [INFO] [stderr] 154 | color[2] as f32 / 255.0, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f32::from(color[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/render/polygon.rs:155:17 [INFO] [stderr] | [INFO] [stderr] 155 | color[3] as f32 / 255.0, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f32::from(color[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/render/polygon.rs:177:55 [INFO] [stderr] | [INFO] [stderr] 177 | 2.0 * (point.coordinates[0] + offset as f32), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f32::from(offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/render/polygon.rs:185:44 [INFO] [stderr] | [INFO] [stderr] 185 | let (width, height) = (width as f32, height as f32); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f32::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/render/polygon.rs:185:58 [INFO] [stderr] | [INFO] [stderr] 185 | let (width, height) = (width as f32, height as f32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f32::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/render/mod.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | / pub fn render< [INFO] [stderr] 53 | | C: gfx::CommandBuffer, [INFO] [stderr] 54 | | Matrix: Into>, [INFO] [stderr] 55 | | Vector: Into>, [INFO] [stderr] ... | [INFO] [stderr] 118 | | Ok(()) [INFO] [stderr] 119 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/render/mod.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | mvp.clone(), [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `mvp` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/tile_chooser.rs:24:6 [INFO] [stderr] | [INFO] [stderr] 24 | ) -> (u8, Vec<(Tile, Vec)>, Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/tile_chooser.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | width = width / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `width /= 2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x` [INFO] [stderr] --> src/tile_chooser.rs:98:25 [INFO] [stderr] | [INFO] [stderr] 98 | let a = (x + 0) + (y + 0) * ELEVATION_TILE_SIZE; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `y` [INFO] [stderr] --> src/tile_chooser.rs:98:35 [INFO] [stderr] | [INFO] [stderr] 98 | let a = (x + 0) + (y + 0) * ELEVATION_TILE_SIZE; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x` [INFO] [stderr] --> src/tile_chooser.rs:99:25 [INFO] [stderr] | [INFO] [stderr] 99 | let b = (x + 0) + (y + 1) * ELEVATION_TILE_SIZE; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `y` [INFO] [stderr] --> src/tile_chooser.rs:100:35 [INFO] [stderr] | [INFO] [stderr] 100 | let c = (x + 1) + (y + 0) * ELEVATION_TILE_SIZE; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 36s [INFO] running `"docker" "inspect" "1e44f5034f4d4ab131b2e2f9595665ee0dae3a42a13731c3b5d6c0402bdd76f0"` [INFO] running `"docker" "rm" "-f" "1e44f5034f4d4ab131b2e2f9595665ee0dae3a42a13731c3b5d6c0402bdd76f0"` [INFO] [stdout] 1e44f5034f4d4ab131b2e2f9595665ee0dae3a42a13731c3b5d6c0402bdd76f0