[INFO] crate gaffe-xilinx 0.1.0 is already in cache
[INFO] extracting crate gaffe-xilinx 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/gaffe-xilinx/0.1.0
[INFO] extracting crate gaffe-xilinx 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gaffe-xilinx/0.1.0
[INFO] validating manifest of gaffe-xilinx-0.1.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of gaffe-xilinx-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing gaffe-xilinx-0.1.0
[INFO] finished frobbing gaffe-xilinx-0.1.0
[INFO] frobbed toml for gaffe-xilinx-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/gaffe-xilinx/0.1.0/Cargo.toml
[INFO] started frobbing gaffe-xilinx-0.1.0
[INFO] finished frobbing gaffe-xilinx-0.1.0
[INFO] frobbed toml for gaffe-xilinx-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gaffe-xilinx/0.1.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting gaffe-xilinx-0.1.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/gaffe-xilinx/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 5327264116aaf5d619f40bc1e323a4c15820ca25aab04a2c000f5dc5d8c813ad
[INFO] running `"docker" "start" "-a" "5327264116aaf5d619f40bc1e323a4c15820ca25aab04a2c000f5dc5d8c813ad"`
[INFO] [stderr]    Compiling packed_struct v0.2.3
[INFO] [stderr]    Compiling smart-default v0.2.0
[INFO] [stderr]    Compiling strum_macros v0.9.1
[INFO] [stderr]    Compiling packed_struct_codegen v0.2.4
[INFO] [stderr]     Checking gaffe-xilinx v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: using `writeln!(f, "")`
[INFO] [stderr]    --> src/xc7/bitstream.rs:162:13
[INFO] [stderr]     |
[INFO] [stderr] 162 |             writeln!(f, "")?;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(f)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::writeln_empty_string)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `writeln!(f, "")`
[INFO] [stderr]    --> src/xc7/bitstream.rs:184:9
[INFO] [stderr]     |
[INFO] [stderr] 184 |         writeln!(f, "")?;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(f)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/xc7/bitstream.rs:246:21
[INFO] [stderr]     |
[INFO] [stderr] 246 |                     payload: payload,
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^ help: replace it with: `payload`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/xc7/bitstream.rs:258:21
[INFO] [stderr]     |
[INFO] [stderr] 258 |                     payload: payload,
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^ help: replace it with: `payload`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/xc7/bitstream.rs:356:22
[INFO] [stderr]     |
[INFO] [stderr] 356 |         Ok(Bitstream{packets: packets})
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^ help: replace it with: `packets`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `writeln!(f, "")`
[INFO] [stderr]   --> src/xc7/configuration.rs:20:9
[INFO] [stderr]    |
[INFO] [stderr] 20 |         writeln!(f, "")?;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(f)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `writeln!(f, "")`
[INFO] [stderr]   --> src/xc7/configuration.rs:31:13
[INFO] [stderr]    |
[INFO] [stderr] 31 |             writeln!(f, "")?;
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(f)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/xc7/frame_address.rs:61:31
[INFO] [stderr]    |
[INFO] [stderr] 61 |             Some(FrameAddress{minor: minor, .. self})
[INFO] [stderr]    |                               ^^^^^^^^^^^^ help: replace it with: `minor`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/xc7/frame_address.rs:169:23
[INFO] [stderr]     |
[INFO] [stderr] 169 |             Some(Self{length: length, .. *self})
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^ help: replace it with: `length`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/xc7/frame_address.rs:600:14
[INFO] [stderr]     |
[INFO] [stderr] 600 |         Self{ranges: ranges}
[INFO] [stderr]     |              ^^^^^^^^^^^^^^ help: replace it with: `ranges`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `writeln!(f, "")`
[INFO] [stderr]    --> src/xc7/bitstream.rs:162:13
[INFO] [stderr]     |
[INFO] [stderr] 162 |             writeln!(f, "")?;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(f)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::writeln_empty_string)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `writeln!(f, "")`
[INFO] [stderr]    --> src/xc7/bitstream.rs:184:9
[INFO] [stderr]     |
[INFO] [stderr] 184 |         writeln!(f, "")?;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(f)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/xc7/bitstream.rs:246:21
[INFO] [stderr]     |
[INFO] [stderr] 246 |                     payload: payload,
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^ help: replace it with: `payload`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/xc7/bitstream.rs:258:21
[INFO] [stderr]     |
[INFO] [stderr] 258 |                     payload: payload,
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^ help: replace it with: `payload`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/xc7/bitstream.rs:356:22
[INFO] [stderr]     |
[INFO] [stderr] 356 |         Ok(Bitstream{packets: packets})
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^ help: replace it with: `packets`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `writeln!(f, "")`
[INFO] [stderr]   --> src/xc7/configuration.rs:20:9
[INFO] [stderr]    |
[INFO] [stderr] 20 |         writeln!(f, "")?;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(f)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `writeln!(f, "")`
[INFO] [stderr]   --> src/xc7/configuration.rs:31:13
[INFO] [stderr]    |
[INFO] [stderr] 31 |             writeln!(f, "")?;
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(f)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/xc7/frame_address.rs:61:31
[INFO] [stderr]    |
[INFO] [stderr] 61 |             Some(FrameAddress{minor: minor, .. self})
[INFO] [stderr]    |                               ^^^^^^^^^^^^ help: replace it with: `minor`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/xc7/frame_address.rs:169:23
[INFO] [stderr]     |
[INFO] [stderr] 169 |             Some(Self{length: length, .. *self})
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^ help: replace it with: `length`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/xc7/frame_address.rs:600:14
[INFO] [stderr]     |
[INFO] [stderr] 600 |         Self{ranges: ranges}
[INFO] [stderr]     |              ^^^^^^^^^^^^^^ help: replace it with: `ranges`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: All variants have the same prefix: `Type`
[INFO] [stderr]   --> src/xc7/bitstream.rs:62:1
[INFO] [stderr]    |
[INFO] [stderr] 62 | / enum PacketType {
[INFO] [stderr] 63 | |     Type0 = 0b000,
[INFO] [stderr] 64 | |     Type1 = 0b001,
[INFO] [stderr] 65 | |     Type2 = 0b010,
[INFO] [stderr] 66 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::enum_variant_names)] on by default
[INFO] [stderr]    = help: remove the prefixes and use full paths to the variants instead of glob imports
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
[INFO] [stderr] 
[INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead
[INFO] [stderr]   --> src/xc7/configuration.rs:59:21
[INFO] [stderr]    |
[INFO] [stderr] 59 |                     opcode: _,
[INFO] [stderr]    |                     ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unneeded_field_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead
[INFO] [stderr]   --> src/xc7/configuration.rs:61:21
[INFO] [stderr]    |
[INFO] [stderr] 61 |                     payload: _,
[INFO] [stderr]    |                     ^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: Try with `Type1 { address, .. }`
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/xc7/frame_address.rs:135:9
[INFO] [stderr]     |
[INFO] [stderr] 135 |         return addr >= &self.start && addr <= &self.last();
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `addr >= &self.start && addr <= &self.last()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/xc7/frame_address.rs:142:13
[INFO] [stderr]     |
[INFO] [stderr] 142 |             return (self.start, None)
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(self.start, None)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/xc7/frame_address.rs:144:13
[INFO] [stderr]     |
[INFO] [stderr] 144 | /             return (self.start, Some(
[INFO] [stderr] 145 | |                 Range{
[INFO] [stderr] 146 | |                     start: (self.start + 1).expect("minor address overflow while splitting off first from range"),
[INFO] [stderr] 147 | |                     length: self.length - 1
[INFO] [stderr] 148 | |                 }))
[INFO] [stderr]     | |___________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 144 |             (self.start, Some(
[INFO] [stderr] 145 |                 Range{
[INFO] [stderr] 146 |                     start: (self.start + 1).expect("minor address overflow while splitting off first from range"),
[INFO] [stderr] 147 |                     length: self.length - 1
[INFO] [stderr] 148 |                 }))
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/xc7/frame_address.rs:184:13
[INFO] [stderr]     |
[INFO] [stderr] 184 |             return (None, Some(self))
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(None, Some(self))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/xc7/frame_address.rs:194:13
[INFO] [stderr]     |
[INFO] [stderr] 194 |             return (Some(before), Some(after))
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(Some(before), Some(after))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/xc7/frame_address.rs:196:13
[INFO] [stderr]     |
[INFO] [stderr] 196 |             return (Some(self), None)
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(Some(self), None)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: All variants have the same prefix: `Type`
[INFO] [stderr]   --> src/xc7/bitstream.rs:62:1
[INFO] [stderr]    |
[INFO] [stderr] 62 | / enum PacketType {
[INFO] [stderr] 63 | |     Type0 = 0b000,
[INFO] [stderr] 64 | |     Type1 = 0b001,
[INFO] [stderr] 65 | |     Type2 = 0b010,
[INFO] [stderr] 66 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::enum_variant_names)] on by default
[INFO] [stderr]    = help: remove the prefixes and use full paths to the variants instead of glob imports
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
[INFO] [stderr] 
[INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead
[INFO] [stderr]   --> src/xc7/configuration.rs:59:21
[INFO] [stderr]    |
[INFO] [stderr] 59 |                     opcode: _,
[INFO] [stderr]    |                     ^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unneeded_field_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead
[INFO] [stderr]   --> src/xc7/configuration.rs:61:21
[INFO] [stderr]    |
[INFO] [stderr] 61 |                     payload: _,
[INFO] [stderr]    |                     ^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: Try with `Type1 { address, .. }`
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/xc7/frame_address.rs:135:9
[INFO] [stderr]     |
[INFO] [stderr] 135 |         return addr >= &self.start && addr <= &self.last();
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `addr >= &self.start && addr <= &self.last()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/xc7/frame_address.rs:142:13
[INFO] [stderr]     |
[INFO] [stderr] 142 |             return (self.start, None)
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(self.start, None)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/xc7/frame_address.rs:144:13
[INFO] [stderr]     |
[INFO] [stderr] 144 | /             return (self.start, Some(
[INFO] [stderr] 145 | |                 Range{
[INFO] [stderr] 146 | |                     start: (self.start + 1).expect("minor address overflow while splitting off first from range"),
[INFO] [stderr] 147 | |                     length: self.length - 1
[INFO] [stderr] 148 | |                 }))
[INFO] [stderr]     | |___________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 144 |             (self.start, Some(
[INFO] [stderr] 145 |                 Range{
[INFO] [stderr] 146 |                     start: (self.start + 1).expect("minor address overflow while splitting off first from range"),
[INFO] [stderr] 147 |                     length: self.length - 1
[INFO] [stderr] 148 |                 }))
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/xc7/frame_address.rs:184:13
[INFO] [stderr]     |
[INFO] [stderr] 184 |             return (None, Some(self))
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(None, Some(self))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/xc7/frame_address.rs:194:13
[INFO] [stderr]     |
[INFO] [stderr] 194 |             return (Some(before), Some(after))
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(Some(before), Some(after))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/xc7/frame_address.rs:196:13
[INFO] [stderr]     |
[INFO] [stderr] 196 |             return (Some(self), None)
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(Some(self), None)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]   --> src/from_bytes.rs:51:12
[INFO] [stderr]    |
[INFO] [stderr] 51 |         Ok(writer.write_all(&packed_bytes).context("I/O error while writing packed struct as bytes")?)
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unit_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]    |
[INFO] [stderr] 51 |         Ok(())
[INFO] [stderr]    |            ^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/xc7/bitstream.rs:156:56
[INFO] [stderr]     |
[INFO] [stderr] 156 | fn write_reg_value<T>(f: &mut fmt::Formatter, payload: &Vec<Word>) -> fmt::Result
[INFO] [stderr]     |                                                        ^^^^^^^^^^ help: change this to: `&[Word]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/xc7/bitstream.rs:172:51
[INFO] [stderr]     |
[INFO] [stderr] 172 | fn write_payload(f: &mut fmt::Formatter, payload: &Vec<Word>) -> fmt::Result
[INFO] [stderr]     |                                                   ^^^^^^^^^^ help: change this to: `&[Word]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: struct update has no effect, all the fields in the struct have already been specified
[INFO] [stderr]    --> src/xc7/bitstream.rs:298:23
[INFO] [stderr]     |
[INFO] [stderr] 298 |                     ..Type2Header::default()
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_update)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/xc7/bitstream.rs:349:16
[INFO] [stderr]     |
[INFO] [stderr] 349 |             if bytes.fill_buf()?.len() == 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `bytes.fill_buf()?.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/xc7/configuration.rs:57:13
[INFO] [stderr]    |
[INFO] [stderr] 57 | /             match packet {
[INFO] [stderr] 58 | |                 Packet::Type1{
[INFO] [stderr] 59 | |                     opcode: _,
[INFO] [stderr] 60 | |                     address,
[INFO] [stderr] ...  |
[INFO] [stderr] 63 | |                 _ => (),
[INFO] [stderr] 64 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 57 |             if let Packet::Type1{
[INFO] [stderr] 58 |                     opcode: _,
[INFO] [stderr] 59 |                     address,
[INFO] [stderr] 60 |                     payload: _,
[INFO] [stderr] 61 |                 } = packet { last_register_address = *address }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/xc7/configuration.rs:434:18
[INFO] [stderr]     |
[INFO] [stderr] 434 |             row: 31.into(),
[INFO] [stderr]     |                  ^^^^^^^^^ help: consider removing `.into()`: `31`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/xc7/configuration.rs:435:21
[INFO] [stderr]     |
[INFO] [stderr] 435 |             column: 0u16.into(),
[INFO] [stderr]     |                     ^^^^^^^^^^^ help: consider removing `.into()`: `0u16`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/xc7/configuration.rs:436:20
[INFO] [stderr]     |
[INFO] [stderr] 436 |             minor: 0.into(),
[INFO] [stderr]     |                    ^^^^^^^^ help: consider removing `.into()`: `0`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]   --> src/from_bytes.rs:51:12
[INFO] [stderr]    |
[INFO] [stderr] 51 |         Ok(writer.write_all(&packed_bytes).context("I/O error while writing packed struct as bytes")?)
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unit_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]    |
[INFO] [stderr] 51 |         Ok(())
[INFO] [stderr]    |            ^^
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/xc7/frame_address.rs:51:24
[INFO] [stderr]    |
[INFO] [stderr] 51 |     pub fn in_same_row(&self, other: &FrameAddress) -> bool {
[INFO] [stderr]    |                        ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/xc7/frame_address.rs:51:38
[INFO] [stderr]    |
[INFO] [stderr] 51 |     pub fn in_same_row(&self, other: &FrameAddress) -> bool {
[INFO] [stderr]    |                                      ^^^^^^^^^^^^^ help: consider passing by value instead: `FrameAddress`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you probably are missing some parameter in your format string
[INFO] [stderr]   --> src/xc7/frame_address.rs:83:28
[INFO] [stderr]    |
[INFO] [stderr] 83 |             None => panic!("FrameAddress{minor: 0} + 1 yielded no result"),
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::panic_params)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#panic_params
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/xc7/bitstream.rs:156:56
[INFO] [stderr]     |
[INFO] [stderr] 156 | fn write_reg_value<T>(f: &mut fmt::Formatter, payload: &Vec<Word>) -> fmt::Result
[INFO] [stderr]     |                                                        ^^^^^^^^^^ help: change this to: `&[Word]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/xc7/bitstream.rs:172:51
[INFO] [stderr]     |
[INFO] [stderr] 172 | fn write_payload(f: &mut fmt::Formatter, payload: &Vec<Word>) -> fmt::Result
[INFO] [stderr]     |                                                   ^^^^^^^^^^ help: change this to: `&[Word]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/xc7/frame_address.rs:134:21
[INFO] [stderr]     |
[INFO] [stderr] 134 |     pub fn contains(&self, addr: &FrameAddress) -> bool {
[INFO] [stderr]     |                     ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/xc7/frame_address.rs:134:34
[INFO] [stderr]     |
[INFO] [stderr] 134 |     pub fn contains(&self, addr: &FrameAddress) -> bool {
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^ help: consider passing by value instead: `FrameAddress`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: taken reference of right operand
[INFO] [stderr]    --> src/xc7/frame_address.rs:135:16
[INFO] [stderr]     |
[INFO] [stderr] 135 |         return addr >= &self.start && addr <= &self.last();
[INFO] [stderr]     |                ^^^^^^^^-----------
[INFO] [stderr]     |                        |
[INFO] [stderr]     |                        help: use the right value directly: `self.start`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: taken reference of right operand
[INFO] [stderr]    --> src/xc7/frame_address.rs:135:39
[INFO] [stderr]     |
[INFO] [stderr] 135 |         return addr >= &self.start && addr <= &self.last();
[INFO] [stderr]     |                                       ^^^^^^^^------------
[INFO] [stderr]     |                                               |
[INFO] [stderr]     |                                               help: use the right value directly: `self.last()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/xc7/frame_address.rs:153:17
[INFO] [stderr]     |
[INFO] [stderr] 153 |     pub fn last(&self) -> FrameAddress {
[INFO] [stderr]     |                 ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/xc7/frame_address.rs:158:17
[INFO] [stderr]     |
[INFO] [stderr] 158 |     pub fn iter(&self) -> RangeIter {
[INFO] [stderr]     |                 ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/xc7/frame_address.rs:167:19
[INFO] [stderr]     |
[INFO] [stderr] 167 |     pub fn extend(&self, amount: u8) -> Option<Self> {
[INFO] [stderr]     |                   ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/xc7/frame_address.rs:182:33
[INFO] [stderr]     |
[INFO] [stderr] 182 |     pub fn split(self, address: &FrameAddress) -> (Option<Range>, Option<Range>) {
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^ help: consider passing by value instead: `FrameAddress`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: struct update has no effect, all the fields in the struct have already been specified
[INFO] [stderr]    --> src/xc7/bitstream.rs:298:23
[INFO] [stderr]     |
[INFO] [stderr] 298 |                     ..Type2Header::default()
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_update)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/xc7/bitstream.rs:349:16
[INFO] [stderr]     |
[INFO] [stderr] 349 |             if bytes.fill_buf()?.len() == 0 {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `bytes.fill_buf()?.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/xc7/frame_address.rs:548:34
[INFO] [stderr]     |
[INFO] [stderr] 548 |     pub fn contains(&self, addr: &FrameAddress) -> bool {
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^ help: consider passing by value instead: `FrameAddress`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/xc7/frame_address.rs:556:5
[INFO] [stderr]     |
[INFO] [stderr] 556 | /     pub fn iter_ranges<'a>(&'a self) -> btree_set::Iter<'a, Range> {
[INFO] [stderr] 557 | |         self.ranges.iter()
[INFO] [stderr] 558 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/xc7/frame_address.rs:815:37
[INFO] [stderr]     |
[INFO] [stderr] 815 |     pub fn skip_past(self, address: &FrameAddress) -> Self {
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^ help: consider passing by value instead: `FrameAddress`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/xc7/configuration.rs:57:13
[INFO] [stderr]    |
[INFO] [stderr] 57 | /             match packet {
[INFO] [stderr] 58 | |                 Packet::Type1{
[INFO] [stderr] 59 | |                     opcode: _,
[INFO] [stderr] 60 | |                     address,
[INFO] [stderr] ...  |
[INFO] [stderr] 63 | |                 _ => (),
[INFO] [stderr] 64 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 57 |             if let Packet::Type1{
[INFO] [stderr] 58 |                     opcode: _,
[INFO] [stderr] 59 |                     address,
[INFO] [stderr] 60 |                     payload: _,
[INFO] [stderr] 61 |                 } = packet { last_register_address = *address }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/xc7/configuration.rs:434:18
[INFO] [stderr]     |
[INFO] [stderr] 434 |             row: 31.into(),
[INFO] [stderr]     |                  ^^^^^^^^^ help: consider removing `.into()`: `31`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/xc7/configuration.rs:435:21
[INFO] [stderr]     |
[INFO] [stderr] 435 |             column: 0u16.into(),
[INFO] [stderr]     |                     ^^^^^^^^^^^ help: consider removing `.into()`: `0u16`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/xc7/configuration.rs:436:20
[INFO] [stderr]     |
[INFO] [stderr] 436 |             minor: 0.into(),
[INFO] [stderr]     |                    ^^^^^^^^ help: consider removing `.into()`: `0`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/xc7/frame_address.rs:51:24
[INFO] [stderr]    |
[INFO] [stderr] 51 |     pub fn in_same_row(&self, other: &FrameAddress) -> bool {
[INFO] [stderr]    |                        ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/xc7/frame_address.rs:51:38
[INFO] [stderr]    |
[INFO] [stderr] 51 |     pub fn in_same_row(&self, other: &FrameAddress) -> bool {
[INFO] [stderr]    |                                      ^^^^^^^^^^^^^ help: consider passing by value instead: `FrameAddress`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/xc7/frame_address.rs:134:21
[INFO] [stderr]     |
[INFO] [stderr] 134 |     pub fn contains(&self, addr: &FrameAddress) -> bool {
[INFO] [stderr]     |                     ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/xc7/frame_address.rs:134:34
[INFO] [stderr]     |
[INFO] [stderr] 134 |     pub fn contains(&self, addr: &FrameAddress) -> bool {
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^ help: consider passing by value instead: `FrameAddress`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: taken reference of right operand
[INFO] [stderr]    --> src/xc7/frame_address.rs:135:16
[INFO] [stderr]     |
[INFO] [stderr] 135 |         return addr >= &self.start && addr <= &self.last();
[INFO] [stderr]     |                ^^^^^^^^-----------
[INFO] [stderr]     |                        |
[INFO] [stderr]     |                        help: use the right value directly: `self.start`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: taken reference of right operand
[INFO] [stderr]    --> src/xc7/frame_address.rs:135:39
[INFO] [stderr]     |
[INFO] [stderr] 135 |         return addr >= &self.start && addr <= &self.last();
[INFO] [stderr]     |                                       ^^^^^^^^------------
[INFO] [stderr]     |                                               |
[INFO] [stderr]     |                                               help: use the right value directly: `self.last()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/xc7/frame_address.rs:153:17
[INFO] [stderr]     |
[INFO] [stderr] 153 |     pub fn last(&self) -> FrameAddress {
[INFO] [stderr]     |                 ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/xc7/frame_address.rs:158:17
[INFO] [stderr]     |
[INFO] [stderr] 158 |     pub fn iter(&self) -> RangeIter {
[INFO] [stderr]     |                 ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/xc7/frame_address.rs:167:19
[INFO] [stderr]     |
[INFO] [stderr] 167 |     pub fn extend(&self, amount: u8) -> Option<Self> {
[INFO] [stderr]     |                   ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/xc7/frame_address.rs:182:33
[INFO] [stderr]     |
[INFO] [stderr] 182 |     pub fn split(self, address: &FrameAddress) -> (Option<Range>, Option<Range>) {
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^ help: consider passing by value instead: `FrameAddress`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/xc7/frame_address.rs:548:34
[INFO] [stderr]     |
[INFO] [stderr] 548 |     pub fn contains(&self, addr: &FrameAddress) -> bool {
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^ help: consider passing by value instead: `FrameAddress`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/xc7/frame_address.rs:556:5
[INFO] [stderr]     |
[INFO] [stderr] 556 | /     pub fn iter_ranges<'a>(&'a self) -> btree_set::Iter<'a, Range> {
[INFO] [stderr] 557 | |         self.ranges.iter()
[INFO] [stderr] 558 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/xc7/frame_address.rs:815:37
[INFO] [stderr]     |
[INFO] [stderr] 815 |     pub fn skip_past(self, address: &FrameAddress) -> Self {
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^ help: consider passing by value instead: `FrameAddress`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: unused `#[macro_use]` import
[INFO] [stderr]  --> src/bin/xc7-tool.rs:7:1
[INFO] [stderr]   |
[INFO] [stderr] 7 | #[macro_use]
[INFO] [stderr]   | ^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead
[INFO] [stderr]    --> src/bin/xc7-tool.rs:140:17
[INFO] [stderr]     |
[INFO] [stderr] 140 |                 payload: _
[INFO] [stderr]     |                 ^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unneeded_field_pattern)] on by default
[INFO] [stderr]     = help: Try with `Type1 { opcode: ::xc7::Opcode::Write, address: ::xc7::RegisterAddress::FDRI, .. }`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: unused `#[macro_use]` import
[INFO] [stderr]  --> src/bin/xc7-tool.rs:7:1
[INFO] [stderr]   |
[INFO] [stderr] 7 | #[macro_use]
[INFO] [stderr]   | ^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead
[INFO] [stderr]    --> src/bin/xc7-tool.rs:140:17
[INFO] [stderr]     |
[INFO] [stderr] 140 |                 payload: _
[INFO] [stderr]     |                 ^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unneeded_field_pattern)] on by default
[INFO] [stderr]     = help: Try with `Type1 { opcode: ::xc7::Opcode::Write, address: ::xc7::RegisterAddress::FDRI, .. }`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 38.93s
[INFO] running `"docker" "inspect" "5327264116aaf5d619f40bc1e323a4c15820ca25aab04a2c000f5dc5d8c813ad"`
[INFO] running `"docker" "rm" "-f" "5327264116aaf5d619f40bc1e323a4c15820ca25aab04a2c000f5dc5d8c813ad"`
[INFO] [stdout] 5327264116aaf5d619f40bc1e323a4c15820ca25aab04a2c000f5dc5d8c813ad