[INFO] crate gabc-parser 0.1.1 is already in cache
[INFO] extracting crate gabc-parser 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/gabc-parser/0.1.1
[INFO] extracting crate gabc-parser 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gabc-parser/0.1.1
[INFO] validating manifest of gabc-parser-0.1.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of gabc-parser-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing gabc-parser-0.1.1
[INFO] finished frobbing gabc-parser-0.1.1
[INFO] frobbed toml for gabc-parser-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/gabc-parser/0.1.1/Cargo.toml
[INFO] started frobbing gabc-parser-0.1.1
[INFO] finished frobbing gabc-parser-0.1.1
[INFO] frobbed toml for gabc-parser-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/gabc-parser/0.1.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting gabc-parser-0.1.1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/gabc-parser/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 5aef8b83677ce87776976e1f4f90a53bac5435a2ebb1ecf38f66102b7c47e912
[INFO] running `"docker" "start" "-a" "5aef8b83677ce87776976e1f4f90a53bac5435a2ebb1ecf38f66102b7c47e912"`
[INFO] [stderr]     Checking gabc-parser v0.1.1 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:113:9
[INFO] [stderr]     |
[INFO] [stderr] 113 |         return ly_notes.get(position + start_index).unwrap();
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ly_notes.get(position + start_index).unwrap()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:229:13
[INFO] [stderr]     |
[INFO] [stderr] 229 |             return text.to_string();
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `text.to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:356:13
[INFO] [stderr]     |
[INFO] [stderr] 356 |             return pairs;
[INFO] [stderr]     |             ^^^^^^^^^^^^^ help: remove `return` as shown: `pairs`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/lib.rs:113:16
[INFO] [stderr]     |
[INFO] [stderr] 113 |         return ly_notes.get(position + start_index).unwrap();
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ly_notes[position + start_index]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]    --> src/lib.rs:199:29
[INFO] [stderr]     |
[INFO] [stderr] 199 |         while let Some(s) = notes_iter.next() {
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^ help: try: `for s in notes_iter { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::while_let_on_iterator)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]    --> src/lib.rs:226:12
[INFO] [stderr]     |
[INFO] [stderr] 226 |         if !flag && !(text.trim() == "") {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!flag && text.trim() != ""`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::nonminimal_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/lib.rs:382:1
[INFO] [stderr]     |
[INFO] [stderr] 382 | / fn parsed_file_to_struct<'b>(mut parsed_file: pest::iterators::Pairs<'b, Rule>) -> GabcFile<'b> {
[INFO] [stderr] 383 | |     let mut syllables: Vec<Syllable> = Vec::new();
[INFO] [stderr] 384 | |     let mut attributes: Vec<(&str, &str)> = Vec::new();
[INFO] [stderr] 385 | |     let mut current_clef = "no clef set";
[INFO] [stderr] ...   |
[INFO] [stderr] 422 | |     }
[INFO] [stderr] 423 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]    --> src/lib.rs:433:28
[INFO] [stderr]     |
[INFO] [stderr] 433 |     while let Some(pair) = syllable_components.next() {
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for pair in syllable_components { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:113:9
[INFO] [stderr]     |
[INFO] [stderr] 113 |         return ly_notes.get(position + start_index).unwrap();
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ly_notes.get(position + start_index).unwrap()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:229:13
[INFO] [stderr]     |
[INFO] [stderr] 229 |             return text.to_string();
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `text.to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:356:13
[INFO] [stderr]     |
[INFO] [stderr] 356 |             return pairs;
[INFO] [stderr]     |             ^^^^^^^^^^^^^ help: remove `return` as shown: `pairs`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/lib.rs:113:16
[INFO] [stderr]     |
[INFO] [stderr] 113 |         return ly_notes.get(position + start_index).unwrap();
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ly_notes[position + start_index]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]    --> src/lib.rs:199:29
[INFO] [stderr]     |
[INFO] [stderr] 199 |         while let Some(s) = notes_iter.next() {
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^ help: try: `for s in notes_iter { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::while_let_on_iterator)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]    --> src/lib.rs:226:12
[INFO] [stderr]     |
[INFO] [stderr] 226 |         if !flag && !(text.trim() == "") {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!flag && text.trim() != ""`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::nonminimal_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/lib.rs:382:1
[INFO] [stderr]     |
[INFO] [stderr] 382 | / fn parsed_file_to_struct<'b>(mut parsed_file: pest::iterators::Pairs<'b, Rule>) -> GabcFile<'b> {
[INFO] [stderr] 383 | |     let mut syllables: Vec<Syllable> = Vec::new();
[INFO] [stderr] 384 | |     let mut attributes: Vec<(&str, &str)> = Vec::new();
[INFO] [stderr] 385 | |     let mut current_clef = "no clef set";
[INFO] [stderr] ...   |
[INFO] [stderr] 422 | |     }
[INFO] [stderr] 423 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]    --> src/lib.rs:433:28
[INFO] [stderr]     |
[INFO] [stderr] 433 |     while let Some(pair) = syllable_components.next() {
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for pair in syllable_components { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 6.89s
[INFO] running `"docker" "inspect" "5aef8b83677ce87776976e1f4f90a53bac5435a2ebb1ecf38f66102b7c47e912"`
[INFO] running `"docker" "rm" "-f" "5aef8b83677ce87776976e1f4f90a53bac5435a2ebb1ecf38f66102b7c47e912"`
[INFO] [stdout] 5aef8b83677ce87776976e1f4f90a53bac5435a2ebb1ecf38f66102b7c47e912