[INFO] crate fxsm-derive 0.3.0 is already in cache [INFO] extracting crate fxsm-derive 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/fxsm-derive/0.3.0 [INFO] extracting crate fxsm-derive 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fxsm-derive/0.3.0 [INFO] validating manifest of fxsm-derive-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of fxsm-derive-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing fxsm-derive-0.3.0 [INFO] finished frobbing fxsm-derive-0.3.0 [INFO] frobbed toml for fxsm-derive-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/fxsm-derive/0.3.0/Cargo.toml [INFO] started frobbing fxsm-derive-0.3.0 [INFO] finished frobbing fxsm-derive-0.3.0 [INFO] frobbed toml for fxsm-derive-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fxsm-derive/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting fxsm-derive-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/fxsm-derive/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5c10acb4a4bdd544e69dbf7755b1427601ea4f2f2cda16d77bbaf5cd63e1d1ae [INFO] running `"docker" "start" "-a" "5c10acb4a4bdd544e69dbf7755b1427601ea4f2f2cda16d77bbaf5cd63e1d1ae"` [INFO] [stderr] Checking fxsm-derive v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:10:31 [INFO] [stderr] | [INFO] [stderr] 10 | const TRANSITIONS_ATTRIBUTE: &'static str = "state_transitions"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:11:28 [INFO] [stderr] | [INFO] [stderr] 11 | const NEW_STATE_OBJ_NAME: &'static str = "new_state"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/lib.rs:31:1 [INFO] [stderr] | [INFO] [stderr] 31 | / macro_rules! quote_block { [INFO] [stderr] 32 | | ($($tt:tt)*) => { [INFO] [stderr] 33 | | Fragment::Block(quote!($($tt)*)) [INFO] [stderr] 34 | | } [INFO] [stderr] 35 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_macros)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:10:31 [INFO] [stderr] | [INFO] [stderr] 10 | const TRANSITIONS_ATTRIBUTE: &'static str = "state_transitions"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:11:28 [INFO] [stderr] | [INFO] [stderr] 11 | const NEW_STATE_OBJ_NAME: &'static str = "new_state"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/lib.rs:31:1 [INFO] [stderr] | [INFO] [stderr] 31 | / macro_rules! quote_block { [INFO] [stderr] 32 | | ($($tt:tt)*) => { [INFO] [stderr] 33 | | Fragment::Block(quote!($($tt)*)) [INFO] [stderr] 34 | | } [INFO] [stderr] 35 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_macros)] on by default [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/lib.rs:127:27 [INFO] [stderr] | [INFO] [stderr] 127 | .filter(|variant| variant.attrs.iter() [INFO] [stderr] | ___________________________^ [INFO] [stderr] 128 | | .find(|a| a.value.name() == TRANSITIONS_ATTRIBUTE).is_some()) [INFO] [stderr] | |______________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `find(|a| a.value.name() == TRANSITIONS_ATTRIBUTE).is_some()` with `any(|a| a.value.name() == TRANSITIONS_ATTRIBUTE)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lib.rs:161:27 [INFO] [stderr] | [INFO] [stderr] 161 | .filter(|variant| !variant.attrs.iter() [INFO] [stderr] | ___________________________^ [INFO] [stderr] 162 | | .find(|a| a.value.name() == TRANSITIONS_ATTRIBUTE).is_some()) [INFO] [stderr] | |______________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 161 | .filter(|variant| variant.attrs.iter() [INFO] [stderr] 162 | .find(|a| a.value.name() == TRANSITIONS_ATTRIBUTE).is_none()) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/lib.rs:161:28 [INFO] [stderr] | [INFO] [stderr] 161 | .filter(|variant| !variant.attrs.iter() [INFO] [stderr] | ____________________________^ [INFO] [stderr] 162 | | .find(|a| a.value.name() == TRANSITIONS_ATTRIBUTE).is_some()) [INFO] [stderr] | |______________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: replace `find(|a| a.value.name() == TRANSITIONS_ATTRIBUTE).is_some()` with `any(|a| a.value.name() == TRANSITIONS_ATTRIBUTE)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/lib.rs:127:27 [INFO] [stderr] | [INFO] [stderr] 127 | .filter(|variant| variant.attrs.iter() [INFO] [stderr] | ___________________________^ [INFO] [stderr] 128 | | .find(|a| a.value.name() == TRANSITIONS_ATTRIBUTE).is_some()) [INFO] [stderr] | |______________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `find(|a| a.value.name() == TRANSITIONS_ATTRIBUTE).is_some()` with `any(|a| a.value.name() == TRANSITIONS_ATTRIBUTE)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/lib.rs:161:27 [INFO] [stderr] | [INFO] [stderr] 161 | .filter(|variant| !variant.attrs.iter() [INFO] [stderr] | ___________________________^ [INFO] [stderr] 162 | | .find(|a| a.value.name() == TRANSITIONS_ATTRIBUTE).is_some()) [INFO] [stderr] | |______________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 161 | .filter(|variant| variant.attrs.iter() [INFO] [stderr] 162 | .find(|a| a.value.name() == TRANSITIONS_ATTRIBUTE).is_none()) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/lib.rs:161:28 [INFO] [stderr] | [INFO] [stderr] 161 | .filter(|variant| !variant.attrs.iter() [INFO] [stderr] | ____________________________^ [INFO] [stderr] 162 | | .find(|a| a.value.name() == TRANSITIONS_ATTRIBUTE).is_some()) [INFO] [stderr] | |______________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: replace `find(|a| a.value.name() == TRANSITIONS_ATTRIBUTE).is_some()` with `any(|a| a.value.name() == TRANSITIONS_ATTRIBUTE)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.87s [INFO] running `"docker" "inspect" "5c10acb4a4bdd544e69dbf7755b1427601ea4f2f2cda16d77bbaf5cd63e1d1ae"` [INFO] running `"docker" "rm" "-f" "5c10acb4a4bdd544e69dbf7755b1427601ea4f2f2cda16d77bbaf5cd63e1d1ae"` [INFO] [stdout] 5c10acb4a4bdd544e69dbf7755b1427601ea4f2f2cda16d77bbaf5cd63e1d1ae