[INFO] crate fuzzy_file_helper 0.1.0 is already in cache [INFO] extracting crate fuzzy_file_helper 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/fuzzy_file_helper/0.1.0 [INFO] extracting crate fuzzy_file_helper 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fuzzy_file_helper/0.1.0 [INFO] validating manifest of fuzzy_file_helper-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of fuzzy_file_helper-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing fuzzy_file_helper-0.1.0 [INFO] finished frobbing fuzzy_file_helper-0.1.0 [INFO] frobbed toml for fuzzy_file_helper-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/fuzzy_file_helper/0.1.0/Cargo.toml [INFO] started frobbing fuzzy_file_helper-0.1.0 [INFO] finished frobbing fuzzy_file_helper-0.1.0 [INFO] frobbed toml for fuzzy_file_helper-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fuzzy_file_helper/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting fuzzy_file_helper-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/fuzzy_file_helper/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0bc64f4d99f1395fafb7e8b24f58d8b04017ae840c7c0b0966b5d69da3101c18 [INFO] running `"docker" "start" "-a" "0bc64f4d99f1395fafb7e8b24f58d8b04017ae840c7c0b0966b5d69da3101c18"` [INFO] [stderr] Checking fuzzy_file_helper v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:11:30 [INFO] [stderr] | [INFO] [stderr] 11 | let files = buffer.split("\n").filter(|file| file.to_string() != ""); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:11:50 [INFO] [stderr] | [INFO] [stderr] 11 | let files = buffer.split("\n").filter(|file| file.to_string() != ""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `file` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:18:54 [INFO] [stderr] | [INFO] [stderr] 18 | let mut ignore_patterns = agignore.split("\n").filter(|pat| pat.to_string() != ""); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:18:73 [INFO] [stderr] | [INFO] [stderr] 18 | let mut ignore_patterns = agignore.split("\n").filter(|pat| pat.to_string() != ""); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `pat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/main.rs:19:43 [INFO] [stderr] | [INFO] [stderr] 19 | if !ignore_patterns.any(|pat| { [INFO] [stderr] | ___________________________________________^ [INFO] [stderr] 20 | | Regex::new(pat).unwrap().is_match(file) [INFO] [stderr] 21 | | }) { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:11:30 [INFO] [stderr] | [INFO] [stderr] 11 | let files = buffer.split("\n").filter(|file| file.to_string() != ""); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:11:50 [INFO] [stderr] | [INFO] [stderr] 11 | let files = buffer.split("\n").filter(|file| file.to_string() != ""); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `file` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:18:54 [INFO] [stderr] | [INFO] [stderr] 18 | let mut ignore_patterns = agignore.split("\n").filter(|pat| pat.to_string() != ""); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:18:73 [INFO] [stderr] | [INFO] [stderr] 18 | let mut ignore_patterns = agignore.split("\n").filter(|pat| pat.to_string() != ""); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `pat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/main.rs:19:43 [INFO] [stderr] | [INFO] [stderr] 19 | if !ignore_patterns.any(|pat| { [INFO] [stderr] | ___________________________________________^ [INFO] [stderr] 20 | | Regex::new(pat).unwrap().is_match(file) [INFO] [stderr] 21 | | }) { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.48s [INFO] running `"docker" "inspect" "0bc64f4d99f1395fafb7e8b24f58d8b04017ae840c7c0b0966b5d69da3101c18"` [INFO] running `"docker" "rm" "-f" "0bc64f4d99f1395fafb7e8b24f58d8b04017ae840c7c0b0966b5d69da3101c18"` [INFO] [stdout] 0bc64f4d99f1395fafb7e8b24f58d8b04017ae840c7c0b0966b5d69da3101c18