[INFO] crate fux_kdtree 0.2.0 is already in cache [INFO] extracting crate fux_kdtree 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/fux_kdtree/0.2.0 [INFO] extracting crate fux_kdtree 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fux_kdtree/0.2.0 [INFO] validating manifest of fux_kdtree-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of fux_kdtree-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing fux_kdtree-0.2.0 [INFO] finished frobbing fux_kdtree-0.2.0 [INFO] frobbed toml for fux_kdtree-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/fux_kdtree/0.2.0/Cargo.toml [INFO] started frobbing fux_kdtree-0.2.0 [INFO] finished frobbing fux_kdtree-0.2.0 [INFO] frobbed toml for fux_kdtree-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fux_kdtree/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting fux_kdtree-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/fux_kdtree/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5b5db85ef9fa30b9fdd822a544f4f18ad170d1b0fb02ff1875ac99e8c9ac46c8 [INFO] running `"docker" "start" "-a" "5b5db85ef9fa30b9fdd822a544f4f18ad170d1b0fb02ff1875ac99e8c9ac46c8"` [INFO] [stderr] warning: path `/opt/crater/workdir/src/bench.rs` was erroneously implicitly accepted for benchmark `bench`, [INFO] [stderr] please set bench.path in Cargo.toml [INFO] [stderr] Checking fux_kdtree v0.2.0 (/opt/crater/workdir) [INFO] [stderr] Checking quickcheck v0.3.2 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/kdtree/test_common.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/kdtree/test_common.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/kdtree/test_common.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/kdtree/test_common.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | return &self.dims; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.dims` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/kdtree/test_common.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | return &self.dims; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.dims` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/kdtree/test_common.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | return &self.dims; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.dims` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/kdtree/partition.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | / return PartitionPointHelper { [INFO] [stderr] 46 | | index_of_splitter: closest_index, [INFO] [stderr] 47 | | points_were_on_side: PointsWereOnSide::Both [INFO] [stderr] 48 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 45 | PartitionPointHelper { [INFO] [stderr] 46 | index_of_splitter: closest_index, [INFO] [stderr] 47 | points_were_on_side: PointsWereOnSide::Both [INFO] [stderr] 48 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/kdtree/partition.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | index_of_splitting_point [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/kdtree/partition.rs:71:44 [INFO] [stderr] | [INFO] [stderr] 71 | let index_of_splitting_point = partition_kdtree(vec, partition_point_data.index_of_splitter, partition_on_dimension); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/kdtree/mod.rs:114:20 [INFO] [stderr] | [INFO] [stderr] 114 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 115 | | if let Some(right_node_index) = current_node.right_node { [INFO] [stderr] 116 | | current_index = right_node_index [INFO] [stderr] 117 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 124 | | } [INFO] [stderr] 125 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 114 | } else if let Some(right_node_index) = current_node.right_node { [INFO] [stderr] 115 | current_index = right_node_index [INFO] [stderr] 116 | } else { [INFO] [stderr] 117 | if current_node.point.eq(&node_to_add) { [INFO] [stderr] 118 | should_pop_node = true; [INFO] [stderr] 119 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/kdtree/partition.rs:24:17 [INFO] [stderr] | [INFO] [stderr] 24 | let p = vec.get(i).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try this: `vec[i]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/kdtree/bounds.rs:45:21 [INFO] [stderr] | [INFO] [stderr] 45 | bounds: self.bounds.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.bounds` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/kdtree/bounds.rs:57:21 [INFO] [stderr] | [INFO] [stderr] 57 | bounds: self.bounds.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.bounds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/kdtree/mod.rs:26:12 [INFO] [stderr] | [INFO] [stderr] 26 | if points.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `points.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/kdtree/mod.rs:132:63 [INFO] [stderr] | [INFO] [stderr] 132 | if self.node_depth_during_last_rebuild as f64 * 4.0 < depth as f64 { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(depth)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/kdtree/test_common.rs:13:13 [INFO] [stderr] | [INFO] [stderr] 13 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/kdtree/test_common.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/kdtree/test_common.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/bench.rs:45:15 [INFO] [stderr] | [INFO] [stderr] 45 | let len = 1000_000usize; [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `1_000_000usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::inconsistent_digit_grouping)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> tests/integration_tests.rs:13:40 [INFO] [stderr] | [INFO] [stderr] 13 | fn find_nn_with_linear_search(points : &Vec, find_for : Point3WithId) -> &Point3WithId { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[Point3WithId]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `points`. [INFO] [stderr] --> tests/integration_tests.rs:52:14 [INFO] [stderr] | [INFO] [stderr] 52 | for i in 0 .. point_count { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 52 | for in points.iter().take(point_count) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `points`. [INFO] [stderr] --> tests/integration_tests.rs:77:14 [INFO] [stderr] | [INFO] [stderr] 77 | for i in 1 .. point_count { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 77 | for in points.iter().take(point_count).skip(1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `points`. [INFO] [stderr] --> tests/integration_tests.rs:85:14 [INFO] [stderr] | [INFO] [stderr] 85 | for i in 0 .. point_count { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 85 | for in points.iter().take(point_count) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/kdtree/test_common.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | return &self.dims; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.dims` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/kdtree/test_common.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | return &self.dims; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.dims` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/kdtree/test_common.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | return &self.dims; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.dims` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/kdtree/partition.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | / return PartitionPointHelper { [INFO] [stderr] 46 | | index_of_splitter: closest_index, [INFO] [stderr] 47 | | points_were_on_side: PointsWereOnSide::Both [INFO] [stderr] 48 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 45 | PartitionPointHelper { [INFO] [stderr] 46 | index_of_splitter: closest_index, [INFO] [stderr] 47 | points_were_on_side: PointsWereOnSide::Both [INFO] [stderr] 48 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/kdtree/partition.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | index_of_splitting_point [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/kdtree/partition.rs:71:44 [INFO] [stderr] | [INFO] [stderr] 71 | let index_of_splitting_point = partition_kdtree(vec, partition_point_data.index_of_splitter, partition_on_dimension); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/kdtree/mod.rs:114:20 [INFO] [stderr] | [INFO] [stderr] 114 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 115 | | if let Some(right_node_index) = current_node.right_node { [INFO] [stderr] 116 | | current_index = right_node_index [INFO] [stderr] 117 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 124 | | } [INFO] [stderr] 125 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 114 | } else if let Some(right_node_index) = current_node.right_node { [INFO] [stderr] 115 | current_index = right_node_index [INFO] [stderr] 116 | } else { [INFO] [stderr] 117 | if current_node.point.eq(&node_to_add) { [INFO] [stderr] 118 | should_pop_node = true; [INFO] [stderr] 119 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/kdtree/distance.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | assert_eq!(0., squared_euclidean(&a, &a)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/kdtree/distance.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | assert_eq!(0., squared_euclidean(&a, &a)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/kdtree/distance.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | assert_eq!(4., squared_euclidean(&a, &b)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/kdtree/distance.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | assert_eq!(4., squared_euclidean(&a, &b)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/kdtree/distance.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | assert_eq!(16., squared_euclidean(&a, &c)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/kdtree/distance.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | assert_eq!(16., squared_euclidean(&a, &c)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/kdtree/distance.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | assert_eq!(0., squared_euclidean(&a, &a)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/kdtree/distance.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | assert_eq!(0., squared_euclidean(&a, &a)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/kdtree/distance.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | assert_eq!(4., squared_euclidean(&a, &b)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/kdtree/distance.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | assert_eq!(4., squared_euclidean(&a, &b)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/kdtree/distance.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | assert_eq!(8., squared_euclidean(&a, &c)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/kdtree/distance.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | assert_eq!(8., squared_euclidean(&a, &c)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/kdtree/partition.rs:24:17 [INFO] [stderr] | [INFO] [stderr] 24 | let p = vec.get(i).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try this: `vec[i]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `xs` [INFO] [stderr] --> src/kdtree/partition.rs:161:22 [INFO] [stderr] | [INFO] [stderr] 161 | for i in 0 .. xs.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 161 | for (i, ) in xs.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/kdtree/partition.rs:166:16 [INFO] [stderr] | [INFO] [stderr] 166 | if xs.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `xs.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/kdtree/partition.rs:172:13 [INFO] [stderr] | [INFO] [stderr] 172 | / for _ in 0 .. 5 { [INFO] [stderr] 173 | | let random_splitting_index = between.ind_sample(&mut rng); [INFO] [stderr] 174 | | [INFO] [stderr] 175 | | let mut vec = vec.clone(); [INFO] [stderr] ... | [INFO] [stderr] 178 | | return assert_partition(&vec, index_of_splitting_point); [INFO] [stderr] 179 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/kdtree/partition.rs:235:28 [INFO] [stderr] | [INFO] [stderr] 235 | fn assert_partition(v: &Vec, index_of_splitting_point: usize) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[Point1WithId]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `v`. [INFO] [stderr] --> src/kdtree/partition.rs:238:18 [INFO] [stderr] | [INFO] [stderr] 238 | for i in 0..index_of_splitting_point { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 238 | for in v.iter().take(index_of_splitting_point) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `v`. [INFO] [stderr] --> src/kdtree/partition.rs:244:18 [INFO] [stderr] | [INFO] [stderr] 244 | for i in index_of_splitting_point + 1..v.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 244 | for in v.iter().skip(index_of_splitting_point + 1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/kdtree/bounds.rs:45:21 [INFO] [stderr] | [INFO] [stderr] 45 | bounds: self.bounds.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.bounds` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/kdtree/bounds.rs:57:21 [INFO] [stderr] | [INFO] [stderr] 57 | bounds: self.bounds.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.bounds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/kdtree/mod.rs:26:12 [INFO] [stderr] | [INFO] [stderr] 26 | if points.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `points.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/kdtree/mod.rs:132:63 [INFO] [stderr] | [INFO] [stderr] 132 | if self.node_depth_during_last_rebuild as f64 * 4.0 < depth as f64 { [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(depth)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/kdtree/mod.rs:250:16 [INFO] [stderr] | [INFO] [stderr] 250 | if xs.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `xs.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `xs` [INFO] [stderr] --> src/kdtree/mod.rs:254:22 [INFO] [stderr] | [INFO] [stderr] 254 | for i in 0 .. xs.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 254 | for (i, ) in xs.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/kdtree/mod.rs:265:19 [INFO] [stderr] | [INFO] [stderr] 265 | while to_iterate.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!to_iterate.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/kdtree/mod.rs:266:34 [INFO] [stderr] | [INFO] [stderr] 266 | let last_index = to_iterate.last().unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*to_iterate.last().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/kdtree/mod.rs:267:21 [INFO] [stderr] | [INFO] [stderr] 267 | let ref x = tree.nodes.get(last_index).unwrap(); [INFO] [stderr] | ----^^^^^--------------------------------------- help: try: `let x = &tree.nodes.get(last_index).unwrap();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/kdtree/mod.rs:267:29 [INFO] [stderr] | [INFO] [stderr] 267 | let ref x = tree.nodes.get(last_index).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `tree.nodes[last_index]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/kdtree/mod.rs:282:16 [INFO] [stderr] | [INFO] [stderr] 282 | if xs.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `xs.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/kdtree/mod.rs:326:9 [INFO] [stderr] | [INFO] [stderr] 326 | assert_eq!(tree.nodes[1].point.dims()[0], 1.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/kdtree/mod.rs:326:9 [INFO] [stderr] | [INFO] [stderr] 326 | assert_eq!(tree.nodes[1].point.dims()[0], 1.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/kdtree/mod.rs:327:9 [INFO] [stderr] | [INFO] [stderr] 327 | assert_eq!(tree.nodes[2].point.dims()[0], -1.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/kdtree/mod.rs:327:9 [INFO] [stderr] | [INFO] [stderr] 327 | assert_eq!(tree.nodes[2].point.dims()[0], -1.); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/kdtree/mod.rs:345:42 [INFO] [stderr] | [INFO] [stderr] 345 | fn qc_value_vec_to_2d_points_vec(xs: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/kdtree/mod.rs:350:20 [INFO] [stderr] | [INFO] [stderr] 350 | if xs[i] == xs[j] { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider comparing them within some error: `(xs[i] - xs[j]).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/kdtree/mod.rs:350:20 [INFO] [stderr] | [INFO] [stderr] 350 | if xs[i] == xs[j] { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: aborting due to 10 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `fux_kdtree`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "5b5db85ef9fa30b9fdd822a544f4f18ad170d1b0fb02ff1875ac99e8c9ac46c8"` [INFO] running `"docker" "rm" "-f" "5b5db85ef9fa30b9fdd822a544f4f18ad170d1b0fb02ff1875ac99e8c9ac46c8"` [INFO] [stdout] 5b5db85ef9fa30b9fdd822a544f4f18ad170d1b0fb02ff1875ac99e8c9ac46c8