[INFO] crate futurize-derive 0.5.0 is already in cache [INFO] extracting crate futurize-derive 0.5.0 into work/ex/clippy-test-run/sources/stable/reg/futurize-derive/0.5.0 [INFO] extracting crate futurize-derive 0.5.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/futurize-derive/0.5.0 [INFO] validating manifest of futurize-derive-0.5.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of futurize-derive-0.5.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing futurize-derive-0.5.0 [INFO] finished frobbing futurize-derive-0.5.0 [INFO] frobbed toml for futurize-derive-0.5.0 written to work/ex/clippy-test-run/sources/stable/reg/futurize-derive/0.5.0/Cargo.toml [INFO] started frobbing futurize-derive-0.5.0 [INFO] finished frobbing futurize-derive-0.5.0 [INFO] frobbed toml for futurize-derive-0.5.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/futurize-derive/0.5.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting futurize-derive-0.5.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/futurize-derive/0.5.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f868842239bf8c36a58f2dc7700193e4a538b41bce99f583530ad895e4f4910f [INFO] running `"docker" "start" "-a" "f868842239bf8c36a58f2dc7700193e4a538b41bce99f583530ad895e4f4910f"` [INFO] [stderr] Checking futurize-derive v0.5.0 (/opt/crater/workdir) [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | / if attr.path.segments.len() == 1 { [INFO] [stderr] 60 | | if format!("{}", attr.path.segments[0].ident) == "returns" { [INFO] [stderr] 61 | | let meta = attr.interpret_meta().expect("cannot parse as meta"); [INFO] [stderr] 62 | | let meta = match meta { [INFO] [stderr] ... | [INFO] [stderr] 74 | | } [INFO] [stderr] 75 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 59 | if attr.path.segments.len() == 1 && format!("{}", attr.path.segments[0].ident) == "returns" { [INFO] [stderr] 60 | let meta = attr.interpret_meta().expect("cannot parse as meta"); [INFO] [stderr] 61 | let meta = match meta { [INFO] [stderr] 62 | syn::Meta::NameValue(m) => m, [INFO] [stderr] 63 | _ => panic!("needs name value pair like '#[returns = \"u8\"]"), [INFO] [stderr] 64 | }; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | / if attr.path.segments.len() == 1 { [INFO] [stderr] 60 | | if format!("{}", attr.path.segments[0].ident) == "returns" { [INFO] [stderr] 61 | | let meta = attr.interpret_meta().expect("cannot parse as meta"); [INFO] [stderr] 62 | | let meta = match meta { [INFO] [stderr] ... | [INFO] [stderr] 74 | | } [INFO] [stderr] 75 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 59 | if attr.path.segments.len() == 1 && format!("{}", attr.path.segments[0].ident) == "returns" { [INFO] [stderr] 60 | let meta = attr.interpret_meta().expect("cannot parse as meta"); [INFO] [stderr] 61 | let meta = match meta { [INFO] [stderr] 62 | syn::Meta::NameValue(m) => m, [INFO] [stderr] 63 | _ => panic!("needs name value pair like '#[returns = \"u8\"]"), [INFO] [stderr] 64 | }; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 30 [INFO] [stderr] --> src/lib.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | / pub fn derive_worker(input: TokenStream) -> TokenStream { [INFO] [stderr] 20 | | [INFO] [stderr] 21 | | let ast: DeriveInput = syn::parse(input).unwrap(); [INFO] [stderr] 22 | | let dnum = match ast.data { [INFO] [stderr] ... | [INFO] [stderr] 245 | | expanded.into() [INFO] [stderr] 246 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:93:26 [INFO] [stderr] | [INFO] [stderr] 93 | let callarg = if argnames.len() > 0 {quote! { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!argnames.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:130:24 [INFO] [stderr] | [INFO] [stderr] 130 | let mcall = if argnames.len() > 0 { quote! { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!argnames.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 30 [INFO] [stderr] --> src/lib.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | / pub fn derive_worker(input: TokenStream) -> TokenStream { [INFO] [stderr] 20 | | [INFO] [stderr] 21 | | let ast: DeriveInput = syn::parse(input).unwrap(); [INFO] [stderr] 22 | | let dnum = match ast.data { [INFO] [stderr] ... | [INFO] [stderr] 245 | | expanded.into() [INFO] [stderr] 246 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:93:26 [INFO] [stderr] | [INFO] [stderr] 93 | let callarg = if argnames.len() > 0 {quote! { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!argnames.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:130:24 [INFO] [stderr] | [INFO] [stderr] 130 | let mcall = if argnames.len() > 0 { quote! { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!argnames.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.64s [INFO] running `"docker" "inspect" "f868842239bf8c36a58f2dc7700193e4a538b41bce99f583530ad895e4f4910f"` [INFO] running `"docker" "rm" "-f" "f868842239bf8c36a58f2dc7700193e4a538b41bce99f583530ad895e4f4910f"` [INFO] [stdout] f868842239bf8c36a58f2dc7700193e4a538b41bce99f583530ad895e4f4910f