[INFO] crate futures-cpupool 0.1.8 is already in cache [INFO] extracting crate futures-cpupool 0.1.8 into work/ex/clippy-test-run/sources/stable/reg/futures-cpupool/0.1.8 [INFO] extracting crate futures-cpupool 0.1.8 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/futures-cpupool/0.1.8 [INFO] validating manifest of futures-cpupool-0.1.8 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of futures-cpupool-0.1.8 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing futures-cpupool-0.1.8 [INFO] finished frobbing futures-cpupool-0.1.8 [INFO] frobbed toml for futures-cpupool-0.1.8 written to work/ex/clippy-test-run/sources/stable/reg/futures-cpupool/0.1.8/Cargo.toml [INFO] started frobbing futures-cpupool-0.1.8 [INFO] finished frobbing futures-cpupool-0.1.8 [INFO] frobbed toml for futures-cpupool-0.1.8 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/futures-cpupool/0.1.8/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting futures-cpupool-0.1.8 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/futures-cpupool/0.1.8:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] db574bbab74f10251f2f951c78a754494cfc789b7eeebc46069ff0cac66dcc0a [INFO] running `"docker" "start" "-a" "db574bbab74f10251f2f951c78a754494cfc789b7eeebc46069ff0cac66dcc0a"` [INFO] [stderr] Checking futures v0.1.25 [INFO] [stderr] Checking futures-cpupool v0.1.8 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:429:9 [INFO] [stderr] | [INFO] [stderr] 429 | return pool [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `pool` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'futures::task::Run' [INFO] [stderr] --> src/lib.rs:53:31 [INFO] [stderr] | [INFO] [stderr] 53 | use futures::executor::{self, Run, Executor as OldExecutor}; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'futures::task::Executor' [INFO] [stderr] --> src/lib.rs:53:36 [INFO] [stderr] | [INFO] [stderr] 53 | use futures::executor::{self, Run, Executor as OldExecutor}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'futures::task::Run' [INFO] [stderr] --> src/lib.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | Run(Run), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'futures::task::Executor' [INFO] [stderr] --> src/lib.rs:282:6 [INFO] [stderr] | [INFO] [stderr] 282 | impl OldExecutor for Inner { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'futures::task::Run' [INFO] [stderr] --> src/lib.rs:283:28 [INFO] [stderr] | [INFO] [stderr] 283 | fn execute(&self, run: Run) { [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'futures::task_impl::std::>::execute' [INFO] [stderr] --> src/lib.rs:214:33 [INFO] [stderr] | [INFO] [stderr] 214 | executor::spawn(sender).execute(self.inner.clone()); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'futures::task_impl::std::>::execute' [INFO] [stderr] --> src/lib.rs:242:33 [INFO] [stderr] | [INFO] [stderr] 242 | executor::spawn(future).execute(self.inner.clone()); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:429:9 [INFO] [stderr] | [INFO] [stderr] 429 | return pool [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `pool` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'futures::task::Run' [INFO] [stderr] --> src/lib.rs:53:31 [INFO] [stderr] | [INFO] [stderr] 53 | use futures::executor::{self, Run, Executor as OldExecutor}; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'futures::task::Executor' [INFO] [stderr] --> src/lib.rs:53:36 [INFO] [stderr] | [INFO] [stderr] 53 | use futures::executor::{self, Run, Executor as OldExecutor}; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'futures::task::Run' [INFO] [stderr] --> src/lib.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | Run(Run), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'futures::task::Executor' [INFO] [stderr] --> src/lib.rs:282:6 [INFO] [stderr] | [INFO] [stderr] 282 | impl OldExecutor for Inner { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'futures::task::Run' [INFO] [stderr] --> src/lib.rs:283:28 [INFO] [stderr] | [INFO] [stderr] 283 | fn execute(&self, run: Run) { [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/lib.rs:253:9 [INFO] [stderr] | [INFO] [stderr] 253 | after_start.map(|fun| fun()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(fun) = after_start { fun() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/lib.rs:261:9 [INFO] [stderr] | [INFO] [stderr] 261 | before_stop.map(|fun| fun()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(fun) = before_stop { fun() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Builder` [INFO] [stderr] --> src/lib.rs:341:5 [INFO] [stderr] | [INFO] [stderr] 341 | / pub fn new() -> Builder { [INFO] [stderr] 342 | | Builder { [INFO] [stderr] 343 | | pool_size: num_cpus::get(), [INFO] [stderr] 344 | | stack_size: 0, [INFO] [stderr] ... | [INFO] [stderr] 348 | | } [INFO] [stderr] 349 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 81 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'futures::task_impl::std::>::execute' [INFO] [stderr] --> src/lib.rs:214:33 [INFO] [stderr] | [INFO] [stderr] 214 | executor::spawn(sender).execute(self.inner.clone()); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'futures::task_impl::std::>::execute' [INFO] [stderr] --> src/lib.rs:242:33 [INFO] [stderr] | [INFO] [stderr] 242 | executor::spawn(future).execute(self.inner.clone()); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/lib.rs:253:9 [INFO] [stderr] | [INFO] [stderr] 253 | after_start.map(|fun| fun()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(fun) = after_start { fun() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/lib.rs:261:9 [INFO] [stderr] | [INFO] [stderr] 261 | before_stop.map(|fun| fun()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(fun) = before_stop { fun() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Builder` [INFO] [stderr] --> src/lib.rs:341:5 [INFO] [stderr] | [INFO] [stderr] 341 | / pub fn new() -> Builder { [INFO] [stderr] 342 | | Builder { [INFO] [stderr] 343 | | pool_size: num_cpus::get(), [INFO] [stderr] 344 | | stack_size: 0, [INFO] [stderr] ... | [INFO] [stderr] 348 | | } [INFO] [stderr] 349 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 81 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.01s [INFO] running `"docker" "inspect" "db574bbab74f10251f2f951c78a754494cfc789b7eeebc46069ff0cac66dcc0a"` [INFO] running `"docker" "rm" "-f" "db574bbab74f10251f2f951c78a754494cfc789b7eeebc46069ff0cac66dcc0a"` [INFO] [stdout] db574bbab74f10251f2f951c78a754494cfc789b7eeebc46069ff0cac66dcc0a