[INFO] crate fuss 0.2.2 is already in cache [INFO] extracting crate fuss 0.2.2 into work/ex/clippy-test-run/sources/stable/reg/fuss/0.2.2 [INFO] extracting crate fuss 0.2.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fuss/0.2.2 [INFO] validating manifest of fuss-0.2.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of fuss-0.2.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing fuss-0.2.2 [INFO] finished frobbing fuss-0.2.2 [INFO] frobbed toml for fuss-0.2.2 written to work/ex/clippy-test-run/sources/stable/reg/fuss/0.2.2/Cargo.toml [INFO] started frobbing fuss-0.2.2 [INFO] finished frobbing fuss-0.2.2 [INFO] frobbed toml for fuss-0.2.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fuss/0.2.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting fuss-0.2.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/fuss/0.2.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4673b101da77a183ef8e92ba66b4499efa5f177299505458f49be7373638a8b2 [INFO] running `"docker" "start" "-a" "4673b101da77a183ef8e92ba66b4499efa5f177299505458f49be7373638a8b2"` [INFO] [stderr] Checking fuss v0.2.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:127:7 [INFO] [stderr] | [INFO] [stderr] 127 | seed: seed, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `seed` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:382:9 [INFO] [stderr] | [INFO] [stderr] 382 | let t = (i + j + k) * G3; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:127:7 [INFO] [stderr] | [INFO] [stderr] 127 | seed: seed, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `seed` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/lib.rs:382:9 [INFO] [stderr] | [INFO] [stderr] 382 | let t = (i + j + k) * G3; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:19:18 [INFO] [stderr] | [INFO] [stderr] 19 | const F2 : f32 = 0.366025403; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.366_025_403` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:21:18 [INFO] [stderr] | [INFO] [stderr] 21 | const G2 : f32 = 0.211324865; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.211_324_865` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:97:5 [INFO] [stderr] | [INFO] [stderr] 97 | return Simplex::from_seed(seed); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Simplex::from_seed(seed)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:131:5 [INFO] [stderr] | [INFO] [stderr] 131 | return sn; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `sn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:186:5 [INFO] [stderr] | [INFO] [stderr] 186 | return noise / max_amp; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `noise / max_amp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:230:5 [INFO] [stderr] | [INFO] [stderr] 230 | return noise / max_amp; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `noise / max_amp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:340:5 [INFO] [stderr] | [INFO] [stderr] 340 | return 70.0 * (n0 + n1 + n2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `70.0 * (n0 + n1 + n2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:526:5 [INFO] [stderr] | [INFO] [stderr] 526 | return 32.0*(n0 + n1 + n2 + n3); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `32.0*(n0 + n1 + n2 + n3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:432:10 [INFO] [stderr] | [INFO] [stderr] 432 | else { [INFO] [stderr] | __________^ [INFO] [stderr] 433 | | if y0 < z0 { [INFO] [stderr] 434 | | // Z Y X order [INFO] [stderr] 435 | | i1=0; [INFO] [stderr] ... | [INFO] [stderr] 457 | | } [INFO] [stderr] 458 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 432 | else if y0 < z0 { [INFO] [stderr] 433 | // Z Y X order [INFO] [stderr] 434 | i1=0; [INFO] [stderr] 435 | j1=0; [INFO] [stderr] 436 | k1=1; [INFO] [stderr] 437 | i2=0; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/lib.rs:19:18 [INFO] [stderr] | [INFO] [stderr] 19 | const F2 : f32 = 0.366025403; [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.366_025_4` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::excessive_precision)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/lib.rs:21:18 [INFO] [stderr] | [INFO] [stderr] 21 | const G2 : f32 = 0.211324865; [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.211_324_87` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:49:3 [INFO] [stderr] | [INFO] [stderr] 49 | g.0 as f32 * x + g.1 as f32 * y [INFO] [stderr] | ^^^^^^^^^^ help: try: `f32::from(g.0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:49:20 [INFO] [stderr] | [INFO] [stderr] 49 | g.0 as f32 * x + g.1 as f32 * y [INFO] [stderr] | ^^^^^^^^^^ help: try: `f32::from(g.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:57:3 [INFO] [stderr] | [INFO] [stderr] 57 | g.0 as f32 * x + g.1 as f32 * y + g.2 as f32 * z [INFO] [stderr] | ^^^^^^^^^^ help: try: `f32::from(g.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:57:20 [INFO] [stderr] | [INFO] [stderr] 57 | g.0 as f32 * x + g.1 as f32 * y + g.2 as f32 * z [INFO] [stderr] | ^^^^^^^^^^ help: try: `f32::from(g.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:57:37 [INFO] [stderr] | [INFO] [stderr] 57 | g.0 as f32 * x + g.1 as f32 * y + g.2 as f32 * z [INFO] [stderr] | ^^^^^^^^^^ help: try: `f32::from(g.2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Simplex` [INFO] [stderr] --> src/lib.rs:94:3 [INFO] [stderr] | [INFO] [stderr] 94 | / pub fn new() -> Simplex { [INFO] [stderr] 95 | | [INFO] [stderr] 96 | | let seed = thread_rng().gen_iter::().take(256).collect::>(); [INFO] [stderr] 97 | | return Simplex::from_seed(seed); [INFO] [stderr] 98 | | [INFO] [stderr] 99 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 70 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:19:18 [INFO] [stderr] | [INFO] [stderr] 19 | const F2 : f32 = 0.366025403; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.366_025_403` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:21:18 [INFO] [stderr] | [INFO] [stderr] 21 | const G2 : f32 = 0.211324865; [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.211_324_865` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:97:5 [INFO] [stderr] | [INFO] [stderr] 97 | return Simplex::from_seed(seed); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Simplex::from_seed(seed)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:131:5 [INFO] [stderr] | [INFO] [stderr] 131 | return sn; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `sn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:186:5 [INFO] [stderr] | [INFO] [stderr] 186 | return noise / max_amp; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `noise / max_amp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:230:5 [INFO] [stderr] | [INFO] [stderr] 230 | return noise / max_amp; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `noise / max_amp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:340:5 [INFO] [stderr] | [INFO] [stderr] 340 | return 70.0 * (n0 + n1 + n2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `70.0 * (n0 + n1 + n2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:526:5 [INFO] [stderr] | [INFO] [stderr] 526 | return 32.0*(n0 + n1 + n2 + n3); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `32.0*(n0 + n1 + n2 + n3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:432:10 [INFO] [stderr] | [INFO] [stderr] 432 | else { [INFO] [stderr] | __________^ [INFO] [stderr] 433 | | if y0 < z0 { [INFO] [stderr] 434 | | // Z Y X order [INFO] [stderr] 435 | | i1=0; [INFO] [stderr] ... | [INFO] [stderr] 457 | | } [INFO] [stderr] 458 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 432 | else if y0 < z0 { [INFO] [stderr] 433 | // Z Y X order [INFO] [stderr] 434 | i1=0; [INFO] [stderr] 435 | j1=0; [INFO] [stderr] 436 | k1=1; [INFO] [stderr] 437 | i2=0; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:281:5 [INFO] [stderr] | [INFO] [stderr] 281 | / let j1 : isize; [INFO] [stderr] 282 | | [INFO] [stderr] 283 | | // lower triangle, XY order: (0,0)->(1,0)->(1,1) [INFO] [stderr] 284 | | if x0 > y0 { [INFO] [stderr] ... | [INFO] [stderr] 291 | | j1 = 1; [INFO] [stderr] 292 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let j1 = if x0 > y0 { ..; 0 } else { ..; 1 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/test.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | assert_eq!(other_sn.noise_2d(1.0, 14.2), sn.noise_2d(1.0, 14.2)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/test.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | assert_eq!(other_sn.noise_2d(1.0, 14.2), sn.noise_2d(1.0, 14.2)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/test.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | assert_eq!(other_sn.noise_3d(1.0, 14.2, -5.4), sn.noise_3d(1.0, 14.2, -5.4)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/test.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | assert_eq!(other_sn.noise_3d(1.0, 14.2, -5.4), sn.noise_3d(1.0, 14.2, -5.4)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/test.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | assert!(other_sn.noise_2d(1.0, 14.2) != sn.noise_2d(1.0, 14.2)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(other_sn.noise_2d(1.0, 14.2) - sn.noise_2d(1.0, 14.2)).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/test.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | assert!(other_sn.noise_2d(1.0, 14.2) != sn.noise_2d(1.0, 14.2)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/test.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | assert!(other_sn.noise_3d(1.0, 14.2, -5.4) != sn.noise_3d(1.0, 14.2, -5.4)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(other_sn.noise_3d(1.0, 14.2, -5.4) - sn.noise_3d(1.0, 14.2, -5.4)).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/test.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | assert!(other_sn.noise_3d(1.0, 14.2, -5.4) != sn.noise_3d(1.0, 14.2, -5.4)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/test.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | assert_eq!(sn.noise_2d(1.5, -0.5), sn.noise_2d(1.5, -0.5)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/test.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | assert_eq!(sn.noise_2d(1.5, -0.5), sn.noise_2d(1.5, -0.5)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/test.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | assert!(sn.noise_2d(1.5, -0.5) != other_sn.noise_2d(1.5, -0.5)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(sn.noise_2d(1.5, -0.5) - other_sn.noise_2d(1.5, -0.5)).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/test.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | assert!(sn.noise_2d(1.5, -0.5) != other_sn.noise_2d(1.5, -0.5)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/test.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | assert_eq!(sn.noise_3d(1.5, -0.5, 2.1), sn.noise_3d(1.5, -0.5, 2.1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/test.rs:64:5 [INFO] [stderr] | [INFO] [stderr] 64 | assert_eq!(sn.noise_3d(1.5, -0.5, 2.1), sn.noise_3d(1.5, -0.5, 2.1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/test.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | assert!(sn.noise_3d(1.5, -0.5, 2.1) != other_sn.noise_3d(1.5, -0.5, 2.1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(sn.noise_3d(1.5, -0.5, 2.1) - other_sn.noise_3d(1.5, -0.5, 2.1)).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/test.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | assert!(sn.noise_3d(1.5, -0.5, 2.1) != other_sn.noise_3d(1.5, -0.5, 2.1)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/lib.rs:19:18 [INFO] [stderr] | [INFO] [stderr] 19 | const F2 : f32 = 0.366025403; [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.366_025_4` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::excessive_precision)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/lib.rs:21:18 [INFO] [stderr] | [INFO] [stderr] 21 | const G2 : f32 = 0.211324865; [INFO] [stderr] | ^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.211_324_87` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:49:3 [INFO] [stderr] | [INFO] [stderr] 49 | g.0 as f32 * x + g.1 as f32 * y [INFO] [stderr] | ^^^^^^^^^^ help: try: `f32::from(g.0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:49:20 [INFO] [stderr] | [INFO] [stderr] 49 | g.0 as f32 * x + g.1 as f32 * y [INFO] [stderr] | ^^^^^^^^^^ help: try: `f32::from(g.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:57:3 [INFO] [stderr] | [INFO] [stderr] 57 | g.0 as f32 * x + g.1 as f32 * y + g.2 as f32 * z [INFO] [stderr] | ^^^^^^^^^^ help: try: `f32::from(g.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:57:20 [INFO] [stderr] | [INFO] [stderr] 57 | g.0 as f32 * x + g.1 as f32 * y + g.2 as f32 * z [INFO] [stderr] | ^^^^^^^^^^ help: try: `f32::from(g.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:57:37 [INFO] [stderr] | [INFO] [stderr] 57 | g.0 as f32 * x + g.1 as f32 * y + g.2 as f32 * z [INFO] [stderr] | ^^^^^^^^^^ help: try: `f32::from(g.2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Simplex` [INFO] [stderr] --> src/lib.rs:94:3 [INFO] [stderr] | [INFO] [stderr] 94 | / pub fn new() -> Simplex { [INFO] [stderr] 95 | | [INFO] [stderr] 96 | | let seed = thread_rng().gen_iter::().take(256).collect::>(); [INFO] [stderr] 97 | | return Simplex::from_seed(seed); [INFO] [stderr] 98 | | [INFO] [stderr] 99 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 70 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:281:5 [INFO] [stderr] | [INFO] [stderr] 281 | / let j1 : isize; [INFO] [stderr] 282 | | [INFO] [stderr] 283 | | // lower triangle, XY order: (0,0)->(1,0)->(1,1) [INFO] [stderr] 284 | | if x0 > y0 { [INFO] [stderr] ... | [INFO] [stderr] 291 | | j1 = 1; [INFO] [stderr] 292 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let j1 = if x0 > y0 { ..; 0 } else { ..; 1 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] error: aborting due to 8 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `fuss`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "4673b101da77a183ef8e92ba66b4499efa5f177299505458f49be7373638a8b2"` [INFO] running `"docker" "rm" "-f" "4673b101da77a183ef8e92ba66b4499efa5f177299505458f49be7373638a8b2"` [INFO] [stdout] 4673b101da77a183ef8e92ba66b4499efa5f177299505458f49be7373638a8b2