[INFO] crate funzzy 0.3.3 is already in cache [INFO] extracting crate funzzy 0.3.3 into work/ex/clippy-test-run/sources/stable/reg/funzzy/0.3.3 [INFO] extracting crate funzzy 0.3.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/funzzy/0.3.3 [INFO] validating manifest of funzzy-0.3.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of funzzy-0.3.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing funzzy-0.3.3 [INFO] finished frobbing funzzy-0.3.3 [INFO] frobbed toml for funzzy-0.3.3 written to work/ex/clippy-test-run/sources/stable/reg/funzzy/0.3.3/Cargo.toml [INFO] started frobbing funzzy-0.3.3 [INFO] finished frobbing funzzy-0.3.3 [INFO] frobbed toml for funzzy-0.3.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/funzzy/0.3.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting funzzy-0.3.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/funzzy/0.3.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9b68e7150dd74c9547da010d4b154bc73a75701e8fc91bcb66533608f89ce02e [INFO] running `"docker" "start" "-a" "9b68e7150dd74c9547da010d4b154bc73a75701e8fc91bcb66533608f89ce02e"` [INFO] [stderr] Checking inotify v0.2.3 [INFO] [stderr] Checking notify v2.6.3 [INFO] [stderr] Checking funzzy v0.3.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cli/watch.rs:28:24 [INFO] [stderr] | [INFO] [stderr] 28 | WatchCommand { watches: watches , verbose: verbose } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `watches` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cli/watch.rs:28:43 [INFO] [stderr] | [INFO] [stderr] 28 | WatchCommand { watches: watches , verbose: verbose } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `verbose` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cli/watch.rs:97:19 [INFO] [stderr] | [INFO] [stderr] 97 | Watches { rules: rules } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `rules` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cli/run.rs:18:22 [INFO] [stderr] | [INFO] [stderr] 18 | RunCommand { command: command, interval: interval } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `command` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cli/run.rs:18:40 [INFO] [stderr] | [INFO] [stderr] 18 | RunCommand { command: command, interval: interval } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `interval` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rules.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | commands: commands, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `commands` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cli/watch.rs:28:24 [INFO] [stderr] | [INFO] [stderr] 28 | WatchCommand { watches: watches , verbose: verbose } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `watches` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cli/watch.rs:28:43 [INFO] [stderr] | [INFO] [stderr] 28 | WatchCommand { watches: watches , verbose: verbose } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `verbose` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cli/watch.rs:97:19 [INFO] [stderr] | [INFO] [stderr] 97 | Watches { rules: rules } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `rules` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cli/run.rs:18:22 [INFO] [stderr] | [INFO] [stderr] 18 | RunCommand { command: command, interval: interval } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `command` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cli/run.rs:18:40 [INFO] [stderr] | [INFO] [stderr] 18 | RunCommand { command: command, interval: interval } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `interval` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rules.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | commands: commands, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `commands` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cli/init.rs:7:29 [INFO] [stderr] | [INFO] [stderr] 7 | pub const DEFAULT_CONTENT: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cli/watch.rs:13:30 [INFO] [stderr] | [INFO] [stderr] 13 | pub const DEFAULT_FILENAME: &'static str = ".watch.yaml"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/cli/watch.rs:108:9 [INFO] [stderr] | [INFO] [stderr] 108 | / for rule in self.rules.iter() [INFO] [stderr] 109 | | .filter(|r| !r.ignore(path) && r.watch(path)) { [INFO] [stderr] 110 | | return Some(rule.to_command()); [INFO] [stderr] 111 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/rules.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | / self.ignore_patterns.iter() [INFO] [stderr] 43 | | .any(|ignore| pattern(ignore).matches(path)) || false [INFO] [stderr] | |_________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 42 | self.ignore_patterns.iter() [INFO] [stderr] 43 | .any(|ignore| pattern(ignore).matches(path)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/rules.rs:63:47 [INFO] [stderr] | [INFO] [stderr] 63 | pub fn from_string(patterns: String, command: &String) -> Vec { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 63 | pub fn from_string(patterns: String, command: &str) -> Vec { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `command.clone()` to [INFO] [stderr] | [INFO] [stderr] 67 | vec![Rules::new(vec![command.to_string()], watches, vec![])] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/rules.rs:74:33 [INFO] [stderr] | [INFO] [stderr] 74 | fn command_from_string(command: &String) -> ShellCommand { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `funzzy`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cli/init.rs:7:29 [INFO] [stderr] | [INFO] [stderr] 7 | pub const DEFAULT_CONTENT: &'static str = " [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cli/watch.rs:13:30 [INFO] [stderr] | [INFO] [stderr] 13 | pub const DEFAULT_FILENAME: &'static str = ".watch.yaml"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/cli/watch.rs:108:9 [INFO] [stderr] | [INFO] [stderr] 108 | / for rule in self.rules.iter() [INFO] [stderr] 109 | | .filter(|r| !r.ignore(path) && r.watch(path)) { [INFO] [stderr] 110 | | return Some(rule.to_command()); [INFO] [stderr] 111 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/rules.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | / self.ignore_patterns.iter() [INFO] [stderr] 43 | | .any(|ignore| pattern(ignore).matches(path)) || false [INFO] [stderr] | |_________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 42 | self.ignore_patterns.iter() [INFO] [stderr] 43 | .any(|ignore| pattern(ignore).matches(path)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/rules.rs:63:47 [INFO] [stderr] | [INFO] [stderr] 63 | pub fn from_string(patterns: String, command: &String) -> Vec { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 63 | pub fn from_string(patterns: String, command: &str) -> Vec { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `command.clone()` to [INFO] [stderr] | [INFO] [stderr] 67 | vec![Rules::new(vec![command.to_string()], watches, vec![])] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/rules.rs:74:33 [INFO] [stderr] | [INFO] [stderr] 74 | fn command_from_string(command: &String) -> ShellCommand { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `funzzy`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "9b68e7150dd74c9547da010d4b154bc73a75701e8fc91bcb66533608f89ce02e"` [INFO] running `"docker" "rm" "-f" "9b68e7150dd74c9547da010d4b154bc73a75701e8fc91bcb66533608f89ce02e"` [INFO] [stdout] 9b68e7150dd74c9547da010d4b154bc73a75701e8fc91bcb66533608f89ce02e