[INFO] crate fungui 0.1.1 is already in cache [INFO] extracting crate fungui 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/fungui/0.1.1 [INFO] extracting crate fungui 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fungui/0.1.1 [INFO] validating manifest of fungui-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of fungui-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing fungui-0.1.1 [INFO] finished frobbing fungui-0.1.1 [INFO] frobbed toml for fungui-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/fungui/0.1.1/Cargo.toml [INFO] started frobbing fungui-0.1.1 [INFO] finished frobbing fungui-0.1.1 [INFO] frobbed toml for fungui-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fungui/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting fungui-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/fungui/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9c5911fcbaa838f158466ed019b7a54784f7a80c1146f0cd2dc658eec2423d0f [INFO] running `"docker" "start" "-a" "9c5911fcbaa838f158466ed019b7a54784f7a80c1146f0cd2dc658eec2423d0f"` [INFO] [stderr] Checking ref_filter_map v1.0.1 [INFO] [stderr] Checking fungui_syntax v0.1.0 [INFO] [stderr] Checking fungui v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:449:48 [INFO] [stderr] | [INFO] [stderr] 449 | location: Some(query::AtLocation { x: x, y: y }), [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:449:54 [INFO] [stderr] | [INFO] [stderr] 449 | location: Some(query::AtLocation { x: x, y: y }), [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:449:48 [INFO] [stderr] | [INFO] [stderr] 449 | location: Some(query::AtLocation { x: x, y: y }), [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:449:54 [INFO] [stderr] | [INFO] [stderr] 449 | location: Some(query::AtLocation { x: x, y: y }), [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/query.rs:99:25 [INFO] [stderr] | [INFO] [stderr] 99 | ValueRef::Float(self as f64) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(self)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/query.rs:351:76 [INFO] [stderr] | [INFO] [stderr] 351 | (Some(Value::Float(a)), ValueRef::Float(b)) => a == b, [INFO] [stderr] | ^^^^^^ help: consider comparing them within some error: `(a - b).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/query.rs:351:76 [INFO] [stderr] | [INFO] [stderr] 351 | (Some(Value::Float(a)), ValueRef::Float(b)) => a == b, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/style.rs:13:25 [INFO] [stderr] | [INFO] [stderr] 13 | pub(crate) layouts: FnvHashMap<&'static str, Box Box>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/style.rs:255:76 [INFO] [stderr] | [INFO] [stderr] 255 | (ValueMatcher::Integer(a), Value::Float(b)) => *a as f64 == *b, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(*a as f64 - *b).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/style.rs:255:76 [INFO] [stderr] | [INFO] [stderr] 255 | (ValueMatcher::Integer(a), Value::Float(b)) => *a as f64 == *b, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/style.rs:255:76 [INFO] [stderr] | [INFO] [stderr] 255 | (ValueMatcher::Integer(a), Value::Float(b)) => *a as f64 == *b, [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(*a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/style.rs:256:74 [INFO] [stderr] | [INFO] [stderr] 256 | (ValueMatcher::Float(a), Value::Float(b)) => *a == *b, [INFO] [stderr] | ^^^^^^^^ help: consider comparing them within some error: `(*a - *b).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/style.rs:256:74 [INFO] [stderr] | [INFO] [stderr] 256 | (ValueMatcher::Float(a), Value::Float(b)) => *a == *b, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/style.rs:257:76 [INFO] [stderr] | [INFO] [stderr] 257 | (ValueMatcher::Float(a), Value::Integer(b)) => *a == *b as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(*a - *b as f64).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/style.rs:257:76 [INFO] [stderr] | [INFO] [stderr] 257 | (ValueMatcher::Float(a), Value::Integer(b)) => *a == *b as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/style.rs:257:82 [INFO] [stderr] | [INFO] [stderr] 257 | (ValueMatcher::Float(a), Value::Integer(b)) => *a == *b as f64, [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(*b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 53 [INFO] [stderr] --> src/expr.rs:101:5 [INFO] [stderr] | [INFO] [stderr] 101 | / pub fn eval<'a>(&'a self, styles: &'a Styles, node: &'a NodeChain) -> Result, Error<'a>> { [INFO] [stderr] 102 | | Ok(match *self { [INFO] [stderr] 103 | | Expr::Value(ref v) => v.clone(), [INFO] [stderr] 104 | | Expr::Variable(ref n) => return node.properties.get(n).cloned().ok_or(Error::UnknownVariable{name: n}), [INFO] [stderr] ... | [INFO] [stderr] 208 | | }) [INFO] [stderr] 209 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/expr.rs:130:51 [INFO] [stderr] | [INFO] [stderr] 130 | Value::Integer(a) => Value::Float(a as f64), [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: item `layout::ChildAccess<'a, L, E>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/layout.rs:200:1 [INFO] [stderr] | [INFO] [stderr] 200 | / impl <'a, L, E> ChildAccess<'a, L, E> [INFO] [stderr] 201 | | where L: LayoutEngine, [INFO] [stderr] 202 | | E: Extension [INFO] [stderr] 203 | | { [INFO] [stderr] ... | [INFO] [stderr] 223 | | } [INFO] [stderr] 224 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/query.rs:99:25 [INFO] [stderr] | [INFO] [stderr] 99 | ValueRef::Float(self as f64) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(self)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/layout.rs:418:9 [INFO] [stderr] | [INFO] [stderr] 418 | data.x.map(|v| current.x = v); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(v) = data.x { ... }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/layout.rs:419:9 [INFO] [stderr] | [INFO] [stderr] 419 | data.y.map(|v| current.y = v); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(v) = data.y { ... }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/layout.rs:420:9 [INFO] [stderr] | [INFO] [stderr] 420 | data.width.map(|v| current.width = v); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(v) = data.width { ... }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/layout.rs:421:9 [INFO] [stderr] | [INFO] [stderr] 421 | data.height.map(|v| current.height = v); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(v) = data.height { ... }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/query.rs:351:76 [INFO] [stderr] | [INFO] [stderr] 351 | (Some(Value::Float(a)), ValueRef::Float(b)) => a == b, [INFO] [stderr] | ^^^^^^ help: consider comparing them within some error: `(a - b).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/query.rs:351:76 [INFO] [stderr] | [INFO] [stderr] 351 | (Some(Value::Float(a)), ValueRef::Float(b)) => a == b, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Manager` [INFO] [stderr] --> src/lib.rs:364:5 [INFO] [stderr] | [INFO] [stderr] 364 | / pub fn new() -> Manager { [INFO] [stderr] 365 | | let mut static_keys = FnvHashMap::default(); [INFO] [stderr] 366 | | { [INFO] [stderr] 367 | | let mut prop = |key: StaticKey| {static_keys.insert(key.0, key);}; [INFO] [stderr] ... | [INFO] [stderr] 390 | | m [INFO] [stderr] 391 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 362 | impl Default for Manager { [INFO] [stderr] 363 | fn default() -> Self { [INFO] [stderr] 364 | Self::new() [INFO] [stderr] 365 | } [INFO] [stderr] 366 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/lib.rs:415:55 [INFO] [stderr] | [INFO] [stderr] 415 | let key = self.styles.static_keys.entry(name).or_insert(StaticKey(name)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| StaticKey(name))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/style.rs:13:25 [INFO] [stderr] | [INFO] [stderr] 13 | pub(crate) layouts: FnvHashMap<&'static str, Box Box>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 28 [INFO] [stderr] --> src/lib.rs:602:5 [INFO] [stderr] | [INFO] [stderr] 602 | / fn do_update( [INFO] [stderr] 603 | | &self, [INFO] [stderr] 604 | | styles: &mut Styles, [INFO] [stderr] 605 | | parent: &NodeChain, [INFO] [stderr] ... | [INFO] [stderr] 718 | | inner.dirty_flags [INFO] [stderr] 719 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:663:28 [INFO] [stderr] | [INFO] [stderr] 663 | if inner.scroll_position.0 != new { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(inner.scroll_position.0 - new).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:663:28 [INFO] [stderr] | [INFO] [stderr] 663 | if inner.scroll_position.0 != new { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:670:28 [INFO] [stderr] | [INFO] [stderr] 670 | if inner.scroll_position.1 != new { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(inner.scroll_position.1 - new).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:670:28 [INFO] [stderr] | [INFO] [stderr] 670 | if inner.scroll_position.1 != new { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/style.rs:255:76 [INFO] [stderr] | [INFO] [stderr] 255 | (ValueMatcher::Integer(a), Value::Float(b)) => *a as f64 == *b, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(*a as f64 - *b).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/style.rs:255:76 [INFO] [stderr] | [INFO] [stderr] 255 | (ValueMatcher::Integer(a), Value::Float(b)) => *a as f64 == *b, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/style.rs:255:76 [INFO] [stderr] | [INFO] [stderr] 255 | (ValueMatcher::Integer(a), Value::Float(b)) => *a as f64 == *b, [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(*a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/style.rs:256:74 [INFO] [stderr] | [INFO] [stderr] 256 | (ValueMatcher::Float(a), Value::Float(b)) => *a == *b, [INFO] [stderr] | ^^^^^^^^ help: consider comparing them within some error: `(*a - *b).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/style.rs:256:74 [INFO] [stderr] | [INFO] [stderr] 256 | (ValueMatcher::Float(a), Value::Float(b)) => *a == *b, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/style.rs:257:76 [INFO] [stderr] | [INFO] [stderr] 257 | (ValueMatcher::Float(a), Value::Integer(b)) => *a == *b as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(*a - *b as f64).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/style.rs:257:76 [INFO] [stderr] | [INFO] [stderr] 257 | (ValueMatcher::Float(a), Value::Integer(b)) => *a == *b as f64, [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/style.rs:257:82 [INFO] [stderr] | [INFO] [stderr] 257 | (ValueMatcher::Float(a), Value::Integer(b)) => *a == *b as f64, [INFO] [stderr] | ^^^^^^^^^ help: try: `f64::from(*b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 53 [INFO] [stderr] --> src/expr.rs:101:5 [INFO] [stderr] | [INFO] [stderr] 101 | / pub fn eval<'a>(&'a self, styles: &'a Styles, node: &'a NodeChain) -> Result, Error<'a>> { [INFO] [stderr] 102 | | Ok(match *self { [INFO] [stderr] 103 | | Expr::Value(ref v) => v.clone(), [INFO] [stderr] 104 | | Expr::Variable(ref n) => return node.properties.get(n).cloned().ok_or(Error::UnknownVariable{name: n}), [INFO] [stderr] ... | [INFO] [stderr] 208 | | }) [INFO] [stderr] 209 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:1068:5 [INFO] [stderr] | [INFO] [stderr] 1068 | / pub fn from_str(s: &str) -> Result, syntax::PError> { [INFO] [stderr] 1069 | | syntax::desc::Document::parse(s).map(|v| Node::from_document(v)) [INFO] [stderr] 1070 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:1069:46 [INFO] [stderr] | [INFO] [stderr] 1069 | syntax::desc::Document::parse(s).map(|v| Node::from_document(v)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Node::from_document` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:1253:23 [INFO] [stderr] | [INFO] [stderr] 1253 | .and_then(|v| V::from_value(v)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `V::from_value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/expr.rs:130:51 [INFO] [stderr] | [INFO] [stderr] 130 | Value::Integer(a) => Value::Float(a as f64), [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1478:39 [INFO] [stderr] | [INFO] [stderr] 1478 | Value::Integer(i) => Some(i as f64), [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1512:22 [INFO] [stderr] | [INFO] [stderr] 1512 | Value::Float(v as f64) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to 6 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `fungui`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: item `layout::ChildAccess<'a, L, E>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/layout.rs:200:1 [INFO] [stderr] | [INFO] [stderr] 200 | / impl <'a, L, E> ChildAccess<'a, L, E> [INFO] [stderr] 201 | | where L: LayoutEngine, [INFO] [stderr] 202 | | E: Extension [INFO] [stderr] 203 | | { [INFO] [stderr] ... | [INFO] [stderr] 223 | | } [INFO] [stderr] 224 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/layout.rs:418:9 [INFO] [stderr] | [INFO] [stderr] 418 | data.x.map(|v| current.x = v); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(v) = data.x { ... }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/layout.rs:419:9 [INFO] [stderr] | [INFO] [stderr] 419 | data.y.map(|v| current.y = v); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(v) = data.y { ... }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/layout.rs:420:9 [INFO] [stderr] | [INFO] [stderr] 420 | data.width.map(|v| current.width = v); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(v) = data.width { ... }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/layout.rs:421:9 [INFO] [stderr] | [INFO] [stderr] 421 | data.height.map(|v| current.height = v); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(v) = data.height { ... }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Manager` [INFO] [stderr] --> src/lib.rs:364:5 [INFO] [stderr] | [INFO] [stderr] 364 | / pub fn new() -> Manager { [INFO] [stderr] 365 | | let mut static_keys = FnvHashMap::default(); [INFO] [stderr] 366 | | { [INFO] [stderr] 367 | | let mut prop = |key: StaticKey| {static_keys.insert(key.0, key);}; [INFO] [stderr] ... | [INFO] [stderr] 390 | | m [INFO] [stderr] 391 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 362 | impl Default for Manager { [INFO] [stderr] 363 | fn default() -> Self { [INFO] [stderr] 364 | Self::new() [INFO] [stderr] 365 | } [INFO] [stderr] 366 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/lib.rs:415:55 [INFO] [stderr] | [INFO] [stderr] 415 | let key = self.styles.static_keys.entry(name).or_insert(StaticKey(name)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| StaticKey(name))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 28 [INFO] [stderr] --> src/lib.rs:602:5 [INFO] [stderr] | [INFO] [stderr] 602 | / fn do_update( [INFO] [stderr] 603 | | &self, [INFO] [stderr] 604 | | styles: &mut Styles, [INFO] [stderr] 605 | | parent: &NodeChain, [INFO] [stderr] ... | [INFO] [stderr] 718 | | inner.dirty_flags [INFO] [stderr] 719 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:663:28 [INFO] [stderr] | [INFO] [stderr] 663 | if inner.scroll_position.0 != new { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(inner.scroll_position.0 - new).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:663:28 [INFO] [stderr] | [INFO] [stderr] 663 | if inner.scroll_position.0 != new { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:670:28 [INFO] [stderr] | [INFO] [stderr] 670 | if inner.scroll_position.1 != new { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(inner.scroll_position.1 - new).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:670:28 [INFO] [stderr] | [INFO] [stderr] 670 | if inner.scroll_position.1 != new { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:1068:5 [INFO] [stderr] | [INFO] [stderr] 1068 | / pub fn from_str(s: &str) -> Result, syntax::PError> { [INFO] [stderr] 1069 | | syntax::desc::Document::parse(s).map(|v| Node::from_document(v)) [INFO] [stderr] 1070 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:1069:46 [INFO] [stderr] | [INFO] [stderr] 1069 | syntax::desc::Document::parse(s).map(|v| Node::from_document(v)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Node::from_document` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:1253:23 [INFO] [stderr] | [INFO] [stderr] 1253 | .and_then(|v| V::from_value(v)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `V::from_value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1478:39 [INFO] [stderr] | [INFO] [stderr] 1478 | Value::Integer(i) => Some(i as f64), [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1512:22 [INFO] [stderr] | [INFO] [stderr] 1512 | Value::Float(v as f64) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to 6 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `fungui`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "9c5911fcbaa838f158466ed019b7a54784f7a80c1146f0cd2dc658eec2423d0f"` [INFO] running `"docker" "rm" "-f" "9c5911fcbaa838f158466ed019b7a54784f7a80c1146f0cd2dc658eec2423d0f"` [INFO] [stdout] 9c5911fcbaa838f158466ed019b7a54784f7a80c1146f0cd2dc658eec2423d0f