[INFO] crate fts 0.2.0 is already in cache [INFO] extracting crate fts 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/fts/0.2.0 [INFO] extracting crate fts 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fts/0.2.0 [INFO] validating manifest of fts-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of fts-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing fts-0.2.0 [INFO] finished frobbing fts-0.2.0 [INFO] frobbed toml for fts-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/fts/0.2.0/Cargo.toml [INFO] started frobbing fts-0.2.0 [INFO] finished frobbing fts-0.2.0 [INFO] frobbed toml for fts-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fts/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting fts-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/fts/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b214f995908ab2516fd98a0c1edfdc2b4ae69feb76d8b8a0e5fbe5f98bec3580 [INFO] running `"docker" "start" "-a" "b214f995908ab2516fd98a0c1edfdc2b4ae69feb76d8b8a0e5fbe5f98bec3580"` [INFO] [stderr] Compiling fts v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fts.rs:145:13 [INFO] [stderr] | [INFO] [stderr] 145 | fts: fts, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `fts` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fts.rs:196:13 [INFO] [stderr] | [INFO] [stderr] 196 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fts.rs:197:13 [INFO] [stderr] | [INFO] [stderr] 197 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fts.rs:199:13 [INFO] [stderr] | [INFO] [stderr] 199 | stat: stat, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `stat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fts.rs:200:13 [INFO] [stderr] | [INFO] [stderr] 200 | level: level, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `level` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fts.rs:201:13 [INFO] [stderr] | [INFO] [stderr] 201 | error: error, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `error` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/walkdir.rs:156:36 [INFO] [stderr] | [INFO] [stderr] 156 | Some(Ok(DirEntry { ent: ent })) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/walkdir.rs:361:13 [INFO] [stderr] | [INFO] [stderr] 361 | conf: conf, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `conf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fts.rs:145:13 [INFO] [stderr] | [INFO] [stderr] 145 | fts: fts, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `fts` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fts.rs:196:13 [INFO] [stderr] | [INFO] [stderr] 196 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fts.rs:197:13 [INFO] [stderr] | [INFO] [stderr] 197 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fts.rs:199:13 [INFO] [stderr] | [INFO] [stderr] 199 | stat: stat, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `stat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fts.rs:200:13 [INFO] [stderr] | [INFO] [stderr] 200 | level: level, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `level` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fts.rs:201:13 [INFO] [stderr] | [INFO] [stderr] 201 | error: error, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `error` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/walkdir.rs:156:36 [INFO] [stderr] | [INFO] [stderr] 156 | Some(Ok(DirEntry { ent: ent })) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ent` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/walkdir.rs:361:13 [INFO] [stderr] | [INFO] [stderr] 361 | conf: conf, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `conf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/fts.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | / let perm; [INFO] [stderr] 95 | | if self.stat.is_some() { [INFO] [stderr] 96 | | let stat = self.stat.clone().unwrap(); [INFO] [stderr] 97 | | len = stat.len(); [INFO] [stderr] ... | [INFO] [stderr] 101 | | perm = String::from("Unknown"); [INFO] [stderr] 102 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let perm = if self.stat.is_some() { ..; $ crate :: fmt :: format ( format_args ! ( $ ( $ arg ) * ) ) } else { ..; String::from("Unknown") };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/fts.rs:165:16 [INFO] [stderr] | [INFO] [stderr] 165 | fn to_path(buf: *const u8, len: usize) -> PathBuf { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/fts.rs:171:21 [INFO] [stderr] | [INFO] [stderr] 171 | fn to_fts_entry(ent: *const ffi::FTSENT, is_no_stat: bool) -> Option { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/fts.rs:185:30 [INFO] [stderr] | [INFO] [stderr] 185 | let level = unsafe { (*ent).fts_level as i32 }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from((*ent).fts_level)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/fts.rs:191:24 [INFO] [stderr] | [INFO] [stderr] 191 | Some((*mem::transmute::<*const stat, *const Metadata>((*ent).fts_statp)).clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(*ent).fts_statp as *const std::fs::Metadata` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/fts.rs:280:5 [INFO] [stderr] | [INFO] [stderr] 280 | / fn by_ascending_ref<'a, T: PartialOrd + ?Sized>( [INFO] [stderr] 281 | | ent0: FtsCompIn, [INFO] [stderr] 282 | | ent1: FtsCompIn, [INFO] [stderr] 283 | | to_value: fn(FtsCompIn) -> &'a T, [INFO] [stderr] ... | [INFO] [stderr] 292 | | } [INFO] [stderr] 293 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/fts.rs:310:5 [INFO] [stderr] | [INFO] [stderr] 310 | / fn by_descending_ref<'a, T: PartialOrd + ?Sized>( [INFO] [stderr] 311 | | ent0: FtsCompIn, [INFO] [stderr] 312 | | ent1: FtsCompIn, [INFO] [stderr] 313 | | to_value: fn(FtsCompIn) -> &'a T, [INFO] [stderr] ... | [INFO] [stderr] 322 | | } [INFO] [stderr] 323 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/fts.rs:325:20 [INFO] [stderr] | [INFO] [stderr] 325 | fn to_name<'a>(ent: *const *const ffi::FTSENT) -> &'a OsStr { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/fts.rs:331:21 [INFO] [stderr] | [INFO] [stderr] 331 | fn to_osstr<'a>(buf: *const u8, len: usize) -> &'a OsStr { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/fts.rs:336:17 [INFO] [stderr] | [INFO] [stderr] 336 | fn to_atime(ent: *const *const ffi::FTSENT) -> c_long { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/fts.rs:339:20 [INFO] [stderr] | [INFO] [stderr] 339 | unsafe { (*mem::transmute::<*const stat, *const Metadata>((**ent).fts_statp)).atime_nsec() } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(**ent).fts_statp as *const std::fs::Metadata` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/fts.rs:342:17 [INFO] [stderr] | [INFO] [stderr] 342 | fn to_mtime(ent: *const *const ffi::FTSENT) -> c_long { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/fts.rs:345:20 [INFO] [stderr] | [INFO] [stderr] 345 | unsafe { (*mem::transmute::<*const stat, *const Metadata>((**ent).fts_statp)).mtime_nsec() } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(**ent).fts_statp as *const std::fs::Metadata` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/fts.rs:348:17 [INFO] [stderr] | [INFO] [stderr] 348 | fn to_ctime(ent: *const *const ffi::FTSENT) -> c_long { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/fts.rs:351:20 [INFO] [stderr] | [INFO] [stderr] 351 | unsafe { (*mem::transmute::<*const stat, *const Metadata>((**ent).fts_statp)).ctime_nsec() } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(**ent).fts_statp as *const std::fs::Metadata` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/fts.rs:354:15 [INFO] [stderr] | [INFO] [stderr] 354 | fn to_len(ent: *const *const ffi::FTSENT) -> u64 { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/fts.rs:357:20 [INFO] [stderr] | [INFO] [stderr] 357 | unsafe { (*mem::transmute::<*const stat, *const Metadata>((**ent).fts_statp)).len() } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(**ent).fts_statp as *const std::fs::Metadata` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/fts.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | / let perm; [INFO] [stderr] 95 | | if self.stat.is_some() { [INFO] [stderr] 96 | | let stat = self.stat.clone().unwrap(); [INFO] [stderr] 97 | | len = stat.len(); [INFO] [stderr] ... | [INFO] [stderr] 101 | | perm = String::from("Unknown"); [INFO] [stderr] 102 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let perm = if self.stat.is_some() { ..; $ crate :: fmt :: format ( format_args ! ( $ ( $ arg ) * ) ) } else { ..; String::from("Unknown") };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/fts.rs:165:16 [INFO] [stderr] | [INFO] [stderr] 165 | fn to_path(buf: *const u8, len: usize) -> PathBuf { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/fts.rs:171:21 [INFO] [stderr] | [INFO] [stderr] 171 | fn to_fts_entry(ent: *const ffi::FTSENT, is_no_stat: bool) -> Option { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/fts.rs:185:30 [INFO] [stderr] | [INFO] [stderr] 185 | let level = unsafe { (*ent).fts_level as i32 }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from((*ent).fts_level)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/fts.rs:191:24 [INFO] [stderr] | [INFO] [stderr] 191 | Some((*mem::transmute::<*const stat, *const Metadata>((*ent).fts_statp)).clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(*ent).fts_statp as *const std::fs::Metadata` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/fts.rs:280:5 [INFO] [stderr] | [INFO] [stderr] 280 | / fn by_ascending_ref<'a, T: PartialOrd + ?Sized>( [INFO] [stderr] 281 | | ent0: FtsCompIn, [INFO] [stderr] 282 | | ent1: FtsCompIn, [INFO] [stderr] 283 | | to_value: fn(FtsCompIn) -> &'a T, [INFO] [stderr] ... | [INFO] [stderr] 292 | | } [INFO] [stderr] 293 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/fts.rs:310:5 [INFO] [stderr] | [INFO] [stderr] 310 | / fn by_descending_ref<'a, T: PartialOrd + ?Sized>( [INFO] [stderr] 311 | | ent0: FtsCompIn, [INFO] [stderr] 312 | | ent1: FtsCompIn, [INFO] [stderr] 313 | | to_value: fn(FtsCompIn) -> &'a T, [INFO] [stderr] ... | [INFO] [stderr] 322 | | } [INFO] [stderr] 323 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/fts.rs:325:20 [INFO] [stderr] | [INFO] [stderr] 325 | fn to_name<'a>(ent: *const *const ffi::FTSENT) -> &'a OsStr { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/fts.rs:331:21 [INFO] [stderr] | [INFO] [stderr] 331 | fn to_osstr<'a>(buf: *const u8, len: usize) -> &'a OsStr { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/fts.rs:336:17 [INFO] [stderr] | [INFO] [stderr] 336 | fn to_atime(ent: *const *const ffi::FTSENT) -> c_long { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/fts.rs:339:20 [INFO] [stderr] | [INFO] [stderr] 339 | unsafe { (*mem::transmute::<*const stat, *const Metadata>((**ent).fts_statp)).atime_nsec() } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(**ent).fts_statp as *const std::fs::Metadata` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/fts.rs:342:17 [INFO] [stderr] | [INFO] [stderr] 342 | fn to_mtime(ent: *const *const ffi::FTSENT) -> c_long { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/fts.rs:345:20 [INFO] [stderr] | [INFO] [stderr] 345 | unsafe { (*mem::transmute::<*const stat, *const Metadata>((**ent).fts_statp)).mtime_nsec() } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(**ent).fts_statp as *const std::fs::Metadata` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/fts.rs:348:17 [INFO] [stderr] | [INFO] [stderr] 348 | fn to_ctime(ent: *const *const ffi::FTSENT) -> c_long { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/fts.rs:351:20 [INFO] [stderr] | [INFO] [stderr] 351 | unsafe { (*mem::transmute::<*const stat, *const Metadata>((**ent).fts_statp)).ctime_nsec() } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(**ent).fts_statp as *const std::fs::Metadata` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/fts.rs:354:15 [INFO] [stderr] | [INFO] [stderr] 354 | fn to_len(ent: *const *const ffi::FTSENT) -> u64 { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: transmute from a pointer to a pointer [INFO] [stderr] --> src/fts.rs:357:20 [INFO] [stderr] | [INFO] [stderr] 357 | unsafe { (*mem::transmute::<*const stat, *const Metadata>((**ent).fts_statp)).len() } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(**ent).fts_statp as *const std::fs::Metadata` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 36 [INFO] [stderr] --> src/fts.rs:373:5 [INFO] [stderr] | [INFO] [stderr] 373 | / fn check_entry(entry: FtsEntry, is_logical: bool) { [INFO] [stderr] 374 | | if entry.path == PathBuf::from("test_data") { [INFO] [stderr] 375 | | assert!(entry.info == FtsInfo::IsDir || entry.info == FtsInfo::IsDirPost); [INFO] [stderr] 376 | | assert_eq!(entry.level, 0); [INFO] [stderr] ... | [INFO] [stderr] 430 | | } [INFO] [stderr] 431 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/fts.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `fts`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "b214f995908ab2516fd98a0c1edfdc2b4ae69feb76d8b8a0e5fbe5f98bec3580"` [INFO] running `"docker" "rm" "-f" "b214f995908ab2516fd98a0c1edfdc2b4ae69feb76d8b8a0e5fbe5f98bec3580"` [INFO] [stdout] b214f995908ab2516fd98a0c1edfdc2b4ae69feb76d8b8a0e5fbe5f98bec3580