[INFO] crate fsync 0.1.0 is already in cache [INFO] extracting crate fsync 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/fsync/0.1.0 [INFO] extracting crate fsync 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fsync/0.1.0 [INFO] validating manifest of fsync-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of fsync-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing fsync-0.1.0 [INFO] finished frobbing fsync-0.1.0 [INFO] frobbed toml for fsync-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/fsync/0.1.0/Cargo.toml [INFO] started frobbing fsync-0.1.0 [INFO] finished frobbing fsync-0.1.0 [INFO] frobbed toml for fsync-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fsync/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting fsync-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/fsync/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f3d5bfc0ea37098d09bfef5e462f7d071f8a84706c913c8cb9d7c13c4df2ed5a [INFO] running `"docker" "start" "-a" "f3d5bfc0ea37098d09bfef5e462f7d071f8a84706c913c8cb9d7c13c4df2ed5a"` [INFO] [stderr] Checking fsync v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/lib.rs:66:8 [INFO] [stderr] | [INFO] [stderr] 66 | Ok((copied)) [INFO] [stderr] | ^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/lib.rs:66:8 [INFO] [stderr] | [INFO] [stderr] 66 | Ok((copied)) [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utils.rs:81:54 [INFO] [stderr] | [INFO] [stderr] 81 | let atime = UNIX_EPOCH + Duration::from_secs(1509062400); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_509_062_400` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/utils.rs:82:54 [INFO] [stderr] | [INFO] [stderr] 82 | let mtime = UNIX_EPOCH + Duration::from_secs(1509105600); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_509_105_600` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/lib.rs:66:8 [INFO] [stderr] | [INFO] [stderr] 66 | Ok((copied)) [INFO] [stderr] | ^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/lib.rs:66:8 [INFO] [stderr] | [INFO] [stderr] 66 | Ok((copied)) [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:159:58 [INFO] [stderr] | [INFO] [stderr] 159 | let test_time = UNIX_EPOCH + Duration::from_secs(1509062400); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_509_062_400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:168:60 [INFO] [stderr] | [INFO] [stderr] 168 | let test_time_a = UNIX_EPOCH + Duration::from_secs(1509062400); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_509_062_400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:169:60 [INFO] [stderr] | [INFO] [stderr] 169 | let test_time_b = UNIX_EPOCH + Duration::from_secs(1509068400); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_509_068_400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:178:58 [INFO] [stderr] | [INFO] [stderr] 178 | let test_time = UNIX_EPOCH + Duration::from_secs(1509062400); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_509_062_400` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:18:31 [INFO] [stderr] | [INFO] [stderr] 18 | tv_nsec: atime_since_epoch.subsec_nanos() as c_long, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(atime_since_epoch.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:22:31 [INFO] [stderr] | [INFO] [stderr] 22 | tv_nsec: mtime_since_epoch.subsec_nanos() as c_long, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(mtime_since_epoch.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:130:12 [INFO] [stderr] | [INFO] [stderr] 130 | if &source_buffer[..] != &target_buffer[..] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 130 | if source_buffer[..] != target_buffer[..] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:18:31 [INFO] [stderr] | [INFO] [stderr] 18 | tv_nsec: atime_since_epoch.subsec_nanos() as c_long, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(atime_since_epoch.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/utils.rs:22:31 [INFO] [stderr] | [INFO] [stderr] 22 | tv_nsec: mtime_since_epoch.subsec_nanos() as c_long, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(mtime_since_epoch.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:130:12 [INFO] [stderr] | [INFO] [stderr] 130 | if &source_buffer[..] != &target_buffer[..] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 130 | if source_buffer[..] != target_buffer[..] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.92s [INFO] running `"docker" "inspect" "f3d5bfc0ea37098d09bfef5e462f7d071f8a84706c913c8cb9d7c13c4df2ed5a"` [INFO] running `"docker" "rm" "-f" "f3d5bfc0ea37098d09bfef5e462f7d071f8a84706c913c8cb9d7c13c4df2ed5a"` [INFO] [stdout] f3d5bfc0ea37098d09bfef5e462f7d071f8a84706c913c8cb9d7c13c4df2ed5a