[INFO] crate fstab 0.3.1 is already in cache
[INFO] extracting crate fstab 0.3.1 into work/ex/clippy-test-run/sources/stable/reg/fstab/0.3.1
[INFO] extracting crate fstab 0.3.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fstab/0.3.1
[INFO] validating manifest of fstab-0.3.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of fstab-0.3.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing fstab-0.3.1
[INFO] finished frobbing fstab-0.3.1
[INFO] frobbed toml for fstab-0.3.1 written to work/ex/clippy-test-run/sources/stable/reg/fstab/0.3.1/Cargo.toml
[INFO] started frobbing fstab-0.3.1
[INFO] finished frobbing fstab-0.3.1
[INFO] frobbed toml for fstab-0.3.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fstab/0.3.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting fstab-0.3.1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/fstab/0.3.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 9799f27c8e5579fa620ee573e62b9b1a18d1f75f178831834116ed2218149e2a
[INFO] running `"docker" "start" "-a" "9799f27c8e5579fa620ee573e62b9b1a18d1f75f178831834116ed2218149e2a"`
[INFO] [stderr]     Checking fstab v0.3.1 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:143:17
[INFO] [stderr]     |
[INFO] [stderr] 143 |                 fsck_order: fsck_order,
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `fsck_order`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:143:17
[INFO] [stderr]     |
[INFO] [stderr] 143 |                 fsck_order: fsck_order,
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `fsck_order`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/lib.rs:125:33
[INFO] [stderr]     |
[INFO] [stderr] 125 |             if line.starts_with("#") {
[INFO] [stderr]     |                                 ^^^ help: try using a char instead: `'#'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/lib.rs:141:47
[INFO] [stderr]     |
[INFO] [stderr] 141 |                 mount_options: parts[3].split(",").map(|s| s.to_string()).collect(),
[INFO] [stderr]     |                                               ^^^ help: try using a char instead: `','`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]    --> src/lib.rs:142:23
[INFO] [stderr]     |
[INFO] [stderr] 142 |                 dump: if parts[4] == "0" { false } else { true },
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `!(parts[4] == "0")`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/lib.rs:149:35
[INFO] [stderr]     |
[INFO] [stderr] 149 |     fn save_fstab(&self, entries: &Vec<FsEntry>) -> Result<usize, Error> {
[INFO] [stderr]     |                                   ^^^^^^^^^^^^^ help: change this to: `&[FsEntry]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `save_fstab` doesn't need a mutable reference
[INFO] [stderr]    --> src/lib.rs:179:25
[INFO] [stderr]     |
[INFO] [stderr] 179 |         self.save_fstab(&mut entries)?;
[INFO] [stderr]     |                         ^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unnecessary_mut_passed)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/lib.rs:191:13
[INFO] [stderr]     |
[INFO] [stderr] 191 | /             match existing_entries.contains(&new_entry) {
[INFO] [stderr] 192 | |                 false => existing_entries.push(new_entry),
[INFO] [stderr] 193 | |                 true => {
[INFO] [stderr] 194 | |                     // The old entries contain this so lets update it
[INFO] [stderr] ...   |
[INFO] [stderr] 201 | |                 }
[INFO] [stderr] 202 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] help: consider using an if/else expression
[INFO] [stderr]     |
[INFO] [stderr] 191 |             if existing_entries.contains(&new_entry) {
[INFO] [stderr] 192 |     // The old entries contain this so lets update it
[INFO] [stderr] 193 |     let position = existing_entries
[INFO] [stderr] 194 |         .iter()
[INFO] [stderr] 195 |         .position(|e| e == &new_entry)
[INFO] [stderr] 196 |         .unwrap();
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `save_fstab` doesn't need a mutable reference
[INFO] [stderr]    --> src/lib.rs:204:25
[INFO] [stderr]     |
[INFO] [stderr] 204 |         self.save_fstab(&mut existing_entries)?;
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `save_fstab` doesn't need a mutable reference
[INFO] [stderr]    --> src/lib.rs:218:33
[INFO] [stderr]     |
[INFO] [stderr] 218 |                 self.save_fstab(&mut entries)?;
[INFO] [stderr]     |                                 ^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/lib.rs:125:33
[INFO] [stderr]     |
[INFO] [stderr] 125 |             if line.starts_with("#") {
[INFO] [stderr]     |                                 ^^^ help: try using a char instead: `'#'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/lib.rs:141:47
[INFO] [stderr]     |
[INFO] [stderr] 141 |                 mount_options: parts[3].split(",").map(|s| s.to_string()).collect(),
[INFO] [stderr]     |                                               ^^^ help: try using a char instead: `','`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]    --> src/lib.rs:142:23
[INFO] [stderr]     |
[INFO] [stderr] 142 |                 dump: if parts[4] == "0" { false } else { true },
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `!(parts[4] == "0")`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/lib.rs:149:35
[INFO] [stderr]     |
[INFO] [stderr] 149 |     fn save_fstab(&self, entries: &Vec<FsEntry>) -> Result<usize, Error> {
[INFO] [stderr]     |                                   ^^^^^^^^^^^^^ help: change this to: `&[FsEntry]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `save_fstab` doesn't need a mutable reference
[INFO] [stderr]    --> src/lib.rs:179:25
[INFO] [stderr]     |
[INFO] [stderr] 179 |         self.save_fstab(&mut entries)?;
[INFO] [stderr]     |                         ^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unnecessary_mut_passed)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/lib.rs:191:13
[INFO] [stderr]     |
[INFO] [stderr] 191 | /             match existing_entries.contains(&new_entry) {
[INFO] [stderr] 192 | |                 false => existing_entries.push(new_entry),
[INFO] [stderr] 193 | |                 true => {
[INFO] [stderr] 194 | |                     // The old entries contain this so lets update it
[INFO] [stderr] ...   |
[INFO] [stderr] 201 | |                 }
[INFO] [stderr] 202 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] help: consider using an if/else expression
[INFO] [stderr]     |
[INFO] [stderr] 191 |             if existing_entries.contains(&new_entry) {
[INFO] [stderr] 192 |     // The old entries contain this so lets update it
[INFO] [stderr] 193 |     let position = existing_entries
[INFO] [stderr] 194 |         .iter()
[INFO] [stderr] 195 |         .position(|e| e == &new_entry)
[INFO] [stderr] 196 |         .unwrap();
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `save_fstab` doesn't need a mutable reference
[INFO] [stderr]    --> src/lib.rs:204:25
[INFO] [stderr]     |
[INFO] [stderr] 204 |         self.save_fstab(&mut existing_entries)?;
[INFO] [stderr]     |                         ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `save_fstab` doesn't need a mutable reference
[INFO] [stderr]    --> src/lib.rs:218:33
[INFO] [stderr]     |
[INFO] [stderr] 218 |                 self.save_fstab(&mut entries)?;
[INFO] [stderr]     |                                 ^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.31s
[INFO] running `"docker" "inspect" "9799f27c8e5579fa620ee573e62b9b1a18d1f75f178831834116ed2218149e2a"`
[INFO] running `"docker" "rm" "-f" "9799f27c8e5579fa620ee573e62b9b1a18d1f75f178831834116ed2218149e2a"`
[INFO] [stdout] 9799f27c8e5579fa620ee573e62b9b1a18d1f75f178831834116ed2218149e2a