[INFO] crate fst-regex 0.2.2 is already in cache [INFO] extracting crate fst-regex 0.2.2 into work/ex/clippy-test-run/sources/stable/reg/fst-regex/0.2.2 [INFO] extracting crate fst-regex 0.2.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fst-regex/0.2.2 [INFO] validating manifest of fst-regex-0.2.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of fst-regex-0.2.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing fst-regex-0.2.2 [INFO] finished frobbing fst-regex-0.2.2 [INFO] frobbed toml for fst-regex-0.2.2 written to work/ex/clippy-test-run/sources/stable/reg/fst-regex/0.2.2/Cargo.toml [INFO] started frobbing fst-regex-0.2.2 [INFO] finished frobbing fst-regex-0.2.2 [INFO] frobbed toml for fst-regex-0.2.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fst-regex/0.2.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting fst-regex-0.2.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/fst-regex/0.2.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] da235cf854b2007f20db96ddb3b3aeff681293dc697cd06f70b93698e1cdde39 [INFO] running `"docker" "start" "-a" "da235cf854b2007f20db96ddb3b3aeff681293dc697cd06f70b93698e1cdde39"` [INFO] [stderr] Checking fst-regex v0.2.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compile.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | size_limit: size_limit, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `size_limit` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dfa.rs:29:17 [INFO] [stderr] | [INFO] [stderr] 29 | insts: insts, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `insts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dfa.rs:98:21 [INFO] [stderr] | [INFO] [stderr] 98 | insts: insts, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `insts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dfa.rs:100:21 [INFO] [stderr] | [INFO] [stderr] 100 | is_match: is_match, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `is_match` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:131:45 [INFO] [stderr] | [INFO] [stderr] 131 | Ok(Regex { original: re.to_owned(), dfa: dfa }) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dfa` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/compile.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | size_limit: size_limit, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `size_limit` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dfa.rs:29:17 [INFO] [stderr] | [INFO] [stderr] 29 | insts: insts, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `insts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dfa.rs:98:21 [INFO] [stderr] | [INFO] [stderr] 98 | insts: insts, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `insts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dfa.rs:100:21 [INFO] [stderr] | [INFO] [stderr] 100 | is_match: is_match, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `is_match` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:131:45 [INFO] [stderr] | [INFO] [stderr] 131 | Ok(Regex { original: re.to_owned(), dfa: dfa }) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dfa` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/compile.rs:30:43 [INFO] [stderr] | [INFO] [stderr] 30 | | Expr::EndText => return Err(From::from(Error::NoEmpty)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `From::from()`: `Error::NoEmpty` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/compile.rs:35:28 [INFO] [stderr] | [INFO] [stderr] 35 | return Err(From::from(Error::NoWordBoundary)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `From::from()`: `Error::NoWordBoundary` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/compile.rs:41:28 [INFO] [stderr] | [INFO] [stderr] 41 | return Err(From::from(Error::NoBytes)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `From::from()`: `Error::NoBytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/compile.rs:76:20 [INFO] [stderr] | [INFO] [stderr] 76 | if es.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `es.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/compile.rs:95:28 [INFO] [stderr] | [INFO] [stderr] 95 | return Err(Error::NoLazy.into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `Error::NoLazy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/compile.rs:182:21 [INFO] [stderr] | [INFO] [stderr] 182 | char_range: &ClassRange, [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `ClassRange` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/compile.rs:215:17 [INFO] [stderr] | [INFO] [stderr] 215 | Err(Error::CompiledTooBig(self.size_limit).into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `Error::CompiledTooBig(self.size_limit)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/dfa.rs:53:32 [INFO] [stderr] | [INFO] [stderr] 53 | return Err(Error::TooManyStates(STATE_LIMIT).into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `Error::TooManyStates(STATE_LIMIT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/dfa.rs:91:12 [INFO] [stderr] | [INFO] [stderr] 91 | if insts.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `insts.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/compile.rs:30:43 [INFO] [stderr] | [INFO] [stderr] 30 | | Expr::EndText => return Err(From::from(Error::NoEmpty)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `From::from()`: `Error::NoEmpty` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/compile.rs:35:28 [INFO] [stderr] | [INFO] [stderr] 35 | return Err(From::from(Error::NoWordBoundary)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `From::from()`: `Error::NoWordBoundary` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/compile.rs:41:28 [INFO] [stderr] | [INFO] [stderr] 41 | return Err(From::from(Error::NoBytes)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `From::from()`: `Error::NoBytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/compile.rs:76:20 [INFO] [stderr] | [INFO] [stderr] 76 | if es.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `es.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/compile.rs:95:28 [INFO] [stderr] | [INFO] [stderr] 95 | return Err(Error::NoLazy.into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `Error::NoLazy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/compile.rs:182:21 [INFO] [stderr] | [INFO] [stderr] 182 | char_range: &ClassRange, [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `ClassRange` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/compile.rs:215:17 [INFO] [stderr] | [INFO] [stderr] 215 | Err(Error::CompiledTooBig(self.size_limit).into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `Error::CompiledTooBig(self.size_limit)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/dfa.rs:53:32 [INFO] [stderr] | [INFO] [stderr] 53 | return Err(Error::TooManyStates(STATE_LIMIT).into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `Error::TooManyStates(STATE_LIMIT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/dfa.rs:91:12 [INFO] [stderr] | [INFO] [stderr] 91 | if insts.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `insts.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.23s [INFO] running `"docker" "inspect" "da235cf854b2007f20db96ddb3b3aeff681293dc697cd06f70b93698e1cdde39"` [INFO] running `"docker" "rm" "-f" "da235cf854b2007f20db96ddb3b3aeff681293dc697cd06f70b93698e1cdde39"` [INFO] [stdout] da235cf854b2007f20db96ddb3b3aeff681293dc697cd06f70b93698e1cdde39