[INFO] crate fs_extra 1.1.0 is already in cache
[INFO] extracting crate fs_extra 1.1.0 into work/ex/clippy-test-run/sources/stable/reg/fs_extra/1.1.0
[INFO] extracting crate fs_extra 1.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fs_extra/1.1.0
[INFO] validating manifest of fs_extra-1.1.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of fs_extra-1.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing fs_extra-1.1.0
[INFO] finished frobbing fs_extra-1.1.0
[INFO] frobbed toml for fs_extra-1.1.0 written to work/ex/clippy-test-run/sources/stable/reg/fs_extra/1.1.0/Cargo.toml
[INFO] started frobbing fs_extra-1.1.0
[INFO] finished frobbing fs_extra-1.1.0
[INFO] frobbed toml for fs_extra-1.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fs_extra/1.1.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting fs_extra-1.1.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/fs_extra/1.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 1ebfc8525b838f30ffa033cea0494058dad11d4e01f4cb77f1601b398baa3291
[INFO] running `"docker" "start" "-a" "1ebfc8525b838f30ffa033cea0494058dad11d4e01f4cb77f1601b398baa3291"`
[INFO] [stderr]     Checking fs_extra v1.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/error.rs:109:13
[INFO] [stderr]     |
[INFO] [stderr] 109 |             kind: kind,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `kind`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/file.rs:189:21
[INFO] [stderr]     |
[INFO] [stderr] 189 |                     copied_bytes: copied_bytes,
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `copied_bytes`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/dir.rs:428:9
[INFO] [stderr]     |
[INFO] [stderr] 428 |         items: items,
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: replace it with: `items`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/dir.rs:429:9
[INFO] [stderr]     |
[INFO] [stderr] 429 |         base: base,
[INFO] [stderr]     |         ^^^^^^^^^^ help: replace it with: `base`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/dir.rs:734:9
[INFO] [stderr]     |
[INFO] [stderr] 734 |         dir_size: dir_size,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^ help: replace it with: `dir_size`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/dir.rs:735:9
[INFO] [stderr]     |
[INFO] [stderr] 735 |         files: files,
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: replace it with: `files`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/dir.rs:736:9
[INFO] [stderr]     |
[INFO] [stderr] 736 |         directories: directories,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `directories`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/error.rs:109:13
[INFO] [stderr]     |
[INFO] [stderr] 109 |             kind: kind,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `kind`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/file.rs:189:21
[INFO] [stderr]     |
[INFO] [stderr] 189 |                     copied_bytes: copied_bytes,
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `copied_bytes`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/dir.rs:428:9
[INFO] [stderr]     |
[INFO] [stderr] 428 |         items: items,
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: replace it with: `items`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/dir.rs:429:9
[INFO] [stderr]     |
[INFO] [stderr] 429 |         base: base,
[INFO] [stderr]     |         ^^^^^^^^^^ help: replace it with: `base`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/dir.rs:734:9
[INFO] [stderr]     |
[INFO] [stderr] 734 |         dir_size: dir_size,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^ help: replace it with: `dir_size`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/dir.rs:735:9
[INFO] [stderr]     |
[INFO] [stderr] 735 |         files: files,
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: replace it with: `files`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/dir.rs:736:9
[INFO] [stderr]     |
[INFO] [stderr] 736 |         directories: directories,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `directories`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/dir.rs:254:16
[INFO] [stderr]     |
[INFO] [stderr] 254 |           } else {
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 255 | |             if let Some(file_stem) = path.file_stem() {
[INFO] [stderr] 256 | |                 item.insert(
[INFO] [stderr] 257 | |                     DirEntryAttr::Name,
[INFO] [stderr] ...   |
[INFO] [stderr] 262 | |             }
[INFO] [stderr] 263 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 254 |         } else if let Some(file_stem) = path.file_stem() {
[INFO] [stderr] 255 |     item.insert(
[INFO] [stderr] 256 |         DirEntryAttr::Name,
[INFO] [stderr] 257 |         DirEntryValue::String(file_stem.to_os_string().into_string()?),
[INFO] [stderr] 258 |     );
[INFO] [stderr] 259 | } else {
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/dir.rs:562:12
[INFO] [stderr]     |
[INFO] [stderr] 562 |       } else {
[INFO] [stderr]     |  ____________^
[INFO] [stderr] 563 | |         if let Some(dir_name) = from.components().last() {
[INFO] [stderr] 564 | |             to.push(dir_name.as_os_str());
[INFO] [stderr] 565 | |         } else {
[INFO] [stderr] 566 | |             err!("Invalid folder from", ErrorKind::InvalidFolder);
[INFO] [stderr] 567 | |         }
[INFO] [stderr] 568 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 562 |     } else if let Some(dir_name) = from.components().last() {
[INFO] [stderr] 563 |     to.push(dir_name.as_os_str());
[INFO] [stderr] 564 | } else {
[INFO] [stderr] 565 |     err!("Invalid folder from", ErrorKind::InvalidFolder);
[INFO] [stderr] 566 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/dir.rs:850:12
[INFO] [stderr]     |
[INFO] [stderr] 850 |       } else {
[INFO] [stderr]     |  ____________^
[INFO] [stderr] 851 | |         if let Some(dir_name) = from.components().last() {
[INFO] [stderr] 852 | |             to.push(dir_name.as_os_str());
[INFO] [stderr] 853 | |         } else {
[INFO] [stderr] 854 | |             err!("Invalid folder from", ErrorKind::InvalidFolder);
[INFO] [stderr] 855 | |         }
[INFO] [stderr] 856 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 850 |     } else if let Some(dir_name) = from.components().last() {
[INFO] [stderr] 851 |     to.push(dir_name.as_os_str());
[INFO] [stderr] 852 | } else {
[INFO] [stderr] 853 |     err!("Invalid folder from", ErrorKind::InvalidFolder);
[INFO] [stderr] 854 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]     --> src/dir.rs:1081:12
[INFO] [stderr]      |
[INFO] [stderr] 1081 |       } else {
[INFO] [stderr]      |  ____________^
[INFO] [stderr] 1082 | |         if let Some(dir_name) = from.components().last() {
[INFO] [stderr] 1083 | |             to.push(dir_name.as_os_str());
[INFO] [stderr] 1084 | |         } else {
[INFO] [stderr] 1085 | |             err!("Invalid folder from", ErrorKind::InvalidFolder);
[INFO] [stderr] 1086 | |         }
[INFO] [stderr] 1087 | |     }
[INFO] [stderr]      | |_____^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]      |
[INFO] [stderr] 1081 |     } else if let Some(dir_name) = from.components().last() {
[INFO] [stderr] 1082 |     to.push(dir_name.as_os_str());
[INFO] [stderr] 1083 | } else {
[INFO] [stderr] 1084 |     err!("Invalid folder from", ErrorKind::InvalidFolder);
[INFO] [stderr] 1085 | }
[INFO] [stderr]      |
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]     --> src/dir.rs:1213:12
[INFO] [stderr]      |
[INFO] [stderr] 1213 |       } else {
[INFO] [stderr]      |  ____________^
[INFO] [stderr] 1214 | |         if let Some(dir_name) = from.components().last() {
[INFO] [stderr] 1215 | |             to.push(dir_name.as_os_str());
[INFO] [stderr] 1216 | |         } else {
[INFO] [stderr] 1217 | |             err!("Invalid folder from", ErrorKind::InvalidFolder);
[INFO] [stderr] 1218 | |         }
[INFO] [stderr] 1219 | |     }
[INFO] [stderr]      | |_____^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]      |
[INFO] [stderr] 1213 |     } else if let Some(dir_name) = from.components().last() {
[INFO] [stderr] 1214 |     to.push(dir_name.as_os_str());
[INFO] [stderr] 1215 | } else {
[INFO] [stderr] 1216 |     err!("Invalid folder from", ErrorKind::InvalidFolder);
[INFO] [stderr] 1217 | }
[INFO] [stderr]      |
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/lib.rs:200:16
[INFO] [stderr]     |
[INFO] [stderr] 200 |           } else {
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 201 | |             if let Some(file_name) = item.file_name() {
[INFO] [stderr] 202 | |                 if let Some(file_name) = file_name.to_str() {
[INFO] [stderr] 203 | |                     let mut file_options = file::CopyOptions::new();
[INFO] [stderr] ...   |
[INFO] [stderr] 211 | |
[INFO] [stderr] 212 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 200 |         } else if let Some(file_name) = item.file_name() {
[INFO] [stderr] 201 |     if let Some(file_name) = file_name.to_str() {
[INFO] [stderr] 202 |         let mut file_options = file::CopyOptions::new();
[INFO] [stderr] 203 |         file_options.overwrite = options.overwrite;
[INFO] [stderr] 204 |         file_options.skip_exist = options.skip_exist;
[INFO] [stderr] 205 |         result += file::copy(item, to.as_ref().join(file_name), &file_options)?;
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/dir.rs:254:16
[INFO] [stderr]     |
[INFO] [stderr] 254 |           } else {
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 255 | |             if let Some(file_stem) = path.file_stem() {
[INFO] [stderr] 256 | |                 item.insert(
[INFO] [stderr] 257 | |                     DirEntryAttr::Name,
[INFO] [stderr] ...   |
[INFO] [stderr] 262 | |             }
[INFO] [stderr] 263 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 254 |         } else if let Some(file_stem) = path.file_stem() {
[INFO] [stderr] 255 |     item.insert(
[INFO] [stderr] 256 |         DirEntryAttr::Name,
[INFO] [stderr] 257 |         DirEntryValue::String(file_stem.to_os_string().into_string()?),
[INFO] [stderr] 258 |     );
[INFO] [stderr] 259 | } else {
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/dir.rs:562:12
[INFO] [stderr]     |
[INFO] [stderr] 562 |       } else {
[INFO] [stderr]     |  ____________^
[INFO] [stderr] 563 | |         if let Some(dir_name) = from.components().last() {
[INFO] [stderr] 564 | |             to.push(dir_name.as_os_str());
[INFO] [stderr] 565 | |         } else {
[INFO] [stderr] 566 | |             err!("Invalid folder from", ErrorKind::InvalidFolder);
[INFO] [stderr] 567 | |         }
[INFO] [stderr] 568 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 562 |     } else if let Some(dir_name) = from.components().last() {
[INFO] [stderr] 563 |     to.push(dir_name.as_os_str());
[INFO] [stderr] 564 | } else {
[INFO] [stderr] 565 |     err!("Invalid folder from", ErrorKind::InvalidFolder);
[INFO] [stderr] 566 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/dir.rs:850:12
[INFO] [stderr]     |
[INFO] [stderr] 850 |       } else {
[INFO] [stderr]     |  ____________^
[INFO] [stderr] 851 | |         if let Some(dir_name) = from.components().last() {
[INFO] [stderr] 852 | |             to.push(dir_name.as_os_str());
[INFO] [stderr] 853 | |         } else {
[INFO] [stderr] 854 | |             err!("Invalid folder from", ErrorKind::InvalidFolder);
[INFO] [stderr] 855 | |         }
[INFO] [stderr] 856 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 850 |     } else if let Some(dir_name) = from.components().last() {
[INFO] [stderr] 851 |     to.push(dir_name.as_os_str());
[INFO] [stderr] 852 | } else {
[INFO] [stderr] 853 |     err!("Invalid folder from", ErrorKind::InvalidFolder);
[INFO] [stderr] 854 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]     --> src/dir.rs:1081:12
[INFO] [stderr]      |
[INFO] [stderr] 1081 |       } else {
[INFO] [stderr]      |  ____________^
[INFO] [stderr] 1082 | |         if let Some(dir_name) = from.components().last() {
[INFO] [stderr] 1083 | |             to.push(dir_name.as_os_str());
[INFO] [stderr] 1084 | |         } else {
[INFO] [stderr] 1085 | |             err!("Invalid folder from", ErrorKind::InvalidFolder);
[INFO] [stderr] 1086 | |         }
[INFO] [stderr] 1087 | |     }
[INFO] [stderr]      | |_____^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]      |
[INFO] [stderr] 1081 |     } else if let Some(dir_name) = from.components().last() {
[INFO] [stderr] 1082 |     to.push(dir_name.as_os_str());
[INFO] [stderr] 1083 | } else {
[INFO] [stderr] 1084 |     err!("Invalid folder from", ErrorKind::InvalidFolder);
[INFO] [stderr] 1085 | }
[INFO] [stderr]      |
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]     --> src/dir.rs:1213:12
[INFO] [stderr]      |
[INFO] [stderr] 1213 |       } else {
[INFO] [stderr]      |  ____________^
[INFO] [stderr] 1214 | |         if let Some(dir_name) = from.components().last() {
[INFO] [stderr] 1215 | |             to.push(dir_name.as_os_str());
[INFO] [stderr] 1216 | |         } else {
[INFO] [stderr] 1217 | |             err!("Invalid folder from", ErrorKind::InvalidFolder);
[INFO] [stderr] 1218 | |         }
[INFO] [stderr] 1219 | |     }
[INFO] [stderr]      | |_____^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]      |
[INFO] [stderr] 1213 |     } else if let Some(dir_name) = from.components().last() {
[INFO] [stderr] 1214 |     to.push(dir_name.as_os_str());
[INFO] [stderr] 1215 | } else {
[INFO] [stderr] 1216 |     err!("Invalid folder from", ErrorKind::InvalidFolder);
[INFO] [stderr] 1217 | }
[INFO] [stderr]      |
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/lib.rs:200:16
[INFO] [stderr]     |
[INFO] [stderr] 200 |           } else {
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 201 | |             if let Some(file_name) = item.file_name() {
[INFO] [stderr] 202 | |                 if let Some(file_name) = file_name.to_str() {
[INFO] [stderr] 203 | |                     let mut file_options = file::CopyOptions::new();
[INFO] [stderr] ...   |
[INFO] [stderr] 211 | |
[INFO] [stderr] 212 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 200 |         } else if let Some(file_name) = item.file_name() {
[INFO] [stderr] 201 |     if let Some(file_name) = file_name.to_str() {
[INFO] [stderr] 202 |         let mut file_options = file::CopyOptions::new();
[INFO] [stderr] 203 |         file_options.overwrite = options.overwrite;
[INFO] [stderr] 204 |         file_options.skip_exist = options.skip_exist;
[INFO] [stderr] 205 |         result += file::copy(item, to.as_ref().join(file_name), &file_options)?;
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `file::CopyOptions`
[INFO] [stderr]   --> src/file.rs:28:5
[INFO] [stderr]    |
[INFO] [stderr] 28 | /     pub fn new() -> CopyOptions {
[INFO] [stderr] 29 | |         CopyOptions {
[INFO] [stderr] 30 | |             overwrite: false,
[INFO] [stderr] 31 | |             skip_exist: false,
[INFO] [stderr] 32 | |             buffer_size: 64000, //64kb
[INFO] [stderr] 33 | |         }
[INFO] [stderr] 34 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 8  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]    --> src/file.rs:186:17
[INFO] [stderr]     |
[INFO] [stderr] 186 |                 file_to.write(&mut buf[..n])?;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::unused_io_amount)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `write` doesn't need a mutable reference
[INFO] [stderr]    --> src/file.rs:186:31
[INFO] [stderr]     |
[INFO] [stderr] 186 |                 file_to.write(&mut buf[..n])?;
[INFO] [stderr]     |                               ^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unnecessary_mut_passed)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/file.rs:187:17
[INFO] [stderr]     |
[INFO] [stderr] 187 |                 copied_bytes = copied_bytes + n as u64;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `copied_bytes += n as u64`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/file.rs:228:5
[INFO] [stderr]     |
[INFO] [stderr] 228 | /     let mut is_remove = true;
[INFO] [stderr] 229 | |     if options.skip_exist && to.as_ref().exists() && !options.overwrite {
[INFO] [stderr] 230 | |         is_remove = false;
[INFO] [stderr] 231 | |     }
[INFO] [stderr]     | |_____^ help: it is more idiomatic to write: `let <mut> is_remove = if options.skip_exist && to.as_ref().exists() && !options.overwrite { false } else { true };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/file.rs:276:5
[INFO] [stderr]     |
[INFO] [stderr] 276 | /     let mut is_remove = true;
[INFO] [stderr] 277 | |     if options.skip_exist && to.as_ref().exists() && !options.overwrite {
[INFO] [stderr] 278 | |         is_remove = false;
[INFO] [stderr] 279 | |     }
[INFO] [stderr]     | |_____^ help: it is more idiomatic to write: `let <mut> is_remove = if options.skip_exist && to.as_ref().exists() && !options.overwrite { false } else { true };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]    --> src/file.rs:311:12
[INFO] [stderr]     |
[INFO] [stderr] 311 |         Ok(remove_file(path)?)
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unit_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]     |
[INFO] [stderr] 311 |         Ok(())
[INFO] [stderr]     |            ^^
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]    --> src/file.rs:391:8
[INFO] [stderr]     |
[INFO] [stderr] 391 |     Ok(f.write_all(content.as_bytes())?)
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]     |
[INFO] [stderr] 391 |     Ok(())
[INFO] [stderr]     |        ^^
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `dir::CopyOptions`
[INFO] [stderr]   --> src/dir.rs:36:5
[INFO] [stderr]    |
[INFO] [stderr] 36 | /     pub fn new() -> CopyOptions {
[INFO] [stderr] 37 | |         CopyOptions {
[INFO] [stderr] 38 | |             overwrite: false,
[INFO] [stderr] 39 | |             skip_exist: false,
[INFO] [stderr] ...  |
[INFO] [stderr] 43 | |         }
[INFO] [stderr] 44 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 9  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `dir::DirOptions`
[INFO] [stderr]   --> src/dir.rs:60:5
[INFO] [stderr]    |
[INFO] [stderr] 60 | /     pub fn new() -> DirOptions {
[INFO] [stderr] 61 | |         DirOptions {
[INFO] [stderr] 62 | |             depth: 0 //  0 - all; 1 - only first level; 2 - second level; ... etc.   
[INFO] [stderr] 63 | |         }
[INFO] [stderr] 64 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 49 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: parameter of type `HashSet` should be generalized over different hashers
[INFO] [stderr]    --> src/dir.rs:225:14
[INFO] [stderr]     |
[INFO] [stderr] 225 |     config: &HashSet<DirEntryAttr>,
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::implicit_hasher)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher
[INFO] [stderr] help: consider adding a type parameter
[INFO] [stderr]     |
[INFO] [stderr] 223 | pub fn get_details_entry<P, S: ::std::hash::BuildHasher>(
[INFO] [stderr] 224 |     path: P,
[INFO] [stderr] 225 |     config: &HashSet<DirEntryAttr, S>,
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: parameter of type `HashSet` should be generalized over different hashers
[INFO] [stderr]    --> src/dir.rs:407:32
[INFO] [stderr]     |
[INFO] [stderr] 407 | pub fn ls<P>(path: P, config: &HashSet<DirEntryAttr>) -> Result<LsResult>
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher
[INFO] [stderr] help: consider adding a type parameter
[INFO] [stderr]     |
[INFO] [stderr] 407 | pub fn ls<P, S: ::std::hash::BuildHasher>(path: P, config: &HashSet<DirEntryAttr, S>) -> Result<LsResult>
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                   ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `file::CopyOptions`
[INFO] [stderr]   --> src/file.rs:28:5
[INFO] [stderr]    |
[INFO] [stderr] 28 | /     pub fn new() -> CopyOptions {
[INFO] [stderr] 29 | |         CopyOptions {
[INFO] [stderr] 30 | |             overwrite: false,
[INFO] [stderr] 31 | |             skip_exist: false,
[INFO] [stderr] 32 | |             buffer_size: 64000, //64kb
[INFO] [stderr] 33 | |         }
[INFO] [stderr] 34 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 8  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/dir.rs:423:5
[INFO] [stderr]     |
[INFO] [stderr] 423 | /     let mut base = HashMap::new();
[INFO] [stderr] 424 | |     if config.contains(&DirEntryAttr::BaseInfo) {
[INFO] [stderr] 425 | |         base = get_details_entry(&path, &config)?;
[INFO] [stderr] 426 | |     }
[INFO] [stderr]     | |_____^ help: it is more idiomatic to write: `let <mut> base = if config.contains(&DirEntryAttr::BaseInfo) { get_details_entry(&path, &config)? } else { HashMap::new() };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]    --> src/dir.rs:465:8
[INFO] [stderr]     |
[INFO] [stderr] 465 |     Ok(create_dir(&path)?)
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]     |
[INFO] [stderr] 465 |     Ok(())
[INFO] [stderr]     |        ^^
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]    --> src/dir.rs:499:8
[INFO] [stderr]     |
[INFO] [stderr] 499 |     Ok(create_dir_all(&path)?)
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]     |
[INFO] [stderr] 499 |     Ok(())
[INFO] [stderr]     |        ^^
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]    --> src/file.rs:186:17
[INFO] [stderr]     |
[INFO] [stderr] 186 |                 file_to.write(&mut buf[..n])?;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::unused_io_amount)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `write` doesn't need a mutable reference
[INFO] [stderr]    --> src/file.rs:186:31
[INFO] [stderr]     |
[INFO] [stderr] 186 |                 file_to.write(&mut buf[..n])?;
[INFO] [stderr]     |                               ^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unnecessary_mut_passed)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/file.rs:187:17
[INFO] [stderr]     |
[INFO] [stderr] 187 |                 copied_bytes = copied_bytes + n as u64;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `copied_bytes += n as u64`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/file.rs:228:5
[INFO] [stderr]     |
[INFO] [stderr] 228 | /     let mut is_remove = true;
[INFO] [stderr] 229 | |     if options.skip_exist && to.as_ref().exists() && !options.overwrite {
[INFO] [stderr] 230 | |         is_remove = false;
[INFO] [stderr] 231 | |     }
[INFO] [stderr]     | |_____^ help: it is more idiomatic to write: `let <mut> is_remove = if options.skip_exist && to.as_ref().exists() && !options.overwrite { false } else { true };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/file.rs:276:5
[INFO] [stderr]     |
[INFO] [stderr] 276 | /     let mut is_remove = true;
[INFO] [stderr] 277 | |     if options.skip_exist && to.as_ref().exists() && !options.overwrite {
[INFO] [stderr] 278 | |         is_remove = false;
[INFO] [stderr] 279 | |     }
[INFO] [stderr]     | |_____^ help: it is more idiomatic to write: `let <mut> is_remove = if options.skip_exist && to.as_ref().exists() && !options.overwrite { false } else { true };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/dir.rs:687:5
[INFO] [stderr]     |
[INFO] [stderr] 687 | /     let mut depth = 0;
[INFO] [stderr] 688 | |     if options.depth != 0 {
[INFO] [stderr] 689 | |         depth = options.depth + 1;
[INFO] [stderr] 690 | |     }
[INFO] [stderr]     | |_____^ help: it is more idiomatic to write: `let <mut> depth = if options.depth != 0 { options.depth + 1 } else { 0 };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]    --> src/file.rs:311:12
[INFO] [stderr]     |
[INFO] [stderr] 311 |         Ok(remove_file(path)?)
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unit_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]     |
[INFO] [stderr] 311 |         Ok(())
[INFO] [stderr]     |            ^^
[INFO] [stderr]    --> src/dir.rs:702:8
[INFO] [stderr]     |
[INFO] [stderr] 702 |     if !item.is_some() {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^ help: try: `item.is_none()`
[INFO] [stderr] 
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::nonminimal_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]    --> src/file.rs:391:8
[INFO] [stderr]     |
[INFO] [stderr] 391 |     Ok(f.write_all(content.as_bytes())?)
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]     |
[INFO] [stderr] 391 |     Ok(())
[INFO] [stderr]     |        ^^
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `dir::CopyOptions`
[INFO] [stderr]   --> src/dir.rs:36:5
[INFO] [stderr]    |
[INFO] [stderr] 36 | /     pub fn new() -> CopyOptions {
[INFO] [stderr] 37 | |         CopyOptions {
[INFO] [stderr] 38 | |             overwrite: false,
[INFO] [stderr] 39 | |             skip_exist: false,
[INFO] [stderr] ...  |
[INFO] [stderr] 43 | |         }
[INFO] [stderr] 44 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 9  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `dir::DirOptions`
[INFO] [stderr]   --> src/dir.rs:60:5
[INFO] [stderr]    |
[INFO] [stderr] 60 | /     pub fn new() -> DirOptions {
[INFO] [stderr] 61 | |         DirOptions {
[INFO] [stderr] 62 | |             depth: 0 //  0 - all; 1 - only first level; 2 - second level; ... etc.   
[INFO] [stderr] 63 | |         }
[INFO] [stderr] 64 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 49 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]    --> src/dir.rs:895:12
[INFO] [stderr]     |
[INFO] [stderr] 895 |         if !file_name.is_some() {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^ help: try: `file_name.is_none()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: parameter of type `HashSet` should be generalized over different hashers
[INFO] [stderr]    --> src/dir.rs:225:14
[INFO] [stderr]     |
[INFO] [stderr] 225 |     config: &HashSet<DirEntryAttr>,
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::implicit_hasher)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher
[INFO] [stderr] help: consider adding a type parameter
[INFO] [stderr]     |
[INFO] [stderr] 223 | pub fn get_details_entry<P, S: ::std::hash::BuildHasher>(
[INFO] [stderr] 224 |     path: P,
[INFO] [stderr] 225 |     config: &HashSet<DirEntryAttr, S>,
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: parameter of type `HashSet` should be generalized over different hashers
[INFO] [stderr]    --> src/dir.rs:407:32
[INFO] [stderr]     |
[INFO] [stderr] 407 | pub fn ls<P>(path: P, config: &HashSet<DirEntryAttr>) -> Result<LsResult>
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher
[INFO] [stderr] help: consider adding a type parameter
[INFO] [stderr]     |
[INFO] [stderr] 407 | pub fn ls<P, S: ::std::hash::BuildHasher>(path: P, config: &HashSet<DirEntryAttr, S>) -> Result<LsResult>
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^                   ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]     --> src/dir.rs:1041:5
[INFO] [stderr]      |
[INFO] [stderr] 1041 | /     let mut is_remove = true;
[INFO] [stderr] 1042 | |     if options.skip_exist && to.as_ref().exists() && !options.overwrite {
[INFO] [stderr] 1043 | |         is_remove = false;
[INFO] [stderr] 1044 | |     }
[INFO] [stderr]      | |_____^ help: it is more idiomatic to write: `let <mut> is_remove = if options.skip_exist && to.as_ref().exists() && !options.overwrite { false } else { true };`
[INFO] [stderr]      |
[INFO] [stderr]      = note: you might not need `mut` at all
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/dir.rs:423:5
[INFO] [stderr]     |
[INFO] [stderr] 423 | /     let mut base = HashMap::new();
[INFO] [stderr] 424 | |     if config.contains(&DirEntryAttr::BaseInfo) {
[INFO] [stderr] 425 | |         base = get_details_entry(&path, &config)?;
[INFO] [stderr] 426 | |     }
[INFO] [stderr]     | |_____^ help: it is more idiomatic to write: `let <mut> base = if config.contains(&DirEntryAttr::BaseInfo) { get_details_entry(&path, &config)? } else { HashMap::new() };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]     --> src/dir.rs:1251:12
[INFO] [stderr]      |
[INFO] [stderr] 1251 |         if !file_name.is_some() {
[INFO] [stderr]      |            ^^^^^^^^^^^^^^^^^^^^ help: try: `file_name.is_none()`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr] 
[INFO] [stderr]    --> src/dir.rs:465:8
[INFO] [stderr]     |
[INFO] [stderr] 465 |     Ok(create_dir(&path)?)
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]     |
[INFO] [stderr] 465 |     Ok(())
[INFO] [stderr]     |        ^^
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]    --> src/dir.rs:499:8
[INFO] [stderr]     |
[INFO] [stderr] 499 |     Ok(create_dir_all(&path)?)
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]     |
[INFO] [stderr] 499 |     Ok(())
[INFO] [stderr]     |        ^^
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]     --> src/dir.rs:1179:5
[INFO] [stderr]      |
[INFO] [stderr] 1179 | /     let mut is_remove = true;
[INFO] [stderr] 1180 | |     if options.skip_exist && to.as_ref().exists() && !options.overwrite {
[INFO] [stderr] 1181 | |         is_remove = false;
[INFO] [stderr] 1182 | |     }
[INFO] [stderr]      | |_____^ help: it is more idiomatic to write: `let <mut> is_remove = if options.skip_exist && to.as_ref().exists() && !options.overwrite { false } else { true };`
[INFO] [stderr]      |
[INFO] [stderr]      = note: you might not need `mut` at all
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/dir.rs:687:5
[INFO] [stderr]     |
[INFO] [stderr] 687 | /     let mut depth = 0;
[INFO] [stderr] 688 | |     if options.depth != 0 {
[INFO] [stderr] 689 | |         depth = options.depth + 1;
[INFO] [stderr] 690 | |     }
[INFO] [stderr]     | |_____^ help: it is more idiomatic to write: `let <mut> depth = if options.depth != 0 { options.depth + 1 } else { 0 };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]    --> src/dir.rs:702:8
[INFO] [stderr]     |
[INFO] [stderr] 702 |     if !item.is_some() {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^ help: try: `item.is_none()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::nonminimal_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]     --> src/dir.rs:1389:12
[INFO] [stderr]      |
[INFO] [stderr] 1389 |         Ok(remove_dir_all(path)?)
[INFO] [stderr]      |            ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]      |
[INFO] [stderr] 1389 |         Ok(())
[INFO] [stderr]      |            ^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/lib.rs:190:31
[INFO] [stderr]     |
[INFO] [stderr] 190 | pub fn copy_items<P, Q>(from: &Vec<P>, to: Q, options: &dir::CopyOptions) -> Result<u64>
[INFO] [stderr]     |                               ^^^^^^^ help: change this to: `&[P]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/lib.rs:286:11
[INFO] [stderr]     |
[INFO] [stderr] 286 |     from: &Vec<P>,
[INFO] [stderr]     |           ^^^^^^^ help: change this to: `&[P]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]    --> src/dir.rs:895:12
[INFO] [stderr]     |
[INFO] [stderr] 895 |         if !file_name.is_some() {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^ help: try: `file_name.is_none()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/lib.rs:496:37
[INFO] [stderr]     |
[INFO] [stderr] 496 | pub fn move_items<P, Q>(from_items: &Vec<P>, to: Q, options: &dir::CopyOptions) -> Result<u64>
[INFO] [stderr]     |                                     ^^^^^^^ help: change this to: `&[P]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/lib.rs:598:17
[INFO] [stderr]     |
[INFO] [stderr] 598 |     from_items: &Vec<P>,
[INFO] [stderr]     |                 ^^^^^^^ help: change this to: `&[P]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/lib.rs:790:36
[INFO] [stderr]     |
[INFO] [stderr] 790 | pub fn remove_items<P>(from_items: &Vec<P>) -> Result<()>
[INFO] [stderr]     |                                    ^^^^^^^ help: change this to: `&[P]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]     --> src/dir.rs:1041:5
[INFO] [stderr]      |
[INFO] [stderr] 1041 | /     let mut is_remove = true;
[INFO] [stderr] 1042 | |     if options.skip_exist && to.as_ref().exists() && !options.overwrite {
[INFO] [stderr] 1043 | |         is_remove = false;
[INFO] [stderr] 1044 | |     }
[INFO] [stderr]      | |_____^ help: it is more idiomatic to write: `let <mut> is_remove = if options.skip_exist && to.as_ref().exists() && !options.overwrite { false } else { true };`
[INFO] [stderr]      |
[INFO] [stderr]      = note: you might not need `mut` at all
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]     --> src/dir.rs:1251:12
[INFO] [stderr]      |
[INFO] [stderr] 1251 |         if !file_name.is_some() {
[INFO] [stderr]      |            ^^^^^^^^^^^^^^^^^^^^ help: try: `file_name.is_none()`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `fs_extra`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]     --> src/dir.rs:1179:5
[INFO] [stderr]      |
[INFO] [stderr] 1179 | /     let mut is_remove = true;
[INFO] [stderr] 1180 | |     if options.skip_exist && to.as_ref().exists() && !options.overwrite {
[INFO] [stderr] 1181 | |         is_remove = false;
[INFO] [stderr] 1182 | |     }
[INFO] [stderr]      | |_____^ help: it is more idiomatic to write: `let <mut> is_remove = if options.skip_exist && to.as_ref().exists() && !options.overwrite { false } else { true };`
[INFO] [stderr]      |
[INFO] [stderr]      = note: you might not need `mut` at all
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: passing a unit value to a function
[INFO] [stderr]     --> src/dir.rs:1389:12
[INFO] [stderr]      |
[INFO] [stderr] 1389 |         Ok(remove_dir_all(path)?)
[INFO] [stderr]      |            ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg
[INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead
[INFO] [stderr]      |
[INFO] [stderr] 1389 |         Ok(())
[INFO] [stderr]      |            ^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/lib.rs:190:31
[INFO] [stderr]     |
[INFO] [stderr] 190 | pub fn copy_items<P, Q>(from: &Vec<P>, to: Q, options: &dir::CopyOptions) -> Result<u64>
[INFO] [stderr]     |                               ^^^^^^^ help: change this to: `&[P]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/lib.rs:286:11
[INFO] [stderr]     |
[INFO] [stderr] 286 |     from: &Vec<P>,
[INFO] [stderr]     |           ^^^^^^^ help: change this to: `&[P]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/lib.rs:496:37
[INFO] [stderr]     |
[INFO] [stderr] 496 | pub fn move_items<P, Q>(from_items: &Vec<P>, to: Q, options: &dir::CopyOptions) -> Result<u64>
[INFO] [stderr]     |                                     ^^^^^^^ help: change this to: `&[P]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/lib.rs:598:17
[INFO] [stderr]     |
[INFO] [stderr] 598 |     from_items: &Vec<P>,
[INFO] [stderr]     |                 ^^^^^^^ help: change this to: `&[P]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/lib.rs:790:36
[INFO] [stderr]     |
[INFO] [stderr] 790 | pub fn remove_items<P>(from_items: &Vec<P>) -> Result<()>
[INFO] [stderr]     |                                    ^^^^^^^ help: change this to: `&[P]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `fs_extra`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "1ebfc8525b838f30ffa033cea0494058dad11d4e01f4cb77f1601b398baa3291"`
[INFO] running `"docker" "rm" "-f" "1ebfc8525b838f30ffa033cea0494058dad11d4e01f4cb77f1601b398baa3291"`
[INFO] [stdout] 1ebfc8525b838f30ffa033cea0494058dad11d4e01f4cb77f1601b398baa3291