[INFO] crate frunk_derives 0.2.2 is already in cache
[INFO] extracting crate frunk_derives 0.2.2 into work/ex/clippy-test-run/sources/stable/reg/frunk_derives/0.2.2
[INFO] extracting crate frunk_derives 0.2.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/frunk_derives/0.2.2
[INFO] validating manifest of frunk_derives-0.2.2 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of frunk_derives-0.2.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing frunk_derives-0.2.2
[INFO] finished frobbing frunk_derives-0.2.2
[INFO] frobbed toml for frunk_derives-0.2.2 written to work/ex/clippy-test-run/sources/stable/reg/frunk_derives/0.2.2/Cargo.toml
[INFO] started frobbing frunk_derives-0.2.2
[INFO] finished frobbing frunk_derives-0.2.2
[INFO] frobbed toml for frunk_derives-0.2.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/frunk_derives/0.2.2/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting frunk_derives-0.2.2 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/frunk_derives/0.2.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] dcd2e00040c7f980e7632459b86b7258a3cfb648e1f6d03f7341279e9f8743bc
[INFO] running `"docker" "start" "-a" "dcd2e00040c7f980e7632459b86b7258a3cfb648e1f6d03f7341279e9f8743bc"`
[INFO] [stderr]     Checking frunk_core v0.2.2
[INFO] [stderr]     Checking syn v0.15.26
[INFO] [stderr]     Checking frunk_derives v0.2.2 (/opt/crater/workdir)
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/derive_labelled_generic.rs:7:21
[INFO] [stderr]   |
[INFO] [stderr] 7 | const ALPHA_CHARS: &'static [char] = &[
[INFO] [stderr]   |                    -^^^^^^^------- help: consider removing `'static`: `&[char]`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/derive_labelled_generic.rs:14:26
[INFO] [stderr]    |
[INFO] [stderr] 14 | const UNDERSCORE_CHARS: &'static [char] = &['_', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9'];
[INFO] [stderr]    |                         -^^^^^^^------- help: consider removing `'static`: `&[char]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/common.rs:24:38
[INFO] [stderr]    |
[INFO] [stderr] 24 | pub fn build_hcons_constr(accessors: &Vec<Ident>) -> impl ToTokens {
[INFO] [stderr]    |                                      ^^^^^^^^^^^ help: change this to: `&[Ident]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/derive_generic.rs:30:18
[INFO] [stderr]    |
[INFO] [stderr] 30 |                 .unwrap_or(call_site_ident(&format!("_{}", i)))
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| call_site_ident(&format!("_{}", i)))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/derive_generic.rs:61:28
[INFO] [stderr]    |
[INFO] [stderr] 61 | fn build_repr(field_types: &Vec<Type>) -> impl ToTokens {
[INFO] [stderr]    |                            ^^^^^^^^^^ help: change this to: `&[Type]`
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/derive_labelled_generic.rs:7:21
[INFO] [stderr]   |
[INFO] [stderr] 7 | const ALPHA_CHARS: &'static [char] = &[
[INFO] [stderr]   |                    -^^^^^^^------- help: consider removing `'static`: `&[char]`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/derive_labelled_generic.rs:14:26
[INFO] [stderr]    |
[INFO] [stderr] 14 | const UNDERSCORE_CHARS: &'static [char] = &['_', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9'];
[INFO] [stderr]    |                         -^^^^^^^------- help: consider removing `'static`: `&[char]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/derive_generic.rs:79:16
[INFO] [stderr]    |
[INFO] [stderr] 79 |     bindnames: &Vec<Ident>,
[INFO] [stderr]    |                ^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]    |
[INFO] [stderr] 79 |     bindnames: &[Ident],
[INFO] [stderr]    |                ^^^^^^^^
[INFO] [stderr] help: change `bindnames.clone()` to
[INFO] [stderr]    |
[INFO] [stderr] 83 |         let cloned_bind = bindnames.to_owned();
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] help: change `bindnames.clone()` to
[INFO] [stderr]    |
[INFO] [stderr] 86 |         let cloned_bind1 = bindnames.to_owned();
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] help: change `bindnames.clone()` to
[INFO] [stderr]    |
[INFO] [stderr] 87 |         let cloned_bind2 = bindnames.to_owned();
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/derive_labelled_generic.rs:34:30
[INFO] [stderr]    |
[INFO] [stderr] 34 |     let fields: Vec<Field> = fields_named.named.iter().map(|f| f.clone()).collect();
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `fields_named.named.iter().cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/derive_labelled_generic.rs:68:32
[INFO] [stderr]    |
[INFO] [stderr] 68 | fn build_labelled_repr(fields: &Vec<Field>) -> impl ToTokens {
[INFO] [stderr]    |                                ^^^^^^^^^^^ help: change this to: `&[Field]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/derive_labelled_generic.rs:91:9
[INFO] [stderr]    |
[INFO] [stderr] 91 |     let ref field_type = field.ty;
[INFO] [stderr]    |     ----^^^^^^^^^^^^^^------------ help: try: `let field_type = &field.ty;`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/derive_labelled_generic.rs:118:23
[INFO] [stderr]     |
[INFO] [stderr] 118 | fn encode_as_ident(c: &char) -> Vec<Ident> {
[INFO] [stderr]     |                       ^^^^^ help: consider passing by value instead: `char`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/derive_labelled_generic.rs:145:40
[INFO] [stderr]     |
[INFO] [stderr] 145 | fn build_labelled_hcons_constr(fields: &Vec<Field>) -> impl ToTokens {
[INFO] [stderr]     |                                        ^^^^^^^^^^^ help: change this to: `&[Field]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/derive_labelled_generic.rs:189:69
[INFO] [stderr]     |
[INFO] [stderr] 189 | fn build_new_labelled_struct_constr(struct_name: &Ident, bindnames: &Vec<Ident>) -> impl ToTokens {
[INFO] [stderr]     |                                                                     ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]     |
[INFO] [stderr] 189 | fn build_new_labelled_struct_constr(struct_name: &Ident, bindnames: &[Ident]) -> impl ToTokens {
[INFO] [stderr]     |                                                                     ^^^^^^^^
[INFO] [stderr] help: change `bindnames.clone()` to
[INFO] [stderr]     |
[INFO] [stderr] 190 |     let cloned_bind1 = bindnames.to_owned();
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] help: change `bindnames.clone()` to
[INFO] [stderr]     |
[INFO] [stderr] 191 |     let cloned_bind2 = bindnames.to_owned();
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/common.rs:24:38
[INFO] [stderr]    |
[INFO] [stderr] 24 | pub fn build_hcons_constr(accessors: &Vec<Ident>) -> impl ToTokens {
[INFO] [stderr]    |                                      ^^^^^^^^^^^ help: change this to: `&[Ident]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/derive_generic.rs:30:18
[INFO] [stderr]    |
[INFO] [stderr] 30 |                 .unwrap_or(call_site_ident(&format!("_{}", i)))
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| call_site_ident(&format!("_{}", i)))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/derive_generic.rs:61:28
[INFO] [stderr]    |
[INFO] [stderr] 61 | fn build_repr(field_types: &Vec<Type>) -> impl ToTokens {
[INFO] [stderr]    |                            ^^^^^^^^^^ help: change this to: `&[Type]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/derive_generic.rs:79:16
[INFO] [stderr]    |
[INFO] [stderr] 79 |     bindnames: &Vec<Ident>,
[INFO] [stderr]    |                ^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]    |
[INFO] [stderr] 79 |     bindnames: &[Ident],
[INFO] [stderr]    |                ^^^^^^^^
[INFO] [stderr] help: change `bindnames.clone()` to
[INFO] [stderr]    |
[INFO] [stderr] 83 |         let cloned_bind = bindnames.to_owned();
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] help: change `bindnames.clone()` to
[INFO] [stderr]    |
[INFO] [stderr] 86 |         let cloned_bind1 = bindnames.to_owned();
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] help: change `bindnames.clone()` to
[INFO] [stderr]    |
[INFO] [stderr] 87 |         let cloned_bind2 = bindnames.to_owned();
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]   --> src/derive_labelled_generic.rs:34:30
[INFO] [stderr]    |
[INFO] [stderr] 34 |     let fields: Vec<Field> = fields_named.named.iter().map(|f| f.clone()).collect();
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `fields_named.named.iter().cloned()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/derive_labelled_generic.rs:68:32
[INFO] [stderr]    |
[INFO] [stderr] 68 | fn build_labelled_repr(fields: &Vec<Field>) -> impl ToTokens {
[INFO] [stderr]    |                                ^^^^^^^^^^^ help: change this to: `&[Field]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/derive_labelled_generic.rs:91:9
[INFO] [stderr]    |
[INFO] [stderr] 91 |     let ref field_type = field.ty;
[INFO] [stderr]    |     ----^^^^^^^^^^^^^^------------ help: try: `let field_type = &field.ty;`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/derive_labelled_generic.rs:118:23
[INFO] [stderr]     |
[INFO] [stderr] 118 | fn encode_as_ident(c: &char) -> Vec<Ident> {
[INFO] [stderr]     |                       ^^^^^ help: consider passing by value instead: `char`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/derive_labelled_generic.rs:145:40
[INFO] [stderr]     |
[INFO] [stderr] 145 | fn build_labelled_hcons_constr(fields: &Vec<Field>) -> impl ToTokens {
[INFO] [stderr]     |                                        ^^^^^^^^^^^ help: change this to: `&[Field]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/derive_labelled_generic.rs:189:69
[INFO] [stderr]     |
[INFO] [stderr] 189 | fn build_new_labelled_struct_constr(struct_name: &Ident, bindnames: &Vec<Ident>) -> impl ToTokens {
[INFO] [stderr]     |                                                                     ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]     |
[INFO] [stderr] 189 | fn build_new_labelled_struct_constr(struct_name: &Ident, bindnames: &[Ident]) -> impl ToTokens {
[INFO] [stderr]     |                                                                     ^^^^^^^^
[INFO] [stderr] help: change `bindnames.clone()` to
[INFO] [stderr]     |
[INFO] [stderr] 190 |     let cloned_bind1 = bindnames.to_owned();
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] help: change `bindnames.clone()` to
[INFO] [stderr]     |
[INFO] [stderr] 191 |     let cloned_bind2 = bindnames.to_owned();
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 16.11s
[INFO] running `"docker" "inspect" "dcd2e00040c7f980e7632459b86b7258a3cfb648e1f6d03f7341279e9f8743bc"`
[INFO] running `"docker" "rm" "-f" "dcd2e00040c7f980e7632459b86b7258a3cfb648e1f6d03f7341279e9f8743bc"`
[INFO] [stdout] dcd2e00040c7f980e7632459b86b7258a3cfb648e1f6d03f7341279e9f8743bc