[INFO] crate fruitbasket 0.6.0 is already in cache [INFO] extracting crate fruitbasket 0.6.0 into work/ex/clippy-test-run/sources/stable/reg/fruitbasket/0.6.0 [INFO] extracting crate fruitbasket 0.6.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fruitbasket/0.6.0 [INFO] validating manifest of fruitbasket-0.6.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of fruitbasket-0.6.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing fruitbasket-0.6.0 [INFO] finished frobbing fruitbasket-0.6.0 [INFO] frobbed toml for fruitbasket-0.6.0 written to work/ex/clippy-test-run/sources/stable/reg/fruitbasket/0.6.0/Cargo.toml [INFO] started frobbing fruitbasket-0.6.0 [INFO] finished frobbing fruitbasket-0.6.0 [INFO] frobbed toml for fruitbasket-0.6.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fruitbasket/0.6.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting fruitbasket-0.6.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/fruitbasket/0.6.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b876e22e62d4ce58e13926a3384fd5589342f387e76271e50c7cc4071eca59de [INFO] running `"docker" "start" "-a" "b876e22e62d4ce58e13926a3384fd5589342f387e76271e50c7cc4071eca59de"` [INFO] [stderr] Checking fruitbasket v0.6.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:119:19 [INFO] [stderr] | [INFO] [stderr] 119 | FruitApp{ tx: tx, rx: rx} [INFO] [stderr] | ^^^^^^ help: replace it with: `tx` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:119:27 [INFO] [stderr] | [INFO] [stderr] 119 | FruitApp{ tx: tx, rx: rx} [INFO] [stderr] | ^^^^^^ help: replace it with: `rx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:119:19 [INFO] [stderr] | [INFO] [stderr] 119 | FruitApp{ tx: tx, rx: rx} [INFO] [stderr] | ^^^^^^ help: replace it with: `tx` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:119:27 [INFO] [stderr] | [INFO] [stderr] 119 | FruitApp{ tx: tx, rx: rx} [INFO] [stderr] | ^^^^^^ help: replace it with: `rx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:73:27 [INFO] [stderr] | [INFO] [stderr] 73 | pub const DEFAULT_PLIST: &'static [(&'static str, &'static str)] = &[ [INFO] [stderr] | -^^^^^^^------------------------------- help: consider removing `'static`: `&[(&'static str, &'static str)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:73:38 [INFO] [stderr] | [INFO] [stderr] 73 | pub const DEFAULT_PLIST: &'static [(&'static str, &'static str)] = &[ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:73:52 [INFO] [stderr] | [INFO] [stderr] 73 | pub const DEFAULT_PLIST: &'static [(&'static str, &'static str)] = &[ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:85:29 [INFO] [stderr] | [INFO] [stderr] 85 | pub const FORBIDDEN_PLIST: &'static [&'static str] = & [ [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:85:39 [INFO] [stderr] | [INFO] [stderr] 85 | pub const FORBIDDEN_PLIST: &'static [&'static str] = & [ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:73:27 [INFO] [stderr] | [INFO] [stderr] 73 | pub const DEFAULT_PLIST: &'static [(&'static str, &'static str)] = &[ [INFO] [stderr] | -^^^^^^^------------------------------- help: consider removing `'static`: `&[(&'static str, &'static str)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:73:38 [INFO] [stderr] | [INFO] [stderr] 73 | pub const DEFAULT_PLIST: &'static [(&'static str, &'static str)] = &[ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:73:52 [INFO] [stderr] | [INFO] [stderr] 73 | pub const DEFAULT_PLIST: &'static [(&'static str, &'static str)] = &[ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:85:29 [INFO] [stderr] | [INFO] [stderr] 85 | pub const FORBIDDEN_PLIST: &'static [&'static str] = & [ [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:85:39 [INFO] [stderr] | [INFO] [stderr] 85 | pub const FORBIDDEN_PLIST: &'static [&'static str] = & [ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `FruitApp` [INFO] [stderr] --> src/lib.rs:116:5 [INFO] [stderr] | [INFO] [stderr] 116 | / pub fn new() -> FruitApp { [INFO] [stderr] 117 | | use std::sync::mpsc::channel; [INFO] [stderr] 118 | | let (tx,rx) = channel(); [INFO] [stderr] 119 | | FruitApp{ tx: tx, rx: rx} [INFO] [stderr] 120 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 114 | impl Default for FruitApp { [INFO] [stderr] 115 | fn default() -> Self { [INFO] [stderr] 116 | Self::new() [INFO] [stderr] 117 | } [INFO] [stderr] 118 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:182:42 [INFO] [stderr] | [INFO] [stderr] 182 | pub fn plist_keys(&mut self, _pairs: &Vec<(&str,&str)>) -> &mut Self { self } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[(&str,&str)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:186:41 [INFO] [stderr] | [INFO] [stderr] 186 | pub fn resources(&mut self, _files: &Vec<&str>) -> &mut Self{ self } [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `FruitApp` [INFO] [stderr] --> src/lib.rs:116:5 [INFO] [stderr] | [INFO] [stderr] 116 | / pub fn new() -> FruitApp { [INFO] [stderr] 117 | | use std::sync::mpsc::channel; [INFO] [stderr] 118 | | let (tx,rx) = channel(); [INFO] [stderr] 119 | | FruitApp{ tx: tx, rx: rx} [INFO] [stderr] 120 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 114 | impl Default for FruitApp { [INFO] [stderr] 115 | fn default() -> Self { [INFO] [stderr] 116 | Self::new() [INFO] [stderr] 117 | } [INFO] [stderr] 118 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:182:42 [INFO] [stderr] | [INFO] [stderr] 182 | pub fn plist_keys(&mut self, _pairs: &Vec<(&str,&str)>) -> &mut Self { self } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[(&str,&str)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:186:41 [INFO] [stderr] | [INFO] [stderr] 186 | pub fn resources(&mut self, _files: &Vec<&str>) -> &mut Self{ self } [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> examples/example.rs:80:36 [INFO] [stderr] | [INFO] [stderr] 80 | info!("Bundled icon: {}", icon.unwrap_or("MISSING!".to_string())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "MISSING!".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.10s [INFO] running `"docker" "inspect" "b876e22e62d4ce58e13926a3384fd5589342f387e76271e50c7cc4071eca59de"` [INFO] running `"docker" "rm" "-f" "b876e22e62d4ce58e13926a3384fd5589342f387e76271e50c7cc4071eca59de"` [INFO] [stdout] b876e22e62d4ce58e13926a3384fd5589342f387e76271e50c7cc4071eca59de