[INFO] crate fruently 0.10.0 is already in cache [INFO] extracting crate fruently 0.10.0 into work/ex/clippy-test-run/sources/stable/reg/fruently/0.10.0 [INFO] extracting crate fruently 0.10.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fruently/0.10.0 [INFO] validating manifest of fruently-0.10.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of fruently-0.10.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing fruently-0.10.0 [INFO] finished frobbing fruently-0.10.0 [INFO] frobbed toml for fruently-0.10.0 written to work/ex/clippy-test-run/sources/stable/reg/fruently/0.10.0/Cargo.toml [INFO] started frobbing fruently-0.10.0 [INFO] finished frobbing fruently-0.10.0 [INFO] frobbed toml for fruently-0.10.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fruently/0.10.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting fruently-0.10.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/fruently/0.10.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ebf0185df0de1fc574ee69a8b23f9a32373c6cf240d290d7c0a1749167c19a1c [INFO] running `"docker" "start" "-a" "ebf0185df0de1fc574ee69a8b23f9a32373c6cf240d290d7c0a1749167c19a1c"` [INFO] [stderr] Compiling pulldown-cmark v0.0.8 [INFO] [stderr] Checking retry v0.4.0 [INFO] [stderr] Checking skeptic v0.9.0 [INFO] [stderr] Compiling fruently v0.10.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fluent.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | addr: addr, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `addr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fluent.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | addr: addr, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fluent.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | conf: conf, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `conf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/record.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | tag: tag, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/record.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | time: time, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/record.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | record: record, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `record` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/forwardable/forward.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | tag: tag, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/forwardable/forward.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | entries: entries, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `entries` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/event_record.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | event_time: event_time, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `event_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/event_record.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | record: record, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `record` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/event_record.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | tag: tag, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/event_time.rs:14:21 [INFO] [stderr] | [INFO] [stderr] 14 | EventTime { time: time } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fluent.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | addr: addr, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `addr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fluent.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | addr: addr, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fluent.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | conf: conf, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `conf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/record.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | tag: tag, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/record.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | time: time, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/record.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | record: record, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `record` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/forwardable/forward.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | tag: tag, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/forwardable/forward.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | entries: entries, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `entries` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/event_record.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | event_time: event_time, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `event_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/event_record.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | record: record, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `record` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/event_record.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | tag: tag, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/event_time.rs:14:21 [INFO] [stderr] | [INFO] [stderr] 14 | EventTime { time: time } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: where clauses are not enforced in type aliases [INFO] [stderr] --> src/fluent.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | T: Serialize = EventRecord; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(type_alias_bounds)] on by default [INFO] [stderr] = help: the clause will not be checked when the type alias is used, and should be removed [INFO] [stderr] [INFO] [stderr] warning: where clauses are not enforced in type aliases [INFO] [stderr] --> src/forwardable/mod.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | T: Serialize = (EventTime, T); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: the clause will not be checked when the type alias is used, and should be removed [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/event_time.rs:36:36 [INFO] [stderr] | [INFO] [stderr] 36 | buf.write_i32::(self.clone().time.clone().to_timespec().sec as i32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.clone().time` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/event_time.rs:38:36 [INFO] [stderr] | [INFO] [stderr] 38 | buf.write_i32::(self.clone().time.clone().to_timespec().nsec as i32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.clone().time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/event_record.rs:89:38 [INFO] [stderr] | [INFO] [stderr] 89 | let timespec = Timespec::new(1494245571, 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_494_245_571` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/event_time.rs:53:38 [INFO] [stderr] | [INFO] [stderr] 53 | let timespec = Timespec::new(1494245571, 0); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_494_245_571` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: where clauses are not enforced in type aliases [INFO] [stderr] --> src/fluent.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | T: Serialize = EventRecord; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(type_alias_bounds)] on by default [INFO] [stderr] = help: the clause will not be checked when the type alias is used, and should be removed [INFO] [stderr] [INFO] [stderr] warning: where clauses are not enforced in type aliases [INFO] [stderr] --> src/forwardable/mod.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | T: Serialize = (EventTime, T); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: the clause will not be checked when the type alias is used, and should be removed [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/event_record.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | let _ = record.serialize(&mut Serializer::new(&mut buf)).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/event_time.rs:36:36 [INFO] [stderr] | [INFO] [stderr] 36 | buf.write_i32::(self.clone().time.clone().to_timespec().sec as i32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.clone().time` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/event_time.rs:38:36 [INFO] [stderr] | [INFO] [stderr] 38 | buf.write_i32::(self.clone().time.clone().to_timespec().nsec as i32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.clone().time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/event_time.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | / let _ = event_time [INFO] [stderr] 58 | | .serialize(&mut Serializer::new(&mut buf)) [INFO] [stderr] 59 | | .unwrap(); [INFO] [stderr] | |______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> examples/store_file.rs:9:16 [INFO] [stderr] | [INFO] [stderr] 9 | let home = env::home_dir().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> examples/forward.rs:14:41 [INFO] [stderr] | [INFO] [stderr] 14 | let thmap = (0..10).fold(&mut obj, |mut acc, i| { [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 17.59s [INFO] running `"docker" "inspect" "ebf0185df0de1fc574ee69a8b23f9a32373c6cf240d290d7c0a1749167c19a1c"` [INFO] running `"docker" "rm" "-f" "ebf0185df0de1fc574ee69a8b23f9a32373c6cf240d290d7c0a1749167c19a1c"` [INFO] [stdout] ebf0185df0de1fc574ee69a8b23f9a32373c6cf240d290d7c0a1749167c19a1c