[INFO] crate from_variants_impl 0.4.0 is already in cache [INFO] extracting crate from_variants_impl 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/from_variants_impl/0.4.0 [INFO] extracting crate from_variants_impl 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/from_variants_impl/0.4.0 [INFO] validating manifest of from_variants_impl-0.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of from_variants_impl-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing from_variants_impl-0.4.0 [INFO] finished frobbing from_variants_impl-0.4.0 [INFO] frobbed toml for from_variants_impl-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/from_variants_impl/0.4.0/Cargo.toml [INFO] started frobbing from_variants_impl-0.4.0 [INFO] finished frobbing from_variants_impl-0.4.0 [INFO] frobbed toml for from_variants_impl-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/from_variants_impl/0.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting from_variants_impl-0.4.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/from_variants_impl/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 81f838b572abe4a10bf55bab2abb572dcb7bf06aff614e424ab91762d6978dfe [INFO] running `"docker" "start" "-a" "81f838b572abe4a10bf55bab2abb572dcb7bf06aff614e424ab91762d6978dfe"` [INFO] [stderr] Checking ident_case v1.0.0 [INFO] [stderr] Checking pretty_assertions v0.1.2 [INFO] [stderr] Checking syn v0.13.11 [INFO] [stderr] Compiling darling_core v0.5.0 [INFO] [stderr] Compiling darling_macro v0.5.0 [INFO] [stderr] Checking darling v0.5.0 [INFO] [stderr] Checking from_variants_impl v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/from_impl.rs:5:22 [INFO] [stderr] | [INFO] [stderr] 5 | const INTO_GENERIC: &'static str = "INTO"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/from_impl.rs:5:22 [INFO] [stderr] | [INFO] [stderr] 5 | const INTO_GENERIC: &'static str = "INTO"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:40:20 [INFO] [stderr] | [INFO] [stderr] 40 | result.parse().expect(&format!("Couldn't parse `{}` to tokens", result)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Couldn't parse `{}` to tokens", result))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:40:20 [INFO] [stderr] | [INFO] [stderr] 40 | result.parse().expect(&format!("Couldn't parse `{}` to tokens", result)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Couldn't parse `{}` to tokens", result))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 18.61s [INFO] running `"docker" "inspect" "81f838b572abe4a10bf55bab2abb572dcb7bf06aff614e424ab91762d6978dfe"` [INFO] running `"docker" "rm" "-f" "81f838b572abe4a10bf55bab2abb572dcb7bf06aff614e424ab91762d6978dfe"` [INFO] [stdout] 81f838b572abe4a10bf55bab2abb572dcb7bf06aff614e424ab91762d6978dfe