[INFO] crate from-repr-enum-derive 0.1.2 is already in cache [INFO] extracting crate from-repr-enum-derive 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/from-repr-enum-derive/0.1.2 [INFO] extracting crate from-repr-enum-derive 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/from-repr-enum-derive/0.1.2 [INFO] validating manifest of from-repr-enum-derive-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of from-repr-enum-derive-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing from-repr-enum-derive-0.1.2 [INFO] finished frobbing from-repr-enum-derive-0.1.2 [INFO] frobbed toml for from-repr-enum-derive-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/from-repr-enum-derive/0.1.2/Cargo.toml [INFO] started frobbing from-repr-enum-derive-0.1.2 [INFO] finished frobbing from-repr-enum-derive-0.1.2 [INFO] frobbed toml for from-repr-enum-derive-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/from-repr-enum-derive/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting from-repr-enum-derive-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/from-repr-enum-derive/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7ddf7c9eb0a4c7d519881c7dde853699affed337ea65c2967f9795059598e134 [INFO] running `"docker" "start" "-a" "7ddf7c9eb0a4c7d519881c7dde853699affed337ea65c2967f9795059598e134"` [INFO] [stderr] Checking syn v0.12.15 [INFO] [stderr] Compiling from-repr-enum-derive v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | / if let &syn::NestedMeta::Meta(syn::Meta::Word(ref r)) = a { [INFO] [stderr] 29 | | rep = Some(*r); [INFO] [stderr] 30 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 28 | if let syn::NestedMeta::Meta(syn::Meta::Word(ref r)) = *a { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^ [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/lib.rs:42:12 [INFO] [stderr] | [INFO] [stderr] 42 | if let None = rep { [INFO] [stderr] | _____- ^^^^ [INFO] [stderr] 43 | | panic!("#[repr(_)] wasn't found for {}", name ); [INFO] [stderr] 44 | | } [INFO] [stderr] | |_____- help: try this: `if rep.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | / if let &syn::NestedMeta::Meta(syn::Meta::Word(ref r)) = a { [INFO] [stderr] 29 | | rep = Some(*r); [INFO] [stderr] 30 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 28 | if let syn::NestedMeta::Meta(syn::Meta::Word(ref r)) = *a { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^ [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/lib.rs:42:12 [INFO] [stderr] | [INFO] [stderr] 42 | if let None = rep { [INFO] [stderr] | _____- ^^^^ [INFO] [stderr] 43 | | panic!("#[repr(_)] wasn't found for {}", name ); [INFO] [stderr] 44 | | } [INFO] [stderr] | |_____- help: try this: `if rep.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.07s [INFO] running `"docker" "inspect" "7ddf7c9eb0a4c7d519881c7dde853699affed337ea65c2967f9795059598e134"` [INFO] running `"docker" "rm" "-f" "7ddf7c9eb0a4c7d519881c7dde853699affed337ea65c2967f9795059598e134"` [INFO] [stdout] 7ddf7c9eb0a4c7d519881c7dde853699affed337ea65c2967f9795059598e134