[INFO] crate freedesktop-categories-codegen 0.1.0 is already in cache [INFO] extracting crate freedesktop-categories-codegen 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/freedesktop-categories-codegen/0.1.0 [INFO] extracting crate freedesktop-categories-codegen 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/freedesktop-categories-codegen/0.1.0 [INFO] validating manifest of freedesktop-categories-codegen-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of freedesktop-categories-codegen-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing freedesktop-categories-codegen-0.1.0 [INFO] finished frobbing freedesktop-categories-codegen-0.1.0 [INFO] frobbed toml for freedesktop-categories-codegen-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/freedesktop-categories-codegen/0.1.0/Cargo.toml [INFO] started frobbing freedesktop-categories-codegen-0.1.0 [INFO] finished frobbing freedesktop-categories-codegen-0.1.0 [INFO] frobbed toml for freedesktop-categories-codegen-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/freedesktop-categories-codegen/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting freedesktop-categories-codegen-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/freedesktop-categories-codegen/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 05f9ebc55386f35a2cb05da2ec4cf3dc23b6e366f5d29efaf5cd83a9fd47dc7a [INFO] running `"docker" "start" "-a" "05f9ebc55386f35a2cb05da2ec4cf3dc23b6e366f5d29efaf5cd83a9fd47dc7a"` [INFO] [stderr] Checking amxml v0.5.3 [INFO] [stderr] Checking phf_generator v0.7.24 [INFO] [stderr] Checking phf_codegen v0.7.24 [INFO] [stderr] Checking freedesktop-categories-codegen v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/generate.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | write!(file, ";\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/generate.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | write!(file, ";\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/generate.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | writeln!(file, "/// Static hash map of desktop menu categories."); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/generate.rs:62:29 [INFO] [stderr] | [INFO] [stderr] 62 | .flat_map(|row| row.into_iter().flat_map(|entry| entry.nth_child(0)).nth(0)) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/generate.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | row.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/generate.rs:115:29 [INFO] [stderr] | [INFO] [stderr] 115 | .flat_map(|row| row.into_iter().flat_map(|entry| entry.nth_child(0)).nth(0)) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `DesktopMenuSpec` [INFO] [stderr] --> src/lib.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | / pub fn new() -> Self { [INFO] [stderr] 72 | | DesktopMenuSpec { [INFO] [stderr] 73 | | xml_cache_dir: None, [INFO] [stderr] 74 | | always_download: false, [INFO] [stderr] ... | [INFO] [stderr] 77 | | } [INFO] [stderr] 78 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 69 | impl Default for DesktopMenuSpec { [INFO] [stderr] 70 | fn default() -> Self { [INFO] [stderr] 71 | Self::new() [INFO] [stderr] 72 | } [INFO] [stderr] 73 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:119:14 [INFO] [stderr] | [INFO] [stderr] 119 | .unwrap_or(env::var("OUT_DIR")?.into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| env::var("OUT_DIR")?.into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:152:13 [INFO] [stderr] | [INFO] [stderr] 152 | / file.write(data) [INFO] [stderr] 153 | | .expect("Unable to write received data to file"); [INFO] [stderr] | |________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/generate.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | writeln!(file, "/// Static hash map of desktop menu categories."); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: Could not compile `freedesktop-categories-codegen`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/generate.rs:62:29 [INFO] [stderr] | [INFO] [stderr] 62 | .flat_map(|row| row.into_iter().flat_map(|entry| entry.nth_child(0)).nth(0)) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/generate.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | row.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/generate.rs:115:29 [INFO] [stderr] | [INFO] [stderr] 115 | .flat_map(|row| row.into_iter().flat_map(|entry| entry.nth_child(0)).nth(0)) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `DesktopMenuSpec` [INFO] [stderr] --> src/lib.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | / pub fn new() -> Self { [INFO] [stderr] 72 | | DesktopMenuSpec { [INFO] [stderr] 73 | | xml_cache_dir: None, [INFO] [stderr] 74 | | always_download: false, [INFO] [stderr] ... | [INFO] [stderr] 77 | | } [INFO] [stderr] 78 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 69 | impl Default for DesktopMenuSpec { [INFO] [stderr] 70 | fn default() -> Self { [INFO] [stderr] 71 | Self::new() [INFO] [stderr] 72 | } [INFO] [stderr] 73 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:119:14 [INFO] [stderr] | [INFO] [stderr] 119 | .unwrap_or(env::var("OUT_DIR")?.into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| env::var("OUT_DIR")?.into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:152:13 [INFO] [stderr] | [INFO] [stderr] 152 | / file.write(data) [INFO] [stderr] 153 | | .expect("Unable to write received data to file"); [INFO] [stderr] | |________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `freedesktop-categories-codegen`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "05f9ebc55386f35a2cb05da2ec4cf3dc23b6e366f5d29efaf5cd83a9fd47dc7a"` [INFO] running `"docker" "rm" "-f" "05f9ebc55386f35a2cb05da2ec4cf3dc23b6e366f5d29efaf5cd83a9fd47dc7a"` [INFO] [stdout] 05f9ebc55386f35a2cb05da2ec4cf3dc23b6e366f5d29efaf5cd83a9fd47dc7a