[INFO] crate frank_jwt 3.1.0 is already in cache [INFO] extracting crate frank_jwt 3.1.0 into work/ex/clippy-test-run/sources/stable/reg/frank_jwt/3.1.0 [INFO] extracting crate frank_jwt 3.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/frank_jwt/3.1.0 [INFO] validating manifest of frank_jwt-3.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of frank_jwt-3.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing frank_jwt-3.1.0 [INFO] finished frobbing frank_jwt-3.1.0 [INFO] frobbed toml for frank_jwt-3.1.0 written to work/ex/clippy-test-run/sources/stable/reg/frank_jwt/3.1.0/Cargo.toml [INFO] started frobbing frank_jwt-3.1.0 [INFO] finished frobbing frank_jwt-3.1.0 [INFO] frobbed toml for frank_jwt-3.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/frank_jwt/3.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting frank_jwt-3.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/frank_jwt/3.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f03ea120aea88c455d076d9424f8a0f827800e57e4c1fefa2de5361e3fc7370b [INFO] running `"docker" "start" "-a" "f03ea120aea88c455d076d9424f8a0f827800e57e4c1fefa2de5361e3fc7370b"` [INFO] [stderr] Checking frank_jwt v3.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: function is never used: `verify_not_before` [INFO] [stderr] --> src/lib.rs:297:1 [INFO] [stderr] | [INFO] [stderr] 297 | fn verify_not_before() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `verify_sub` [INFO] [stderr] --> src/lib.rs:301:1 [INFO] [stderr] | [INFO] [stderr] 301 | fn verify_sub() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `verify_jti` [INFO] [stderr] --> src/lib.rs:305:1 [INFO] [stderr] | [INFO] [stderr] 305 | fn verify_jti() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `verify_iss` [INFO] [stderr] --> src/lib.rs:309:1 [INFO] [stderr] | [INFO] [stderr] 309 | fn verify_iss() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `verify_iat` [INFO] [stderr] --> src/lib.rs:313:1 [INFO] [stderr] | [INFO] [stderr] 313 | fn verify_iat() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `verify_expiration` [INFO] [stderr] --> src/lib.rs:317:1 [INFO] [stderr] | [INFO] [stderr] 317 | fn verify_expiration() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `verify_aud` [INFO] [stderr] --> src/lib.rs:321:1 [INFO] [stderr] | [INFO] [stderr] 321 | fn verify_aud() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:122:40 [INFO] [stderr] | [INFO] [stderr] 122 | pub fn decode(encoded_token: &String, signing_key: &P, algorithm: Algorithm) -> Result<(JsonValue, JsonValue), Error> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:131:52 [INFO] [stderr] | [INFO] [stderr] 131 | pub fn validate_signature(encoded_token: &String, signing_key: &P, algorithm: Algorithm) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:192:35 [INFO] [stderr] | [INFO] [stderr] 192 | fn decode_segments(encoded_token: &String) -> Result<(JsonValue, JsonValue, Vec, String), Error> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:193:55 [INFO] [stderr] | [INFO] [stderr] 193 | let raw_segments: Vec<&str> = encoded_token.split(".").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:207:45 [INFO] [stderr] | [INFO] [stderr] 207 | fn decode_signature_segments(encoded_token: &String) -> Result<(Vec, String), Error> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:208:55 [INFO] [stderr] | [INFO] [stderr] 208 | let raw_segments: Vec<&str> = encoded_token.split(".").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:231:32 [INFO] [stderr] | [INFO] [stderr] 231 | fn sign_hmac2(data: &str, key: &Vec, algorithm: Algorithm) -> Result, Error> { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused variable: `p1` [INFO] [stderr] --> src/lib.rs:352:13 [INFO] [stderr] | [INFO] [stderr] 352 | let p1 = json!({ [INFO] [stderr] | ^^ help: consider using `_p1` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `p1` [INFO] [stderr] --> src/lib.rs:550:13 [INFO] [stderr] | [INFO] [stderr] 550 | let p1 = json!({ [INFO] [stderr] | ^^ help: consider using `_p1` instead [INFO] [stderr] [INFO] [stderr] warning: function is never used: `verify_not_before` [INFO] [stderr] --> src/lib.rs:297:1 [INFO] [stderr] | [INFO] [stderr] 297 | fn verify_not_before() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `verify_sub` [INFO] [stderr] --> src/lib.rs:301:1 [INFO] [stderr] | [INFO] [stderr] 301 | fn verify_sub() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `verify_jti` [INFO] [stderr] --> src/lib.rs:305:1 [INFO] [stderr] | [INFO] [stderr] 305 | fn verify_jti() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `verify_iss` [INFO] [stderr] --> src/lib.rs:309:1 [INFO] [stderr] | [INFO] [stderr] 309 | fn verify_iss() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `verify_iat` [INFO] [stderr] --> src/lib.rs:313:1 [INFO] [stderr] | [INFO] [stderr] 313 | fn verify_iat() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `verify_expiration` [INFO] [stderr] --> src/lib.rs:317:1 [INFO] [stderr] | [INFO] [stderr] 317 | fn verify_expiration() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `verify_aud` [INFO] [stderr] --> src/lib.rs:321:1 [INFO] [stderr] | [INFO] [stderr] 321 | fn verify_aud() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:122:40 [INFO] [stderr] | [INFO] [stderr] 122 | pub fn decode(encoded_token: &String, signing_key: &P, algorithm: Algorithm) -> Result<(JsonValue, JsonValue), Error> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:131:52 [INFO] [stderr] | [INFO] [stderr] 131 | pub fn validate_signature(encoded_token: &String, signing_key: &P, algorithm: Algorithm) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:192:35 [INFO] [stderr] | [INFO] [stderr] 192 | fn decode_segments(encoded_token: &String) -> Result<(JsonValue, JsonValue, Vec, String), Error> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:193:55 [INFO] [stderr] | [INFO] [stderr] 193 | let raw_segments: Vec<&str> = encoded_token.split(".").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:207:45 [INFO] [stderr] | [INFO] [stderr] 207 | fn decode_signature_segments(encoded_token: &String) -> Result<(Vec, String), Error> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:208:55 [INFO] [stderr] | [INFO] [stderr] 208 | let raw_segments: Vec<&str> = encoded_token.split(".").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:231:32 [INFO] [stderr] | [INFO] [stderr] 231 | fn sign_hmac2(data: &str, key: &Vec, algorithm: Algorithm) -> Result, Error> { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:388:20 [INFO] [stderr] | [INFO] [stderr] 388 | let str1 = "same same".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"same same"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:389:20 [INFO] [stderr] | [INFO] [stderr] 389 | let str2 = "same same".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"same same"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:396:20 [INFO] [stderr] | [INFO] [stderr] 396 | let str1 = "same same".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"same same"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/lib.rs:397:20 [INFO] [stderr] | [INFO] [stderr] 397 | let str2 = "same same but different".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"same same but different"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.05s [INFO] running `"docker" "inspect" "f03ea120aea88c455d076d9424f8a0f827800e57e4c1fefa2de5361e3fc7370b"` [INFO] running `"docker" "rm" "-f" "f03ea120aea88c455d076d9424f8a0f827800e57e4c1fefa2de5361e3fc7370b"` [INFO] [stdout] f03ea120aea88c455d076d9424f8a0f827800e57e4c1fefa2de5361e3fc7370b