[INFO] crate fragile 0.3.0 is already in cache [INFO] extracting crate fragile 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/fragile/0.3.0 [INFO] extracting crate fragile 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fragile/0.3.0 [INFO] validating manifest of fragile-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of fragile-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing fragile-0.3.0 [INFO] finished frobbing fragile-0.3.0 [INFO] frobbed toml for fragile-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/fragile/0.3.0/Cargo.toml [INFO] started frobbing fragile-0.3.0 [INFO] finished frobbing fragile-0.3.0 [INFO] frobbed toml for fragile-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fragile/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting fragile-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/fragile/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4effd55257c9954342d93d37c88f9a426f42c32cae00c2abc23079690672769c [INFO] running `"docker" "start" "-a" "4effd55257c9954342d93d37c88f9a426f42c32cae00c2abc23079690672769c"` [INFO] [stderr] Checking fragile v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sticky.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | item_id: item_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `item_id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sticky.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | item_id: item_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `item_id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/sticky.rs:16:17 [INFO] [stderr] | [INFO] [stderr] 16 | struct Registry(HashMap, Box)>)>); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/sticky.rs:87:19 [INFO] [stderr] | [INFO] [stderr] 87 | f(mem::transmute(&item.0)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(&item.0 as *const std::cell::UnsafeCell<*mut ()> as *const std::cell::UnsafeCell>)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/fragile.rs:301:31 [INFO] [stderr] | [INFO] [stderr] 301 | thread::spawn(move || { [INFO] [stderr] | _______________________________^ [INFO] [stderr] 302 | | val.try_get().ok(); [INFO] [stderr] 303 | | }).join() [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/semisticky.rs:286:39 [INFO] [stderr] | [INFO] [stderr] 286 | thread::spawn(move || { [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 287 | | // moves it here but do not deallocate [INFO] [stderr] 288 | | val.try_get().ok(); [INFO] [stderr] 289 | | }).join() [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/sticky.rs:16:17 [INFO] [stderr] | [INFO] [stderr] 16 | struct Registry(HashMap, Box)>)>); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/sticky.rs:87:19 [INFO] [stderr] | [INFO] [stderr] 87 | f(mem::transmute(&item.0)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&*(&item.0 as *const std::cell::UnsafeCell<*mut ()> as *const std::cell::UnsafeCell>)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/sticky.rs:356:39 [INFO] [stderr] | [INFO] [stderr] 356 | thread::spawn(move || { [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 357 | | // moves it here but do not deallocate [INFO] [stderr] 358 | | val.try_get().ok(); [INFO] [stderr] 359 | | }).join() [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.22s [INFO] running `"docker" "inspect" "4effd55257c9954342d93d37c88f9a426f42c32cae00c2abc23079690672769c"` [INFO] running `"docker" "rm" "-f" "4effd55257c9954342d93d37c88f9a426f42c32cae00c2abc23079690672769c"` [INFO] [stdout] 4effd55257c9954342d93d37c88f9a426f42c32cae00c2abc23079690672769c