[INFO] crate fraction 0.5.0 is already in cache [INFO] extracting crate fraction 0.5.0 into work/ex/clippy-test-run/sources/stable/reg/fraction/0.5.0 [INFO] extracting crate fraction 0.5.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fraction/0.5.0 [INFO] validating manifest of fraction-0.5.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of fraction-0.5.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing fraction-0.5.0 [INFO] finished frobbing fraction-0.5.0 [INFO] frobbed toml for fraction-0.5.0 written to work/ex/clippy-test-run/sources/stable/reg/fraction/0.5.0/Cargo.toml [INFO] started frobbing fraction-0.5.0 [INFO] finished frobbing fraction-0.5.0 [INFO] frobbed toml for fraction-0.5.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fraction/0.5.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting fraction-0.5.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/fraction/0.5.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fd327dfbac602fd7aea0f291422d5a221c2477773da58b261405c6e8214030fa [INFO] running `"docker" "start" "-a" "fd327dfbac602fd7aea0f291422d5a221c2477773da58b261405c6e8214030fa"` [INFO] [stderr] Checking num v0.2.0 [INFO] [stderr] Checking fraction v0.5.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/division.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | remainder: remainder, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `remainder` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/division.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | divisor: divisor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `divisor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/division.rs:289:21 [INFO] [stderr] | [INFO] [stderr] 289 | let _10 = I::_10(); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::just_underscores_and_digits)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/division.rs:490:13 [INFO] [stderr] | [INFO] [stderr] 490 | let _10: I = GenericInteger::_10(); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/decimal/mod.rs:772:37 [INFO] [stderr] | [INFO] [stderr] 772 | let _1 = P::one(); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/division.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | remainder: remainder, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `remainder` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/division.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | divisor: divisor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `divisor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/division.rs:289:21 [INFO] [stderr] | [INFO] [stderr] 289 | let _10 = I::_10(); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::just_underscores_and_digits)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/division.rs:490:13 [INFO] [stderr] | [INFO] [stderr] 490 | let _10: I = GenericInteger::_10(); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: consider choosing a more descriptive name [INFO] [stderr] --> src/decimal/mod.rs:772:37 [INFO] [stderr] | [INFO] [stderr] 772 | let _1 = P::one(); [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#just_underscores_and_digits [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/division.rs:415:5 [INFO] [stderr] | [INFO] [stderr] 415 | / if precision > 0 { [INFO] [stderr] 416 | | if !div_state.remainder.is_zero() { [INFO] [stderr] 417 | | match write!(&mut result, ".") { [INFO] [stderr] 418 | | Ok(()) => (), [INFO] [stderr] ... | [INFO] [stderr] 448 | | } [INFO] [stderr] 449 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 415 | if precision > 0 && !div_state.remainder.is_zero() { [INFO] [stderr] 416 | match write!(&mut result, ".") { [INFO] [stderr] 417 | Ok(()) => (), [INFO] [stderr] 418 | Err(e) => return Err(DivisionError::from(e)), [INFO] [stderr] 419 | }; [INFO] [stderr] 420 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/division.rs:517:5 [INFO] [stderr] | [INFO] [stderr] 517 | / if precision > 0 { [INFO] [stderr] 518 | | if !div_state.remainder.is_zero() { [INFO] [stderr] 519 | | result.push(DOT); [INFO] [stderr] 520 | | [INFO] [stderr] ... | [INFO] [stderr] 545 | | } [INFO] [stderr] 546 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 517 | if precision > 0 && !div_state.remainder.is_zero() { [INFO] [stderr] 518 | result.push(DOT); [INFO] [stderr] 519 | [INFO] [stderr] 520 | divide_rem( [INFO] [stderr] 521 | div_state.remainder, [INFO] [stderr] 522 | div_state.divisor, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/division.rs:600:5 [INFO] [stderr] | [INFO] [stderr] 600 | / if precision > 0 { [INFO] [stderr] 601 | | if !div_state.remainder.is_zero() { [INFO] [stderr] 602 | | let mut dot = false; [INFO] [stderr] 603 | | let mut trailing_zeroes = 0; [INFO] [stderr] ... | [INFO] [stderr] 643 | | } [INFO] [stderr] 644 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 600 | if precision > 0 && !div_state.remainder.is_zero() { [INFO] [stderr] 601 | let mut dot = false; [INFO] [stderr] 602 | let mut trailing_zeroes = 0; [INFO] [stderr] 603 | [INFO] [stderr] 604 | div_state = divide_rem( [INFO] [stderr] 605 | div_state.remainder, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/fraction/mod.rs:1001:28 [INFO] [stderr] | [INFO] [stderr] 1001 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 1002 | | if l < r { [INFO] [stderr] 1003 | | GenericFraction::Rational(Sign::Plus, r.sub(l)) [INFO] [stderr] 1004 | | } else { [INFO] [stderr] 1005 | | GenericFraction::Rational(Sign::Minus, l.sub(r)) [INFO] [stderr] 1006 | | } [INFO] [stderr] 1007 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1001 | } else if l < r { [INFO] [stderr] 1002 | GenericFraction::Rational(Sign::Plus, r.sub(l)) [INFO] [stderr] 1003 | } else { [INFO] [stderr] 1004 | GenericFraction::Rational(Sign::Minus, l.sub(r)) [INFO] [stderr] 1005 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/fraction/mod.rs:1046:28 [INFO] [stderr] | [INFO] [stderr] 1046 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 1047 | | if l < r { [INFO] [stderr] 1048 | | GenericFraction::Rational(Sign::Plus, r.sub(l)) [INFO] [stderr] 1049 | | } else { [INFO] [stderr] 1050 | | GenericFraction::Rational(Sign::Minus, l.sub(r)) [INFO] [stderr] 1051 | | } [INFO] [stderr] 1052 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1046 | } else if l < r { [INFO] [stderr] 1047 | GenericFraction::Rational(Sign::Plus, r.sub(l)) [INFO] [stderr] 1048 | } else { [INFO] [stderr] 1049 | GenericFraction::Rational(Sign::Minus, l.sub(r)) [INFO] [stderr] 1050 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/fraction/mod.rs:1093:28 [INFO] [stderr] | [INFO] [stderr] 1093 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 1094 | | if l < r { [INFO] [stderr] 1095 | | r.checked_sub(l) [INFO] [stderr] 1096 | | .map(|value| GenericFraction::Rational(Sign::Plus, value)) [INFO] [stderr] ... | [INFO] [stderr] 1100 | | } [INFO] [stderr] 1101 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1093 | } else if l < r { [INFO] [stderr] 1094 | r.checked_sub(l) [INFO] [stderr] 1095 | .map(|value| GenericFraction::Rational(Sign::Plus, value)) [INFO] [stderr] 1096 | } else { [INFO] [stderr] 1097 | l.checked_sub(r) [INFO] [stderr] 1098 | .map(|value| GenericFraction::Rational(Sign::Minus, value)) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/fraction/mod.rs:1137:28 [INFO] [stderr] | [INFO] [stderr] 1137 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 1138 | | if l_ < r { [INFO] [stderr] 1139 | | GenericFraction::Rational(Sign::Plus, r.sub(l_)) [INFO] [stderr] 1140 | | } else { [INFO] [stderr] 1141 | | GenericFraction::Rational(Sign::Minus, l_.sub(r)) [INFO] [stderr] 1142 | | } [INFO] [stderr] 1143 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1137 | } else if l_ < r { [INFO] [stderr] 1138 | GenericFraction::Rational(Sign::Plus, r.sub(l_)) [INFO] [stderr] 1139 | } else { [INFO] [stderr] 1140 | GenericFraction::Rational(Sign::Minus, l_.sub(r)) [INFO] [stderr] 1141 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/fraction/mod.rs:1182:28 [INFO] [stderr] | [INFO] [stderr] 1182 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 1183 | | if l_ < *r { [INFO] [stderr] 1184 | | GenericFraction::Rational(Sign::Plus, r.sub(l_)) [INFO] [stderr] 1185 | | } else { [INFO] [stderr] 1186 | | GenericFraction::Rational(Sign::Minus, l_.sub(r)) [INFO] [stderr] 1187 | | } [INFO] [stderr] 1188 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1182 | } else if l_ < *r { [INFO] [stderr] 1183 | GenericFraction::Rational(Sign::Plus, r.sub(l_)) [INFO] [stderr] 1184 | } else { [INFO] [stderr] 1185 | GenericFraction::Rational(Sign::Minus, l_.sub(r)) [INFO] [stderr] 1186 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/fraction/mod.rs:1843:24 [INFO] [stderr] | [INFO] [stderr] 1843 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 1844 | | if osign == Sign::Plus { [INFO] [stderr] 1845 | | GenericFraction::zero() [INFO] [stderr] 1846 | | } else { [INFO] [stderr] 1847 | | GenericFraction::Infinity(Sign::Plus) [INFO] [stderr] 1848 | | } [INFO] [stderr] 1849 | | }, [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1843 | } else if osign == Sign::Plus { [INFO] [stderr] 1844 | GenericFraction::zero() [INFO] [stderr] 1845 | } else { [INFO] [stderr] 1846 | GenericFraction::Infinity(Sign::Plus) [INFO] [stderr] 1847 | }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/fraction/mod.rs:1860:24 [INFO] [stderr] | [INFO] [stderr] 1860 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 1861 | | if sign == Sign::Minus { [INFO] [stderr] 1862 | | GenericFraction::Infinity(Sign::Minus) [INFO] [stderr] 1863 | | } else { [INFO] [stderr] 1864 | | GenericFraction::Infinity(Sign::Plus) [INFO] [stderr] 1865 | | } [INFO] [stderr] 1866 | | }, [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1860 | } else if sign == Sign::Minus { [INFO] [stderr] 1861 | GenericFraction::Infinity(Sign::Minus) [INFO] [stderr] 1862 | } else { [INFO] [stderr] 1863 | GenericFraction::Infinity(Sign::Plus) [INFO] [stderr] 1864 | }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/division.rs:415:5 [INFO] [stderr] | [INFO] [stderr] 415 | / if precision > 0 { [INFO] [stderr] 416 | | if !div_state.remainder.is_zero() { [INFO] [stderr] 417 | | match write!(&mut result, ".") { [INFO] [stderr] 418 | | Ok(()) => (), [INFO] [stderr] ... | [INFO] [stderr] 448 | | } [INFO] [stderr] 449 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 415 | if precision > 0 && !div_state.remainder.is_zero() { [INFO] [stderr] 416 | match write!(&mut result, ".") { [INFO] [stderr] 417 | Ok(()) => (), [INFO] [stderr] 418 | Err(e) => return Err(DivisionError::from(e)), [INFO] [stderr] 419 | }; [INFO] [stderr] 420 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/division.rs:517:5 [INFO] [stderr] | [INFO] [stderr] 517 | / if precision > 0 { [INFO] [stderr] 518 | | if !div_state.remainder.is_zero() { [INFO] [stderr] 519 | | result.push(DOT); [INFO] [stderr] 520 | | [INFO] [stderr] ... | [INFO] [stderr] 545 | | } [INFO] [stderr] 546 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 517 | if precision > 0 && !div_state.remainder.is_zero() { [INFO] [stderr] 518 | result.push(DOT); [INFO] [stderr] 519 | [INFO] [stderr] 520 | divide_rem( [INFO] [stderr] 521 | div_state.remainder, [INFO] [stderr] 522 | div_state.divisor, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/division.rs:600:5 [INFO] [stderr] | [INFO] [stderr] 600 | / if precision > 0 { [INFO] [stderr] 601 | | if !div_state.remainder.is_zero() { [INFO] [stderr] 602 | | let mut dot = false; [INFO] [stderr] 603 | | let mut trailing_zeroes = 0; [INFO] [stderr] ... | [INFO] [stderr] 643 | | } [INFO] [stderr] 644 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 600 | if precision > 0 && !div_state.remainder.is_zero() { [INFO] [stderr] 601 | let mut dot = false; [INFO] [stderr] 602 | let mut trailing_zeroes = 0; [INFO] [stderr] 603 | [INFO] [stderr] 604 | div_state = divide_rem( [INFO] [stderr] 605 | div_state.remainder, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/division.rs:1031:33 [INFO] [stderr] | [INFO] [stderr] 1031 | divide_to_ascii_vec(1000001u64, 10000u64, 3).unwrap(), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_000_001u64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/fraction/mod.rs:1001:28 [INFO] [stderr] | [INFO] [stderr] 1001 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 1002 | | if l < r { [INFO] [stderr] 1003 | | GenericFraction::Rational(Sign::Plus, r.sub(l)) [INFO] [stderr] 1004 | | } else { [INFO] [stderr] 1005 | | GenericFraction::Rational(Sign::Minus, l.sub(r)) [INFO] [stderr] 1006 | | } [INFO] [stderr] 1007 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1001 | } else if l < r { [INFO] [stderr] 1002 | GenericFraction::Rational(Sign::Plus, r.sub(l)) [INFO] [stderr] 1003 | } else { [INFO] [stderr] 1004 | GenericFraction::Rational(Sign::Minus, l.sub(r)) [INFO] [stderr] 1005 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/fraction/mod.rs:1046:28 [INFO] [stderr] | [INFO] [stderr] 1046 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 1047 | | if l < r { [INFO] [stderr] 1048 | | GenericFraction::Rational(Sign::Plus, r.sub(l)) [INFO] [stderr] 1049 | | } else { [INFO] [stderr] 1050 | | GenericFraction::Rational(Sign::Minus, l.sub(r)) [INFO] [stderr] 1051 | | } [INFO] [stderr] 1052 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1046 | } else if l < r { [INFO] [stderr] 1047 | GenericFraction::Rational(Sign::Plus, r.sub(l)) [INFO] [stderr] 1048 | } else { [INFO] [stderr] 1049 | GenericFraction::Rational(Sign::Minus, l.sub(r)) [INFO] [stderr] 1050 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/fraction/mod.rs:1093:28 [INFO] [stderr] | [INFO] [stderr] 1093 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 1094 | | if l < r { [INFO] [stderr] 1095 | | r.checked_sub(l) [INFO] [stderr] 1096 | | .map(|value| GenericFraction::Rational(Sign::Plus, value)) [INFO] [stderr] ... | [INFO] [stderr] 1100 | | } [INFO] [stderr] 1101 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1093 | } else if l < r { [INFO] [stderr] 1094 | r.checked_sub(l) [INFO] [stderr] 1095 | .map(|value| GenericFraction::Rational(Sign::Plus, value)) [INFO] [stderr] 1096 | } else { [INFO] [stderr] 1097 | l.checked_sub(r) [INFO] [stderr] 1098 | .map(|value| GenericFraction::Rational(Sign::Minus, value)) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/fraction/mod.rs:1137:28 [INFO] [stderr] | [INFO] [stderr] 1137 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 1138 | | if l_ < r { [INFO] [stderr] 1139 | | GenericFraction::Rational(Sign::Plus, r.sub(l_)) [INFO] [stderr] 1140 | | } else { [INFO] [stderr] 1141 | | GenericFraction::Rational(Sign::Minus, l_.sub(r)) [INFO] [stderr] 1142 | | } [INFO] [stderr] 1143 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1137 | } else if l_ < r { [INFO] [stderr] 1138 | GenericFraction::Rational(Sign::Plus, r.sub(l_)) [INFO] [stderr] 1139 | } else { [INFO] [stderr] 1140 | GenericFraction::Rational(Sign::Minus, l_.sub(r)) [INFO] [stderr] 1141 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/fraction/mod.rs:1182:28 [INFO] [stderr] | [INFO] [stderr] 1182 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 1183 | | if l_ < *r { [INFO] [stderr] 1184 | | GenericFraction::Rational(Sign::Plus, r.sub(l_)) [INFO] [stderr] 1185 | | } else { [INFO] [stderr] 1186 | | GenericFraction::Rational(Sign::Minus, l_.sub(r)) [INFO] [stderr] 1187 | | } [INFO] [stderr] 1188 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1182 | } else if l_ < *r { [INFO] [stderr] 1183 | GenericFraction::Rational(Sign::Plus, r.sub(l_)) [INFO] [stderr] 1184 | } else { [INFO] [stderr] 1185 | GenericFraction::Rational(Sign::Minus, l_.sub(r)) [INFO] [stderr] 1186 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/fraction/mod.rs:1843:24 [INFO] [stderr] | [INFO] [stderr] 1843 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 1844 | | if osign == Sign::Plus { [INFO] [stderr] 1845 | | GenericFraction::zero() [INFO] [stderr] 1846 | | } else { [INFO] [stderr] 1847 | | GenericFraction::Infinity(Sign::Plus) [INFO] [stderr] 1848 | | } [INFO] [stderr] 1849 | | }, [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1843 | } else if osign == Sign::Plus { [INFO] [stderr] 1844 | GenericFraction::zero() [INFO] [stderr] 1845 | } else { [INFO] [stderr] 1846 | GenericFraction::Infinity(Sign::Plus) [INFO] [stderr] 1847 | }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/fraction/mod.rs:1860:24 [INFO] [stderr] | [INFO] [stderr] 1860 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 1861 | | if sign == Sign::Minus { [INFO] [stderr] 1862 | | GenericFraction::Infinity(Sign::Minus) [INFO] [stderr] 1863 | | } else { [INFO] [stderr] 1864 | | GenericFraction::Infinity(Sign::Plus) [INFO] [stderr] 1865 | | } [INFO] [stderr] 1866 | | }, [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1860 | } else if sign == Sign::Minus { [INFO] [stderr] 1861 | GenericFraction::Infinity(Sign::Minus) [INFO] [stderr] 1862 | } else { [INFO] [stderr] 1863 | GenericFraction::Infinity(Sign::Plus) [INFO] [stderr] 1864 | }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fraction/mod.rs:2648:32 [INFO] [stderr] | [INFO] [stderr] 2648 | let f = Fraction::from(22460602606i128); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `22_460_602_606i128` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fraction/mod.rs:2650:20 [INFO] [stderr] | [INFO] [stderr] 2650 | assert_eq!(22460602606, *f.numer().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `22_460_602_606` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fraction/mod.rs:2715:32 [INFO] [stderr] | [INFO] [stderr] 2715 | let f = Fraction::from(16584253f32); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `16_584_253f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fraction/mod.rs:2717:20 [INFO] [stderr] | [INFO] [stderr] 2717 | assert_eq!(16584253u64, *f.numer().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `16_584_253u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fraction/mod.rs:2738:32 [INFO] [stderr] | [INFO] [stderr] 2738 | let f = Fraction::from(1658425342060f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `1_658_425_342_060f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fraction/mod.rs:2740:20 [INFO] [stderr] | [INFO] [stderr] 2740 | assert_eq!(1658425342060u64, *f.numer().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `1_658_425_342_060u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fraction/mod.rs:2923:40 [INFO] [stderr] | [INFO] [stderr] 2923 | let f3 = Fraction::new(456u64, 10000000000u64); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `10_000_000_000u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fraction/mod.rs:2951:31 [INFO] [stderr] | [INFO] [stderr] 2951 | BigUint::from(1000000000000000u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `1_000_000_000_000_000u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fraction/mod.rs:2952:37 [INFO] [stderr] | [INFO] [stderr] 2952 | * BigUint::from(1000000000000000u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `1_000_000_000_000_000u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fraction/mod.rs:2953:37 [INFO] [stderr] | [INFO] [stderr] 2953 | * BigUint::from(1000000000000000u64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `1_000_000_000_000_000u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fraction/mod.rs:3282:49 [INFO] [stderr] | [INFO] [stderr] 3282 | let f1 = F::new_generic(Sign::Plus, 123456788u64, 123456789i32).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `123_456_788u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fraction/mod.rs:3282:63 [INFO] [stderr] | [INFO] [stderr] 3282 | let f1 = F::new_generic(Sign::Plus, 123456788u64, 123456789i32).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `123_456_789i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fraction/mod.rs:3283:50 [INFO] [stderr] | [INFO] [stderr] 3283 | let f2 = F::new_generic(Sign::Minus, 1234567890122u64, -1234567890123i64).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `1_234_567_890_122u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fraction/mod.rs:3283:69 [INFO] [stderr] | [INFO] [stderr] 3283 | let f2 = F::new_generic(Sign::Minus, 1234567890122u64, -1234567890123i64).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `1_234_567_890_123i64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fraction/mod.rs:3291:30 [INFO] [stderr] | [INFO] [stderr] 3291 | (Sign::Plus, 123456788u128, 123456789u128) [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `123_456_788u128` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fraction/mod.rs:3291:45 [INFO] [stderr] | [INFO] [stderr] 3291 | (Sign::Plus, 123456788u128, 123456789u128) [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `123_456_789u128` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fraction/mod.rs:3299:30 [INFO] [stderr] | [INFO] [stderr] 3299 | (Sign::Plus, 1234567890122u128, 1234567890123u128) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `1_234_567_890_122u128` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/fraction/mod.rs:3299:49 [INFO] [stderr] | [INFO] [stderr] 3299 | (Sign::Plus, 1234567890122u128, 1234567890123u128) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `1_234_567_890_123u128` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/fraction/mod.rs:1236:45 [INFO] [stderr] | [INFO] [stderr] 1236 | } else if sign == osign { [INFO] [stderr] | _____________________________________________^ [INFO] [stderr] 1237 | | Sign::Plus [INFO] [stderr] 1238 | | } else { [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/fraction/mod.rs:1234:59 [INFO] [stderr] | [INFO] [stderr] 1234 | let s = if l.is_zero() || r.is_zero() { [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 1235 | | Sign::Plus [INFO] [stderr] 1236 | | } else if sign == osign { [INFO] [stderr] | |_____________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/fraction/mod.rs:1234:44 [INFO] [stderr] | [INFO] [stderr] 1234 | let s = if l.is_zero() || r.is_zero() { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::suspicious_arithmetic_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/fraction/mod.rs:1292:45 [INFO] [stderr] | [INFO] [stderr] 1292 | } else if sign == osign { [INFO] [stderr] | _____________________________________________^ [INFO] [stderr] 1293 | | Sign::Plus [INFO] [stderr] 1294 | | } else { [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/fraction/mod.rs:1290:59 [INFO] [stderr] | [INFO] [stderr] 1290 | let s = if l.is_zero() || r.is_zero() { [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 1291 | | Sign::Plus [INFO] [stderr] 1292 | | } else if sign == osign { [INFO] [stderr] | |_____________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/fraction/mod.rs:1290:44 [INFO] [stderr] | [INFO] [stderr] 1290 | let s = if l.is_zero() || r.is_zero() { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/fraction/mod.rs:1349:49 [INFO] [stderr] | [INFO] [stderr] 1349 | } else if sign == osign { [INFO] [stderr] | _________________________________________________^ [INFO] [stderr] 1350 | | Sign::Plus [INFO] [stderr] 1351 | | } else { [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/fraction/mod.rs:1347:55 [INFO] [stderr] | [INFO] [stderr] 1347 | if l.is_zero() || r.is_zero() { [INFO] [stderr] | _______________________________________________________^ [INFO] [stderr] 1348 | | Sign::Plus [INFO] [stderr] 1349 | | } else if sign == osign { [INFO] [stderr] | |_________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/fraction/mod.rs:1393:40 [INFO] [stderr] | [INFO] [stderr] 1393 | } else if ls == rs { [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 1394 | | Sign::Plus [INFO] [stderr] 1395 | | } else { [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/fraction/mod.rs:1391:60 [INFO] [stderr] | [INFO] [stderr] 1391 | let s = if l_.is_zero() || r.is_zero() { [INFO] [stderr] | ____________________________________________________________^ [INFO] [stderr] 1392 | | Sign::Plus [INFO] [stderr] 1393 | | } else if ls == rs { [INFO] [stderr] | |_____________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `MulAssign` impl [INFO] [stderr] --> src/fraction/mod.rs:1391:45 [INFO] [stderr] | [INFO] [stderr] 1391 | let s = if l_.is_zero() || r.is_zero() { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::suspicious_op_assign_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_op_assign_impl [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/fraction/mod.rs:1440:40 [INFO] [stderr] | [INFO] [stderr] 1440 | } else if ls == rs { [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 1441 | | Sign::Plus [INFO] [stderr] 1442 | | } else { [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/fraction/mod.rs:1438:60 [INFO] [stderr] | [INFO] [stderr] 1438 | let s = if l_.is_zero() || r.is_zero() { [INFO] [stderr] | ____________________________________________________________^ [INFO] [stderr] 1439 | | Sign::Plus [INFO] [stderr] 1440 | | } else if ls == rs { [INFO] [stderr] | |_____________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `MulAssign` impl [INFO] [stderr] --> src/fraction/mod.rs:1438:45 [INFO] [stderr] | [INFO] [stderr] 1438 | let s = if l_.is_zero() || r.is_zero() { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_op_assign_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/fraction/mod.rs:1476:36 [INFO] [stderr] | [INFO] [stderr] 1476 | if l.is_zero() && r.is_zero() { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/fraction/mod.rs:1524:36 [INFO] [stderr] | [INFO] [stderr] 1524 | if l.is_zero() && r.is_zero() { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `DivAssign` impl [INFO] [stderr] --> src/fraction/mod.rs:1613:37 [INFO] [stderr] | [INFO] [stderr] 1613 | if l_.is_zero() && r.is_zero() { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_op_assign_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `DivAssign` impl [INFO] [stderr] --> src/fraction/mod.rs:1653:37 [INFO] [stderr] | [INFO] [stderr] 1653 | if l_.is_zero() && r.is_zero() { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_op_assign_impl [INFO] [stderr] [INFO] [stderr] error: aborting due to 13 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `fraction`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/fraction/mod.rs:1236:45 [INFO] [stderr] | [INFO] [stderr] 1236 | } else if sign == osign { [INFO] [stderr] | _____________________________________________^ [INFO] [stderr] 1237 | | Sign::Plus [INFO] [stderr] 1238 | | } else { [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/fraction/mod.rs:1234:59 [INFO] [stderr] | [INFO] [stderr] 1234 | let s = if l.is_zero() || r.is_zero() { [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 1235 | | Sign::Plus [INFO] [stderr] 1236 | | } else if sign == osign { [INFO] [stderr] | |_____________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/fraction/mod.rs:1234:44 [INFO] [stderr] | [INFO] [stderr] 1234 | let s = if l.is_zero() || r.is_zero() { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::suspicious_arithmetic_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/fraction/mod.rs:1292:45 [INFO] [stderr] | [INFO] [stderr] 1292 | } else if sign == osign { [INFO] [stderr] | _____________________________________________^ [INFO] [stderr] 1293 | | Sign::Plus [INFO] [stderr] 1294 | | } else { [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/fraction/mod.rs:1290:59 [INFO] [stderr] | [INFO] [stderr] 1290 | let s = if l.is_zero() || r.is_zero() { [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 1291 | | Sign::Plus [INFO] [stderr] 1292 | | } else if sign == osign { [INFO] [stderr] | |_____________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/fraction/mod.rs:1290:44 [INFO] [stderr] | [INFO] [stderr] 1290 | let s = if l.is_zero() || r.is_zero() { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/fraction/mod.rs:1349:49 [INFO] [stderr] | [INFO] [stderr] 1349 | } else if sign == osign { [INFO] [stderr] | _________________________________________________^ [INFO] [stderr] 1350 | | Sign::Plus [INFO] [stderr] 1351 | | } else { [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/fraction/mod.rs:1347:55 [INFO] [stderr] | [INFO] [stderr] 1347 | if l.is_zero() || r.is_zero() { [INFO] [stderr] | _______________________________________________________^ [INFO] [stderr] 1348 | | Sign::Plus [INFO] [stderr] 1349 | | } else if sign == osign { [INFO] [stderr] | |_________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/fraction/mod.rs:1393:40 [INFO] [stderr] | [INFO] [stderr] 1393 | } else if ls == rs { [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 1394 | | Sign::Plus [INFO] [stderr] 1395 | | } else { [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/fraction/mod.rs:1391:60 [INFO] [stderr] | [INFO] [stderr] 1391 | let s = if l_.is_zero() || r.is_zero() { [INFO] [stderr] | ____________________________________________________________^ [INFO] [stderr] 1392 | | Sign::Plus [INFO] [stderr] 1393 | | } else if ls == rs { [INFO] [stderr] | |_____________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `MulAssign` impl [INFO] [stderr] --> src/fraction/mod.rs:1391:45 [INFO] [stderr] | [INFO] [stderr] 1391 | let s = if l_.is_zero() || r.is_zero() { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::suspicious_op_assign_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_op_assign_impl [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/fraction/mod.rs:1440:40 [INFO] [stderr] | [INFO] [stderr] 1440 | } else if ls == rs { [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 1441 | | Sign::Plus [INFO] [stderr] 1442 | | } else { [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/fraction/mod.rs:1438:60 [INFO] [stderr] | [INFO] [stderr] 1438 | let s = if l_.is_zero() || r.is_zero() { [INFO] [stderr] | ____________________________________________________________^ [INFO] [stderr] 1439 | | Sign::Plus [INFO] [stderr] 1440 | | } else if ls == rs { [INFO] [stderr] | |_____________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `MulAssign` impl [INFO] [stderr] --> src/fraction/mod.rs:1438:45 [INFO] [stderr] | [INFO] [stderr] 1438 | let s = if l_.is_zero() || r.is_zero() { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_op_assign_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/fraction/mod.rs:1476:36 [INFO] [stderr] | [INFO] [stderr] 1476 | if l.is_zero() && r.is_zero() { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/fraction/mod.rs:1524:36 [INFO] [stderr] | [INFO] [stderr] 1524 | if l.is_zero() && r.is_zero() { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `DivAssign` impl [INFO] [stderr] --> src/fraction/mod.rs:1613:37 [INFO] [stderr] | [INFO] [stderr] 1613 | if l_.is_zero() && r.is_zero() { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_op_assign_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `DivAssign` impl [INFO] [stderr] --> src/fraction/mod.rs:1653:37 [INFO] [stderr] | [INFO] [stderr] 1653 | if l_.is_zero() && r.is_zero() { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_op_assign_impl [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/fraction/mod.rs:2534:20 [INFO] [stderr] | [INFO] [stderr] 2534 | assert_eq!(u8::max_value() as u64, *f.numer().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(u8::max_value())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 36 [INFO] [stderr] --> src/fraction/mod.rs:2854:5 [INFO] [stderr] | [INFO] [stderr] 2854 | / fn comparison() { [INFO] [stderr] 2855 | | assert_eq!(Frac::zero(), Frac::zero()); [INFO] [stderr] 2856 | | assert_eq!(Frac::zero(), Frac::neg_zero()); [INFO] [stderr] 2857 | | assert_eq!(Frac::from(0), Frac::zero()); [INFO] [stderr] ... | [INFO] [stderr] 2898 | | assert!(Frac::zero() < Frac::new(1u8, 2u8)); [INFO] [stderr] 2899 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/fraction/mod.rs:2863:17 [INFO] [stderr] | [INFO] [stderr] 2863 | assert!(!(Frac::zero() < Frac::neg_zero())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::neg_cmp_op_on_partial_ord)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/fraction/mod.rs:2864:17 [INFO] [stderr] | [INFO] [stderr] 2864 | assert!(!(Frac::neg_zero() < Frac::zero())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/fraction/mod.rs:2866:17 [INFO] [stderr] | [INFO] [stderr] 2866 | assert!(!(Frac::zero() > Frac::neg_zero())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/fraction/mod.rs:2867:17 [INFO] [stderr] | [INFO] [stderr] 2867 | assert!(!(Frac::neg_zero() > Frac::zero())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/fraction/mod.rs:2870:17 [INFO] [stderr] | [INFO] [stderr] 2870 | assert!(!(Frac::neg_zero() > Frac::new(1u8, 2u8))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/fraction/mod.rs:2873:17 [INFO] [stderr] | [INFO] [stderr] 2873 | assert!(!(Frac::zero() > Frac::new(1u8, 2u8))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/fraction/mod.rs:2878:17 [INFO] [stderr] | [INFO] [stderr] 2878 | assert!(!(Frac::new_neg(1u8, 2u8) > Frac::neg_zero())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/fraction/mod.rs:2879:17 [INFO] [stderr] | [INFO] [stderr] 2879 | assert!(!(Frac::new_neg(1u8, 2u8) > Frac::zero())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/fraction/mod.rs:2885:17 [INFO] [stderr] | [INFO] [stderr] 2885 | assert!(!(Frac::new(1u8, 2u8) < Frac::new_neg(1u8, 2u8))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/fraction/mod.rs:2886:17 [INFO] [stderr] | [INFO] [stderr] 2886 | assert!(!(Frac::new_neg(1u8, 2u8) < Frac::new_neg(1u8, 2u8))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/fraction/mod.rs:2891:17 [INFO] [stderr] | [INFO] [stderr] 2891 | assert!(!(Frac::neg_zero() < Frac::new_neg(1u8, 2u8))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/fraction/mod.rs:2892:17 [INFO] [stderr] | [INFO] [stderr] 2892 | assert!(!(Frac::zero() < Frac::new_neg(1u8, 2u8))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/fraction/mod.rs:2897:17 [INFO] [stderr] | [INFO] [stderr] 2897 | assert!(!(Frac::new(1u8, 2u8) < Frac::neg_zero())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/fraction/mod.rs:2966:5 [INFO] [stderr] | [INFO] [stderr] 2966 | / fn from_decimal_str() { [INFO] [stderr] 2967 | | assert_eq!(Ok(Frac::zero()), Frac::from_decimal_str("0")); [INFO] [stderr] 2968 | | assert_eq!(Ok(Frac::zero()), Frac::from_decimal_str("-0")); [INFO] [stderr] 2969 | | assert_eq!(Ok(Frac::zero()), Frac::from_decimal_str("+0")); [INFO] [stderr] ... | [INFO] [stderr] 3048 | | ); [INFO] [stderr] 3049 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/fraction/mod.rs:3052:5 [INFO] [stderr] | [INFO] [stderr] 3052 | / fn new_generic() { [INFO] [stderr] 3053 | | { [INFO] [stderr] 3054 | | type F = GenericFraction; [INFO] [stderr] 3055 | | [INFO] [stderr] ... | [INFO] [stderr] 3301 | | } [INFO] [stderr] 3302 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 73 [INFO] [stderr] --> src/fraction/mod.rs:3326:5 [INFO] [stderr] | [INFO] [stderr] 3326 | / fn fraction() { [INFO] [stderr] 3327 | | assert_eq!(Frac::nan(), Frac::new(0, 0)); [INFO] [stderr] 3328 | | assert_eq!(Frac::infinity(), Frac::new(1, 0)); [INFO] [stderr] 3329 | | [INFO] [stderr] ... | [INFO] [stderr] 3440 | | assert_eq!(Frac::new(2, 1), Frac::new(1, 2).recip()); [INFO] [stderr] 3441 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/fraction/mod.rs:3353:17 [INFO] [stderr] | [INFO] [stderr] 3353 | assert!(!(Frac::infinity() > Frac::infinity())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/fraction/mod.rs:3355:17 [INFO] [stderr] | [INFO] [stderr] 3355 | assert!(!(Frac::neg_infinity() > Frac::infinity())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/fraction/mod.rs:3373:13 [INFO] [stderr] | [INFO] [stderr] 3373 | &Frac::new_neg(1, 1) + &Frac::new_neg(1, 1), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 3373 | Frac::new_neg(1, 1) + Frac::new_neg(1, 1), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/fraction/mod.rs:3379:20 [INFO] [stderr] | [INFO] [stderr] 3379 | assert_eq!(&Frac::new_neg(1, 1) - &Frac::new_neg(1, 1), Frac::zero()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 3379 | assert_eq!(Frac::new_neg(1, 1) - Frac::new_neg(1, 1), Frac::zero()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/fraction/mod.rs:3380:20 [INFO] [stderr] | [INFO] [stderr] 3380 | assert_eq!(&Frac::new_neg(1, 1) - &Frac::new_neg(2, 1), Frac::one()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 3380 | assert_eq!(Frac::new_neg(1, 1) - Frac::new_neg(2, 1), Frac::one()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 29 [INFO] [stderr] --> src/fraction/mod.rs:3718:5 [INFO] [stderr] | [INFO] [stderr] 3718 | / fn mul_assign() { [INFO] [stderr] 3719 | | { [INFO] [stderr] 3720 | | let mut v = Frac::nan(); [INFO] [stderr] 3721 | | v *= Frac::nan(); [INFO] [stderr] ... | [INFO] [stderr] 3887 | | } [INFO] [stderr] 3888 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 31 [INFO] [stderr] --> src/fraction/mod.rs:3891:5 [INFO] [stderr] | [INFO] [stderr] 3891 | / fn div_assign() { [INFO] [stderr] 3892 | | { [INFO] [stderr] 3893 | | let mut v = Frac::nan(); [INFO] [stderr] 3894 | | v /= Frac::nan(); [INFO] [stderr] ... | [INFO] [stderr] 4072 | | } [INFO] [stderr] 4073 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 26 [INFO] [stderr] --> src/fraction/mod.rs:4419:5 [INFO] [stderr] | [INFO] [stderr] 4419 | / fn signed() { [INFO] [stderr] 4420 | | // abs [INFO] [stderr] 4421 | | assert_eq!(Frac::one(), ::abs(&Frac::new_neg(1, 1))); [INFO] [stderr] 4422 | | assert_eq!(Frac::nan(), ::abs(&Frac::nan())); [INFO] [stderr] ... | [INFO] [stderr] 4467 | | assert_eq!(-Frac::one(), Frac::new_neg(1, 1).signum()); [INFO] [stderr] 4468 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/fraction/mod.rs:4493:9 [INFO] [stderr] | [INFO] [stderr] 4493 | assert_eq!(::std::f64::INFINITY, Frac::infinity().to_f64().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/fraction/mod.rs:4493:9 [INFO] [stderr] | [INFO] [stderr] 4493 | assert_eq!(::std::f64::INFINITY, Frac::infinity().to_f64().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/fraction/mod.rs:4494:9 [INFO] [stderr] | [INFO] [stderr] 4494 | / assert_eq!( [INFO] [stderr] 4495 | | ::std::f64::NEG_INFINITY, [INFO] [stderr] 4496 | | Frac::neg_infinity().to_f64().unwrap() [INFO] [stderr] 4497 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/fraction/mod.rs:4494:9 [INFO] [stderr] | [INFO] [stderr] 4494 | / assert_eq!( [INFO] [stderr] 4495 | | ::std::f64::NEG_INFINITY, [INFO] [stderr] 4496 | | Frac::neg_infinity().to_f64().unwrap() [INFO] [stderr] 4497 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/fraction/mod.rs:4499:9 [INFO] [stderr] | [INFO] [stderr] 4499 | assert_eq!(1f64, Frac::one().to_f64().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/fraction/mod.rs:4499:9 [INFO] [stderr] | [INFO] [stderr] 4499 | assert_eq!(1f64, Frac::one().to_f64().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/dynaint.rs:907:24 [INFO] [stderr] | [INFO] [stderr] 907 | assert_eq!(m8, val.clone().unpack().ok().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `val` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/dynaint.rs:911:24 [INFO] [stderr] | [INFO] [stderr] 911 | assert_eq!(m8, val.clone().unpack().ok().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/dynaint.rs:915:39 [INFO] [stderr] | [INFO] [stderr] 915 | assert_eq!(u16::from(m8) + 1, val.clone().unpack().err().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/dynaint.rs:919:39 [INFO] [stderr] | [INFO] [stderr] 919 | assert_eq!(u16::from(m8) + 2, val.clone().unpack().err().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/dynaint.rs:923:24 [INFO] [stderr] | [INFO] [stderr] 923 | assert_eq!(m8, val.clone().unpack().ok().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/dynaint.rs:1014:25 [INFO] [stderr] | [INFO] [stderr] 1014 | assert_eq!(2u8, (D::one() + &D::one()).unpack().ok().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^---------^ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `D::one()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/dynaint.rs:1017:28 [INFO] [stderr] | [INFO] [stderr] 1017 | assert_eq!(256u16, (D::one() + &D::from(255u8)).unpack().err().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^---------------^ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `D::from(255u8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/dynaint.rs:1018:28 [INFO] [stderr] | [INFO] [stderr] 1018 | assert_eq!(257u16, (D::one() + &D::from(256u16)).unpack().err().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^----------------^ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `D::from(256u16)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/dynaint.rs:1019:28 [INFO] [stderr] | [INFO] [stderr] 1019 | assert_eq!(257u16, (&D::one() + &D::from(256u16)).unpack().err().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 1019 | assert_eq!(257u16, (D::one() + D::from(256u16)).unpack().err().unwrap()); [INFO] [stderr] | ^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/dynaint.rs:1022:28 [INFO] [stderr] | [INFO] [stderr] 1022 | assert_eq!(257u16, (D::from(256u16) + &D::one()).unpack().err().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^---------^ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `D::one()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/dynaint.rs:1023:28 [INFO] [stderr] | [INFO] [stderr] 1023 | assert_eq!(257u16, (&D::from(256u16) + &D::one()).unpack().err().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 1023 | assert_eq!(257u16, (D::from(256u16) + D::one()).unpack().err().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/dynaint.rs:1026:28 [INFO] [stderr] | [INFO] [stderr] 1026 | assert_eq!(512u16, (D::from(256u16) + &D::from(256u16)).unpack().err().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^----------------^ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `D::from(256u16)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/dynaint.rs:1027:28 [INFO] [stderr] | [INFO] [stderr] 1027 | assert_eq!(512u16, (&D::from(256u16) + &D::from(256u16)).unpack().err().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 1027 | assert_eq!(512u16, (D::from(256u16) + D::from(256u16)).unpack().err().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/dynaint.rs:1033:30 [INFO] [stderr] | [INFO] [stderr] 1033 | assert_eq!(D::one(), &D::one() & &D::one()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 1033 | assert_eq!(D::one(), D::one() & D::one()); [INFO] [stderr] | ^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/dynaint.rs:1036:31 [INFO] [stderr] | [INFO] [stderr] 1036 | assert_eq!(D::zero(), &D::one() & &D::from(256u16)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 1036 | assert_eq!(D::zero(), D::one() & D::from(256u16)); [INFO] [stderr] | ^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/dynaint.rs:1039:31 [INFO] [stderr] | [INFO] [stderr] 1039 | assert_eq!(D::zero(), &D::from(256u16) & &D::one()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 1039 | assert_eq!(D::zero(), D::from(256u16) & D::one()); [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/dynaint.rs:1042:37 [INFO] [stderr] | [INFO] [stderr] 1042 | assert_eq!(D::from(256u16), &D::from(256u16) & &D::from(257u16)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 1042 | assert_eq!(D::from(256u16), D::from(256u16) & D::from(257u16)); [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/dynaint.rs:1098:30 [INFO] [stderr] | [INFO] [stderr] 1098 | assert_eq!(D::one(), D::from(3u8) % &D::from(2u8)); [INFO] [stderr] | ^^^^^^^^^^^^^^^------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `D::from(2u8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/dynaint.rs:1099:30 [INFO] [stderr] | [INFO] [stderr] 1099 | assert_eq!(D::one(), &D::from(3u8) % &D::from(2u8)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 1099 | assert_eq!(D::one(), D::from(3u8) % D::from(2u8)); [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/dynaint.rs:1114:30 [INFO] [stderr] | [INFO] [stderr] 1114 | assert_eq!(D::one(), D::one() % &D::from(256u16)); [INFO] [stderr] | ^^^^^^^^^^^---------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `D::from(256u16)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/dynaint.rs:1115:30 [INFO] [stderr] | [INFO] [stderr] 1115 | assert_eq!(D::one(), &D::one() % &D::from(256u16)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 1115 | assert_eq!(D::one(), D::one() % D::from(256u16)); [INFO] [stderr] | ^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/dynaint.rs:1118:25 [INFO] [stderr] | [INFO] [stderr] 1118 | let mut v = D::from(D::one()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider removing `D::from()`: `D::one()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/dynaint.rs:1124:25 [INFO] [stderr] | [INFO] [stderr] 1124 | let mut v = D::from(D::one()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider removing `D::from()`: `D::one()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/dynaint.rs:1130:31 [INFO] [stderr] | [INFO] [stderr] 1130 | assert_eq!(D::zero(), D::from(256u16) % &D::one()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^--------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `D::one()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/dynaint.rs:1131:31 [INFO] [stderr] | [INFO] [stderr] 1131 | assert_eq!(D::zero(), &D::from(256u16) % &D::one()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 1131 | assert_eq!(D::zero(), D::from(256u16) % D::one()); [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/dynaint.rs:1146:31 [INFO] [stderr] | [INFO] [stderr] 1146 | assert_eq!(D::zero(), D::from(256u16) % &D::from(256u16)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^---------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `D::from(256u16)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/dynaint.rs:1147:31 [INFO] [stderr] | [INFO] [stderr] 1147 | assert_eq!(D::zero(), &D::from(256u16) % &D::from(256u16)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 1147 | assert_eq!(D::zero(), D::from(256u16) % D::from(256u16)); [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/dynaint.rs:1150:25 [INFO] [stderr] | [INFO] [stderr] 1150 | let mut v = D::from(D::from(256u16)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `D::from()`: `D::from(256u16)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/dynaint.rs:1156:25 [INFO] [stderr] | [INFO] [stderr] 1156 | let mut v = D::from(D::from(256u16)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `D::from()`: `D::from(256u16)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] error: aborting due to 16 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `fraction`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "fd327dfbac602fd7aea0f291422d5a221c2477773da58b261405c6e8214030fa"` [INFO] running `"docker" "rm" "-f" "fd327dfbac602fd7aea0f291422d5a221c2477773da58b261405c6e8214030fa"` [INFO] [stdout] fd327dfbac602fd7aea0f291422d5a221c2477773da58b261405c6e8214030fa