[INFO] crate fpe 0.1.0 is already in cache [INFO] extracting crate fpe 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/fpe/0.1.0 [INFO] extracting crate fpe 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fpe/0.1.0 [INFO] validating manifest of fpe-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of fpe-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing fpe-0.1.0 [INFO] finished frobbing fpe-0.1.0 [INFO] frobbed toml for fpe-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/fpe/0.1.0/Cargo.toml [INFO] started frobbing fpe-0.1.0 [INFO] finished frobbing fpe-0.1.0 [INFO] frobbed toml for fpe-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fpe/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting fpe-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/fpe/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 12e7bf1030a00755b489d4bc2b26467f12c36595f94dd2b6a35529fe8a1cca9d [INFO] running `"docker" "start" "-a" "12e7bf1030a00755b489d4bc2b26467f12c36595f94dd2b6a35529fe8a1cca9d"` [INFO] [stderr] Checking aes-soft v0.2.0 [INFO] [stderr] Checking aes v0.2.0 [INFO] [stderr] Checking fpe v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/ff1.rs:328:13 [INFO] [stderr] | [INFO] [stderr] 328 | let v = n - u; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/ff1.rs:334:13 [INFO] [stderr] | [INFO] [stderr] 334 | let b = self.radix.calculate_b(v); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/ff1.rs:337:13 [INFO] [stderr] | [INFO] [stderr] 337 | let d = 4 * ((b + 3) / 4) + 4; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/ff1.rs:340:17 [INFO] [stderr] | [INFO] [stderr] 340 | let mut p = vec![1, 2, 1]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 9th binding whose name is just one char [INFO] [stderr] --> src/ff1.rs:350:21 [INFO] [stderr] | [INFO] [stderr] 350 | let mut q = Vec::from(tweak); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 9th binding whose name is just one char [INFO] [stderr] --> src/ff1.rs:355:21 [INFO] [stderr] | [INFO] [stderr] 355 | let mut q = q_base.clone(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 10th binding whose name is just one char [INFO] [stderr] --> src/ff1.rs:364:17 [INFO] [stderr] | [INFO] [stderr] 364 | let r = self.prf(&[&p[..], &q[..]].concat()); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 11th binding whose name is just one char [INFO] [stderr] --> src/ff1.rs:367:17 [INFO] [stderr] | [INFO] [stderr] 367 | let s = generate_s(&self.ciph, &r[..], d); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 12th binding whose name is just one char [INFO] [stderr] --> src/ff1.rs:370:17 [INFO] [stderr] | [INFO] [stderr] 370 | let y = BigUint::from_bytes_be(&s); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 13th binding whose name is just one char [INFO] [stderr] --> src/ff1.rs:373:17 [INFO] [stderr] | [INFO] [stderr] 373 | let m = if i % 2 == 0 { u } else { v }; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 14th binding whose name is just one char [INFO] [stderr] --> src/ff1.rs:376:17 [INFO] [stderr] | [INFO] [stderr] 376 | let c = (x_a.num_radix(&self.radix_bi) + y) % pow(&self.radix_bi, m); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/ff1.rs:405:13 [INFO] [stderr] | [INFO] [stderr] 405 | let v = n - u; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/ff1.rs:411:13 [INFO] [stderr] | [INFO] [stderr] 411 | let b = self.radix.calculate_b(v); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/ff1.rs:414:13 [INFO] [stderr] | [INFO] [stderr] 414 | let d = 4 * ((b + 3) / 4) + 4; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/ff1.rs:417:17 [INFO] [stderr] | [INFO] [stderr] 417 | let mut p = vec![1, 2, 1]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 9th binding whose name is just one char [INFO] [stderr] --> src/ff1.rs:427:21 [INFO] [stderr] | [INFO] [stderr] 427 | let mut q = Vec::from(tweak); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 9th binding whose name is just one char [INFO] [stderr] --> src/ff1.rs:432:17 [INFO] [stderr] | [INFO] [stderr] 432 | let i = 9 - i; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 10th binding whose name is just one char [INFO] [stderr] --> src/ff1.rs:433:21 [INFO] [stderr] | [INFO] [stderr] 433 | let mut q = q_base.clone(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 11th binding whose name is just one char [INFO] [stderr] --> src/ff1.rs:442:17 [INFO] [stderr] | [INFO] [stderr] 442 | let r = self.prf(&[&p[..], &q[..]].concat()); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 12th binding whose name is just one char [INFO] [stderr] --> src/ff1.rs:445:17 [INFO] [stderr] | [INFO] [stderr] 445 | let s = generate_s(&self.ciph, &r[..], d); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 13th binding whose name is just one char [INFO] [stderr] --> src/ff1.rs:448:17 [INFO] [stderr] | [INFO] [stderr] 448 | let y = BigInt::from(BigUint::from_bytes_be(&s)); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 14th binding whose name is just one char [INFO] [stderr] --> src/ff1.rs:451:17 [INFO] [stderr] | [INFO] [stderr] 451 | let m = if i % 2 == 0 { u } else { v }; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 15th binding whose name is just one char [INFO] [stderr] --> src/ff1.rs:455:21 [INFO] [stderr] | [INFO] [stderr] 455 | let mut c = (BigInt::from(x_b.num_radix(&self.radix_bi)) - y) % &modulus; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/ff1.rs:328:13 [INFO] [stderr] | [INFO] [stderr] 328 | let v = n - u; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/ff1.rs:334:13 [INFO] [stderr] | [INFO] [stderr] 334 | let b = self.radix.calculate_b(v); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/ff1.rs:337:13 [INFO] [stderr] | [INFO] [stderr] 337 | let d = 4 * ((b + 3) / 4) + 4; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/ff1.rs:340:17 [INFO] [stderr] | [INFO] [stderr] 340 | let mut p = vec![1, 2, 1]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 9th binding whose name is just one char [INFO] [stderr] --> src/ff1.rs:350:21 [INFO] [stderr] | [INFO] [stderr] 350 | let mut q = Vec::from(tweak); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 9th binding whose name is just one char [INFO] [stderr] --> src/ff1.rs:355:21 [INFO] [stderr] | [INFO] [stderr] 355 | let mut q = q_base.clone(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 10th binding whose name is just one char [INFO] [stderr] --> src/ff1.rs:364:17 [INFO] [stderr] | [INFO] [stderr] 364 | let r = self.prf(&[&p[..], &q[..]].concat()); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 11th binding whose name is just one char [INFO] [stderr] --> src/ff1.rs:367:17 [INFO] [stderr] | [INFO] [stderr] 367 | let s = generate_s(&self.ciph, &r[..], d); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 12th binding whose name is just one char [INFO] [stderr] --> src/ff1.rs:370:17 [INFO] [stderr] | [INFO] [stderr] 370 | let y = BigUint::from_bytes_be(&s); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 13th binding whose name is just one char [INFO] [stderr] --> src/ff1.rs:373:17 [INFO] [stderr] | [INFO] [stderr] 373 | let m = if i % 2 == 0 { u } else { v }; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 14th binding whose name is just one char [INFO] [stderr] --> src/ff1.rs:376:17 [INFO] [stderr] | [INFO] [stderr] 376 | let c = (x_a.num_radix(&self.radix_bi) + y) % pow(&self.radix_bi, m); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/ff1.rs:405:13 [INFO] [stderr] | [INFO] [stderr] 405 | let v = n - u; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/ff1.rs:411:13 [INFO] [stderr] | [INFO] [stderr] 411 | let b = self.radix.calculate_b(v); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/ff1.rs:414:13 [INFO] [stderr] | [INFO] [stderr] 414 | let d = 4 * ((b + 3) / 4) + 4; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/ff1.rs:417:17 [INFO] [stderr] | [INFO] [stderr] 417 | let mut p = vec![1, 2, 1]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 9th binding whose name is just one char [INFO] [stderr] --> src/ff1.rs:427:21 [INFO] [stderr] | [INFO] [stderr] 427 | let mut q = Vec::from(tweak); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 9th binding whose name is just one char [INFO] [stderr] --> src/ff1.rs:432:17 [INFO] [stderr] | [INFO] [stderr] 432 | let i = 9 - i; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 10th binding whose name is just one char [INFO] [stderr] --> src/ff1.rs:433:21 [INFO] [stderr] | [INFO] [stderr] 433 | let mut q = q_base.clone(); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 11th binding whose name is just one char [INFO] [stderr] --> src/ff1.rs:442:17 [INFO] [stderr] | [INFO] [stderr] 442 | let r = self.prf(&[&p[..], &q[..]].concat()); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 12th binding whose name is just one char [INFO] [stderr] --> src/ff1.rs:445:17 [INFO] [stderr] | [INFO] [stderr] 445 | let s = generate_s(&self.ciph, &r[..], d); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 13th binding whose name is just one char [INFO] [stderr] --> src/ff1.rs:448:17 [INFO] [stderr] | [INFO] [stderr] 448 | let y = BigInt::from(BigUint::from_bytes_be(&s)); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 14th binding whose name is just one char [INFO] [stderr] --> src/ff1.rs:451:17 [INFO] [stderr] | [INFO] [stderr] 451 | let m = if i % 2 == 0 { u } else { v }; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 15th binding whose name is just one char [INFO] [stderr] --> src/ff1.rs:455:21 [INFO] [stderr] | [INFO] [stderr] 455 | let mut c = (BigInt::from(x_b.num_radix(&self.radix_bi)) - y) % &modulus; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/ff1.rs:55:17 [INFO] [stderr] | [INFO] [stderr] 55 | radix: _, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `PowerTwo { log_radix, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/ff1.rs:70:17 [INFO] [stderr] | [INFO] [stderr] 70 | log_radix: _, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `PowerTwo { radix, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ff1.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | / match self { [INFO] [stderr] 53 | | &Radix::Any(r) => (v as f64 * (r as f64).log2() / 8f64).ceil() as usize, [INFO] [stderr] 54 | | &Radix::PowerTwo { [INFO] [stderr] 55 | | radix: _, [INFO] [stderr] 56 | | log_radix, [INFO] [stderr] 57 | | } => ((v * log_radix as usize) + 7) / 8, [INFO] [stderr] 58 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 52 | match *self { [INFO] [stderr] 53 | Radix::Any(r) => (v as f64 * (r as f64).log2() / 8f64).ceil() as usize, [INFO] [stderr] 54 | Radix::PowerTwo { [INFO] [stderr] 55 | radix: _, [INFO] [stderr] 56 | log_radix, [INFO] [stderr] 57 | } => ((v * log_radix as usize) + 7) / 8, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ff1.rs:53:43 [INFO] [stderr] | [INFO] [stderr] 53 | &Radix::Any(r) => (v as f64 * (r as f64).log2() / 8f64).ceil() as usize, [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(r)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ff1.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | / match self { [INFO] [stderr] 67 | | &Radix::Any(r) => r, [INFO] [stderr] 68 | | &Radix::PowerTwo { [INFO] [stderr] 69 | | radix, [INFO] [stderr] 70 | | log_radix: _, [INFO] [stderr] 71 | | } => radix, [INFO] [stderr] 72 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 66 | match *self { [INFO] [stderr] 67 | Radix::Any(r) => r, [INFO] [stderr] 68 | Radix::PowerTwo { [INFO] [stderr] 69 | radix, [INFO] [stderr] 70 | log_radix: _, [INFO] [stderr] 71 | } => radix, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: trait `NumeralString` has a `len` method but no (possibly inherited) `is_empty` method [INFO] [stderr] --> src/ff1.rs:77:1 [INFO] [stderr] | [INFO] [stderr] 77 | / pub trait NumeralString: Sized { [INFO] [stderr] 78 | | /// Returns whether this numeral string is valid for the base radix. [INFO] [stderr] 79 | | fn is_valid(&self, radix: u32) -> bool; [INFO] [stderr] 80 | | [INFO] [stderr] ... | [INFO] [stderr] 98 | | fn str_radix(x: BigUint, radix: &BigUint, m: usize) -> Self; [INFO] [stderr] 99 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/ff1.rs:119:20 [INFO] [stderr] | [INFO] [stderr] 119 | .iter() [INFO] [stderr] | ____________________^ [INFO] [stderr] 120 | | .fold(true, |acc, n| acc && ((*n as u32) < radix)) [INFO] [stderr] | |______________________________________________________________^ help: try: `.all(|n| ((*n as u32) < radix))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ff1.rs:120:42 [INFO] [stderr] | [INFO] [stderr] 120 | .fold(true, |acc, n| acc && ((*n as u32) < radix)) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(*n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ff1.rs:151:13 [INFO] [stderr] | [INFO] [stderr] 151 | x = x / radix; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `x /= radix` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/ff1.rs:199:20 [INFO] [stderr] | [INFO] [stderr] 199 | .iter() [INFO] [stderr] | ____________________^ [INFO] [stderr] 200 | | .fold(true, |acc, n| acc && ((*n as u32) < radix)) [INFO] [stderr] | |______________________________________________________________^ help: try: `.all(|n| ((*n as u32) < radix))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ff1.rs:200:42 [INFO] [stderr] | [INFO] [stderr] 200 | .fold(true, |acc, n| acc && ((*n as u32) < radix)) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(*n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/ff1.rs:55:17 [INFO] [stderr] | [INFO] [stderr] 55 | radix: _, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `PowerTwo { log_radix, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/ff1.rs:70:17 [INFO] [stderr] | [INFO] [stderr] 70 | log_radix: _, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `PowerTwo { radix, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ff1.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | / match self { [INFO] [stderr] 53 | | &Radix::Any(r) => (v as f64 * (r as f64).log2() / 8f64).ceil() as usize, [INFO] [stderr] 54 | | &Radix::PowerTwo { [INFO] [stderr] 55 | | radix: _, [INFO] [stderr] 56 | | log_radix, [INFO] [stderr] 57 | | } => ((v * log_radix as usize) + 7) / 8, [INFO] [stderr] 58 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 52 | match *self { [INFO] [stderr] 53 | Radix::Any(r) => (v as f64 * (r as f64).log2() / 8f64).ceil() as usize, [INFO] [stderr] 54 | Radix::PowerTwo { [INFO] [stderr] 55 | radix: _, [INFO] [stderr] 56 | log_radix, [INFO] [stderr] 57 | } => ((v * log_radix as usize) + 7) / 8, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ff1.rs:53:43 [INFO] [stderr] | [INFO] [stderr] 53 | &Radix::Any(r) => (v as f64 * (r as f64).log2() / 8f64).ceil() as usize, [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(r)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ff1.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | / match self { [INFO] [stderr] 67 | | &Radix::Any(r) => r, [INFO] [stderr] 68 | | &Radix::PowerTwo { [INFO] [stderr] 69 | | radix, [INFO] [stderr] 70 | | log_radix: _, [INFO] [stderr] 71 | | } => radix, [INFO] [stderr] 72 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 66 | match *self { [INFO] [stderr] 67 | Radix::Any(r) => r, [INFO] [stderr] 68 | Radix::PowerTwo { [INFO] [stderr] 69 | radix, [INFO] [stderr] 70 | log_radix: _, [INFO] [stderr] 71 | } => radix, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: trait `NumeralString` has a `len` method but no (possibly inherited) `is_empty` method [INFO] [stderr] --> src/ff1.rs:77:1 [INFO] [stderr] | [INFO] [stderr] 77 | / pub trait NumeralString: Sized { [INFO] [stderr] 78 | | /// Returns whether this numeral string is valid for the base radix. [INFO] [stderr] 79 | | fn is_valid(&self, radix: u32) -> bool; [INFO] [stderr] 80 | | [INFO] [stderr] ... | [INFO] [stderr] 98 | | fn str_radix(x: BigUint, radix: &BigUint, m: usize) -> Self; [INFO] [stderr] 99 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/ff1.rs:119:20 [INFO] [stderr] | [INFO] [stderr] 119 | .iter() [INFO] [stderr] | ____________________^ [INFO] [stderr] 120 | | .fold(true, |acc, n| acc && ((*n as u32) < radix)) [INFO] [stderr] | |______________________________________________________________^ help: try: `.all(|n| ((*n as u32) < radix))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ff1.rs:120:42 [INFO] [stderr] | [INFO] [stderr] 120 | .fold(true, |acc, n| acc && ((*n as u32) < radix)) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(*n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ff1.rs:151:13 [INFO] [stderr] | [INFO] [stderr] 151 | x = x / radix; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `x /= radix` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/ff1.rs:199:20 [INFO] [stderr] | [INFO] [stderr] 199 | .iter() [INFO] [stderr] | ____________________^ [INFO] [stderr] 200 | | .fold(true, |acc, n| acc && ((*n as u32) < radix)) [INFO] [stderr] | |______________________________________________________________^ help: try: `.all(|n| ((*n as u32) < radix))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ff1.rs:200:42 [INFO] [stderr] | [INFO] [stderr] 200 | .fold(true, |acc, n| acc && ((*n as u32) < radix)) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(*n)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.02s [INFO] running `"docker" "inspect" "12e7bf1030a00755b489d4bc2b26467f12c36595f94dd2b6a35529fe8a1cca9d"` [INFO] running `"docker" "rm" "-f" "12e7bf1030a00755b489d4bc2b26467f12c36595f94dd2b6a35529fe8a1cca9d"` [INFO] [stdout] 12e7bf1030a00755b489d4bc2b26467f12c36595f94dd2b6a35529fe8a1cca9d