[INFO] crate fors 0.1.0 is already in cache [INFO] extracting crate fors 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/fors/0.1.0 [INFO] extracting crate fors 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fors/0.1.0 [INFO] validating manifest of fors-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of fors-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing fors-0.1.0 [INFO] finished frobbing fors-0.1.0 [INFO] frobbed toml for fors-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/fors/0.1.0/Cargo.toml [INFO] started frobbing fors-0.1.0 [INFO] finished frobbing fors-0.1.0 [INFO] frobbed toml for fors-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fors/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting fors-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/fors/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5aa158d52c97d6944d00586dabf99d80bc13bfa7e5263f490316b90d190726aa [INFO] running `"docker" "start" "-a" "5aa158d52c97d6944d00586dabf99d80bc13bfa7e5263f490316b90d190726aa"` [INFO] [stderr] Checking fors v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/output.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | padding: padding, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `padding` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/output.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | padding: padding, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `padding` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/output.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | / loop { [INFO] [stderr] 35 | | let mut temp = [0; 1024]; [INFO] [stderr] 36 | | let read = match child.stdout { [INFO] [stderr] 37 | | Some(ref mut r) => try!(r.read(&mut temp)), [INFO] [stderr] ... | [INFO] [stderr] 64 | | break; [INFO] [stderr] 65 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/output.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | / loop { [INFO] [stderr] 50 | | let position = match slice.iter().position(|b| *b == b'\n') { [INFO] [stderr] 51 | | Some(v) => v, [INFO] [stderr] 52 | | None => break, [INFO] [stderr] ... | [INFO] [stderr] 60 | | slice = &slice[position + 1..]; [INFO] [stderr] 61 | | } [INFO] [stderr] | |_____________^ help: try: `while let Some(v) = slice.iter().position(|b| *b == b'\n') { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/output.rs:55:37 [INFO] [stderr] | [INFO] [stderr] 55 | let before = &slice[..position + 1]; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `..=position` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/output.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | try!(self.terminal.write(buffer)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `fors`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/output.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | / loop { [INFO] [stderr] 35 | | let mut temp = [0; 1024]; [INFO] [stderr] 36 | | let read = match child.stdout { [INFO] [stderr] 37 | | Some(ref mut r) => try!(r.read(&mut temp)), [INFO] [stderr] ... | [INFO] [stderr] 64 | | break; [INFO] [stderr] 65 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/output.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | / loop { [INFO] [stderr] 50 | | let position = match slice.iter().position(|b| *b == b'\n') { [INFO] [stderr] 51 | | Some(v) => v, [INFO] [stderr] 52 | | None => break, [INFO] [stderr] ... | [INFO] [stderr] 60 | | slice = &slice[position + 1..]; [INFO] [stderr] 61 | | } [INFO] [stderr] | |_____________^ help: try: `while let Some(v) = slice.iter().position(|b| *b == b'\n') { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/output.rs:55:37 [INFO] [stderr] | [INFO] [stderr] 55 | let before = &slice[..position + 1]; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `..=position` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/output.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | try!(self.terminal.write(buffer)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `fors`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "5aa158d52c97d6944d00586dabf99d80bc13bfa7e5263f490316b90d190726aa"` [INFO] running `"docker" "rm" "-f" "5aa158d52c97d6944d00586dabf99d80bc13bfa7e5263f490316b90d190726aa"` [INFO] [stdout] 5aa158d52c97d6944d00586dabf99d80bc13bfa7e5263f490316b90d190726aa