[INFO] crate form 0.4.0 is already in cache
[INFO] extracting crate form 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/form/0.4.0
[INFO] extracting crate form 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/form/0.4.0
[INFO] validating manifest of form-0.4.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of form-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing form-0.4.0
[INFO] finished frobbing form-0.4.0
[INFO] frobbed toml for form-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/form/0.4.0/Cargo.toml
[INFO] started frobbing form-0.4.0
[INFO] finished frobbing form-0.4.0
[INFO] frobbed toml for form-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/form/0.4.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting form-0.4.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/form/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 6f62aee9fc1ee4408687336b66fd6d290c6ae262dd2a8d413417b1726b154451
[INFO] running `"docker" "start" "-a" "6f62aee9fc1ee4408687336b66fd6d290c6ae262dd2a8d413417b1726b154451"`
[INFO] [stderr]     Checking syn v0.11.11
[INFO] [stderr]     Checking form v0.4.0 (/opt/crater/workdir)
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/opts.rs:16:29
[INFO] [stderr]    |
[INFO] [stderr] 16 |         const SHORT_INPUT: &'static str = "i";
[INFO] [stderr]    |                            -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/opts.rs:17:30
[INFO] [stderr]    |
[INFO] [stderr] 17 |         const SHORT_OUTDIR: &'static str = "o";
[INFO] [stderr]    |                             -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/opts.rs:18:28
[INFO] [stderr]    |
[INFO] [stderr] 18 |         const SHORT_HELP: &'static str = "h";
[INFO] [stderr]    |                           -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:41:5
[INFO] [stderr]    |
[INFO] [stderr] 41 |     return Ok(())
[INFO] [stderr]    |     ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/opts.rs:37:56
[INFO] [stderr]    |
[INFO] [stderr] 37 |         let output_dir = matches.opt_str(SHORT_OUTDIR).ok_or(err_msg("Output directory missing"))?;
[INFO] [stderr]    |                                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("Output directory missing"))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] error: for loop over `extract_crate_from_mod(&mut item.node)`, which is an `Option`. This is more readably written as an `if let` statement.
[INFO] [stderr]    --> src/main.rs:124:27
[INFO] [stderr]     |
[INFO] [stderr] 124 |         for rust_crate in extract_crate_from_mod(&mut item.node) {
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::for_loop_over_option)] on by default
[INFO] [stderr]     = help: consider replacing `for rust_crate in extract_crate_from_mod(&mut item.node)` with `if let Some(rust_crate) = extract_crate_from_mod(&mut item.node)`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_loop_over_option
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/main.rs:141:1
[INFO] [stderr]     |
[INFO] [stderr] 141 | / fn extract_crate_from_mod<'a>(node: &'a mut ItemKind) -> Option<Crate> {
[INFO] [stderr] 142 | |     if let ItemKind::Mod(ref mut maybe_items) = *node {
[INFO] [stderr] 143 | |         maybe_items.take().map(make_crate)
[INFO] [stderr] 144 | |     } else {
[INFO] [stderr] 145 | |         None
[INFO] [stderr] 146 | |     }
[INFO] [stderr] 147 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/opts.rs:16:29
[INFO] [stderr]    |
[INFO] [stderr] 16 |         const SHORT_INPUT: &'static str = "i";
[INFO] [stderr]    |                            -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/opts.rs:17:30
[INFO] [stderr]    |
[INFO] [stderr] 17 |         const SHORT_OUTDIR: &'static str = "o";
[INFO] [stderr]    |                             -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/opts.rs:18:28
[INFO] [stderr]    |
[INFO] [stderr] 18 |         const SHORT_HELP: &'static str = "h";
[INFO] [stderr]    |                           -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:41:5
[INFO] [stderr]    |
[INFO] [stderr] 41 |     return Ok(())
[INFO] [stderr]    |     ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `form`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]   --> src/opts.rs:37:56
[INFO] [stderr]    |
[INFO] [stderr] 37 |         let output_dir = matches.opt_str(SHORT_OUTDIR).ok_or(err_msg("Output directory missing"))?;
[INFO] [stderr]    |                                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| err_msg("Output directory missing"))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] error: for loop over `extract_crate_from_mod(&mut item.node)`, which is an `Option`. This is more readably written as an `if let` statement.
[INFO] [stderr]    --> src/main.rs:124:27
[INFO] [stderr]     |
[INFO] [stderr] 124 |         for rust_crate in extract_crate_from_mod(&mut item.node) {
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::for_loop_over_option)] on by default
[INFO] [stderr]     = help: consider replacing `for rust_crate in extract_crate_from_mod(&mut item.node)` with `if let Some(rust_crate) = extract_crate_from_mod(&mut item.node)`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_loop_over_option
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/main.rs:141:1
[INFO] [stderr]     |
[INFO] [stderr] 141 | / fn extract_crate_from_mod<'a>(node: &'a mut ItemKind) -> Option<Crate> {
[INFO] [stderr] 142 | |     if let ItemKind::Mod(ref mut maybe_items) = *node {
[INFO] [stderr] 143 | |         maybe_items.take().map(make_crate)
[INFO] [stderr] 144 | |     } else {
[INFO] [stderr] 145 | |         None
[INFO] [stderr] 146 | |     }
[INFO] [stderr] 147 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `form`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "6f62aee9fc1ee4408687336b66fd6d290c6ae262dd2a8d413417b1726b154451"`
[INFO] running `"docker" "rm" "-f" "6f62aee9fc1ee4408687336b66fd6d290c6ae262dd2a8d413417b1726b154451"`
[INFO] [stdout] 6f62aee9fc1ee4408687336b66fd6d290c6ae262dd2a8d413417b1726b154451