[INFO] crate font-loader 0.7.0 is already in cache [INFO] extracting crate font-loader 0.7.0 into work/ex/clippy-test-run/sources/stable/reg/font-loader/0.7.0 [INFO] extracting crate font-loader 0.7.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/font-loader/0.7.0 [INFO] validating manifest of font-loader-0.7.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of font-loader-0.7.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing font-loader-0.7.0 [INFO] finished frobbing font-loader-0.7.0 [INFO] frobbed toml for font-loader-0.7.0 written to work/ex/clippy-test-run/sources/stable/reg/font-loader/0.7.0/Cargo.toml [INFO] started frobbing font-loader-0.7.0 [INFO] finished frobbing font-loader-0.7.0 [INFO] frobbed toml for font-loader-0.7.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/font-loader/0.7.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting font-loader-0.7.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/font-loader/0.7.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9af7c9384480af3799db625a4d74bd304169d941a522b846a181f6dd50547528 [INFO] running `"docker" "start" "-a" "9af7c9384480af3799db625a4d74bd304169d941a522b846a181f6dd50547528"` [INFO] [stderr] Checking servo-fontconfig v0.4.0 [INFO] [stderr] Checking font-loader v0.7.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fontconfig.rs:106:35 [INFO] [stderr] | [INFO] [stderr] 106 | FontPropertyBuilder { property: property } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `property` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fontconfig.rs:106:35 [INFO] [stderr] | [INFO] [stderr] 106 | FontPropertyBuilder { property: property } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `property` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `fontconfig::system_fonts::FontPropertyBuilder` [INFO] [stderr] --> src/fontconfig.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | / pub fn new() -> FontPropertyBuilder { [INFO] [stderr] 100 | | let property = FontProperty { [INFO] [stderr] 101 | | slant: FC_SLANT_ROMAN, [INFO] [stderr] 102 | | weight: FC_WEIGHT_REGULAR, [INFO] [stderr] ... | [INFO] [stderr] 106 | | FontPropertyBuilder { property: property } [INFO] [stderr] 107 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 98 | impl Default for fontconfig::system_fonts::FontPropertyBuilder { [INFO] [stderr] 99 | fn default() -> Self { [INFO] [stderr] 100 | Self::new() [INFO] [stderr] 101 | } [INFO] [stderr] 102 | } [INFO] [stderr] 103 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/fontconfig.rs:189:13 [INFO] [stderr] | [INFO] [stderr] 189 | property.spacing.map(|spacing| add_int(pattern, FC_SPACING, spacing)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(spacing) = property.spacing { add_int(pattern, FC_SPACING, spacing) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `fontconfig::system_fonts::FontPropertyBuilder` [INFO] [stderr] --> src/fontconfig.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | / pub fn new() -> FontPropertyBuilder { [INFO] [stderr] 100 | | let property = FontProperty { [INFO] [stderr] 101 | | slant: FC_SLANT_ROMAN, [INFO] [stderr] 102 | | weight: FC_WEIGHT_REGULAR, [INFO] [stderr] ... | [INFO] [stderr] 106 | | FontPropertyBuilder { property: property } [INFO] [stderr] 107 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 98 | impl Default for fontconfig::system_fonts::FontPropertyBuilder { [INFO] [stderr] 99 | fn default() -> Self { [INFO] [stderr] 100 | Self::new() [INFO] [stderr] 101 | } [INFO] [stderr] 102 | } [INFO] [stderr] 103 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/fontconfig.rs:189:13 [INFO] [stderr] | [INFO] [stderr] 189 | property.spacing.map(|spacing| add_int(pattern, FC_SPACING, spacing)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(spacing) = property.spacing { add_int(pattern, FC_SPACING, spacing) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.86s [INFO] running `"docker" "inspect" "9af7c9384480af3799db625a4d74bd304169d941a522b846a181f6dd50547528"` [INFO] running `"docker" "rm" "-f" "9af7c9384480af3799db625a4d74bd304169d941a522b846a181f6dd50547528"` [INFO] [stdout] 9af7c9384480af3799db625a4d74bd304169d941a522b846a181f6dd50547528