[INFO] crate font-kit 0.1.0 is already in cache [INFO] extracting crate font-kit 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/font-kit/0.1.0 [INFO] extracting crate font-kit 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/font-kit/0.1.0 [INFO] validating manifest of font-kit-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of font-kit-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing font-kit-0.1.0 [INFO] finished frobbing font-kit-0.1.0 [INFO] frobbed toml for font-kit-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/font-kit/0.1.0/Cargo.toml [INFO] started frobbing font-kit-0.1.0 [INFO] finished frobbing font-kit-0.1.0 [INFO] frobbed toml for font-kit-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/font-kit/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting font-kit-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/font-kit/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] db32329403cb8b15cf98e196930596728c7c5c3f475883824efaa0c16cff79df [INFO] running `"docker" "start" "-a" "db32329403cb8b15cf98e196930596728c7c5c3f475883824efaa0c16cff79df"` [INFO] [stderr] Compiling expat-sys v2.1.6 [INFO] [stderr] Compiling euclid_macros v0.1.0 [INFO] [stderr] Compiling servo-fontconfig-sys v4.0.7 [INFO] [stderr] Checking euclid v0.19.5 [INFO] [stderr] Checking lyon_geom v0.12.2 [INFO] [stderr] Checking lyon_path v0.12.0 [INFO] [stderr] Checking servo-fontconfig v0.4.0 [INFO] [stderr] Checking font-kit v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sources/mem.rs:49:21 [INFO] [stderr] | [INFO] [stderr] 49 | postscript_name: postscript_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `postscript_name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/sources/mem.rs:49:21 [INFO] [stderr] | [INFO] [stderr] 49 | postscript_name: postscript_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `postscript_name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/source.rs:46:35 [INFO] [stderr] | [INFO] [stderr] 46 | const DEFAULT_FONT_FAMILY_SERIF: &'static str = "DejaVu Serif"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/source.rs:48:40 [INFO] [stderr] | [INFO] [stderr] 48 | const DEFAULT_FONT_FAMILY_SANS_SERIF: &'static str = "DejaVu Sans"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/source.rs:50:39 [INFO] [stderr] | [INFO] [stderr] 50 | const DEFAULT_FONT_FAMILY_MONOSPACE: &'static str = "DejaVu Sans Mono"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/source.rs:52:37 [INFO] [stderr] | [INFO] [stderr] 52 | const DEFAULT_FONT_FAMILY_CURSIVE: &'static str = "DejaVu Sans"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/source.rs:54:37 [INFO] [stderr] | [INFO] [stderr] 54 | const DEFAULT_FONT_FAMILY_FANTASY: &'static str = "DejaVu Sans"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/sources/fontconfig.rs:40:19 [INFO] [stderr] | [INFO] [stderr] 40 | const FC_FAMILY: &'static [u8] = b"family\0"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/sources/fontconfig.rs:41:17 [INFO] [stderr] | [INFO] [stderr] 41 | const FC_FILE: &'static [u8] = b"file\0"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/sources/fontconfig.rs:42:18 [INFO] [stderr] | [INFO] [stderr] 42 | const FC_INDEX: &'static [u8] = b"index\0"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/sources/fontconfig.rs:43:28 [INFO] [stderr] | [INFO] [stderr] 43 | const FC_POSTSCRIPT_NAME: &'static [u8] = b"postscriptname\0"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/source.rs:46:35 [INFO] [stderr] | [INFO] [stderr] 46 | const DEFAULT_FONT_FAMILY_SERIF: &'static str = "DejaVu Serif"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/source.rs:48:40 [INFO] [stderr] | [INFO] [stderr] 48 | const DEFAULT_FONT_FAMILY_SANS_SERIF: &'static str = "DejaVu Sans"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/source.rs:50:39 [INFO] [stderr] | [INFO] [stderr] 50 | const DEFAULT_FONT_FAMILY_MONOSPACE: &'static str = "DejaVu Sans Mono"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/source.rs:52:37 [INFO] [stderr] | [INFO] [stderr] 52 | const DEFAULT_FONT_FAMILY_CURSIVE: &'static str = "DejaVu Sans"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/source.rs:54:37 [INFO] [stderr] | [INFO] [stderr] 54 | const DEFAULT_FONT_FAMILY_FANTASY: &'static str = "DejaVu Sans"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/sources/fontconfig.rs:40:19 [INFO] [stderr] | [INFO] [stderr] 40 | const FC_FAMILY: &'static [u8] = b"family\0"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/sources/fontconfig.rs:41:17 [INFO] [stderr] | [INFO] [stderr] 41 | const FC_FILE: &'static [u8] = b"file\0"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/sources/fontconfig.rs:42:18 [INFO] [stderr] | [INFO] [stderr] 42 | const FC_INDEX: &'static [u8] = b"index\0"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/sources/fontconfig.rs:43:28 [INFO] [stderr] | [INFO] [stderr] 43 | const FC_POSTSCRIPT_NAME: &'static [u8] = b"postscriptname\0"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/lib.rs:123:1 [INFO] [stderr] | [INFO] [stderr] 123 | #[allow(unused_imports)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(unused_imports)]` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::useless_attribute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] warning: the loop variable `byte` is used to index `lut` [INFO] [stderr] --> src/canvas.rs:21:21 [INFO] [stderr] | [INFO] [stderr] 21 | for byte in 0..0x100 { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 21 | for (byte, ) in lut.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `bit` is used to index `value` [INFO] [stderr] --> src/canvas.rs:23:24 [INFO] [stderr] | [INFO] [stderr] 23 | for bit in 0..8 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 23 | for (bit, ) in value.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/canvas.rs:53:22 [INFO] [stderr] | [INFO] [stderr] 53 | pub fn new(size: &Size2D, format: Format) -> Canvas { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `Size2D` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/canvas.rs:61:30 [INFO] [stderr] | [INFO] [stderr] 61 | pub fn with_stride(size: &Size2D, stride: usize, format: Format) -> Canvas { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `Size2D` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/canvas.rs:78:39 [INFO] [stderr] | [INFO] [stderr] 78 | src_size: &Size2D, [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `Size2D` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/canvas.rs:107:51 [INFO] [stderr] | [INFO] [stderr] 107 | src_size: &Size2D, [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `Size2D` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `family_handle::FamilyHandle` [INFO] [stderr] --> src/family_handle.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | / pub fn new() -> FamilyHandle { [INFO] [stderr] 25 | | FamilyHandle { [INFO] [stderr] 26 | | fonts: vec![], [INFO] [stderr] 27 | | } [INFO] [stderr] 28 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 17 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/hinting.rs:48:30 [INFO] [stderr] | [INFO] [stderr] 48 | pub fn grid_fitting_size(&self) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/loader.rs:166:30 [INFO] [stderr] | [INFO] [stderr] 166 | origin: &Point2D, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `Point2D` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/loader.rs:189:32 [INFO] [stderr] | [INFO] [stderr] 189 | origin: &Point2D, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `Point2D` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/loaders/freetype.rs:131:39 [INFO] [stderr] | [INFO] [stderr] 131 | font_index as FT_Long, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(font_index)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/loaders/freetype.rs:158:39 [INFO] [stderr] | [INFO] [stderr] 158 | font_index as FT_Long, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(font_index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/loaders/freetype.rs:325:48 [INFO] [stderr] | [INFO] [stderr] 325 | (*self.freetype_face).face_flags & (FT_FACE_FLAG_FIXED_WIDTH as i64) != 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(FT_FACE_FLAG_FIXED_WIDTH)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/loaders/freetype.rs:337:59 [INFO] [stderr] | [INFO] [stderr] 337 | _ if ((*self.freetype_face).style_flags & (FT_STYLE_FLAG_ITALIC) as i64) != 0 => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from((FT_STYLE_FLAG_ITALIC))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/loaders/freetype.rs:350:43 [INFO] [stderr] | [INFO] [stderr] 350 | Some(os2_table) => Weight((*os2_table).usWeightClass as u32 as f32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from((*os2_table).usWeightClass)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/loaders/freetype.rs:526:35 [INFO] [stderr] | [INFO] [stderr] 526 | point_position *= (units_per_em as f32) / grid_fitting_size [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(units_per_em)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/loaders/freetype.rs:581:31 [INFO] [stderr] | [INFO] [stderr] 581 | units_per_em: (*self.freetype_face).units_per_EM as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from((*self.freetype_face).units_per_EM)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/loaders/freetype.rs:582:25 [INFO] [stderr] | [INFO] [stderr] 582 | ascent: ascender as f32, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f32::from(ascender)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/loaders/freetype.rs:583:26 [INFO] [stderr] | [INFO] [stderr] 583 | descent: descender as f32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f32::from(descender)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/loaders/freetype.rs:584:27 [INFO] [stderr] | [INFO] [stderr] 584 | line_gap: ((*self.freetype_face).height + descender - ascender) as f32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from((*self.freetype_face).height + descender - ascender)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/loaders/freetype.rs:585:37 [INFO] [stderr] | [INFO] [stderr] 585 | underline_position: (underline_position + underline_thickness / 2) as f32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(underline_position + underline_thickness / 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/loaders/freetype.rs:586:38 [INFO] [stderr] | [INFO] [stderr] 586 | underline_thickness: underline_thickness as f32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(underline_thickness)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/loaders/freetype.rs:587:51 [INFO] [stderr] | [INFO] [stderr] 587 | cap_height: os2_table.map(|table| (*table).sCapHeight as f32).unwrap_or(0.0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from((*table).sCapHeight)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/loaders/freetype.rs:588:49 [INFO] [stderr] | [INFO] [stderr] 588 | x_height: os2_table.map(|table| (*table).sxHeight as f32).unwrap_or(0.0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from((*table).sxHeight)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/loaders/freetype.rs:683:34 [INFO] [stderr] | [INFO] [stderr] 683 | origin: &Point2D, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `Point2D` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/loaders/freetype.rs:708:36 [INFO] [stderr] | [INFO] [stderr] 708 | origin: &Point2D, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `Point2D` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/loaders/freetype.rs:979:24 [INFO] [stderr] | [INFO] [stderr] 979 | let units_per_em = (*face).units_per_EM as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from((*face).units_per_EM)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/loaders/freetype.rs:981:43 [INFO] [stderr] | [INFO] [stderr] 981 | assert_eq!(FT_Set_Char_Size(face, ((*face).units_per_EM as i64) << 6, 0, 0, 0), 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from((*face).units_per_EM)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `sources::fontconfig::FontconfigSource` [INFO] [stderr] --> src/sources/fontconfig.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | / pub fn new() -> FontconfigSource { [INFO] [stderr] 58 | | unsafe { [INFO] [stderr] 59 | | FontconfigSource { [INFO] [stderr] 60 | | fontconfig: FcInitLoadConfigAndFonts(), [INFO] [stderr] 61 | | } [INFO] [stderr] 62 | | } [INFO] [stderr] 63 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 55 | impl Default for sources::fontconfig::FontconfigSource { [INFO] [stderr] 56 | fn default() -> Self { [INFO] [stderr] 57 | Self::new() [INFO] [stderr] 58 | } [INFO] [stderr] 59 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `sources::fs::FsSource` [INFO] [stderr] --> src/sources/fs.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | / pub fn new() -> FsSource { [INFO] [stderr] 58 | | let mut fonts = vec![]; [INFO] [stderr] 59 | | for font_directory in default_font_directories() { [INFO] [stderr] 60 | | for directory_entry in WalkDir::new(font_directory).into_iter() { [INFO] [stderr] ... | [INFO] [stderr] 84 | | } [INFO] [stderr] 85 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 51 | impl Default for sources::fs::FsSource { [INFO] [stderr] 52 | fn default() -> Self { [INFO] [stderr] 53 | Self::new() [INFO] [stderr] 54 | } [INFO] [stderr] 55 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/sources/mem.rs:89:39 [INFO] [stderr] | [INFO] [stderr] 89 | let families = &self.families[first_family_index..(last_family_index + 1)]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `first_family_index..=last_family_index` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/matching.rs:36:45 [INFO] [stderr] | [INFO] [stderr] 36 | if matching_set.iter().any(|&index| { [INFO] [stderr] | _____________________________________________^ [INFO] [stderr] 37 | | candidates[index].properties.stretch == query.stretch [INFO] [stderr] 38 | | }) { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/matching.rs:92:27 [INFO] [stderr] | [INFO] [stderr] 92 | let matching_style = *style_preference.iter().filter(|&query_style| { [INFO] [stderr] | ___________________________^ [INFO] [stderr] 93 | | matching_set.iter().any(|&index| candidates[index].properties.style == *query_style) [INFO] [stderr] 94 | | }).next().unwrap(); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `font-kit`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/lib.rs:123:1 [INFO] [stderr] | [INFO] [stderr] 123 | #[allow(unused_imports)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(unused_imports)]` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::useless_attribute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] warning: the loop variable `byte` is used to index `lut` [INFO] [stderr] --> src/canvas.rs:21:21 [INFO] [stderr] | [INFO] [stderr] 21 | for byte in 0..0x100 { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 21 | for (byte, ) in lut.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `bit` is used to index `value` [INFO] [stderr] --> src/canvas.rs:23:24 [INFO] [stderr] | [INFO] [stderr] 23 | for bit in 0..8 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 23 | for (bit, ) in value.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/canvas.rs:53:22 [INFO] [stderr] | [INFO] [stderr] 53 | pub fn new(size: &Size2D, format: Format) -> Canvas { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `Size2D` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/canvas.rs:61:30 [INFO] [stderr] | [INFO] [stderr] 61 | pub fn with_stride(size: &Size2D, stride: usize, format: Format) -> Canvas { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `Size2D` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/canvas.rs:78:39 [INFO] [stderr] | [INFO] [stderr] 78 | src_size: &Size2D, [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `Size2D` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/canvas.rs:107:51 [INFO] [stderr] | [INFO] [stderr] 107 | src_size: &Size2D, [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `Size2D` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `family_handle::FamilyHandle` [INFO] [stderr] --> src/family_handle.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | / pub fn new() -> FamilyHandle { [INFO] [stderr] 25 | | FamilyHandle { [INFO] [stderr] 26 | | fonts: vec![], [INFO] [stderr] 27 | | } [INFO] [stderr] 28 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 17 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/hinting.rs:48:30 [INFO] [stderr] | [INFO] [stderr] 48 | pub fn grid_fitting_size(&self) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/loader.rs:166:30 [INFO] [stderr] | [INFO] [stderr] 166 | origin: &Point2D, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `Point2D` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/loader.rs:189:32 [INFO] [stderr] | [INFO] [stderr] 189 | origin: &Point2D, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `Point2D` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/loaders/freetype.rs:131:39 [INFO] [stderr] | [INFO] [stderr] 131 | font_index as FT_Long, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(font_index)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/loaders/freetype.rs:158:39 [INFO] [stderr] | [INFO] [stderr] 158 | font_index as FT_Long, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(font_index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/loaders/freetype.rs:325:48 [INFO] [stderr] | [INFO] [stderr] 325 | (*self.freetype_face).face_flags & (FT_FACE_FLAG_FIXED_WIDTH as i64) != 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(FT_FACE_FLAG_FIXED_WIDTH)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/loaders/freetype.rs:337:59 [INFO] [stderr] | [INFO] [stderr] 337 | _ if ((*self.freetype_face).style_flags & (FT_STYLE_FLAG_ITALIC) as i64) != 0 => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from((FT_STYLE_FLAG_ITALIC))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/loaders/freetype.rs:350:43 [INFO] [stderr] | [INFO] [stderr] 350 | Some(os2_table) => Weight((*os2_table).usWeightClass as u32 as f32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from((*os2_table).usWeightClass)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/loaders/freetype.rs:526:35 [INFO] [stderr] | [INFO] [stderr] 526 | point_position *= (units_per_em as f32) / grid_fitting_size [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(units_per_em)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/loaders/freetype.rs:581:31 [INFO] [stderr] | [INFO] [stderr] 581 | units_per_em: (*self.freetype_face).units_per_EM as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from((*self.freetype_face).units_per_EM)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/loaders/freetype.rs:582:25 [INFO] [stderr] | [INFO] [stderr] 582 | ascent: ascender as f32, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f32::from(ascender)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/loaders/freetype.rs:583:26 [INFO] [stderr] | [INFO] [stderr] 583 | descent: descender as f32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f32::from(descender)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/loaders/freetype.rs:584:27 [INFO] [stderr] | [INFO] [stderr] 584 | line_gap: ((*self.freetype_face).height + descender - ascender) as f32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from((*self.freetype_face).height + descender - ascender)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/loaders/freetype.rs:585:37 [INFO] [stderr] | [INFO] [stderr] 585 | underline_position: (underline_position + underline_thickness / 2) as f32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(underline_position + underline_thickness / 2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/loaders/freetype.rs:586:38 [INFO] [stderr] | [INFO] [stderr] 586 | underline_thickness: underline_thickness as f32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(underline_thickness)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/loaders/freetype.rs:587:51 [INFO] [stderr] | [INFO] [stderr] 587 | cap_height: os2_table.map(|table| (*table).sCapHeight as f32).unwrap_or(0.0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from((*table).sCapHeight)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/loaders/freetype.rs:588:49 [INFO] [stderr] | [INFO] [stderr] 588 | x_height: os2_table.map(|table| (*table).sxHeight as f32).unwrap_or(0.0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from((*table).sxHeight)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/loaders/freetype.rs:683:34 [INFO] [stderr] | [INFO] [stderr] 683 | origin: &Point2D, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `Point2D` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/loaders/freetype.rs:708:36 [INFO] [stderr] | [INFO] [stderr] 708 | origin: &Point2D, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `Point2D` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/loaders/freetype.rs:979:24 [INFO] [stderr] | [INFO] [stderr] 979 | let units_per_em = (*face).units_per_EM as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from((*face).units_per_EM)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/loaders/freetype.rs:981:43 [INFO] [stderr] | [INFO] [stderr] 981 | assert_eq!(FT_Set_Char_Size(face, ((*face).units_per_EM as i64) << 6, 0, 0, 0), 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from((*face).units_per_EM)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `sources::fontconfig::FontconfigSource` [INFO] [stderr] --> src/sources/fontconfig.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | / pub fn new() -> FontconfigSource { [INFO] [stderr] 58 | | unsafe { [INFO] [stderr] 59 | | FontconfigSource { [INFO] [stderr] 60 | | fontconfig: FcInitLoadConfigAndFonts(), [INFO] [stderr] 61 | | } [INFO] [stderr] 62 | | } [INFO] [stderr] 63 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 55 | impl Default for sources::fontconfig::FontconfigSource { [INFO] [stderr] 56 | fn default() -> Self { [INFO] [stderr] 57 | Self::new() [INFO] [stderr] 58 | } [INFO] [stderr] 59 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `sources::fs::FsSource` [INFO] [stderr] --> src/sources/fs.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | / pub fn new() -> FsSource { [INFO] [stderr] 58 | | let mut fonts = vec![]; [INFO] [stderr] 59 | | for font_directory in default_font_directories() { [INFO] [stderr] 60 | | for directory_entry in WalkDir::new(font_directory).into_iter() { [INFO] [stderr] ... | [INFO] [stderr] 84 | | } [INFO] [stderr] 85 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 51 | impl Default for sources::fs::FsSource { [INFO] [stderr] 52 | fn default() -> Self { [INFO] [stderr] 53 | Self::new() [INFO] [stderr] 54 | } [INFO] [stderr] 55 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/sources/mem.rs:89:39 [INFO] [stderr] | [INFO] [stderr] 89 | let families = &self.families[first_family_index..(last_family_index + 1)]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `first_family_index..=last_family_index` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/test.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | assert!(family.fonts().len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!family.fonts().is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/test.rs:407:5 [INFO] [stderr] | [INFO] [stderr] 407 | assert_eq!(metrics.ascent, 1901.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/test.rs:407:5 [INFO] [stderr] | [INFO] [stderr] 407 | assert_eq!(metrics.ascent, 1901.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/test.rs:408:5 [INFO] [stderr] | [INFO] [stderr] 408 | assert_eq!(metrics.descent, -483.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/test.rs:408:5 [INFO] [stderr] | [INFO] [stderr] 408 | assert_eq!(metrics.descent, -483.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/test.rs:409:5 [INFO] [stderr] | [INFO] [stderr] 409 | assert_eq!(metrics.line_gap, 0.0); // FIXME(pcwalton): Huh?! [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/test.rs:409:5 [INFO] [stderr] | [INFO] [stderr] 409 | assert_eq!(metrics.line_gap, 0.0); // FIXME(pcwalton): Huh?! [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/test.rs:410:5 [INFO] [stderr] | [INFO] [stderr] 410 | assert_eq!(metrics.underline_position, -130.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/test.rs:410:5 [INFO] [stderr] | [INFO] [stderr] 410 | assert_eq!(metrics.underline_position, -130.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/test.rs:411:5 [INFO] [stderr] | [INFO] [stderr] 411 | assert_eq!(metrics.underline_thickness, 90.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/test.rs:411:5 [INFO] [stderr] | [INFO] [stderr] 411 | assert_eq!(metrics.underline_thickness, 90.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/test.rs:412:5 [INFO] [stderr] | [INFO] [stderr] 412 | assert_eq!(metrics.cap_height, 0.0); // FIXME(pcwalton): Huh?! [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/test.rs:412:5 [INFO] [stderr] | [INFO] [stderr] 412 | assert_eq!(metrics.cap_height, 0.0); // FIXME(pcwalton): Huh?! [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/test.rs:413:5 [INFO] [stderr] | [INFO] [stderr] 413 | assert_eq!(metrics.x_height, 0.0); // FIXME(pcwalton): Huh?! [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/test.rs:413:5 [INFO] [stderr] | [INFO] [stderr] 413 | assert_eq!(metrics.x_height, 0.0); // FIXME(pcwalton): Huh?! [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/matching.rs:36:45 [INFO] [stderr] | [INFO] [stderr] 36 | if matching_set.iter().any(|&index| { [INFO] [stderr] | _____________________________________________^ [INFO] [stderr] 37 | | candidates[index].properties.stretch == query.stretch [INFO] [stderr] 38 | | }) { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/matching.rs:92:27 [INFO] [stderr] | [INFO] [stderr] 92 | let matching_style = *style_preference.iter().filter(|&query_style| { [INFO] [stderr] | ___________________________^ [INFO] [stderr] 93 | | matching_set.iter().any(|&index| candidates[index].properties.style == *query_style) [INFO] [stderr] 94 | | }).next().unwrap(); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] error: aborting due to 8 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `font-kit`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "db32329403cb8b15cf98e196930596728c7c5c3f475883824efaa0c16cff79df"` [INFO] running `"docker" "rm" "-f" "db32329403cb8b15cf98e196930596728c7c5c3f475883824efaa0c16cff79df"` [INFO] [stdout] db32329403cb8b15cf98e196930596728c7c5c3f475883824efaa0c16cff79df