[INFO] crate font-atlas 0.1.4 is already in cache [INFO] extracting crate font-atlas 0.1.4 into work/ex/clippy-test-run/sources/stable/reg/font-atlas/0.1.4 [INFO] extracting crate font-atlas 0.1.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/font-atlas/0.1.4 [INFO] validating manifest of font-atlas-0.1.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of font-atlas-0.1.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing font-atlas-0.1.4 [INFO] finished frobbing font-atlas-0.1.4 [INFO] frobbed toml for font-atlas-0.1.4 written to work/ex/clippy-test-run/sources/stable/reg/font-atlas/0.1.4/Cargo.toml [INFO] started frobbing font-atlas-0.1.4 [INFO] finished frobbing font-atlas-0.1.4 [INFO] frobbed toml for font-atlas-0.1.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/font-atlas/0.1.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting font-atlas-0.1.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/font-atlas/0.1.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 10f7380ee463eedf17774f8455adbba4af6189df10e17c064a8886a2af163d18 [INFO] running `"docker" "start" "-a" "10f7380ee463eedf17774f8455adbba4af6189df10e17c064a8886a2af163d18"` [INFO] [stderr] Checking font-atlas v0.1.4 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/glyph_packer/skyline_packer.rs:33:17 [INFO] [stderr] | [INFO] [stderr] 33 | let mut y = self.skylines[i].y; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/glyph_packer/skyline_packer.rs:166:13 [INFO] [stderr] | [INFO] [stderr] 166 | buf: buf, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/glyph_packer/skyline_packer.rs:167:13 [INFO] [stderr] | [INFO] [stderr] 167 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/glyph_packer/skyline_packer.rs:168:13 [INFO] [stderr] | [INFO] [stderr] 168 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/glyph_packer/skyline_packer.rs:169:13 [INFO] [stderr] | [INFO] [stderr] 169 | skylines: skylines, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `skylines` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/glyph_packer/rect.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/glyph_packer/rect.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | y: y, [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/glyph_packer/rect.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | w: w, [INFO] [stderr] | ^^^^ help: replace it with: `w` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/glyph_packer/rect.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | h: h, [INFO] [stderr] | ^^^^ help: replace it with: `h` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rasterize/mod.rs:165:13 [INFO] [stderr] | [INFO] [stderr] 165 | chr: chr, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `chr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rasterize/mod.rs:166:13 [INFO] [stderr] | [INFO] [stderr] 166 | scale: scale, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `scale` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cache/mod.rs:149:17 [INFO] [stderr] | [INFO] [stderr] 149 | font: font, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `font` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cache/mod.rs:150:17 [INFO] [stderr] | [INFO] [stderr] 150 | atlas: atlas, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `atlas` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cache/mod.rs:151:17 [INFO] [stderr] | [INFO] [stderr] 151 | bitmap: bitmap, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bitmap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cache/mod.rs:152:17 [INFO] [stderr] | [INFO] [stderr] 152 | scale: scale, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `scale` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cache/mod.rs:155:17 [INFO] [stderr] | [INFO] [stderr] 155 | line_height: line_height, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `line_height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cache/mod.rs:225:17 [INFO] [stderr] | [INFO] [stderr] 225 | bitmap: bitmap, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bitmap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/glyph_packer/skyline_packer.rs:33:17 [INFO] [stderr] | [INFO] [stderr] 33 | let mut y = self.skylines[i].y; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/glyph_packer/skyline_packer.rs:166:13 [INFO] [stderr] | [INFO] [stderr] 166 | buf: buf, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/glyph_packer/skyline_packer.rs:167:13 [INFO] [stderr] | [INFO] [stderr] 167 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/glyph_packer/skyline_packer.rs:168:13 [INFO] [stderr] | [INFO] [stderr] 168 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/glyph_packer/skyline_packer.rs:169:13 [INFO] [stderr] | [INFO] [stderr] 169 | skylines: skylines, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `skylines` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/glyph_packer/rect.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/glyph_packer/rect.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | y: y, [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/glyph_packer/rect.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | w: w, [INFO] [stderr] | ^^^^ help: replace it with: `w` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/glyph_packer/rect.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | h: h, [INFO] [stderr] | ^^^^ help: replace it with: `h` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rasterize/mod.rs:165:13 [INFO] [stderr] | [INFO] [stderr] 165 | chr: chr, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `chr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rasterize/mod.rs:166:13 [INFO] [stderr] | [INFO] [stderr] 166 | scale: scale, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `scale` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cache/mod.rs:149:17 [INFO] [stderr] | [INFO] [stderr] 149 | font: font, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `font` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cache/mod.rs:150:17 [INFO] [stderr] | [INFO] [stderr] 150 | atlas: atlas, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `atlas` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cache/mod.rs:151:17 [INFO] [stderr] | [INFO] [stderr] 151 | bitmap: bitmap, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bitmap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cache/mod.rs:152:17 [INFO] [stderr] | [INFO] [stderr] 152 | scale: scale, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `scale` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cache/mod.rs:155:17 [INFO] [stderr] | [INFO] [stderr] 155 | line_height: line_height, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `line_height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cache/mod.rs:225:17 [INFO] [stderr] | [INFO] [stderr] 225 | bitmap: bitmap, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bitmap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cache/mod.rs:89:17 [INFO] [stderr] | [INFO] [stderr] 89 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cache/mod.rs:91:21 [INFO] [stderr] | [INFO] [stderr] 91 | None => return Err(FontCacheError::NoLoadedFont(name.into())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(FontCacheError::NoLoadedFont(name.into()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cache/mod.rs:188:9 [INFO] [stderr] | [INFO] [stderr] 188 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:15:19 [INFO] [stderr] | [INFO] [stderr] 15 | pub const ASCII: &'static [char] = &[ [INFO] [stderr] | -^^^^^^^------- help: consider removing `'static`: `&[char]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cache/mod.rs:89:17 [INFO] [stderr] | [INFO] [stderr] 89 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cache/mod.rs:91:21 [INFO] [stderr] | [INFO] [stderr] 91 | None => return Err(FontCacheError::NoLoadedFont(name.into())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(FontCacheError::NoLoadedFont(name.into()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/cache/mod.rs:188:9 [INFO] [stderr] | [INFO] [stderr] 188 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:15:19 [INFO] [stderr] | [INFO] [stderr] 15 | pub const ASCII: &'static [char] = &[ [INFO] [stderr] | -^^^^^^^------- help: consider removing `'static`: `&[char]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/glyph_packer/buffer2d.rs:17:17 [INFO] [stderr] | [INFO] [stderr] 17 | / match buf.get(sx, sy) { [INFO] [stderr] 18 | | Some(val) => { [INFO] [stderr] 19 | | self.set(x + sx, y + sy, val); [INFO] [stderr] 20 | | }, [INFO] [stderr] 21 | | _ => {}, [INFO] [stderr] 22 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 17 | if let Some(val) = buf.get(sx, sy) { [INFO] [stderr] 18 | self.set(x + sx, y + sy, val); [INFO] [stderr] 19 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/glyph_packer/buffer2d.rs:33:17 [INFO] [stderr] | [INFO] [stderr] 33 | / match buf.get(sx, sy) { [INFO] [stderr] 34 | | Some(val) => { [INFO] [stderr] 35 | | self.set(x + h - sy - 1, y + sx, val); [INFO] [stderr] 36 | | }, [INFO] [stderr] 37 | | _ => {}, [INFO] [stderr] 38 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 33 | if let Some(val) = buf.get(sx, sy) { [INFO] [stderr] 34 | self.set(x + h - sy - 1, y + sx, val); [INFO] [stderr] 35 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `cache::FontCache` [INFO] [stderr] --> src/cache/mod.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | / pub fn new() -> FontCache { [INFO] [stderr] 60 | | FontCache { [INFO] [stderr] 61 | | base_font: HashMap::new(), [INFO] [stderr] 62 | | cached: Vec::new(), [INFO] [stderr] 63 | | } [INFO] [stderr] 64 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 14 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/cache/mod.rs:81:65 [INFO] [stderr] | [INFO] [stderr] 81 | if self.cached.iter().any(|&(ref n, s, _)| n == name && scale == s) { [INFO] [stderr] | ^^^^^^^^^^ help: consider comparing them within some error: `(scale - s).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/cache/mod.rs:81:65 [INFO] [stderr] | [INFO] [stderr] 81 | if self.cached.iter().any(|&(ref n, s, _)| n == name && scale == s) { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/cache/mod.rs:98:59 [INFO] [stderr] | [INFO] [stderr] 98 | .filter(|&&(ref n, s, _)| n == name && scale == s) [INFO] [stderr] | ^^^^^^^^^^ help: consider comparing them within some error: `(scale - s).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/cache/mod.rs:98:59 [INFO] [stderr] | [INFO] [stderr] 98 | .filter(|&&(ref n, s, _)| n == name && scale == s) [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/cache/mod.rs:106:63 [INFO] [stderr] | [INFO] [stderr] 106 | .filter(|&&mut (ref n, s, _)| n == name && scale == s) [INFO] [stderr] | ^^^^^^^^^^ help: consider comparing them within some error: `(scale - s).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/cache/mod.rs:106:63 [INFO] [stderr] | [INFO] [stderr] 106 | .filter(|&&mut (ref n, s, _)| n == name && scale == s) [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cache/mod.rs:115:61 [INFO] [stderr] | [INFO] [stderr] 115 | let fc = try!(self.get_face_cache(font_name, scale).ok_or(FontCacheError::NoRenderedFace(font_name.into(), scale))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| FontCacheError::NoRenderedFace(font_name.into(), scale))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/cache/mod.rs:127:69 [INFO] [stderr] | [INFO] [stderr] 127 | try!(self.create_face(font_name, scale, string.chars(), |a| f(a))); [INFO] [stderr] | ^^^^^^^^ help: remove closure as shown: `f` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cache/mod.rs:213:26 [INFO] [stderr] | [INFO] [stderr] 213 | bitmap = self.missing.get(&c).unwrap().as_ref().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.missing[&c]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `font-atlas`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/glyph_packer/buffer2d.rs:17:17 [INFO] [stderr] | [INFO] [stderr] 17 | / match buf.get(sx, sy) { [INFO] [stderr] 18 | | Some(val) => { [INFO] [stderr] 19 | | self.set(x + sx, y + sy, val); [INFO] [stderr] 20 | | }, [INFO] [stderr] 21 | | _ => {}, [INFO] [stderr] 22 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 17 | if let Some(val) = buf.get(sx, sy) { [INFO] [stderr] 18 | self.set(x + sx, y + sy, val); [INFO] [stderr] 19 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/glyph_packer/buffer2d.rs:33:17 [INFO] [stderr] | [INFO] [stderr] 33 | / match buf.get(sx, sy) { [INFO] [stderr] 34 | | Some(val) => { [INFO] [stderr] 35 | | self.set(x + h - sy - 1, y + sx, val); [INFO] [stderr] 36 | | }, [INFO] [stderr] 37 | | _ => {}, [INFO] [stderr] 38 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 33 | if let Some(val) = buf.get(sx, sy) { [INFO] [stderr] 34 | self.set(x + h - sy - 1, y + sx, val); [INFO] [stderr] 35 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `cache::FontCache` [INFO] [stderr] --> src/cache/mod.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | / pub fn new() -> FontCache { [INFO] [stderr] 60 | | FontCache { [INFO] [stderr] 61 | | base_font: HashMap::new(), [INFO] [stderr] 62 | | cached: Vec::new(), [INFO] [stderr] 63 | | } [INFO] [stderr] 64 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 14 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/cache/mod.rs:81:65 [INFO] [stderr] | [INFO] [stderr] 81 | if self.cached.iter().any(|&(ref n, s, _)| n == name && scale == s) { [INFO] [stderr] | ^^^^^^^^^^ help: consider comparing them within some error: `(scale - s).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/cache/mod.rs:81:65 [INFO] [stderr] | [INFO] [stderr] 81 | if self.cached.iter().any(|&(ref n, s, _)| n == name && scale == s) { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/cache/mod.rs:98:59 [INFO] [stderr] | [INFO] [stderr] 98 | .filter(|&&(ref n, s, _)| n == name && scale == s) [INFO] [stderr] | ^^^^^^^^^^ help: consider comparing them within some error: `(scale - s).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/cache/mod.rs:98:59 [INFO] [stderr] | [INFO] [stderr] 98 | .filter(|&&(ref n, s, _)| n == name && scale == s) [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/cache/mod.rs:106:63 [INFO] [stderr] | [INFO] [stderr] 106 | .filter(|&&mut (ref n, s, _)| n == name && scale == s) [INFO] [stderr] | ^^^^^^^^^^ help: consider comparing them within some error: `(scale - s).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/cache/mod.rs:106:63 [INFO] [stderr] | [INFO] [stderr] 106 | .filter(|&&mut (ref n, s, _)| n == name && scale == s) [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cache/mod.rs:115:61 [INFO] [stderr] | [INFO] [stderr] 115 | let fc = try!(self.get_face_cache(font_name, scale).ok_or(FontCacheError::NoRenderedFace(font_name.into(), scale))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| FontCacheError::NoRenderedFace(font_name.into(), scale))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/cache/mod.rs:127:69 [INFO] [stderr] | [INFO] [stderr] 127 | try!(self.create_face(font_name, scale, string.chars(), |a| f(a))); [INFO] [stderr] | ^^^^^^^^ help: remove closure as shown: `f` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/cache/mod.rs:213:26 [INFO] [stderr] | [INFO] [stderr] 213 | bitmap = self.missing.get(&c).unwrap().as_ref().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.missing[&c]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `font-atlas`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "10f7380ee463eedf17774f8455adbba4af6189df10e17c064a8886a2af163d18"` [INFO] running `"docker" "rm" "-f" "10f7380ee463eedf17774f8455adbba4af6189df10e17c064a8886a2af163d18"` [INFO] [stdout] 10f7380ee463eedf17774f8455adbba4af6189df10e17c064a8886a2af163d18