[INFO] crate font 0.3.2 is already in cache [INFO] extracting crate font 0.3.2 into work/ex/clippy-test-run/sources/stable/reg/font/0.3.2 [INFO] extracting crate font 0.3.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/font/0.3.2 [INFO] validating manifest of font-0.3.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of font-0.3.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing font-0.3.2 [INFO] removed 0 missing tests [INFO] finished frobbing font-0.3.2 [INFO] frobbed toml for font-0.3.2 written to work/ex/clippy-test-run/sources/stable/reg/font/0.3.2/Cargo.toml [INFO] started frobbing font-0.3.2 [INFO] removed 0 missing tests [INFO] finished frobbing font-0.3.2 [INFO] frobbed toml for font-0.3.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/font/0.3.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting font-0.3.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/font/0.3.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c7bdbf457d2fb7537c6243cd8c570b41fd6457ba2cbae81409fed6bc9794d5f1 [INFO] running `"docker" "start" "-a" "c7bdbf457d2fb7537c6243cd8c570b41fd6457ba2cbae81409fed6bc9794d5f1"` [INFO] [stderr] warning: An explicit [[test]] section is specified in Cargo.toml which currently [INFO] [stderr] disables Cargo from automatically inferring other test targets. [INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following [INFO] [stderr] files will be included as a test target: [INFO] [stderr] [INFO] [stderr] * /opt/crater/workdir/tests/ttf.rs [INFO] [stderr] * /opt/crater/workdir/tests/cff.rs [INFO] [stderr] [INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be [INFO] [stderr] ready to be compiled as a test target today. You can future-proof yourself [INFO] [stderr] and disable this warning by adding `autotests = false` to your [package] [INFO] [stderr] section. You may also move the files to a location where Cargo would not [INFO] [stderr] automatically infer them to be a target, such as in subfolders. [INFO] [stderr] [INFO] [stderr] For more information on this warning you can consult [INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330 [INFO] [stderr] Checking postscript v0.11.1 [INFO] [stderr] Checking truetype v0.22.0 [INFO] [stderr] Checking opentype v0.17.1 [INFO] [stderr] Checking font v0.3.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/format/opentype/metrics.rs:14:22 [INFO] [stderr] | [INFO] [stderr] 14 | Ok(Metrics { header: header, metrics: metrics }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/format/opentype/metrics.rs:14:38 [INFO] [stderr] | [INFO] [stderr] 14 | Ok(Metrics { header: header, metrics: metrics }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `metrics` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/format/opentype/postscript.rs:24:22 [INFO] [stderr] | [INFO] [stderr] 24 | PostScript { id: id, font_set: font_set, metrics: metrics, mapping: mapping } [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/format/opentype/postscript.rs:24:30 [INFO] [stderr] | [INFO] [stderr] 24 | PostScript { id: id, font_set: font_set, metrics: metrics, mapping: mapping } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `font_set` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/format/opentype/postscript.rs:24:50 [INFO] [stderr] | [INFO] [stderr] 24 | PostScript { id: id, font_set: font_set, metrics: metrics, mapping: mapping } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `metrics` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/format/opentype/postscript.rs:24:68 [INFO] [stderr] | [INFO] [stderr] 24 | PostScript { id: id, font_set: font_set, metrics: metrics, mapping: mapping } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `mapping` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/format/opentype/truetype.rs:23:20 [INFO] [stderr] | [INFO] [stderr] 23 | TrueType { glyph_data: glyph_data, metrics: metrics, mapping: mapping } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `glyph_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/format/opentype/truetype.rs:23:44 [INFO] [stderr] | [INFO] [stderr] 23 | TrueType { glyph_data: glyph_data, metrics: metrics, mapping: mapping } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `metrics` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/format/opentype/truetype.rs:23:62 [INFO] [stderr] | [INFO] [stderr] 23 | TrueType { glyph_data: glyph_data, metrics: metrics, mapping: mapping } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `mapping` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/format/opentype/mod.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | case: case, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `case` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/format/opentype/metrics.rs:14:22 [INFO] [stderr] | [INFO] [stderr] 14 | Ok(Metrics { header: header, metrics: metrics }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `header` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/format/opentype/metrics.rs:14:38 [INFO] [stderr] | [INFO] [stderr] 14 | Ok(Metrics { header: header, metrics: metrics }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `metrics` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/format/opentype/postscript.rs:24:22 [INFO] [stderr] | [INFO] [stderr] 24 | PostScript { id: id, font_set: font_set, metrics: metrics, mapping: mapping } [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/format/opentype/postscript.rs:24:30 [INFO] [stderr] | [INFO] [stderr] 24 | PostScript { id: id, font_set: font_set, metrics: metrics, mapping: mapping } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `font_set` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/format/opentype/postscript.rs:24:50 [INFO] [stderr] | [INFO] [stderr] 24 | PostScript { id: id, font_set: font_set, metrics: metrics, mapping: mapping } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `metrics` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/format/opentype/postscript.rs:24:68 [INFO] [stderr] | [INFO] [stderr] 24 | PostScript { id: id, font_set: font_set, metrics: metrics, mapping: mapping } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `mapping` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/format/opentype/truetype.rs:23:20 [INFO] [stderr] | [INFO] [stderr] 23 | TrueType { glyph_data: glyph_data, metrics: metrics, mapping: mapping } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `glyph_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/format/opentype/truetype.rs:23:44 [INFO] [stderr] | [INFO] [stderr] 23 | TrueType { glyph_data: glyph_data, metrics: metrics, mapping: mapping } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `metrics` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/format/opentype/truetype.rs:23:62 [INFO] [stderr] | [INFO] [stderr] 23 | TrueType { glyph_data: glyph_data, metrics: metrics, mapping: mapping } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `mapping` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/format/opentype/mod.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | case: case, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `case` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/font.rs:31:18 [INFO] [stderr] | [INFO] [stderr] 31 | 1 => return Ok(fonts.remove(0)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(fonts.remove(0))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/font.rs:31:18 [INFO] [stderr] | [INFO] [stderr] 31 | 1 => return Ok(fonts.remove(0)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(fonts.remove(0))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 26 [INFO] [stderr] --> src/format/opentype/postscript.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | / fn draw(&self, glyph: char) -> Result> { [INFO] [stderr] 33 | | use postscript::type2::Operator::*; [INFO] [stderr] 34 | | [INFO] [stderr] 35 | | let index = match self.mapping.find(glyph) { [INFO] [stderr] ... | [INFO] [stderr] 221 | | Ok(Some(builder.into())) [INFO] [stderr] 222 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `j` [INFO] [stderr] --> src/format/opentype/postscript.rs:67:50 [INFO] [stderr] | [INFO] [stderr] 67 | builder.add_linear((get!(j + 0), get!(j + 1))); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `operands` [INFO] [stderr] --> src/format/opentype/postscript.rs:71:30 [INFO] [stderr] | [INFO] [stderr] 71 | for i in 0..count { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 71 | for (i, ) in operands.iter().enumerate().take(count) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `operands` [INFO] [stderr] --> src/format/opentype/postscript.rs:80:30 [INFO] [stderr] | [INFO] [stderr] 80 | for i in 0..count { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 80 | for (i, ) in operands.iter().enumerate().take(count) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `j` [INFO] [stderr] --> src/format/opentype/postscript.rs:93:35 [INFO] [stderr] | [INFO] [stderr] 93 | (get!(j + 0), get!(j + 1)), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `j` [INFO] [stderr] --> src/format/opentype/postscript.rs:110:35 [INFO] [stderr] | [INFO] [stderr] 110 | (get!(j + 0), first), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `j` [INFO] [stderr] --> src/format/opentype/postscript.rs:128:39 [INFO] [stderr] | [INFO] [stderr] 128 | (get!(j + 0), 0.0), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `j` [INFO] [stderr] --> src/format/opentype/postscript.rs:134:52 [INFO] [stderr] | [INFO] [stderr] 134 | ( 0.0, get!(j + 0)), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `j` [INFO] [stderr] --> src/format/opentype/postscript.rs:153:39 [INFO] [stderr] | [INFO] [stderr] 153 | (get!(j + 0), 0.0), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `j` [INFO] [stderr] --> src/format/opentype/postscript.rs:159:52 [INFO] [stderr] | [INFO] [stderr] 159 | ( 0.0, get!(j + 0)), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `j` [INFO] [stderr] --> src/format/opentype/postscript.rs:177:48 [INFO] [stderr] | [INFO] [stderr] 177 | ( first, get!(j + 0)), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `j` [INFO] [stderr] --> src/format/opentype/postscript.rs:188:35 [INFO] [stderr] | [INFO] [stderr] 188 | (get!(j + 0), get!(j + 1)), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `j` [INFO] [stderr] --> src/format/opentype/postscript.rs:194:46 [INFO] [stderr] | [INFO] [stderr] 194 | builder.add_linear((get!(j + 0), get!(j + 1))); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `j` [INFO] [stderr] --> src/format/opentype/postscript.rs:200:50 [INFO] [stderr] | [INFO] [stderr] 200 | builder.add_linear((get!(j + 0), get!(j + 1))); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `j` [INFO] [stderr] --> src/format/opentype/postscript.rs:204:31 [INFO] [stderr] | [INFO] [stderr] 204 | (get!(j + 0), get!(j + 1)), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/format/opentype/truetype.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | / match &glyph.description { [INFO] [stderr] 30 | | &Simple(ref description) => draw_simple(builder, description), [INFO] [stderr] 31 | | &Composite(ref description) => draw_composite(self, builder, description), [INFO] [stderr] 32 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 29 | match glyph.description { [INFO] [stderr] 30 | Simple(ref description) => draw_simple(builder, description), [INFO] [stderr] 31 | Composite(ref description) => draw_composite(self, builder, description), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/format/opentype/truetype.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | / if let &Some(ref glyph) = glyph { [INFO] [stderr] 49 | | try!(self.draw_glyph(&mut builder, glyph)); [INFO] [stderr] 50 | | builder.set_bounding_box(glyph.min_x, glyph.min_y, glyph.max_x, glyph.max_y); [INFO] [stderr] 51 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 48 | if let Some(ref glyph) = *glyph { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/format/opentype/truetype.rs:68:23 [INFO] [stderr] | [INFO] [stderr] 68 | for cursor in (cursor + 1)..(end + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use: `((cursor + 1)..=end)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/format/opentype/truetype.rs:106:9 [INFO] [stderr] | [INFO] [stderr] 106 | / match &component.arguments { [INFO] [stderr] 107 | | &Arguments::Offsets(x, y) => builder.add_compensation((x, y)), [INFO] [stderr] 108 | | &Arguments::Indices(..) => unimplemented!(), [INFO] [stderr] 109 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 106 | match component.arguments { [INFO] [stderr] 107 | Arguments::Offsets(x, y) => builder.add_compensation((x, y)), [INFO] [stderr] 108 | Arguments::Indices(..) => unimplemented!(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/format/opentype/truetype.rs:110:9 [INFO] [stderr] | [INFO] [stderr] 110 | / match &component.options { [INFO] [stderr] 111 | | &Options::None => {}, [INFO] [stderr] 112 | | &Options::Scalar(..) => unimplemented!(), [INFO] [stderr] 113 | | &Options::Vector(..) => unimplemented!(), [INFO] [stderr] 114 | | &Options::Matrix(..) => unimplemented!(), [INFO] [stderr] 115 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 110 | match component.options { [INFO] [stderr] 111 | Options::None => {}, [INFO] [stderr] 112 | Options::Scalar(..) => unimplemented!(), [INFO] [stderr] 113 | Options::Vector(..) => unimplemented!(), [INFO] [stderr] 114 | Options::Matrix(..) => unimplemented!(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 26 [INFO] [stderr] --> src/format/opentype/postscript.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | / fn draw(&self, glyph: char) -> Result> { [INFO] [stderr] 33 | | use postscript::type2::Operator::*; [INFO] [stderr] 34 | | [INFO] [stderr] 35 | | let index = match self.mapping.find(glyph) { [INFO] [stderr] ... | [INFO] [stderr] 221 | | Ok(Some(builder.into())) [INFO] [stderr] 222 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `j` [INFO] [stderr] --> src/format/opentype/postscript.rs:67:50 [INFO] [stderr] | [INFO] [stderr] 67 | builder.add_linear((get!(j + 0), get!(j + 1))); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `operands` [INFO] [stderr] --> src/format/opentype/postscript.rs:71:30 [INFO] [stderr] | [INFO] [stderr] 71 | for i in 0..count { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 71 | for (i, ) in operands.iter().enumerate().take(count) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `operands` [INFO] [stderr] --> src/format/opentype/postscript.rs:80:30 [INFO] [stderr] | [INFO] [stderr] 80 | for i in 0..count { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 80 | for (i, ) in operands.iter().enumerate().take(count) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `j` [INFO] [stderr] --> src/format/opentype/postscript.rs:93:35 [INFO] [stderr] | [INFO] [stderr] 93 | (get!(j + 0), get!(j + 1)), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `j` [INFO] [stderr] --> src/format/opentype/postscript.rs:110:35 [INFO] [stderr] | [INFO] [stderr] 110 | (get!(j + 0), first), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `j` [INFO] [stderr] --> src/format/opentype/postscript.rs:128:39 [INFO] [stderr] | [INFO] [stderr] 128 | (get!(j + 0), 0.0), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `j` [INFO] [stderr] --> src/format/opentype/postscript.rs:134:52 [INFO] [stderr] | [INFO] [stderr] 134 | ( 0.0, get!(j + 0)), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `j` [INFO] [stderr] --> src/format/opentype/postscript.rs:153:39 [INFO] [stderr] | [INFO] [stderr] 153 | (get!(j + 0), 0.0), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `j` [INFO] [stderr] --> src/format/opentype/postscript.rs:159:52 [INFO] [stderr] | [INFO] [stderr] 159 | ( 0.0, get!(j + 0)), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `j` [INFO] [stderr] --> src/format/opentype/postscript.rs:177:48 [INFO] [stderr] | [INFO] [stderr] 177 | ( first, get!(j + 0)), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `j` [INFO] [stderr] --> src/format/opentype/postscript.rs:188:35 [INFO] [stderr] | [INFO] [stderr] 188 | (get!(j + 0), get!(j + 1)), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `j` [INFO] [stderr] --> src/format/opentype/postscript.rs:194:46 [INFO] [stderr] | [INFO] [stderr] 194 | builder.add_linear((get!(j + 0), get!(j + 1))); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `j` [INFO] [stderr] --> src/format/opentype/postscript.rs:200:50 [INFO] [stderr] | [INFO] [stderr] 200 | builder.add_linear((get!(j + 0), get!(j + 1))); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `j` [INFO] [stderr] --> src/format/opentype/postscript.rs:204:31 [INFO] [stderr] | [INFO] [stderr] 204 | (get!(j + 0), get!(j + 1)), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/format/opentype/truetype.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | / match &glyph.description { [INFO] [stderr] 30 | | &Simple(ref description) => draw_simple(builder, description), [INFO] [stderr] 31 | | &Composite(ref description) => draw_composite(self, builder, description), [INFO] [stderr] 32 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 29 | match glyph.description { [INFO] [stderr] 30 | Simple(ref description) => draw_simple(builder, description), [INFO] [stderr] 31 | Composite(ref description) => draw_composite(self, builder, description), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/format/opentype/truetype.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | / if let &Some(ref glyph) = glyph { [INFO] [stderr] 49 | | try!(self.draw_glyph(&mut builder, glyph)); [INFO] [stderr] 50 | | builder.set_bounding_box(glyph.min_x, glyph.min_y, glyph.max_x, glyph.max_y); [INFO] [stderr] 51 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 48 | if let Some(ref glyph) = *glyph { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/format/opentype/truetype.rs:68:23 [INFO] [stderr] | [INFO] [stderr] 68 | for cursor in (cursor + 1)..(end + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: use: `((cursor + 1)..=end)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/format/opentype/truetype.rs:106:9 [INFO] [stderr] | [INFO] [stderr] 106 | / match &component.arguments { [INFO] [stderr] 107 | | &Arguments::Offsets(x, y) => builder.add_compensation((x, y)), [INFO] [stderr] 108 | | &Arguments::Indices(..) => unimplemented!(), [INFO] [stderr] 109 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 106 | match component.arguments { [INFO] [stderr] 107 | Arguments::Offsets(x, y) => builder.add_compensation((x, y)), [INFO] [stderr] 108 | Arguments::Indices(..) => unimplemented!(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/format/opentype/truetype.rs:110:9 [INFO] [stderr] | [INFO] [stderr] 110 | / match &component.options { [INFO] [stderr] 111 | | &Options::None => {}, [INFO] [stderr] 112 | | &Options::Scalar(..) => unimplemented!(), [INFO] [stderr] 113 | | &Options::Vector(..) => unimplemented!(), [INFO] [stderr] 114 | | &Options::Matrix(..) => unimplemented!(), [INFO] [stderr] 115 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 110 | match component.options { [INFO] [stderr] 111 | Options::None => {}, [INFO] [stderr] 112 | Options::Scalar(..) => unimplemented!(), [INFO] [stderr] 113 | Options::Vector(..) => unimplemented!(), [INFO] [stderr] 114 | Options::Matrix(..) => unimplemented!(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> examples/glyph.rs:7:13 [INFO] [stderr] | [INFO] [stderr] 7 | const OTF: &'static str = "tests/fixtures/SourceSerifPro-Regular.otf"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> examples/glyph.rs:8:13 [INFO] [stderr] | [INFO] [stderr] 8 | const SVG: &'static str = "examples/glyph.svg"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> examples/glyph.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | / match segment { [INFO] [stderr] 38 | | &Segment::Linear(b) => { [INFO] [stderr] 39 | | a += b; [INFO] [stderr] 40 | | data = data.line_by(vec![b.0, b.1]); [INFO] [stderr] ... | [INFO] [stderr] 48 | | _ => unreachable!(), [INFO] [stderr] 49 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 37 | match *segment { [INFO] [stderr] 38 | Segment::Linear(b) => { [INFO] [stderr] 39 | a += b; [INFO] [stderr] 40 | data = data.line_by(vec![b.0, b.1]); [INFO] [stderr] 41 | }, [INFO] [stderr] 42 | Segment::Cubic(b, mut c, mut d) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> tests/cff.rs:6:17 [INFO] [stderr] | [INFO] [stderr] 6 | for code in b'a'..(b'z' + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `b'a'..=b'z'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> tests/ttf.rs:68:17 [INFO] [stderr] | [INFO] [stderr] 68 | for code in b'a'..(b'z' + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `b'a'..=b'z'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> tests/lib.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | / match segment { [INFO] [stderr] 31 | | &Linear(a) => { [INFO] [stderr] 32 | | offset += a; [INFO] [stderr] 33 | | }, [INFO] [stderr] ... | [INFO] [stderr] 42 | | }, [INFO] [stderr] 43 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 30 | match *segment { [INFO] [stderr] 31 | Linear(a) => { [INFO] [stderr] 32 | offset += a; [INFO] [stderr] 33 | }, [INFO] [stderr] 34 | Quadratic(a, b) => { [INFO] [stderr] 35 | offset += a; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.24s [INFO] running `"docker" "inspect" "c7bdbf457d2fb7537c6243cd8c570b41fd6457ba2cbae81409fed6bc9794d5f1"` [INFO] running `"docker" "rm" "-f" "c7bdbf457d2fb7537c6243cd8c570b41fd6457ba2cbae81409fed6bc9794d5f1"` [INFO] [stdout] c7bdbf457d2fb7537c6243cd8c570b41fd6457ba2cbae81409fed6bc9794d5f1