[INFO] crate fomat-macros 0.2.1 is already in cache [INFO] extracting crate fomat-macros 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/fomat-macros/0.2.1 [INFO] extracting crate fomat-macros 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fomat-macros/0.2.1 [INFO] validating manifest of fomat-macros-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of fomat-macros-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing fomat-macros-0.2.1 [INFO] finished frobbing fomat-macros-0.2.1 [INFO] frobbed toml for fomat-macros-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/fomat-macros/0.2.1/Cargo.toml [INFO] started frobbing fomat-macros-0.2.1 [INFO] finished frobbing fomat-macros-0.2.1 [INFO] frobbed toml for fomat-macros-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fomat-macros/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting fomat-macros-0.2.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/fomat-macros/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 233f6a1a5be9f531c6b9fdcdc8c0aa0b04a89e6ff2feb7eb02584d37ca81ceca [INFO] running `"docker" "start" "-a" "233f6a1a5be9f531c6b9fdcdc8c0aa0b04a89e6ff2feb7eb02584d37ca81ceca"` [INFO] [stderr] Checking fomat-macros v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:814:27 [INFO] [stderr] | [INFO] [stderr] 814 | if {let t = true; t} { "K" } [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:814:21 [INFO] [stderr] | [INFO] [stderr] 814 | if {let t = true; t} { "K" } [INFO] [stderr] | ^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/lib.rs:811:16 [INFO] [stderr] | [INFO] [stderr] 422 | / if let $p = $e { [INFO] [stderr] 423 | | wite!(@rec $w, $($then)*); [INFO] [stderr] 424 | | } else { [INFO] [stderr] 425 | | wite!(@rec $w, $($els)*); [INFO] [stderr] 426 | | } [INFO] [stderr] | |_____________- help: try this: `if Some(5).is_none()` [INFO] [stderr] ... [INFO] [stderr] 811 | if let None = Some(5) { "X" } else { "F" "F" } [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/lib.rs:813:16 [INFO] [stderr] | [INFO] [stderr] 422 | / if let $p = $e { [INFO] [stderr] 423 | | wite!(@rec $w, $($then)*); [INFO] [stderr] 424 | | } else { [INFO] [stderr] 425 | | wite!(@rec $w, $($els)*); [INFO] [stderr] 426 | | } [INFO] [stderr] | |_____________- help: try this: `if Some(5).is_none()` [INFO] [stderr] ... [INFO] [stderr] 813 | if let None = Some(5) { "X" } [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:401:13 [INFO] [stderr] | [INFO] [stderr] 401 | / match $e { [INFO] [stderr] 402 | | $( [INFO] [stderr] 403 | | $($p)|+ $(if $g)* => { [INFO] [stderr] 404 | | wite!(@rec $w, $($body)*) [INFO] [stderr] 405 | | } [INFO] [stderr] 406 | | )* [INFO] [stderr] 407 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 852 | let s = fomat!( [INFO] [stderr] | _____________- [INFO] [stderr] 853 | | "Hello" [INFO] [stderr] 854 | | for x in [1][1..].iter() { (x) "a" } [INFO] [stderr] 855 | | if let Some(()) = None { "b" } [INFO] [stderr] ... | [INFO] [stderr] 858 | | "!" [INFO] [stderr] 859 | | ); [INFO] [stderr] | |_____- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 401 | if let 2 = 1 { fomat!( [INFO] [stderr] 402 | "Hello" [INFO] [stderr] 403 | for x in [1][1..].iter() { (x) "a" } [INFO] [stderr] 404 | if let Some(()) = None { "b" } [INFO] [stderr] 405 | if false { "c" } else {} [INFO] [stderr] 406 | match 1 { 2 => { "e" } _ => {} } [INFO] [stderr] ... [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/bench.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] [INFO] [stderr] error: Could not compile `fomat-macros`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> tests/capturing.rs:6:15 [INFO] [stderr] | [INFO] [stderr] 6 | const FILES: &'static [(&'static str, &'static str)] = &[ [INFO] [stderr] | -^^^^^^^------------------------------- help: consider removing `'static`: `&[(&'static str, &'static str)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> tests/capturing.rs:6:26 [INFO] [stderr] | [INFO] [stderr] 6 | const FILES: &'static [(&'static str, &'static str)] = &[ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> tests/capturing.rs:6:40 [INFO] [stderr] | [INFO] [stderr] 6 | const FILES: &'static [(&'static str, &'static str)] = &[ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "233f6a1a5be9f531c6b9fdcdc8c0aa0b04a89e6ff2feb7eb02584d37ca81ceca"` [INFO] running `"docker" "rm" "-f" "233f6a1a5be9f531c6b9fdcdc8c0aa0b04a89e6ff2feb7eb02584d37ca81ceca"` [INFO] [stdout] 233f6a1a5be9f531c6b9fdcdc8c0aa0b04a89e6ff2feb7eb02584d37ca81ceca