[INFO] crate fluid_attributes 0.3.0 is already in cache [INFO] extracting crate fluid_attributes 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/fluid_attributes/0.3.0 [INFO] extracting crate fluid_attributes 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fluid_attributes/0.3.0 [INFO] validating manifest of fluid_attributes-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of fluid_attributes-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing fluid_attributes-0.3.0 [INFO] finished frobbing fluid_attributes-0.3.0 [INFO] frobbed toml for fluid_attributes-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/fluid_attributes/0.3.0/Cargo.toml [INFO] started frobbing fluid_attributes-0.3.0 [INFO] finished frobbing fluid_attributes-0.3.0 [INFO] frobbed toml for fluid_attributes-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/fluid_attributes/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting fluid_attributes-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/fluid_attributes/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e6cb292214a32667bbf996d90419f401e91eaba7a6ad736ee4ef928f69f491c7 [INFO] running `"docker" "start" "-a" "e6cb292214a32667bbf996d90419f401e91eaba7a6ad736ee4ef928f69f491c7"` [INFO] [stderr] Checking fluid_attributes v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/theory.rs:44:16 [INFO] [stderr] | [INFO] [stderr] 44 | let span = input.ident.span().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `input.ident.span()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/theory.rs:110:37 [INFO] [stderr] | [INFO] [stderr] 110 | Pat::Ident(ident) => if ident.ident.to_string() == "__case__" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*ident.ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/iterator_unique.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | / match self.next().is_some() { [INFO] [stderr] 13 | | true => None, [INFO] [stderr] 14 | | false => next, [INFO] [stderr] 15 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.next().is_some() { None } else { next }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/theory.rs:44:16 [INFO] [stderr] | [INFO] [stderr] 44 | let span = input.ident.span().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `input.ident.span()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/theory.rs:110:37 [INFO] [stderr] | [INFO] [stderr] 110 | Pat::Ident(ident) => if ident.ident.to_string() == "__case__" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*ident.ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/iterator_unique.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | / match self.next().is_some() { [INFO] [stderr] 13 | | true => None, [INFO] [stderr] 14 | | false => next, [INFO] [stderr] 15 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.next().is_some() { None } else { next }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.99s [INFO] running `"docker" "inspect" "e6cb292214a32667bbf996d90419f401e91eaba7a6ad736ee4ef928f69f491c7"` [INFO] running `"docker" "rm" "-f" "e6cb292214a32667bbf996d90419f401e91eaba7a6ad736ee4ef928f69f491c7"` [INFO] [stdout] e6cb292214a32667bbf996d90419f401e91eaba7a6ad736ee4ef928f69f491c7