[INFO] crate flowrlib 0.3.1 is already in cache [INFO] extracting crate flowrlib 0.3.1 into work/ex/clippy-test-run/sources/stable/reg/flowrlib/0.3.1 [INFO] extracting crate flowrlib 0.3.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/flowrlib/0.3.1 [INFO] validating manifest of flowrlib-0.3.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of flowrlib-0.3.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing flowrlib-0.3.1 [INFO] finished frobbing flowrlib-0.3.1 [INFO] frobbed toml for flowrlib-0.3.1 written to work/ex/clippy-test-run/sources/stable/reg/flowrlib/0.3.1/Cargo.toml [INFO] started frobbing flowrlib-0.3.1 [INFO] finished frobbing flowrlib-0.3.1 [INFO] frobbed toml for flowrlib-0.3.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/flowrlib/0.3.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting flowrlib-0.3.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/flowrlib/0.3.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cebdc13df40d914c1754d5b041d6959c5e9527be4a2e3fdc5fea0af427aa50b7 [INFO] running `"docker" "start" "-a" "cebdc13df40d914c1754d5b041d6959c5e9527be4a2e3fdc5fea0af427aa50b7"` [INFO] [stderr] Checking flowrlib v0.3.1 (/opt/crater/workdir) [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/runlist.rs:120:13 [INFO] [stderr] | [INFO] [stderr] 120 | write!(f, "\tid: {}\n", self.id).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/runlist.rs:120:13 [INFO] [stderr] | [INFO] [stderr] 120 | write!(f, "\tid: {}\n", self.id).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/info.rs:1:17 [INFO] [stderr] | [INFO] [stderr] 1 | const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/runlist.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | / if blocking_id == destination_id { [INFO] [stderr] 81 | | if self.inputs_satisfied.remove(&blocked_id) { [INFO] [stderr] 82 | | self.ready.push(blocked_id); [INFO] [stderr] 83 | | } [INFO] [stderr] 84 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 80 | if blocking_id == destination_id && self.inputs_satisfied.remove(&blocked_id) { [INFO] [stderr] 81 | self.ready.push(blocked_id); [INFO] [stderr] 82 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/runlist.rs:58:12 [INFO] [stderr] | [INFO] [stderr] 58 | if self.ready.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.ready.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/value.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | for ref route in &self.output_routes { [INFO] [stderr] | ^^^^^^^^^ ------------------- help: try: `let route = &&self.output_routes;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/function.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | for ref route in &self.output_routes { [INFO] [stderr] | ^^^^^^^^^ ------------------- help: try: `let route = &&self.output_routes;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/info.rs:1:17 [INFO] [stderr] | [INFO] [stderr] 1 | const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/runlist.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | / if blocking_id == destination_id { [INFO] [stderr] 81 | | if self.inputs_satisfied.remove(&blocked_id) { [INFO] [stderr] 82 | | self.ready.push(blocked_id); [INFO] [stderr] 83 | | } [INFO] [stderr] 84 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 80 | if blocking_id == destination_id && self.inputs_satisfied.remove(&blocked_id) { [INFO] [stderr] 81 | self.ready.push(blocked_id); [INFO] [stderr] 82 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/runlist.rs:58:12 [INFO] [stderr] | [INFO] [stderr] 58 | if self.ready.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.ready.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/value.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | for ref route in &self.output_routes { [INFO] [stderr] | ^^^^^^^^^ ------------------- help: try: `let route = &&self.output_routes;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/function.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | for ref route in &self.output_routes { [INFO] [stderr] | ^^^^^^^^^ ------------------- help: try: `let route = &&self.output_routes;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.38s [INFO] running `"docker" "inspect" "cebdc13df40d914c1754d5b041d6959c5e9527be4a2e3fdc5fea0af427aa50b7"` [INFO] running `"docker" "rm" "-f" "cebdc13df40d914c1754d5b041d6959c5e9527be4a2e3fdc5fea0af427aa50b7"` [INFO] [stdout] cebdc13df40d914c1754d5b041d6959c5e9527be4a2e3fdc5fea0af427aa50b7