[INFO] crate flow_between 0.1.0 is already in cache [INFO] extracting crate flow_between 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/flow_between/0.1.0 [INFO] extracting crate flow_between 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/flow_between/0.1.0 [INFO] validating manifest of flow_between-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of flow_between-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing flow_between-0.1.0 [INFO] finished frobbing flow_between-0.1.0 [INFO] frobbed toml for flow_between-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/flow_between/0.1.0/Cargo.toml [INFO] started frobbing flow_between-0.1.0 [INFO] finished frobbing flow_between-0.1.0 [INFO] frobbed toml for flow_between-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/flow_between/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting flow_between-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/flow_between/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c5134dc013f8e3c5e7b8cc420ba64726716c52d4d0743ea63313e9e138b9cde0 [INFO] running `"docker" "start" "-a" "c5134dc013f8e3c5e7b8cc420ba64726716c52d4d0743ea63313e9e138b9cde0"` [INFO] [stderr] Checking rust-hsluv v0.1.3 [INFO] [stderr] Checking flo_float_encoder v0.1.0 [INFO] [stderr] Compiling libsqlite3-sys v0.8.1 [INFO] [stderr] Checking desync v0.1.2 [INFO] [stderr] Checking desync v0.2.4 [INFO] [stderr] Checking block-buffer v0.2.0 [INFO] [stderr] Checking digest v0.6.2 [INFO] [stderr] Checking flo_curves v0.1.0 [INFO] [stderr] Checking sha2 v0.6.0 [INFO] [stderr] Checking flo_binding v0.1.1 [INFO] [stderr] Checking flo_canvas v0.1.0 [INFO] [stderr] Checking flo_static_files v0.1.0 [INFO] [stderr] Checking flo_animation v0.1.0 [INFO] [stderr] Checking flo_ui v0.1.0 [INFO] [stderr] Checking flo v0.1.0 [INFO] [stderr] Checking flo_http_ui v0.1.0 [INFO] [stderr] Checking rusqlite v0.11.0 [INFO] [stderr] Checking flo_anim_sqlite v0.1.0 [INFO] [stderr] Checking flow_between v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http_session.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | images: images [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `images` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/http_session.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | images: images [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `images` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/http_session.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | session [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/http_session.rs:83:23 [INFO] [stderr] | [INFO] [stderr] 83 | let session = FlowBetweenSession::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `frame_length` [INFO] [stderr] --> src/http_session.rs:69:60 [INFO] [stderr] | [INFO] [stderr] 69 | AnimationEdit::Layer(0, LayerEdit::AddKeyFrame(frame_length*1)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/http_session.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | session [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/http_session.rs:83:23 [INFO] [stderr] | [INFO] [stderr] 83 | let session = FlowBetweenSession::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `frame_length` [INFO] [stderr] --> src/http_session.rs:69:60 [INFO] [stderr] | [INFO] [stderr] 69 | AnimationEdit::Layer(0, LayerEdit::AddKeyFrame(frame_length*1)), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 43.69s [INFO] running `"docker" "inspect" "c5134dc013f8e3c5e7b8cc420ba64726716c52d4d0743ea63313e9e138b9cde0"` [INFO] running `"docker" "rm" "-f" "c5134dc013f8e3c5e7b8cc420ba64726716c52d4d0743ea63313e9e138b9cde0"` [INFO] [stdout] c5134dc013f8e3c5e7b8cc420ba64726716c52d4d0743ea63313e9e138b9cde0