[INFO] crate flo_static_files 0.1.0 is already in cache [INFO] extracting crate flo_static_files 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/flo_static_files/0.1.0 [INFO] extracting crate flo_static_files 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/flo_static_files/0.1.0 [INFO] validating manifest of flo_static_files-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of flo_static_files-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing flo_static_files-0.1.0 [INFO] finished frobbing flo_static_files-0.1.0 [INFO] frobbed toml for flo_static_files-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/flo_static_files/0.1.0/Cargo.toml [INFO] started frobbing flo_static_files-0.1.0 [INFO] finished frobbing flo_static_files-0.1.0 [INFO] frobbed toml for flo_static_files-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/flo_static_files/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting flo_static_files-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/flo_static_files/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ab7a9a478245025176545ae8f13d324f08f90f60b70b36f06ad2eaaac9befaf3 [INFO] running `"docker" "start" "-a" "ab7a9a478245025176545ae8f13d324f08f90f60b70b36f06ad2eaaac9befaf3"` [INFO] [stderr] Checking block-buffer v0.2.0 [INFO] [stderr] Checking sha2 v0.6.0 [INFO] [stderr] Checking flo_static_files v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/static_file.rs:165:31 [INFO] [stderr] | [INFO] [stderr] 165 | Ok(Response::with((status::BadRequest))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/static_file.rs:165:31 [INFO] [stderr] | [INFO] [stderr] 165 | Ok(Response::with((status::BadRequest))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/static_service.rs:72:31 [INFO] [stderr] | [INFO] [stderr] 72 | Ok(Response::with((status::NotFound))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/static_service.rs:72:31 [INFO] [stderr] | [INFO] [stderr] 72 | Ok(Response::with((status::NotFound))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/static_file.rs:106:5 [INFO] [stderr] | [INFO] [stderr] 106 | / pub fn content<'a>(&'a self) -> &'a [u8] { [INFO] [stderr] 107 | | &self.content [INFO] [stderr] 108 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/static_file.rs:113:5 [INFO] [stderr] | [INFO] [stderr] 113 | / pub fn mime_type<'a>(&'a self) -> &'a str { [INFO] [stderr] 114 | | &self.mime_type [INFO] [stderr] 115 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/static_service.rs:24:22 [INFO] [stderr] | [INFO] [stderr] 24 | .map(|file| Arc::new(file)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Arc::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/static_service.rs:44:40 [INFO] [stderr] | [INFO] [stderr] 44 | } else if *component == "" { [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 45 | | // Also ignore; note that if this is at the end the final path should have a '/' at the end [INFO] [stderr] 46 | | } else if *component == ".." { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/static_service.rs:42:34 [INFO] [stderr] | [INFO] [stderr] 42 | if *component == "." { [INFO] [stderr] | __________________________________^ [INFO] [stderr] 43 | | // Ignore [INFO] [stderr] 44 | | } else if *component == "" { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/static_service.rs:48:20 [INFO] [stderr] | [INFO] [stderr] 48 | if path_components.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!path_components.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `flo_static_files`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/static_file.rs:165:31 [INFO] [stderr] | [INFO] [stderr] 165 | Ok(Response::with((status::BadRequest))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/static_file.rs:165:31 [INFO] [stderr] | [INFO] [stderr] 165 | Ok(Response::with((status::BadRequest))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/static_service.rs:72:31 [INFO] [stderr] | [INFO] [stderr] 72 | Ok(Response::with((status::NotFound))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/static_service.rs:72:31 [INFO] [stderr] | [INFO] [stderr] 72 | Ok(Response::with((status::NotFound))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/static_file.rs:106:5 [INFO] [stderr] | [INFO] [stderr] 106 | / pub fn content<'a>(&'a self) -> &'a [u8] { [INFO] [stderr] 107 | | &self.content [INFO] [stderr] 108 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/static_file.rs:113:5 [INFO] [stderr] | [INFO] [stderr] 113 | / pub fn mime_type<'a>(&'a self) -> &'a str { [INFO] [stderr] 114 | | &self.mime_type [INFO] [stderr] 115 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/static_service.rs:24:22 [INFO] [stderr] | [INFO] [stderr] 24 | .map(|file| Arc::new(file)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Arc::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/static_service.rs:44:40 [INFO] [stderr] | [INFO] [stderr] 44 | } else if *component == "" { [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 45 | | // Also ignore; note that if this is at the end the final path should have a '/' at the end [INFO] [stderr] 46 | | } else if *component == ".." { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/static_service.rs:42:34 [INFO] [stderr] | [INFO] [stderr] 42 | if *component == "." { [INFO] [stderr] | __________________________________^ [INFO] [stderr] 43 | | // Ignore [INFO] [stderr] 44 | | } else if *component == "" { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/static_service.rs:48:20 [INFO] [stderr] | [INFO] [stderr] 48 | if path_components.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!path_components.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `flo_static_files`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "ab7a9a478245025176545ae8f13d324f08f90f60b70b36f06ad2eaaac9befaf3"` [INFO] running `"docker" "rm" "-f" "ab7a9a478245025176545ae8f13d324f08f90f60b70b36f06ad2eaaac9befaf3"` [INFO] [stdout] ab7a9a478245025176545ae8f13d324f08f90f60b70b36f06ad2eaaac9befaf3