[INFO] crate flo_anim_sqlite 0.1.0 is already in cache [INFO] extracting crate flo_anim_sqlite 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/flo_anim_sqlite/0.1.0 [INFO] extracting crate flo_anim_sqlite 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/flo_anim_sqlite/0.1.0 [INFO] validating manifest of flo_anim_sqlite-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of flo_anim_sqlite-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing flo_anim_sqlite-0.1.0 [INFO] finished frobbing flo_anim_sqlite-0.1.0 [INFO] frobbed toml for flo_anim_sqlite-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/flo_anim_sqlite/0.1.0/Cargo.toml [INFO] started frobbing flo_anim_sqlite-0.1.0 [INFO] finished frobbing flo_anim_sqlite-0.1.0 [INFO] frobbed toml for flo_anim_sqlite-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/flo_anim_sqlite/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting flo_anim_sqlite-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/flo_anim_sqlite/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9236732f694a65fe48d3aa490e5a1c58f35770756f8bdb04540743e589bcbed6 [INFO] running `"docker" "start" "-a" "9236732f694a65fe48d3aa490e5a1c58f35770756f8bdb04540743e589bcbed6"` [INFO] [stderr] Checking flo_float_encoder v0.1.0 [INFO] [stderr] Compiling libsqlite3-sys v0.8.1 [INFO] [stderr] Checking flo_canvas v0.1.0 [INFO] [stderr] Checking flo_animation v0.1.0 [INFO] [stderr] Checking rusqlite v0.11.0 [INFO] [stderr] Checking flo_anim_sqlite v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db/flo_sqlite/query.rs:147:25 [INFO] [stderr] | [INFO] [stderr] 147 | edit_id: edit_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `edit_id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db/flo_sqlite/query.rs:148:25 [INFO] [stderr] | [INFO] [stderr] 148 | edit_type: edit_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `edit_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db/flo_sqlite/query.rs:152:25 [INFO] [stderr] | [INFO] [stderr] 152 | brush_properties_id: brush_properties_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `brush_properties_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db/flo_sqlite/query.rs:153:25 [INFO] [stderr] | [INFO] [stderr] 153 | element_id: element_id [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `element_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/db/flo_sqlite/query.rs:190:21 [INFO] [stderr] | [INFO] [stderr] 190 | let s: Option = s; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/db/flo_sqlite/query.rs:191:21 [INFO] [stderr] | [INFO] [stderr] 191 | let l: Option = l; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db/flo_sqlite/mod.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | sqlite: sqlite, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sqlite` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db/flo_sqlite/mod.rs:110:13 [INFO] [stderr] | [INFO] [stderr] 110 | animation_id: animation_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `animation_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db/brush.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | color: color [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db/vector_layer.rs:52:21 [INFO] [stderr] | [INFO] [stderr] 52 | assigned_id: assigned_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `assigned_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db/vector_layer.rs:53:21 [INFO] [stderr] | [INFO] [stderr] 53 | layer_id: layer_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `layer_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db/vector_frame.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | keyframe_time: keyframe_time, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `keyframe_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db/vector_frame.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | keyframe_offset: keyframe_offset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `keyframe_offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db/vector_frame.rs:98:13 [INFO] [stderr] | [INFO] [stderr] 98 | elements: elements [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `elements` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db/mod.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | core: core, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `core` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db/mod.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | core: core, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `core` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/animation_sqlite/data.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | db: db [INFO] [stderr] | ^^^^^^ help: replace it with: `db` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/animation_sqlite/data.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | db: db [INFO] [stderr] | ^^^^^^ help: replace it with: `db` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/animation_sqlite/data.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | db: db [INFO] [stderr] | ^^^^^^ help: replace it with: `db` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/animation_sqlite/data.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | db: db [INFO] [stderr] | ^^^^^^ help: replace it with: `db` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db/flo_sqlite/query.rs:147:25 [INFO] [stderr] | [INFO] [stderr] 147 | edit_id: edit_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `edit_id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db/flo_sqlite/query.rs:148:25 [INFO] [stderr] | [INFO] [stderr] 148 | edit_type: edit_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `edit_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db/flo_sqlite/query.rs:152:25 [INFO] [stderr] | [INFO] [stderr] 152 | brush_properties_id: brush_properties_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `brush_properties_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db/flo_sqlite/query.rs:153:25 [INFO] [stderr] | [INFO] [stderr] 153 | element_id: element_id [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `element_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/db/flo_sqlite/query.rs:190:21 [INFO] [stderr] | [INFO] [stderr] 190 | let s: Option = s; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/db/flo_sqlite/query.rs:191:21 [INFO] [stderr] | [INFO] [stderr] 191 | let l: Option = l; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db/flo_sqlite/mod.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | sqlite: sqlite, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sqlite` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db/flo_sqlite/mod.rs:110:13 [INFO] [stderr] | [INFO] [stderr] 110 | animation_id: animation_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `animation_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db/brush.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | color: color [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db/vector_layer.rs:52:21 [INFO] [stderr] | [INFO] [stderr] 52 | assigned_id: assigned_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `assigned_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db/vector_layer.rs:53:21 [INFO] [stderr] | [INFO] [stderr] 53 | layer_id: layer_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `layer_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db/vector_frame.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | keyframe_time: keyframe_time, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `keyframe_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db/vector_frame.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | keyframe_offset: keyframe_offset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `keyframe_offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db/vector_frame.rs:98:13 [INFO] [stderr] | [INFO] [stderr] 98 | elements: elements [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `elements` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db/mod.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | core: core, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `core` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/db/mod.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | core: core, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `core` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/animation_sqlite/data.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | db: db [INFO] [stderr] | ^^^^^^ help: replace it with: `db` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/animation_sqlite/data.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | db: db [INFO] [stderr] | ^^^^^^ help: replace it with: `db` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/animation_sqlite/data.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | db: db [INFO] [stderr] | ^^^^^^ help: replace it with: `db` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/animation_sqlite/data.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | db: db [INFO] [stderr] | ^^^^^^ help: replace it with: `db` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/db/editlog.rs:7:28 [INFO] [stderr] | [INFO] [stderr] 7 | const INVALID_LAYER: u64 = 0xffffffffffffffff; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff_ffff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/db/vector_layer.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | keyframes [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/db/vector_layer.rs:94:27 [INFO] [stderr] | [INFO] [stderr] 94 | let keyframes = Box::new(keyframes.into_iter()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/db/mod.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | db [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/db/mod.rs:68:23 [INFO] [stderr] | [INFO] [stderr] 68 | let db = AnimationDb { [INFO] [stderr] | _______________________^ [INFO] [stderr] 69 | | core: core, [INFO] [stderr] 70 | | editor: Mutex::new(editor), [INFO] [stderr] 71 | | next_element_id: Arc::new(Mutex::new(initial_element_id)) [INFO] [stderr] 72 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/db/mod.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | db [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/db/mod.rs:87:18 [INFO] [stderr] | [INFO] [stderr] 87 | let db = AnimationDb { [INFO] [stderr] | __________________^ [INFO] [stderr] 88 | | core: core, [INFO] [stderr] 89 | | editor: Mutex::new(editor), [INFO] [stderr] 90 | | next_element_id: Arc::new(Mutex::new(initial_element_id)) [INFO] [stderr] 91 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/db/mod.rs:152:9 [INFO] [stderr] | [INFO] [stderr] 152 | core [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/db/mod.rs:147:20 [INFO] [stderr] | [INFO] [stderr] 147 | let core = AnimationDbCore { [INFO] [stderr] | ____________________^ [INFO] [stderr] 148 | | db: FloSqlite::new(connection), [INFO] [stderr] 149 | | failure: None [INFO] [stderr] 150 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/db/tests.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | core [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/db/tests.rs:22:16 [INFO] [stderr] | [INFO] [stderr] 22 | let core = AnimationDbCore::new(connection); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/db/editlog.rs:7:28 [INFO] [stderr] | [INFO] [stderr] 7 | const INVALID_LAYER: u64 = 0xffffffffffffffff; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff_ffff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/db/vector_layer.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | keyframes [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/db/vector_layer.rs:94:27 [INFO] [stderr] | [INFO] [stderr] 94 | let keyframes = Box::new(keyframes.into_iter()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/db/mod.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | db [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/db/mod.rs:68:23 [INFO] [stderr] | [INFO] [stderr] 68 | let db = AnimationDb { [INFO] [stderr] | _______________________^ [INFO] [stderr] 69 | | core: core, [INFO] [stderr] 70 | | editor: Mutex::new(editor), [INFO] [stderr] 71 | | next_element_id: Arc::new(Mutex::new(initial_element_id)) [INFO] [stderr] 72 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/db/mod.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | db [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/db/mod.rs:87:18 [INFO] [stderr] | [INFO] [stderr] 87 | let db = AnimationDb { [INFO] [stderr] | __________________^ [INFO] [stderr] 88 | | core: core, [INFO] [stderr] 89 | | editor: Mutex::new(editor), [INFO] [stderr] 90 | | next_element_id: Arc::new(Mutex::new(initial_element_id)) [INFO] [stderr] 91 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/db/mod.rs:152:9 [INFO] [stderr] | [INFO] [stderr] 152 | core [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/db/mod.rs:147:20 [INFO] [stderr] | [INFO] [stderr] 147 | let core = AnimationDbCore { [INFO] [stderr] | ____________________^ [INFO] [stderr] 148 | | db: FloSqlite::new(connection), [INFO] [stderr] 149 | | failure: None [INFO] [stderr] 150 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/db/flo_query.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | fn query_key_frame_times_for_layer_id<'a>(&'a mut self, layer_id: i64, from: Duration, until: Duration) -> Result>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/db/flo_query.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | fn query_nearest_key_frame<'a>(&'a mut self, layer_id: i64, when: Duration) -> Result<(i64, Duration)>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/db/flo_sqlite/query.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | / fn query_key_frame_times_for_layer_id<'a>(&'a mut self, layer_id: i64, from: Duration, until: Duration) -> Result> { [INFO] [stderr] 46 | | let from = Self::get_micros(&from); [INFO] [stderr] 47 | | let until = Self::get_micros(&until); [INFO] [stderr] 48 | | [INFO] [stderr] ... | [INFO] [stderr] 52 | | Ok(rows.collect()) [INFO] [stderr] 53 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/db/flo_sqlite/query.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | / fn query_nearest_key_frame<'a>(&'a mut self, layer_id: i64, when: Duration) -> Result<(i64, Duration)> { [INFO] [stderr] 59 | | self.query_row(FloStatement::SelectNearestKeyFrame, &[&layer_id, &Self::get_micros(&when)], |row| (row.get(0), Self::from_micros(row.get(1)))) [INFO] [stderr] 60 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/db/flo_sqlite/store.rs:40:50 [INFO] [stderr] | [INFO] [stderr] 40 | set_size.insert(&[&edit_log_id, &(width as f64), &(height as f64)])?; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/db/flo_sqlite/store.rs:40:67 [INFO] [stderr] | [INFO] [stderr] 40 | set_size.insert(&[&edit_log_id, &(width as f64), &(height as f64)])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/db/flo_sqlite/store.rs:107:54 [INFO] [stderr] | [INFO] [stderr] 107 | insert_ink_brush.insert(&[brush_id, &(min_width as f64), &(max_width as f64), &(scale_up_distance as f64)])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(min_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/db/flo_sqlite/store.rs:107:75 [INFO] [stderr] | [INFO] [stderr] 107 | insert_ink_brush.insert(&[brush_id, &(min_width as f64), &(max_width as f64), &(scale_up_distance as f64)])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(max_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/db/flo_sqlite/store.rs:107:96 [INFO] [stderr] | [INFO] [stderr] 107 | insert_ink_brush.insert(&[brush_id, &(min_width as f64), &(max_width as f64), &(scale_up_distance as f64)])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(scale_up_distance)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/db/flo_sqlite/store.rs:114:85 [INFO] [stderr] | [INFO] [stderr] 114 | let brush_props_id = insert_brush_properties.insert(&[&(size as f64), &(opacity as f64), &color_id])?; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/db/flo_sqlite/store.rs:114:101 [INFO] [stderr] | [INFO] [stderr] 114 | let brush_props_id = insert_brush_properties.insert(&[&(size as f64), &(opacity as f64), &color_id])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(opacity)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/db/flo_sqlite/store.rs:130:48 [INFO] [stderr] | [INFO] [stderr] 130 | insert_rgb.insert(&[color_id, &(r as f64), &(g as f64), &(b as f64)])?; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/db/flo_sqlite/store.rs:130:61 [INFO] [stderr] | [INFO] [stderr] 130 | insert_rgb.insert(&[color_id, &(r as f64), &(g as f64), &(b as f64)])?; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/db/flo_sqlite/store.rs:130:74 [INFO] [stderr] | [INFO] [stderr] 130 | insert_rgb.insert(&[color_id, &(r as f64), &(g as f64), &(b as f64)])?; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/db/flo_sqlite/store.rs:137:50 [INFO] [stderr] | [INFO] [stderr] 137 | insert_hsluv.insert(&[color_id, &(h as f64), &(s as f64), &(l as f64)])?; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/db/flo_sqlite/store.rs:137:63 [INFO] [stderr] | [INFO] [stderr] 137 | insert_hsluv.insert(&[color_id, &(h as f64), &(s as f64), &(l as f64)])?; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/db/flo_sqlite/store.rs:137:76 [INFO] [stderr] | [INFO] [stderr] 137 | insert_hsluv.insert(&[color_id, &(h as f64), &(s as f64), &(l as f64)])?; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(l)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/db/flo_sqlite/store.rs:240:57 [INFO] [stderr] | [INFO] [stderr] 240 | for (point, index) in points.iter().zip((0..num_points).into_iter()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..num_points)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/db/flo_sqlite/store.rs:243:26 [INFO] [stderr] | [INFO] [stderr] 243 | &(point.cp1.0 as f64), &(point.cp1.1 as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(point.cp1.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/db/flo_sqlite/store.rs:243:49 [INFO] [stderr] | [INFO] [stderr] 243 | &(point.cp1.0 as f64), &(point.cp1.1 as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(point.cp1.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/db/flo_sqlite/store.rs:244:26 [INFO] [stderr] | [INFO] [stderr] 244 | &(point.cp2.0 as f64), &(point.cp2.1 as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(point.cp2.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/db/flo_sqlite/store.rs:244:49 [INFO] [stderr] | [INFO] [stderr] 244 | &(point.cp2.0 as f64), &(point.cp2.1 as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(point.cp2.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/db/flo_sqlite/store.rs:245:26 [INFO] [stderr] | [INFO] [stderr] 245 | &(point.position.0 as f64), &(point.position.1 as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(point.position.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/db/flo_sqlite/store.rs:245:54 [INFO] [stderr] | [INFO] [stderr] 245 | &(point.position.0 as f64), &(point.position.1 as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(point.position.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/db/flo_sqlite/store.rs:246:26 [INFO] [stderr] | [INFO] [stderr] 246 | &(point.width as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(point.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/db/flo_sqlite/mod.rs:163:27 [INFO] [stderr] | [INFO] [stderr] 163 | let nanos:i64 = when.subsec_nanos() as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(when.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/db/flo_sqlite/mod.rs:293:17 [INFO] [stderr] | [INFO] [stderr] 293 | enum_values.get(&convert_value).map(|val| *val) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `enum_values.get(&convert_value).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/db/db_enum.rs:214:9 [INFO] [stderr] | [INFO] [stderr] 214 | / match t { [INFO] [stderr] 215 | | &SetSize(_, _) => EditLogType::SetSize, [INFO] [stderr] 216 | | &AddNewLayer(_) => EditLogType::AddNewLayer, [INFO] [stderr] 217 | | &RemoveLayer(_) => EditLogType::RemoveLayer, [INFO] [stderr] ... | [INFO] [stderr] 222 | | &Layer(_, Paint(_, BrushStroke(_,_))) => EditLogType::LayerPaintBrushStroke [INFO] [stderr] 223 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 214 | match *t { [INFO] [stderr] 215 | SetSize(_, _) => EditLogType::SetSize, [INFO] [stderr] 216 | AddNewLayer(_) => EditLogType::AddNewLayer, [INFO] [stderr] 217 | RemoveLayer(_) => EditLogType::RemoveLayer, [INFO] [stderr] 218 | Layer(_, AddKeyFrame(_)) => EditLogType::LayerAddKeyFrame, [INFO] [stderr] 219 | Layer(_, RemoveKeyFrame(_)) => EditLogType::LayerRemoveKeyFrame, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/db/db_enum.rs:231:9 [INFO] [stderr] | [INFO] [stderr] 231 | / match t { [INFO] [stderr] 232 | | &Draw => DrawingStyleType::Draw, [INFO] [stderr] 233 | | &Erase => DrawingStyleType::Erase [INFO] [stderr] 234 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 231 | match *t { [INFO] [stderr] 232 | Draw => DrawingStyleType::Draw, [INFO] [stderr] 233 | Erase => DrawingStyleType::Erase [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/db/db_enum.rs:242:9 [INFO] [stderr] | [INFO] [stderr] 242 | / match t { [INFO] [stderr] 243 | | &BrushDefinition(_) => VectorElementType::BrushDefinition, [INFO] [stderr] 244 | | &BrushProperties(_) => VectorElementType::BrushProperties, [INFO] [stderr] 245 | | &BrushStroke(_) => VectorElementType::BrushStroke [INFO] [stderr] 246 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 242 | match *t { [INFO] [stderr] 243 | BrushDefinition(_) => VectorElementType::BrushDefinition, [INFO] [stderr] 244 | BrushProperties(_) => VectorElementType::BrushProperties, [INFO] [stderr] 245 | BrushStroke(_) => VectorElementType::BrushStroke [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/db/db_enum.rs:253:9 [INFO] [stderr] | [INFO] [stderr] 253 | / match t { [INFO] [stderr] 254 | | &Simple => BrushDefinitionType::Simple, [INFO] [stderr] 255 | | &Ink(_) => BrushDefinitionType::Ink [INFO] [stderr] 256 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 253 | match *t { [INFO] [stderr] 254 | Simple => BrushDefinitionType::Simple, [INFO] [stderr] 255 | Ink(_) => BrushDefinitionType::Ink [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/db/editlog.rs:67:14 [INFO] [stderr] | [INFO] [stderr] 67 | .unwrap_or(BrushProperties::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(BrushProperties::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/db/editlog.rs:66:113 [INFO] [stderr] | [INFO] [stderr] 66 | .map(|brush_properties_id| AnimationDbCore::get_brush_properties(&mut core.db, brush_properties_id).unwrap_or(BrushProperties::new())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| BrushProperties::new())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/db/editlog.rs:142:56 [INFO] [stderr] | [INFO] [stderr] 142 | let current_range = indices.next().map(|pos| pos..(pos+1)); [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `pos..=pos` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/db/editlog.rs:153:37 [INFO] [stderr] | [INFO] [stderr] 153 | current_range = next_index..(next_index+1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `next_index..=next_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/db/insert_editlog.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | / match element_id { [INFO] [stderr] 44 | | &Unassigned => { }, [INFO] [stderr] 45 | | &Assigned(id) => { db.update(vec![PushEditLogElementId(id)])?; }, [INFO] [stderr] 46 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 43 | match *element_id { [INFO] [stderr] 44 | Unassigned => { }, [INFO] [stderr] 45 | Assigned(id) => { db.update(vec![PushEditLogElementId(id)])?; }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/db/insert_editlog.rs:54:24 [INFO] [stderr] | [INFO] [stderr] 54 | fn insert_edit_log<'a>(&mut self, edit: &AnimationEdit) -> Result<()> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/db/insert_editlog.rs:67:30 [INFO] [stderr] | [INFO] [stderr] 67 | fn insert_animation_edit<'a>(&mut self, edit: &AnimationEdit) -> Result<()> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/db/insert_editlog.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | / match edit { [INFO] [stderr] 71 | | &Layer(layer_id, ref layer_edit) => { [INFO] [stderr] 72 | | self.db.update(vec![PushEditLogLayer(layer_id)])?; [INFO] [stderr] 73 | | self.insert_layer_edit(layer_edit)?; [INFO] [stderr] ... | [INFO] [stderr] 86 | | } [INFO] [stderr] 87 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 70 | match *edit { [INFO] [stderr] 71 | Layer(layer_id, ref layer_edit) => { [INFO] [stderr] 72 | self.db.update(vec![PushEditLogLayer(layer_id)])?; [INFO] [stderr] 73 | self.insert_layer_edit(layer_edit)?; [INFO] [stderr] 74 | }, [INFO] [stderr] 75 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/db/insert_editlog.rs:95:26 [INFO] [stderr] | [INFO] [stderr] 95 | fn insert_layer_edit<'a>(&mut self, edit: &LayerEdit) -> Result<()> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/db/insert_editlog.rs:98:9 [INFO] [stderr] | [INFO] [stderr] 98 | / match edit { [INFO] [stderr] 99 | | &Paint(when, ref paint_edit) => { [INFO] [stderr] 100 | | self.db.update(vec![PushEditLogWhen(when)])?; [INFO] [stderr] 101 | | self.insert_paint_edit(paint_edit)?; [INFO] [stderr] ... | [INFO] [stderr] 110 | | } [INFO] [stderr] 111 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 98 | match *edit { [INFO] [stderr] 99 | Paint(when, ref paint_edit) => { [INFO] [stderr] 100 | self.db.update(vec![PushEditLogWhen(when)])?; [INFO] [stderr] 101 | self.insert_paint_edit(paint_edit)?; [INFO] [stderr] 102 | } [INFO] [stderr] 103 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/db/insert_editlog.rs:119:26 [INFO] [stderr] | [INFO] [stderr] 119 | fn insert_paint_edit<'a>(&mut self, edit: &PaintEdit) -> Result<()> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/db/insert_editlog.rs:122:9 [INFO] [stderr] | [INFO] [stderr] 122 | / match edit { [INFO] [stderr] 123 | | &SelectBrush(ref id, ref definition, ref drawing_style) => { [INFO] [stderr] 124 | | Self::insert_element_id(&mut self.db, id)?; [INFO] [stderr] 125 | | Self::insert_brush(&mut self.db, definition)?; [INFO] [stderr] ... | [INFO] [stderr] 138 | | } [INFO] [stderr] 139 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 122 | match *edit { [INFO] [stderr] 123 | SelectBrush(ref id, ref definition, ref drawing_style) => { [INFO] [stderr] 124 | Self::insert_element_id(&mut self.db, id)?; [INFO] [stderr] 125 | Self::insert_brush(&mut self.db, definition)?; [INFO] [stderr] 126 | self.db.update(vec![PopEditLogBrush(DrawingStyleType::from(drawing_style))])?; [INFO] [stderr] 127 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/db/mutable_animation.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | / fn edit_layer<'a>(&'a mut self, layer_id: u64) -> Option> { [INFO] [stderr] 74 | | // Create the layer if one is not already cached [INFO] [stderr] 75 | | let layer = if !self.layers.contains_key(&layer_id) { [INFO] [stderr] 76 | | let new_layer = SqliteVectorLayer::from_assigned_id(&self.core, layer_id); [INFO] [stderr] ... | [INFO] [stderr] 89 | | layer.map(|layer| Editor::new(layer as &mut Layer)) [INFO] [stderr] 90 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/db/mutable_animation.rs:75:21 [INFO] [stderr] | [INFO] [stderr] 75 | let layer = if !self.layers.contains_key(&layer_id) { [INFO] [stderr] | _____________________^ [INFO] [stderr] 76 | | let new_layer = SqliteVectorLayer::from_assigned_id(&self.core, layer_id); [INFO] [stderr] 77 | | [INFO] [stderr] 78 | | if let Some(new_layer) = new_layer { [INFO] [stderr] ... | [INFO] [stderr] 85 | | self.layers.get_mut(&layer_id) [INFO] [stderr] 86 | | }; [INFO] [stderr] | |_________^ help: consider using: `self.layers.entry(layer_id)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/db/color.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | / match color { [INFO] [stderr] 15 | | &Color::Rgba(r, g, b, _) => { [INFO] [stderr] 16 | | db.update(vec![ [INFO] [stderr] 17 | | PushColorType(ColorType::Rgb), [INFO] [stderr] ... | [INFO] [stderr] 27 | | }, [INFO] [stderr] 28 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 14 | match *color { [INFO] [stderr] 15 | Color::Rgba(r, g, b, _) => { [INFO] [stderr] 16 | db.update(vec![ [INFO] [stderr] 17 | PushColorType(ColorType::Rgb), [INFO] [stderr] 18 | PushRgb(r, g, b) [INFO] [stderr] 19 | ]) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/db/brush.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | / match brush_definition { [INFO] [stderr] 13 | | &BrushDefinition::Simple => { [INFO] [stderr] 14 | | db.update(vec![ [INFO] [stderr] 15 | | PushBrushType(BrushDefinitionType::from(brush_definition)), [INFO] [stderr] ... | [INFO] [stderr] 24 | | } [INFO] [stderr] 25 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 12 | match *brush_definition { [INFO] [stderr] 13 | BrushDefinition::Simple => { [INFO] [stderr] 14 | db.update(vec![ [INFO] [stderr] 15 | PushBrushType(BrushDefinitionType::from(brush_definition)), [INFO] [stderr] 16 | ]) [INFO] [stderr] 17 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/db/vector_layer.rs:125:5 [INFO] [stderr] | [INFO] [stderr] 125 | / fn as_vector_layer<'a>(&'a self) -> Option> { [INFO] [stderr] 126 | | let vector_layer = self as &VectorLayer; [INFO] [stderr] 127 | | [INFO] [stderr] 128 | | Some(Reader::new(vector_layer)) [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/db/vector_layer.rs:131:5 [INFO] [stderr] | [INFO] [stderr] 131 | / fn edit_vectors<'a>(&'a mut self) -> Option> { [INFO] [stderr] 132 | | let vector_layer = self as &mut VectorLayer; [INFO] [stderr] 133 | | [INFO] [stderr] 134 | | Some(Editor::new(vector_layer)) [INFO] [stderr] 135 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/db/vector_layer.rs:222:9 [INFO] [stderr] | [INFO] [stderr] 222 | / match new_element { [INFO] [stderr] 223 | | BrushDefinition(ref brush_definition) => { [INFO] [stderr] 224 | | self.active_brush = Some((when, create_brush_from_definition(brush_definition.definition(), brush_definition.drawing_style()))); [INFO] [stderr] 225 | | }, [INFO] [stderr] 226 | | [INFO] [stderr] 227 | | _ => () [INFO] [stderr] 228 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 222 | if let BrushDefinition(ref brush_definition) = new_element { [INFO] [stderr] 223 | self.active_brush = Some((when, create_brush_from_definition(brush_definition.definition(), brush_definition.drawing_style()))); [INFO] [stderr] 224 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/db/vector_frame.rs:141:17 [INFO] [stderr] | [INFO] [stderr] 141 | / match element { [INFO] [stderr] 142 | | &Vector::BrushDefinition(_) => changes_definition = true, [INFO] [stderr] 143 | | _ => () [INFO] [stderr] 144 | | }; [INFO] [stderr] | |_________________^ help: try this: `if let &Vector::BrushDefinition(_) = element { changes_definition = true }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/db/vector_frame.rs:141:17 [INFO] [stderr] | [INFO] [stderr] 141 | / match element { [INFO] [stderr] 142 | | &Vector::BrushDefinition(_) => changes_definition = true, [INFO] [stderr] 143 | | _ => () [INFO] [stderr] 144 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 141 | match *element { [INFO] [stderr] 142 | Vector::BrushDefinition(_) => changes_definition = true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/db/vector_frame.rs:167:17 [INFO] [stderr] | [INFO] [stderr] 167 | / match element { [INFO] [stderr] 168 | | &Vector::BrushProperties(_) => changes_properties = true, [INFO] [stderr] 169 | | _ => () [INFO] [stderr] 170 | | }; [INFO] [stderr] | |_________________^ help: try this: `if let &Vector::BrushProperties(_) = element { changes_properties = true }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/db/vector_frame.rs:167:17 [INFO] [stderr] | [INFO] [stderr] 167 | / match element { [INFO] [stderr] 168 | | &Vector::BrushProperties(_) => changes_properties = true, [INFO] [stderr] 169 | | _ => () [INFO] [stderr] 170 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 167 | match *element { [INFO] [stderr] 168 | Vector::BrushProperties(_) => changes_properties = true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/db/mod.rs:123:5 [INFO] [stderr] | [INFO] [stderr] 123 | / pub fn edit<'a>(&'a self) -> Editor<'a, MutableAnimation> { [INFO] [stderr] 124 | | let editor: &Mutex = &self.editor; [INFO] [stderr] 125 | | let editor = editor.lock().unwrap(); [INFO] [stderr] 126 | | [INFO] [stderr] 127 | | Editor::new(editor) [INFO] [stderr] 128 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/animation_sqlite/anim.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | self.retrieve_and_clear_error().map(|erm| panic!("{:?}", erm)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 22 | if let Some(erm) = self.retrieve_and_clear_error() { $ crate :: rt :: begin_panic_fmt ( [INFO] [stderr] 23 | & format_args ! ( $ fmt , $ ( $ arg ) + ) , & ( [INFO] [stderr] 24 | file ! ( ) , line ! ( ) , __rust_unstable_column ! ( ) ) ) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/animation_sqlite/anim.rs:76:5 [INFO] [stderr] | [INFO] [stderr] 76 | / fn get_layer_with_id<'a>(&'a self, layer_id: u64) -> Option> { [INFO] [stderr] 77 | | // Try to retrieve the layer from the editor [INFO] [stderr] 78 | | let layer = self.db.get_layer_with_id(layer_id); [INFO] [stderr] 79 | | [INFO] [stderr] ... | [INFO] [stderr] 86 | | layer.map(|layer| Reader::new(layer)) [INFO] [stderr] 87 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/animation_sqlite/anim.rs:86:19 [INFO] [stderr] | [INFO] [stderr] 86 | layer.map(|layer| Reader::new(layer)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Reader::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/animation_sqlite/anim.rs:89:5 [INFO] [stderr] | [INFO] [stderr] 89 | / fn get_log<'a>(&'a self) -> Reader<'a, EditLog> { [INFO] [stderr] 90 | | self.db.get_log() [INFO] [stderr] 91 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/db/tests.rs:106:5 [INFO] [stderr] | [INFO] [stderr] 106 | core.retrieve_and_clear_error().map(|erm| panic!("{:?}", erm)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 106 | if let Some(erm) = core.retrieve_and_clear_error() { $ crate :: rt :: begin_panic_fmt ( [INFO] [stderr] 107 | & format_args ! ( $ fmt , $ ( $ arg ) + ) , & ( [INFO] [stderr] 108 | file ! ( ) , line ! ( ) , __rust_unstable_column ! ( ) ) ) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/db/tests.rs:167:17 [INFO] [stderr] | [INFO] [stderr] 167 | assert!(edit_entries3.len() == 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `edit_entries3.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/db/flo_query.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | fn query_key_frame_times_for_layer_id<'a>(&'a mut self, layer_id: i64, from: Duration, until: Duration) -> Result>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/db/flo_query.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | fn query_nearest_key_frame<'a>(&'a mut self, layer_id: i64, when: Duration) -> Result<(i64, Duration)>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/db/flo_sqlite/query.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | / fn query_key_frame_times_for_layer_id<'a>(&'a mut self, layer_id: i64, from: Duration, until: Duration) -> Result> { [INFO] [stderr] 46 | | let from = Self::get_micros(&from); [INFO] [stderr] 47 | | let until = Self::get_micros(&until); [INFO] [stderr] 48 | | [INFO] [stderr] ... | [INFO] [stderr] 52 | | Ok(rows.collect()) [INFO] [stderr] 53 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/db/flo_sqlite/query.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | / fn query_nearest_key_frame<'a>(&'a mut self, layer_id: i64, when: Duration) -> Result<(i64, Duration)> { [INFO] [stderr] 59 | | self.query_row(FloStatement::SelectNearestKeyFrame, &[&layer_id, &Self::get_micros(&when)], |row| (row.get(0), Self::from_micros(row.get(1)))) [INFO] [stderr] 60 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/db/flo_sqlite/store.rs:15:24 [INFO] [stderr] | [INFO] [stderr] 15 | if self.stack.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/db/flo_sqlite/store.rs:40:50 [INFO] [stderr] | [INFO] [stderr] 40 | set_size.insert(&[&edit_log_id, &(width as f64), &(height as f64)])?; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/db/flo_sqlite/store.rs:40:67 [INFO] [stderr] | [INFO] [stderr] 40 | set_size.insert(&[&edit_log_id, &(width as f64), &(height as f64)])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/db/flo_sqlite/store.rs:107:54 [INFO] [stderr] | [INFO] [stderr] 107 | insert_ink_brush.insert(&[brush_id, &(min_width as f64), &(max_width as f64), &(scale_up_distance as f64)])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(min_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/db/flo_sqlite/store.rs:107:75 [INFO] [stderr] | [INFO] [stderr] 107 | insert_ink_brush.insert(&[brush_id, &(min_width as f64), &(max_width as f64), &(scale_up_distance as f64)])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(max_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/db/flo_sqlite/store.rs:107:96 [INFO] [stderr] | [INFO] [stderr] 107 | insert_ink_brush.insert(&[brush_id, &(min_width as f64), &(max_width as f64), &(scale_up_distance as f64)])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(scale_up_distance)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/db/flo_sqlite/store.rs:114:85 [INFO] [stderr] | [INFO] [stderr] 114 | let brush_props_id = insert_brush_properties.insert(&[&(size as f64), &(opacity as f64), &color_id])?; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/db/flo_sqlite/store.rs:114:101 [INFO] [stderr] | [INFO] [stderr] 114 | let brush_props_id = insert_brush_properties.insert(&[&(size as f64), &(opacity as f64), &color_id])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(opacity)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/db/flo_sqlite/store.rs:130:48 [INFO] [stderr] | [INFO] [stderr] 130 | insert_rgb.insert(&[color_id, &(r as f64), &(g as f64), &(b as f64)])?; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/db/flo_sqlite/store.rs:130:61 [INFO] [stderr] | [INFO] [stderr] 130 | insert_rgb.insert(&[color_id, &(r as f64), &(g as f64), &(b as f64)])?; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(g)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/db/flo_sqlite/store.rs:130:74 [INFO] [stderr] | [INFO] [stderr] 130 | insert_rgb.insert(&[color_id, &(r as f64), &(g as f64), &(b as f64)])?; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/db/flo_sqlite/store.rs:137:50 [INFO] [stderr] | [INFO] [stderr] 137 | insert_hsluv.insert(&[color_id, &(h as f64), &(s as f64), &(l as f64)])?; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(h)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/db/flo_sqlite/store.rs:137:63 [INFO] [stderr] | [INFO] [stderr] 137 | insert_hsluv.insert(&[color_id, &(h as f64), &(s as f64), &(l as f64)])?; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(s)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/db/flo_sqlite/store.rs:137:76 [INFO] [stderr] | [INFO] [stderr] 137 | insert_hsluv.insert(&[color_id, &(h as f64), &(s as f64), &(l as f64)])?; [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(l)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/db/flo_sqlite/store.rs:240:57 [INFO] [stderr] | [INFO] [stderr] 240 | for (point, index) in points.iter().zip((0..num_points).into_iter()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..num_points)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/db/flo_sqlite/store.rs:243:26 [INFO] [stderr] | [INFO] [stderr] 243 | &(point.cp1.0 as f64), &(point.cp1.1 as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(point.cp1.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/db/flo_sqlite/store.rs:243:49 [INFO] [stderr] | [INFO] [stderr] 243 | &(point.cp1.0 as f64), &(point.cp1.1 as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(point.cp1.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/db/flo_sqlite/store.rs:244:26 [INFO] [stderr] | [INFO] [stderr] 244 | &(point.cp2.0 as f64), &(point.cp2.1 as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(point.cp2.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/db/flo_sqlite/store.rs:244:49 [INFO] [stderr] | [INFO] [stderr] 244 | &(point.cp2.0 as f64), &(point.cp2.1 as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(point.cp2.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/db/flo_sqlite/store.rs:245:26 [INFO] [stderr] | [INFO] [stderr] 245 | &(point.position.0 as f64), &(point.position.1 as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(point.position.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/db/flo_sqlite/store.rs:245:54 [INFO] [stderr] | [INFO] [stderr] 245 | &(point.position.0 as f64), &(point.position.1 as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(point.position.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/db/flo_sqlite/store.rs:246:26 [INFO] [stderr] | [INFO] [stderr] 246 | &(point.width as f64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(point.width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/db/flo_sqlite/mod.rs:123:9 [INFO] [stderr] | [INFO] [stderr] 123 | self.stack.len() == 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/db/flo_sqlite/mod.rs:163:27 [INFO] [stderr] | [INFO] [stderr] 163 | let nanos:i64 = when.subsec_nanos() as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(when.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/db/flo_sqlite/mod.rs:293:17 [INFO] [stderr] | [INFO] [stderr] 293 | enum_values.get(&convert_value).map(|val| *val) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `enum_values.get(&convert_value).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/db/db_enum.rs:214:9 [INFO] [stderr] | [INFO] [stderr] 214 | / match t { [INFO] [stderr] 215 | | &SetSize(_, _) => EditLogType::SetSize, [INFO] [stderr] 216 | | &AddNewLayer(_) => EditLogType::AddNewLayer, [INFO] [stderr] 217 | | &RemoveLayer(_) => EditLogType::RemoveLayer, [INFO] [stderr] ... | [INFO] [stderr] 222 | | &Layer(_, Paint(_, BrushStroke(_,_))) => EditLogType::LayerPaintBrushStroke [INFO] [stderr] 223 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 214 | match *t { [INFO] [stderr] 215 | SetSize(_, _) => EditLogType::SetSize, [INFO] [stderr] 216 | AddNewLayer(_) => EditLogType::AddNewLayer, [INFO] [stderr] 217 | RemoveLayer(_) => EditLogType::RemoveLayer, [INFO] [stderr] 218 | Layer(_, AddKeyFrame(_)) => EditLogType::LayerAddKeyFrame, [INFO] [stderr] 219 | Layer(_, RemoveKeyFrame(_)) => EditLogType::LayerRemoveKeyFrame, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/db/db_enum.rs:231:9 [INFO] [stderr] | [INFO] [stderr] 231 | / match t { [INFO] [stderr] 232 | | &Draw => DrawingStyleType::Draw, [INFO] [stderr] 233 | | &Erase => DrawingStyleType::Erase [INFO] [stderr] 234 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 231 | match *t { [INFO] [stderr] 232 | Draw => DrawingStyleType::Draw, [INFO] [stderr] 233 | Erase => DrawingStyleType::Erase [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/db/db_enum.rs:242:9 [INFO] [stderr] | [INFO] [stderr] 242 | / match t { [INFO] [stderr] 243 | | &BrushDefinition(_) => VectorElementType::BrushDefinition, [INFO] [stderr] 244 | | &BrushProperties(_) => VectorElementType::BrushProperties, [INFO] [stderr] 245 | | &BrushStroke(_) => VectorElementType::BrushStroke [INFO] [stderr] 246 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 242 | match *t { [INFO] [stderr] 243 | BrushDefinition(_) => VectorElementType::BrushDefinition, [INFO] [stderr] 244 | BrushProperties(_) => VectorElementType::BrushProperties, [INFO] [stderr] 245 | BrushStroke(_) => VectorElementType::BrushStroke [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/db/db_enum.rs:253:9 [INFO] [stderr] | [INFO] [stderr] 253 | / match t { [INFO] [stderr] 254 | | &Simple => BrushDefinitionType::Simple, [INFO] [stderr] 255 | | &Ink(_) => BrushDefinitionType::Ink [INFO] [stderr] 256 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 253 | match *t { [INFO] [stderr] 254 | Simple => BrushDefinitionType::Simple, [INFO] [stderr] 255 | Ink(_) => BrushDefinitionType::Ink [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/db/editlog.rs:67:14 [INFO] [stderr] | [INFO] [stderr] 67 | .unwrap_or(BrushProperties::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(BrushProperties::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/db/editlog.rs:66:113 [INFO] [stderr] | [INFO] [stderr] 66 | .map(|brush_properties_id| AnimationDbCore::get_brush_properties(&mut core.db, brush_properties_id).unwrap_or(BrushProperties::new())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| BrushProperties::new())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/db/editlog.rs:142:56 [INFO] [stderr] | [INFO] [stderr] 142 | let current_range = indices.next().map(|pos| pos..(pos+1)); [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `pos..=pos` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/db/editlog.rs:153:37 [INFO] [stderr] | [INFO] [stderr] 153 | current_range = next_index..(next_index+1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `next_index..=next_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/db/insert_editlog.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | / match element_id { [INFO] [stderr] 44 | | &Unassigned => { }, [INFO] [stderr] 45 | | &Assigned(id) => { db.update(vec![PushEditLogElementId(id)])?; }, [INFO] [stderr] 46 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 43 | match *element_id { [INFO] [stderr] 44 | Unassigned => { }, [INFO] [stderr] 45 | Assigned(id) => { db.update(vec![PushEditLogElementId(id)])?; }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/db/insert_editlog.rs:54:24 [INFO] [stderr] | [INFO] [stderr] 54 | fn insert_edit_log<'a>(&mut self, edit: &AnimationEdit) -> Result<()> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/db/insert_editlog.rs:67:30 [INFO] [stderr] | [INFO] [stderr] 67 | fn insert_animation_edit<'a>(&mut self, edit: &AnimationEdit) -> Result<()> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/db/insert_editlog.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | / match edit { [INFO] [stderr] 71 | | &Layer(layer_id, ref layer_edit) => { [INFO] [stderr] 72 | | self.db.update(vec![PushEditLogLayer(layer_id)])?; [INFO] [stderr] 73 | | self.insert_layer_edit(layer_edit)?; [INFO] [stderr] ... | [INFO] [stderr] 86 | | } [INFO] [stderr] 87 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 70 | match *edit { [INFO] [stderr] 71 | Layer(layer_id, ref layer_edit) => { [INFO] [stderr] 72 | self.db.update(vec![PushEditLogLayer(layer_id)])?; [INFO] [stderr] 73 | self.insert_layer_edit(layer_edit)?; [INFO] [stderr] 74 | }, [INFO] [stderr] 75 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/db/insert_editlog.rs:95:26 [INFO] [stderr] | [INFO] [stderr] 95 | fn insert_layer_edit<'a>(&mut self, edit: &LayerEdit) -> Result<()> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/db/insert_editlog.rs:98:9 [INFO] [stderr] | [INFO] [stderr] 98 | / match edit { [INFO] [stderr] 99 | | &Paint(when, ref paint_edit) => { [INFO] [stderr] 100 | | self.db.update(vec![PushEditLogWhen(when)])?; [INFO] [stderr] 101 | | self.insert_paint_edit(paint_edit)?; [INFO] [stderr] ... | [INFO] [stderr] 110 | | } [INFO] [stderr] 111 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 98 | match *edit { [INFO] [stderr] 99 | Paint(when, ref paint_edit) => { [INFO] [stderr] 100 | self.db.update(vec![PushEditLogWhen(when)])?; [INFO] [stderr] 101 | self.insert_paint_edit(paint_edit)?; [INFO] [stderr] 102 | } [INFO] [stderr] 103 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/db/insert_editlog.rs:119:26 [INFO] [stderr] | [INFO] [stderr] 119 | fn insert_paint_edit<'a>(&mut self, edit: &PaintEdit) -> Result<()> { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/db/insert_editlog.rs:122:9 [INFO] [stderr] | [INFO] [stderr] 122 | / match edit { [INFO] [stderr] 123 | | &SelectBrush(ref id, ref definition, ref drawing_style) => { [INFO] [stderr] 124 | | Self::insert_element_id(&mut self.db, id)?; [INFO] [stderr] 125 | | Self::insert_brush(&mut self.db, definition)?; [INFO] [stderr] ... | [INFO] [stderr] 138 | | } [INFO] [stderr] 139 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 122 | match *edit { [INFO] [stderr] 123 | SelectBrush(ref id, ref definition, ref drawing_style) => { [INFO] [stderr] 124 | Self::insert_element_id(&mut self.db, id)?; [INFO] [stderr] 125 | Self::insert_brush(&mut self.db, definition)?; [INFO] [stderr] 126 | self.db.update(vec![PopEditLogBrush(DrawingStyleType::from(drawing_style))])?; [INFO] [stderr] 127 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/db/mutable_animation.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | / fn edit_layer<'a>(&'a mut self, layer_id: u64) -> Option> { [INFO] [stderr] 74 | | // Create the layer if one is not already cached [INFO] [stderr] 75 | | let layer = if !self.layers.contains_key(&layer_id) { [INFO] [stderr] 76 | | let new_layer = SqliteVectorLayer::from_assigned_id(&self.core, layer_id); [INFO] [stderr] ... | [INFO] [stderr] 89 | | layer.map(|layer| Editor::new(layer as &mut Layer)) [INFO] [stderr] 90 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/db/mutable_animation.rs:75:21 [INFO] [stderr] | [INFO] [stderr] 75 | let layer = if !self.layers.contains_key(&layer_id) { [INFO] [stderr] | _____________________^ [INFO] [stderr] 76 | | let new_layer = SqliteVectorLayer::from_assigned_id(&self.core, layer_id); [INFO] [stderr] 77 | | [INFO] [stderr] 78 | | if let Some(new_layer) = new_layer { [INFO] [stderr] ... | [INFO] [stderr] 85 | | self.layers.get_mut(&layer_id) [INFO] [stderr] 86 | | }; [INFO] [stderr] | |_________^ help: consider using: `self.layers.entry(layer_id)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/db/color.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | / match color { [INFO] [stderr] 15 | | &Color::Rgba(r, g, b, _) => { [INFO] [stderr] 16 | | db.update(vec![ [INFO] [stderr] 17 | | PushColorType(ColorType::Rgb), [INFO] [stderr] ... | [INFO] [stderr] 27 | | }, [INFO] [stderr] 28 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 14 | match *color { [INFO] [stderr] 15 | Color::Rgba(r, g, b, _) => { [INFO] [stderr] 16 | db.update(vec![ [INFO] [stderr] 17 | PushColorType(ColorType::Rgb), [INFO] [stderr] 18 | PushRgb(r, g, b) [INFO] [stderr] 19 | ]) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/db/brush.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | / match brush_definition { [INFO] [stderr] 13 | | &BrushDefinition::Simple => { [INFO] [stderr] 14 | | db.update(vec![ [INFO] [stderr] 15 | | PushBrushType(BrushDefinitionType::from(brush_definition)), [INFO] [stderr] ... | [INFO] [stderr] 24 | | } [INFO] [stderr] 25 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 12 | match *brush_definition { [INFO] [stderr] 13 | BrushDefinition::Simple => { [INFO] [stderr] 14 | db.update(vec![ [INFO] [stderr] 15 | PushBrushType(BrushDefinitionType::from(brush_definition)), [INFO] [stderr] 16 | ]) [INFO] [stderr] 17 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/db/vector_layer.rs:125:5 [INFO] [stderr] | [INFO] [stderr] 125 | / fn as_vector_layer<'a>(&'a self) -> Option> { [INFO] [stderr] 126 | | let vector_layer = self as &VectorLayer; [INFO] [stderr] 127 | | [INFO] [stderr] 128 | | Some(Reader::new(vector_layer)) [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/db/vector_layer.rs:131:5 [INFO] [stderr] | [INFO] [stderr] 131 | / fn edit_vectors<'a>(&'a mut self) -> Option> { [INFO] [stderr] 132 | | let vector_layer = self as &mut VectorLayer; [INFO] [stderr] 133 | | [INFO] [stderr] 134 | | Some(Editor::new(vector_layer)) [INFO] [stderr] 135 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/db/vector_layer.rs:222:9 [INFO] [stderr] | [INFO] [stderr] 222 | / match new_element { [INFO] [stderr] 223 | | BrushDefinition(ref brush_definition) => { [INFO] [stderr] 224 | | self.active_brush = Some((when, create_brush_from_definition(brush_definition.definition(), brush_definition.drawing_style()))); [INFO] [stderr] 225 | | }, [INFO] [stderr] 226 | | [INFO] [stderr] 227 | | _ => () [INFO] [stderr] 228 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 222 | if let BrushDefinition(ref brush_definition) = new_element { [INFO] [stderr] 223 | self.active_brush = Some((when, create_brush_from_definition(brush_definition.definition(), brush_definition.drawing_style()))); [INFO] [stderr] 224 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/db/vector_frame.rs:141:17 [INFO] [stderr] | [INFO] [stderr] 141 | / match element { [INFO] [stderr] 142 | | &Vector::BrushDefinition(_) => changes_definition = true, [INFO] [stderr] 143 | | _ => () [INFO] [stderr] 144 | | }; [INFO] [stderr] | |_________________^ help: try this: `if let &Vector::BrushDefinition(_) = element { changes_definition = true }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/db/vector_frame.rs:141:17 [INFO] [stderr] | [INFO] [stderr] 141 | / match element { [INFO] [stderr] 142 | | &Vector::BrushDefinition(_) => changes_definition = true, [INFO] [stderr] 143 | | _ => () [INFO] [stderr] 144 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 141 | match *element { [INFO] [stderr] 142 | Vector::BrushDefinition(_) => changes_definition = true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/db/vector_frame.rs:167:17 [INFO] [stderr] | [INFO] [stderr] 167 | / match element { [INFO] [stderr] 168 | | &Vector::BrushProperties(_) => changes_properties = true, [INFO] [stderr] 169 | | _ => () [INFO] [stderr] 170 | | }; [INFO] [stderr] | |_________________^ help: try this: `if let &Vector::BrushProperties(_) = element { changes_properties = true }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/db/vector_frame.rs:167:17 [INFO] [stderr] | [INFO] [stderr] 167 | / match element { [INFO] [stderr] 168 | | &Vector::BrushProperties(_) => changes_properties = true, [INFO] [stderr] 169 | | _ => () [INFO] [stderr] 170 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 167 | match *element { [INFO] [stderr] 168 | Vector::BrushProperties(_) => changes_properties = true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/db/mod.rs:123:5 [INFO] [stderr] | [INFO] [stderr] 123 | / pub fn edit<'a>(&'a self) -> Editor<'a, MutableAnimation> { [INFO] [stderr] 124 | | let editor: &Mutex = &self.editor; [INFO] [stderr] 125 | | let editor = editor.lock().unwrap(); [INFO] [stderr] 126 | | [INFO] [stderr] 127 | | Editor::new(editor) [INFO] [stderr] 128 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/animation_sqlite/tests.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | assert!(anim.get_layer_ids().len() == 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `anim.get_layer_ids().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/animation_sqlite/tests.rs:114:13 [INFO] [stderr] | [INFO] [stderr] 114 | assert!(anim.get_layer_ids().len() == 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `anim.get_layer_ids().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/animation_sqlite/tests.rs:439:13 [INFO] [stderr] | [INFO] [stderr] 439 | assert!(match &paint_edit[0] { &AnimationEdit::Layer(0, LayerEdit::Paint(_, _)) => true, _ => false }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 439 | assert!(match paint_edit[0] { AnimationEdit::Layer(0, LayerEdit::Paint(_, _)) => true, _ => false }); [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/animation_sqlite/tests.rs:442:13 [INFO] [stderr] | [INFO] [stderr] 442 | assert!(match &paint_edit[0] { &AnimationEdit::Layer(0, LayerEdit::Paint(_, PaintEdit::BrushStroke(ElementId::Assigned(_), _))) => true, _ => false }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 442 | assert!(match paint_edit[0] { AnimationEdit::Layer(0, LayerEdit::Paint(_, PaintEdit::BrushStroke(ElementId::Assigned(_), _))) => true, _ => false }); [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/animation_sqlite/tests.rs:485:17 [INFO] [stderr] | [INFO] [stderr] 485 | assert!(match &elements[0] { [INFO] [stderr] | _________________^ [INFO] [stderr] 486 | | &Vector::BrushDefinition(ref defn) => Some(defn.definition()), [INFO] [stderr] 487 | | _ => None [INFO] [stderr] 488 | | } == Some(&BrushDefinition::Ink(InkDefinition::default()))); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 485 | assert!(match elements[0] { [INFO] [stderr] 486 | Vector::BrushDefinition(ref defn) => Some(defn.definition()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/animation_sqlite/tests.rs:490:17 [INFO] [stderr] | [INFO] [stderr] 490 | assert!(match &elements[1] { [INFO] [stderr] | _________________^ [INFO] [stderr] 491 | | &Vector::BrushProperties(ref props) => Some(props.brush_properties()), [INFO] [stderr] 492 | | _ => None [INFO] [stderr] 493 | | } == Some(&BrushProperties { color: Color::Rgba(0.5, 0.2, 0.7, 1.0), opacity: 1.0, size: 32.0 })); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 490 | assert!(match elements[1] { [INFO] [stderr] 491 | Vector::BrushProperties(ref props) => Some(props.brush_properties()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/animation_sqlite/tests.rs:495:17 [INFO] [stderr] | [INFO] [stderr] 495 | assert!(match &elements[3] { [INFO] [stderr] | _________________^ [INFO] [stderr] 496 | | &Vector::BrushStroke(ref brush_stroke) => Some(brush_stroke.points()), [INFO] [stderr] 497 | | _ => None [INFO] [stderr] 498 | | }.is_some()); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 495 | assert!(match elements[3] { [INFO] [stderr] 496 | Vector::BrushStroke(ref brush_stroke) => Some(brush_stroke.points()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/animation_sqlite/tests.rs:500:17 [INFO] [stderr] | [INFO] [stderr] 500 | assert!(match &elements[3] { [INFO] [stderr] | _________________^ [INFO] [stderr] 501 | | &Vector::BrushStroke(ref brush_stroke) => Some(brush_stroke.id()), [INFO] [stderr] 502 | | _ => None [INFO] [stderr] 503 | | } == Some(ElementId::Assigned(127))); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 500 | assert!(match elements[3] { [INFO] [stderr] 501 | Vector::BrushStroke(ref brush_stroke) => Some(brush_stroke.id()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/animation_sqlite/tests.rs:511:17 [INFO] [stderr] | [INFO] [stderr] 511 | assert!(elements.len() == 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `elements.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/animation_sqlite/anim.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | self.retrieve_and_clear_error().map(|erm| panic!("{:?}", erm)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 22 | if let Some(erm) = self.retrieve_and_clear_error() { $ crate :: rt :: begin_panic_fmt ( [INFO] [stderr] 23 | & format_args ! ( $ fmt , $ ( $ arg ) + ) , & ( [INFO] [stderr] 24 | file ! ( ) , line ! ( ) , __rust_unstable_column ! ( ) ) ) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/animation_sqlite/anim.rs:76:5 [INFO] [stderr] | [INFO] [stderr] 76 | / fn get_layer_with_id<'a>(&'a self, layer_id: u64) -> Option> { [INFO] [stderr] 77 | | // Try to retrieve the layer from the editor [INFO] [stderr] 78 | | let layer = self.db.get_layer_with_id(layer_id); [INFO] [stderr] 79 | | [INFO] [stderr] ... | [INFO] [stderr] 86 | | layer.map(|layer| Reader::new(layer)) [INFO] [stderr] 87 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/animation_sqlite/anim.rs:86:19 [INFO] [stderr] | [INFO] [stderr] 86 | layer.map(|layer| Reader::new(layer)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Reader::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/animation_sqlite/anim.rs:89:5 [INFO] [stderr] | [INFO] [stderr] 89 | / fn get_log<'a>(&'a self) -> Reader<'a, EditLog> { [INFO] [stderr] 90 | | self.db.get_log() [INFO] [stderr] 91 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 30.41s [INFO] running `"docker" "inspect" "9236732f694a65fe48d3aa490e5a1c58f35770756f8bdb04540743e589bcbed6"` [INFO] running `"docker" "rm" "-f" "9236732f694a65fe48d3aa490e5a1c58f35770756f8bdb04540743e589bcbed6"` [INFO] [stdout] 9236732f694a65fe48d3aa490e5a1c58f35770756f8bdb04540743e589bcbed6