[INFO] crate flif 0.3.0 is already in cache [INFO] extracting crate flif 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/flif/0.3.0 [INFO] extracting crate flif 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/flif/0.3.0 [INFO] validating manifest of flif-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of flif-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing flif-0.3.0 [INFO] finished frobbing flif-0.3.0 [INFO] frobbed toml for flif-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/flif/0.3.0/Cargo.toml [INFO] started frobbing flif-0.3.0 [INFO] finished frobbing flif-0.3.0 [INFO] frobbed toml for flif-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/flif/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting flif-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/flif/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7a64a35646a138978bd053cc6b67839c3516a8de4a7f199df7ab794be0c88b68 [INFO] running `"docker" "start" "-a" "7a64a35646a138978bd053cc6b67839c3516a8de4a7f199df7ab794be0c88b68"` [INFO] [stderr] Checking flif v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/maniac/mod.rs:378:17 [INFO] [stderr] | [INFO] [stderr] 378 | table: table, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `table` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/numbers/chances.rs:151:5 [INFO] [stderr] | [INFO] [stderr] 151 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/numbers/chances.rs:195:5 [INFO] [stderr] | [INFO] [stderr] 195 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/maniac/mod.rs:378:17 [INFO] [stderr] | [INFO] [stderr] 378 | table: table, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `table` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/numbers/chances.rs:151:5 [INFO] [stderr] | [INFO] [stderr] 151 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/numbers/chances.rs:195:5 [INFO] [stderr] | [INFO] [stderr] 195 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/maniac/mod.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | return self.nodes.len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.nodes.len()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/maniac/mod.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | return self.nodes.len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.nodes.len()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/colors.rs:66:36 [INFO] [stderr] | [INFO] [stderr] 66 | pub(crate) fn contains_channel(&self, channel: Channel) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/components/header.rs:41:18 [INFO] [stderr] | [INFO] [stderr] 41 | let pixels = (frames as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(frames)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/components/header.rs:42:22 [INFO] [stderr] | [INFO] [stderr] 42 | .checked_mul(width as u64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/components/header.rs:43:41 [INFO] [stderr] | [INFO] [stderr] 43 | .and_then(|val| val.checked_mul(height as u64)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/components/transformations/channel_compact.rs:31:22 [INFO] [stderr] | [INFO] [stderr] 31 | for i in 0..t.ranges[c].max + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=t.ranges[c].max` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/components/transformations/mod.rs:68:45 [INFO] [stderr] | [INFO] [stderr] 68 | fn snap(&self, channel: Channel, pixel: &Pixel, value: ColorValue) -> ColorValue { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Pixel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/components/transformations/mod.rs:84:48 [INFO] [stderr] | [INFO] [stderr] 84 | fn crange(&self, channel: Channel, values: &Pixel) -> ColorRange; [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Pixel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/components/transformations/mod.rs:124:64 [INFO] [stderr] | [INFO] [stderr] 124 | let id = Transformation::from_id(rac.read_val(0, 13)?).ok_or(Error::InvalidOperation( [INFO] [stderr] | ________________________________________________________________^ [INFO] [stderr] 125 | | "Invalid transformation identifier read, possibly corrupt file".into(), [INFO] [stderr] 126 | | ))?; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 124 | let id = Transformation::from_id(rac.read_val(0, 13)?).ok_or_else(|| Error::InvalidOperation( [INFO] [stderr] 125 | "Invalid transformation identifier read, possibly corrupt file".into(), [INFO] [stderr] 126 | ))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/maniac/mod.rs:106:9 [INFO] [stderr] | [INFO] [stderr] 106 | / loop { [INFO] [stderr] 107 | | let (index, prange) = match process_stack.pop() { [INFO] [stderr] 108 | | Some(process) => process, [INFO] [stderr] 109 | | _ => break, [INFO] [stderr] ... | [INFO] [stderr] 148 | | result_vec[index] = node; [INFO] [stderr] 149 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(process) = process_stack.pop() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/maniac/mod.rs:113:43 [INFO] [stderr] | [INFO] [stderr] 113 | Err(Error::LimitViolation(format!( [INFO] [stderr] | ___________________________________________^ [INFO] [stderr] 114 | | "number of maniac nodes exceeds limit" [INFO] [stderr] 115 | | )))?; [INFO] [stderr] | |_________________^ help: consider using .to_string(): `"number of maniac nodes exceeds limit".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/maniac/mod.rs:170:41 [INFO] [stderr] | [INFO] [stderr] 170 | Err(Error::InvalidOperation(format!("Invalid maniac tree")))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Invalid maniac tree".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/maniac/mod.rs:204:41 [INFO] [stderr] | [INFO] [stderr] 204 | Err(Error::InvalidOperation(format!("Invalid maniac tree")))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Invalid maniac tree".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/numbers/chances.rs:106:27 [INFO] [stderr] | [INFO] [stderr] 106 | for old_chance in u16::from(cutoff)..(max_chance + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `u16::from(cutoff)..=max_chance` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/numbers/rac.rs:76:45 [INFO] [stderr] | [INFO] [stderr] 76 | (Self::MAX_RANGE_BITS / 8) + if Self::MAX_RANGE_BITS % 8 > 0 { 1 } else { 0 }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because Self::MAX_RANGE_BITS % 8 is the minimum value for this type, this comparison is always false [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `flif`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/colors.rs:66:36 [INFO] [stderr] | [INFO] [stderr] 66 | pub(crate) fn contains_channel(&self, channel: Channel) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/components/header.rs:41:18 [INFO] [stderr] | [INFO] [stderr] 41 | let pixels = (frames as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(frames)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/components/header.rs:42:22 [INFO] [stderr] | [INFO] [stderr] 42 | .checked_mul(width as u64) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/components/header.rs:43:41 [INFO] [stderr] | [INFO] [stderr] 43 | .and_then(|val| val.checked_mul(height as u64)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/components/transformations/channel_compact.rs:31:22 [INFO] [stderr] | [INFO] [stderr] 31 | for i in 0..t.ranges[c].max + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=t.ranges[c].max` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/components/transformations/mod.rs:68:45 [INFO] [stderr] | [INFO] [stderr] 68 | fn snap(&self, channel: Channel, pixel: &Pixel, value: ColorValue) -> ColorValue { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Pixel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/components/transformations/mod.rs:84:48 [INFO] [stderr] | [INFO] [stderr] 84 | fn crange(&self, channel: Channel, values: &Pixel) -> ColorRange; [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Pixel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/components/transformations/mod.rs:124:64 [INFO] [stderr] | [INFO] [stderr] 124 | let id = Transformation::from_id(rac.read_val(0, 13)?).ok_or(Error::InvalidOperation( [INFO] [stderr] | ________________________________________________________________^ [INFO] [stderr] 125 | | "Invalid transformation identifier read, possibly corrupt file".into(), [INFO] [stderr] 126 | | ))?; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 124 | let id = Transformation::from_id(rac.read_val(0, 13)?).ok_or_else(|| Error::InvalidOperation( [INFO] [stderr] 125 | "Invalid transformation identifier read, possibly corrupt file".into(), [INFO] [stderr] 126 | ))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/maniac/mod.rs:106:9 [INFO] [stderr] | [INFO] [stderr] 106 | / loop { [INFO] [stderr] 107 | | let (index, prange) = match process_stack.pop() { [INFO] [stderr] 108 | | Some(process) => process, [INFO] [stderr] 109 | | _ => break, [INFO] [stderr] ... | [INFO] [stderr] 148 | | result_vec[index] = node; [INFO] [stderr] 149 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(process) = process_stack.pop() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/maniac/mod.rs:113:43 [INFO] [stderr] | [INFO] [stderr] 113 | Err(Error::LimitViolation(format!( [INFO] [stderr] | ___________________________________________^ [INFO] [stderr] 114 | | "number of maniac nodes exceeds limit" [INFO] [stderr] 115 | | )))?; [INFO] [stderr] | |_________________^ help: consider using .to_string(): `"number of maniac nodes exceeds limit".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/maniac/mod.rs:170:41 [INFO] [stderr] | [INFO] [stderr] 170 | Err(Error::InvalidOperation(format!("Invalid maniac tree")))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Invalid maniac tree".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/maniac/mod.rs:204:41 [INFO] [stderr] | [INFO] [stderr] 204 | Err(Error::InvalidOperation(format!("Invalid maniac tree")))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Invalid maniac tree".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/numbers/chances.rs:106:27 [INFO] [stderr] | [INFO] [stderr] 106 | for old_chance in u16::from(cutoff)..(max_chance + 1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `u16::from(cutoff)..=max_chance` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `UPDATE_TABLE_FALSE` [INFO] [stderr] --> src/numbers/chances.rs:252:18 [INFO] [stderr] | [INFO] [stderr] 252 | for i in 1..4096 { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 252 | for (i, ) in UPDATE_TABLE_FALSE.iter().enumerate().skip(1) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/numbers/rac.rs:76:45 [INFO] [stderr] | [INFO] [stderr] 76 | (Self::MAX_RANGE_BITS / 8) + if Self::MAX_RANGE_BITS % 8 > 0 { 1 } else { 0 }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because Self::MAX_RANGE_BITS % 8 is the minimum value for this type, this comparison is always false [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `flif`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "7a64a35646a138978bd053cc6b67839c3516a8de4a7f199df7ab794be0c88b68"` [INFO] running `"docker" "rm" "-f" "7a64a35646a138978bd053cc6b67839c3516a8de4a7f199df7ab794be0c88b68"` [INFO] [stdout] 7a64a35646a138978bd053cc6b67839c3516a8de4a7f199df7ab794be0c88b68