[INFO] crate flickr 0.1.1 is already in cache [INFO] extracting crate flickr 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/flickr/0.1.1 [INFO] extracting crate flickr 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/flickr/0.1.1 [INFO] validating manifest of flickr-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of flickr-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing flickr-0.1.1 [INFO] finished frobbing flickr-0.1.1 [INFO] frobbed toml for flickr-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/flickr/0.1.1/Cargo.toml [INFO] started frobbing flickr-0.1.1 [INFO] finished frobbing flickr-0.1.1 [INFO] frobbed toml for flickr-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/flickr/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting flickr-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/flickr/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 11b23871117382719fd667abeeda7ffd05738c6c391ad52eda4bc633be3cdb65 [INFO] running `"docker" "start" "-a" "11b23871117382719fd667abeeda7ffd05738c6c391ad52eda4bc633be3cdb65"` [INFO] [stderr] Checking webbrowser v0.3.1 [INFO] [stderr] Compiling flickr_derive v0.1.1 [INFO] [stderr] Checking tiny_http v0.6.2 [INFO] [stderr] Checking flickr v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/methods/activity.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | flickr: flickr, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `flickr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/methods/auth/oauth.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | flickr: flickr, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `flickr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/methods/auth/mod.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | flickr: flickr, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `flickr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/methods/favorites.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | flickr: flickr, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `flickr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/methods/photos.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | flickr: flickr, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `flickr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/methods/activity.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | flickr: flickr, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `flickr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/methods/auth/oauth.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | flickr: flickr, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `flickr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/methods/auth/mod.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | flickr: flickr, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `flickr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/methods/favorites.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | flickr: flickr, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `flickr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/methods/photos.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | flickr: flickr, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `flickr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/methods/mod.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | return Ok(i); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/methods/mod.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | return Err(de::Error::invalid_value(Unexpected::Str(&""), &"i32 as string",)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(de::Error::invalid_value(Unexpected::Str(&""), &"i32 as string",))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/methods/mod.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | return Ok(Content::deserialize(deserializer)?.content); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Content::deserialize(deserializer)?.content)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/methods/mod.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | return Ok(i); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/methods/mod.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | return Err(de::Error::invalid_value(Unexpected::Str(&""), &"i32 as string",)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(de::Error::invalid_value(Unexpected::Str(&""), &"i32 as string",))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/methods/mod.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | return Ok(utc.with_timezone(&local_tz)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(utc.with_timezone(&local_tz))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/methods/mod.rs:110:13 [INFO] [stderr] | [INFO] [stderr] 110 | return Err(de::Error::invalid_value(Unexpected::Str(&""), &"i64 as string",)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(de::Error::invalid_value(Unexpected::Str(&""), &"i64 as string",))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/methods/mod.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | return Ok(utc.with_timezone(&local_tz)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(utc.with_timezone(&local_tz))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/methods/mod.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | return Err(de::Error::invalid_value(Unexpected::Str(&s), &"mysql date string",)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(de::Error::invalid_value(Unexpected::Str(&s), &"mysql date string",))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/methods/mod.rs:144:13 [INFO] [stderr] | [INFO] [stderr] 144 | return Err(de::Error::invalid_value(Unexpected::Str(&s), &"value",)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(de::Error::invalid_value(Unexpected::Str(&s), &"value",))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:317:9 [INFO] [stderr] | [INFO] [stderr] 317 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:377:9 [INFO] [stderr] | [INFO] [stderr] 377 | return methods::activity::Builder::new(self); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `methods::activity::Builder::new(self)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:382:9 [INFO] [stderr] | [INFO] [stderr] 382 | return methods::auth::Builder::new(self); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `methods::auth::Builder::new(self)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:387:9 [INFO] [stderr] | [INFO] [stderr] 387 | return methods::favorites::Builder::new(self); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `methods::favorites::Builder::new(self)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:392:9 [INFO] [stderr] | [INFO] [stderr] 392 | return methods::photos::Builder::new(self); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `methods::photos::Builder::new(self)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:433:5 [INFO] [stderr] | [INFO] [stderr] 433 | return url_final; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `url_final` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:458:5 [INFO] [stderr] | [INFO] [stderr] 458 | return res; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `res` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:509:5 [INFO] [stderr] | [INFO] [stderr] 509 | return Ok((body, content_type, content_encoding)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((body, content_type, content_encoding))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:522:5 [INFO] [stderr] | [INFO] [stderr] 522 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/methods/activity.rs:188:9 [INFO] [stderr] | [INFO] [stderr] 188 | return flickr; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `flickr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/methods/favorites.rs:257:9 [INFO] [stderr] | [INFO] [stderr] 257 | return flickr; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `flickr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/methods/favorites.rs:318:66 [INFO] [stderr] | [INFO] [stderr] 318 | assert_eq!(photos.photo[0].date_faved, Utc.timestamp(222222, 0)); [INFO] [stderr] | ^^^^^^ help: consider: `222_222` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/methods/favorites.rs:328:66 [INFO] [stderr] | [INFO] [stderr] 328 | assert_eq!(photos.photo[1].date_faved, Utc.timestamp(333333, 0)); [INFO] [stderr] | ^^^^^^ help: consider: `333_333` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/methods/photos.rs:1296:9 [INFO] [stderr] | [INFO] [stderr] 1296 | return flickr; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `flickr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/methods/mod.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | return Ok(i); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/methods/mod.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | return Err(de::Error::invalid_value(Unexpected::Str(&""), &"i32 as string",)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(de::Error::invalid_value(Unexpected::Str(&""), &"i32 as string",))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/methods/mod.rs:65:5 [INFO] [stderr] | [INFO] [stderr] 65 | return Ok(Content::deserialize(deserializer)?.content); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Content::deserialize(deserializer)?.content)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/methods/mod.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | return Ok(i); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/methods/mod.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | return Err(de::Error::invalid_value(Unexpected::Str(&""), &"i32 as string",)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(de::Error::invalid_value(Unexpected::Str(&""), &"i32 as string",))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/methods/mod.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | return Ok(utc.with_timezone(&local_tz)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(utc.with_timezone(&local_tz))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/methods/mod.rs:110:13 [INFO] [stderr] | [INFO] [stderr] 110 | return Err(de::Error::invalid_value(Unexpected::Str(&""), &"i64 as string",)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(de::Error::invalid_value(Unexpected::Str(&""), &"i64 as string",))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/methods/mod.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | return Ok(utc.with_timezone(&local_tz)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(utc.with_timezone(&local_tz))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/methods/mod.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | return Err(de::Error::invalid_value(Unexpected::Str(&s), &"mysql date string",)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(de::Error::invalid_value(Unexpected::Str(&s), &"mysql date string",))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/methods/mod.rs:144:13 [INFO] [stderr] | [INFO] [stderr] 144 | return Err(de::Error::invalid_value(Unexpected::Str(&s), &"value",)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(de::Error::invalid_value(Unexpected::Str(&s), &"value",))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:317:9 [INFO] [stderr] | [INFO] [stderr] 317 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:377:9 [INFO] [stderr] | [INFO] [stderr] 377 | return methods::activity::Builder::new(self); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `methods::activity::Builder::new(self)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:382:9 [INFO] [stderr] | [INFO] [stderr] 382 | return methods::auth::Builder::new(self); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `methods::auth::Builder::new(self)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:387:9 [INFO] [stderr] | [INFO] [stderr] 387 | return methods::favorites::Builder::new(self); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `methods::favorites::Builder::new(self)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:392:9 [INFO] [stderr] | [INFO] [stderr] 392 | return methods::photos::Builder::new(self); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `methods::photos::Builder::new(self)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:433:5 [INFO] [stderr] | [INFO] [stderr] 433 | return url_final; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `url_final` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:458:5 [INFO] [stderr] | [INFO] [stderr] 458 | return res; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `res` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:509:5 [INFO] [stderr] | [INFO] [stderr] 509 | return Ok((body, content_type, content_encoding)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((body, content_type, content_encoding))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:522:5 [INFO] [stderr] | [INFO] [stderr] 522 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/methods/mod.rs:77:34 [INFO] [stderr] | [INFO] [stderr] 77 | Unexpected::Unsigned(other as u64), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(other)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 31 [INFO] [stderr] --> src/lib.rs:135:5 [INFO] [stderr] | [INFO] [stderr] 135 | / fn do_auth(&mut self) -> Result<(), FlickrError> { [INFO] [stderr] 136 | | // From serde point of view this is a better place to set nonce. [INFO] [stderr] 137 | | if self.nonce_suffix == 0 { [INFO] [stderr] 138 | | self.nonce_suffix = (Utc::now().timestamp() as u128) << 64; [INFO] [stderr] ... | [INFO] [stderr] 317 | | return Ok(()); [INFO] [stderr] 318 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:192:21 [INFO] [stderr] | [INFO] [stderr] 192 | / let mut result = HashMap::new(); [INFO] [stderr] 193 | | if content_type == "text/plain" { [INFO] [stderr] 194 | | result = parse_hashmap(&content); [INFO] [stderr] 195 | | } else { [INFO] [stderr] 196 | | return Err(FlickrError::OauthFailed(format!("Unexpected content type: {}", content_type))); [INFO] [stderr] 197 | | } [INFO] [stderr] | |_____________________^ help: it is more idiomatic to write: `let result = if content_type == "text/plain" { parse_hashmap(&content) } else { ..; HashMap::new() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:203:49 [INFO] [stderr] | [INFO] [stderr] 203 | self.token_secret = result.get("oauth_token_secret").unwrap().to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&result["oauth_token_secret"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:242:93 [INFO] [stderr] | [INFO] [stderr] 242 | debug!("Got OAUTH verifier: {}", oauth_verifier.clone().unwrap_or("???".into())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "???".into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:316:40 [INFO] [stderr] | [INFO] [stderr] 316 | self.user_nsid.clone().unwrap_or("".into())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:399:39 [INFO] [stderr] | [INFO] [stderr] 399 | let hostname = get_hostname().unwrap_or("localhost".into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "localhost".into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:416:12 [INFO] [stderr] | [INFO] [stderr] 416 | if url_params.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!url_params.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:421:41 [INFO] [stderr] | [INFO] [stderr] 421 | url_params.push_str(&url_encode(params.get(key).unwrap())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `¶ms[key]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:444:27 [INFO] [stderr] | [INFO] [stderr] 444 | fn hmac_sha1_digest(text: &String, hmac_key_base64: Option<&str>) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/lib.rs:450:23 [INFO] [stderr] | [INFO] [stderr] 450 | let mut gen = OsRng::new().ok().expect("Failed to get OS random generator"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:515:27 [INFO] [stderr] | [INFO] [stderr] 515 | for line in doc.split("\n") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:516:33 [INFO] [stderr] | [INFO] [stderr] 516 | for field in line.split("&") { [INFO] [stderr] | ^^^ help: try using a char instead: `'&'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/lib.rs:527:12 [INFO] [stderr] | [INFO] [stderr] 527 | if let Some(_) = pair.find(sep) { [INFO] [stderr] | _____- ^^^^^^^ [INFO] [stderr] 528 | | let trimmed: String = { [INFO] [stderr] 529 | | if trim { [INFO] [stderr] 530 | | pair.replace("\n", "").replace("\r", "") [INFO] [stderr] ... | [INFO] [stderr] 542 | | return Err("No separator found to parse a key pair"); [INFO] [stderr] 543 | | } [INFO] [stderr] | |_____- help: try this: `if pair.find(sep).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/methods/activity.rs:202:5 [INFO] [stderr] | [INFO] [stderr] 202 | / fn user_photos() { [INFO] [stderr] 203 | | let mut flickr = setup(r#" [INFO] [stderr] 204 | | { [INFO] [stderr] 205 | | "items": { [INFO] [stderr] ... | [INFO] [stderr] 287 | | assert_eq!(r.items.item.get(0).unwrap().activity.event.get(0).unwrap().realname, "event_realname"); [INFO] [stderr] 288 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/activity.rs:263:20 [INFO] [stderr] | [INFO] [stderr] 263 | assert_eq!(r.items.item.get(0).unwrap().r#type, "photo"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&r.items.item[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/activity.rs:264:20 [INFO] [stderr] | [INFO] [stderr] 264 | assert_eq!(r.items.item.get(0).unwrap().id, "item_id"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&r.items.item[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/activity.rs:265:20 [INFO] [stderr] | [INFO] [stderr] 265 | assert_eq!(r.items.item.get(0).unwrap().owner, "item_owner"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&r.items.item[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/activity.rs:266:20 [INFO] [stderr] | [INFO] [stderr] 266 | assert_eq!(r.items.item.get(0).unwrap().ownername, "item_ownername"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&r.items.item[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/activity.rs:267:20 [INFO] [stderr] | [INFO] [stderr] 267 | assert_eq!(r.items.item.get(0).unwrap().realname, "item_realname"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&r.items.item[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/activity.rs:268:20 [INFO] [stderr] | [INFO] [stderr] 268 | assert_eq!(r.items.item.get(0).unwrap().iconserver, "item_iconserver"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&r.items.item[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/activity.rs:269:20 [INFO] [stderr] | [INFO] [stderr] 269 | assert_eq!(r.items.item.get(0).unwrap().iconfarm, 6); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&r.items.item[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/activity.rs:270:20 [INFO] [stderr] | [INFO] [stderr] 270 | assert_eq!(r.items.item.get(0).unwrap().secret, "icon_secret"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&r.items.item[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/activity.rs:271:20 [INFO] [stderr] | [INFO] [stderr] 271 | assert_eq!(r.items.item.get(0).unwrap().server, "icon_server"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&r.items.item[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/activity.rs:272:20 [INFO] [stderr] | [INFO] [stderr] 272 | assert_eq!(r.items.item.get(0).unwrap().farm, 5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&r.items.item[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/activity.rs:273:20 [INFO] [stderr] | [INFO] [stderr] 273 | assert_eq!(r.items.item.get(0).unwrap().title, "icon_title"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&r.items.item[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/activity.rs:274:20 [INFO] [stderr] | [INFO] [stderr] 274 | assert_eq!(r.items.item.get(0).unwrap().media, "icon_media"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&r.items.item[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/activity.rs:275:20 [INFO] [stderr] | [INFO] [stderr] 275 | assert_eq!(r.items.item.get(0).unwrap().comments, 10); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&r.items.item[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/activity.rs:276:20 [INFO] [stderr] | [INFO] [stderr] 276 | assert_eq!(r.items.item.get(0).unwrap().notes, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&r.items.item[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/activity.rs:277:20 [INFO] [stderr] | [INFO] [stderr] 277 | assert_eq!(r.items.item.get(0).unwrap().views, 224); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&r.items.item[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/activity.rs:278:20 [INFO] [stderr] | [INFO] [stderr] 278 | assert_eq!(r.items.item.get(0).unwrap().faves, 6); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&r.items.item[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/activity.rs:279:20 [INFO] [stderr] | [INFO] [stderr] 279 | assert_eq!(r.items.item.get(0).unwrap().activity.event.len(), 2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&r.items.item[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/activity.rs:280:20 [INFO] [stderr] | [INFO] [stderr] 280 | assert_eq!(r.items.item.get(0).unwrap().activity.event.get(0).unwrap().r#type, "fave"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&r.items.item.get(0).unwrap().activity.event[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/activity.rs:280:20 [INFO] [stderr] | [INFO] [stderr] 280 | assert_eq!(r.items.item.get(0).unwrap().activity.event.get(0).unwrap().r#type, "fave"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&r.items.item[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/activity.rs:281:20 [INFO] [stderr] | [INFO] [stderr] 281 | assert_eq!(r.items.item.get(0).unwrap().activity.event.get(0).unwrap().user, "event_user"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&r.items.item.get(0).unwrap().activity.event[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/activity.rs:281:20 [INFO] [stderr] | [INFO] [stderr] 281 | assert_eq!(r.items.item.get(0).unwrap().activity.event.get(0).unwrap().user, "event_user"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&r.items.item[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/activity.rs:282:20 [INFO] [stderr] | [INFO] [stderr] 282 | assert_eq!(r.items.item.get(0).unwrap().activity.event.get(0).unwrap().username, "event_username"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&r.items.item.get(0).unwrap().activity.event[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/activity.rs:282:20 [INFO] [stderr] | [INFO] [stderr] 282 | assert_eq!(r.items.item.get(0).unwrap().activity.event.get(0).unwrap().username, "event_username"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&r.items.item[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/activity.rs:283:20 [INFO] [stderr] | [INFO] [stderr] 283 | assert_eq!(r.items.item.get(0).unwrap().activity.event.get(0).unwrap().iconserver, "event_iconserver"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&r.items.item.get(0).unwrap().activity.event[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/activity.rs:283:20 [INFO] [stderr] | [INFO] [stderr] 283 | assert_eq!(r.items.item.get(0).unwrap().activity.event.get(0).unwrap().iconserver, "event_iconserver"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&r.items.item[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/activity.rs:284:20 [INFO] [stderr] | [INFO] [stderr] 284 | assert_eq!(r.items.item.get(0).unwrap().activity.event.get(0).unwrap().iconfarm, 4); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&r.items.item.get(0).unwrap().activity.event[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/activity.rs:284:20 [INFO] [stderr] | [INFO] [stderr] 284 | assert_eq!(r.items.item.get(0).unwrap().activity.event.get(0).unwrap().iconfarm, 4); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&r.items.item[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/activity.rs:285:20 [INFO] [stderr] | [INFO] [stderr] 285 | assert_eq!(r.items.item.get(0).unwrap().activity.event.get(0).unwrap().dateadded, Local.ymd(2018, 12, 4).and_hms(4, 36, 4)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&r.items.item.get(0).unwrap().activity.event[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/activity.rs:285:20 [INFO] [stderr] | [INFO] [stderr] 285 | assert_eq!(r.items.item.get(0).unwrap().activity.event.get(0).unwrap().dateadded, Local.ymd(2018, 12, 4).and_hms(4, 36, 4)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&r.items.item[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/activity.rs:286:20 [INFO] [stderr] | [INFO] [stderr] 286 | assert_eq!(r.items.item.get(0).unwrap().activity.event.get(0).unwrap().is_muted, None); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&r.items.item.get(0).unwrap().activity.event[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/activity.rs:286:20 [INFO] [stderr] | [INFO] [stderr] 286 | assert_eq!(r.items.item.get(0).unwrap().activity.event.get(0).unwrap().is_muted, None); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&r.items.item[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/activity.rs:287:20 [INFO] [stderr] | [INFO] [stderr] 287 | assert_eq!(r.items.item.get(0).unwrap().activity.event.get(0).unwrap().realname, "event_realname"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&r.items.item.get(0).unwrap().activity.event[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/activity.rs:287:20 [INFO] [stderr] | [INFO] [stderr] 287 | assert_eq!(r.items.item.get(0).unwrap().activity.event.get(0).unwrap().realname, "event_realname"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&r.items.item[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 35 [INFO] [stderr] --> src/methods/favorites.rs:261:5 [INFO] [stderr] | [INFO] [stderr] 261 | / fn get_lists() { [INFO] [stderr] 262 | | let mut flickr = setup(r#" [INFO] [stderr] 263 | | { [INFO] [stderr] 264 | | "photos": { [INFO] [stderr] ... | [INFO] [stderr] 342 | | } [INFO] [stderr] 343 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 29 [INFO] [stderr] --> src/methods/favorites.rs:346:5 [INFO] [stderr] | [INFO] [stderr] 346 | / fn get_context() { [INFO] [stderr] 347 | | let mut flickr = setup(r#" [INFO] [stderr] 348 | | { [INFO] [stderr] 349 | | "count": { [INFO] [stderr] ... | [INFO] [stderr] 417 | | } [INFO] [stderr] 418 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1376:20 [INFO] [stderr] | [INFO] [stderr] 1376 | assert_eq!(r.set.get(0).unwrap().title, "set_1_title"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `&r.set[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1377:20 [INFO] [stderr] | [INFO] [stderr] 1377 | assert_eq!(r.set.get(0).unwrap().id, "set_1_id"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `&r.set[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1378:20 [INFO] [stderr] | [INFO] [stderr] 1378 | assert_eq!(r.pool.get(0).unwrap().title, "pool_1_title"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&r.pool[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1379:20 [INFO] [stderr] | [INFO] [stderr] 1379 | assert_eq!(r.pool.get(0).unwrap().id, "pool_1_id"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&r.pool[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1380:20 [INFO] [stderr] | [INFO] [stderr] 1380 | assert_eq!(r.pool.get(0).unwrap().url, "pool_1_url"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&r.pool[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1381:20 [INFO] [stderr] | [INFO] [stderr] 1381 | assert_eq!(r.pool.get(1).unwrap().title, "pool_2_title"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&r.pool[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1382:20 [INFO] [stderr] | [INFO] [stderr] 1382 | assert_eq!(r.pool.get(1).unwrap().id, "pool_2_id"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&r.pool[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1383:20 [INFO] [stderr] | [INFO] [stderr] 1383 | assert_eq!(r.pool.get(1).unwrap().url, "pool_2_url"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&r.pool[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1421:24 [INFO] [stderr] | [INFO] [stderr] 1421 | assert_eq!(photos.photo.get(0).unwrap().id, "photo_1_id"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1422:24 [INFO] [stderr] | [INFO] [stderr] 1422 | assert_eq!(photos.photo.get(0).unwrap().secret, "photo_1_secret"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1423:24 [INFO] [stderr] | [INFO] [stderr] 1423 | assert_eq!(photos.photo.get(0).unwrap().server, "photo_1_server"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1424:24 [INFO] [stderr] | [INFO] [stderr] 1424 | assert_eq!(photos.photo.get(0).unwrap().farm, 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1425:24 [INFO] [stderr] | [INFO] [stderr] 1425 | assert_eq!(photos.photo.get(0).unwrap().owner, "photo_1_owner"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1426:24 [INFO] [stderr] | [INFO] [stderr] 1426 | assert_eq!(photos.photo.get(0).unwrap().username, "photo_1_username"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1427:24 [INFO] [stderr] | [INFO] [stderr] 1427 | assert_eq!(photos.photo.get(0).unwrap().title, "photo_1_title"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1428:24 [INFO] [stderr] | [INFO] [stderr] 1428 | assert_eq!(photos.photo.get(0).unwrap().ispublic, true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1429:24 [INFO] [stderr] | [INFO] [stderr] 1429 | assert_eq!(photos.photo.get(0).unwrap().isfriend, true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1430:24 [INFO] [stderr] | [INFO] [stderr] 1430 | assert_eq!(photos.photo.get(0).unwrap().isfamily, true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1483:24 [INFO] [stderr] | [INFO] [stderr] 1483 | assert_eq!(photos.photo.get(0).unwrap().id, "photo_1_id"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1484:24 [INFO] [stderr] | [INFO] [stderr] 1484 | assert_eq!(photos.photo.get(0).unwrap().secret, "photo_1_secret"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1485:24 [INFO] [stderr] | [INFO] [stderr] 1485 | assert_eq!(photos.photo.get(0).unwrap().server, "photo_1_server"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1486:24 [INFO] [stderr] | [INFO] [stderr] 1486 | assert_eq!(photos.photo.get(0).unwrap().farm, 5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1487:24 [INFO] [stderr] | [INFO] [stderr] 1487 | assert_eq!(photos.photo.get(0).unwrap().owner, "photo_1_owner"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1488:24 [INFO] [stderr] | [INFO] [stderr] 1488 | assert_eq!(photos.photo.get(0).unwrap().username, "photo_1_username"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1489:24 [INFO] [stderr] | [INFO] [stderr] 1489 | assert_eq!(photos.photo.get(0).unwrap().title, "photo_1_title"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1490:24 [INFO] [stderr] | [INFO] [stderr] 1490 | assert_eq!(photos.photo.get(0).unwrap().ispublic, true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1491:24 [INFO] [stderr] | [INFO] [stderr] 1491 | assert_eq!(photos.photo.get(0).unwrap().isfriend, true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1492:24 [INFO] [stderr] | [INFO] [stderr] 1492 | assert_eq!(photos.photo.get(0).unwrap().isfamily, true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1493:24 [INFO] [stderr] | [INFO] [stderr] 1493 | assert_eq!(photos.photo.get(1).unwrap().id, "photo_2_id"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1526:24 [INFO] [stderr] | [INFO] [stderr] 1526 | assert_eq!(photocounts.photocount.get(0).unwrap().count, 4); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photocounts.photocount[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1578:24 [INFO] [stderr] | [INFO] [stderr] 1578 | assert_eq!(photo.exif.get(0).unwrap().tagspace, "exif_1_space"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photo.exif[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1579:24 [INFO] [stderr] | [INFO] [stderr] 1579 | assert_eq!(photo.exif.get(0).unwrap().tagspaceid, 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photo.exif[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1580:24 [INFO] [stderr] | [INFO] [stderr] 1580 | assert_eq!(photo.exif.get(0).unwrap().label, "exif_1_label"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photo.exif[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1581:24 [INFO] [stderr] | [INFO] [stderr] 1581 | assert_eq!(photo.exif.get(0).unwrap().raw, "exif_1_raw"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photo.exif[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 50 [INFO] [stderr] --> src/methods/photos.rs:1639:5 [INFO] [stderr] | [INFO] [stderr] 1639 | / fn get_info() { [INFO] [stderr] 1640 | | let mut flickr = setup(r#" [INFO] [stderr] 1641 | | { [INFO] [stderr] 1642 | | "photo": { [INFO] [stderr] ... | [INFO] [stderr] 1789 | | } [INFO] [stderr] 1790 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1780:24 [INFO] [stderr] | [INFO] [stderr] 1780 | assert_eq!(p.tags.tag.get(0).unwrap().id, "tag_id"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&p.tags.tag[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1781:24 [INFO] [stderr] | [INFO] [stderr] 1781 | assert_eq!(p.tags.tag.get(0).unwrap().author, "tag_author"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&p.tags.tag[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1782:24 [INFO] [stderr] | [INFO] [stderr] 1782 | assert_eq!(p.tags.tag.get(0).unwrap().authorname, "tag_authorname"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&p.tags.tag[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1783:24 [INFO] [stderr] | [INFO] [stderr] 1783 | assert_eq!(p.tags.tag.get(0).unwrap().raw, "tag_raw"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&p.tags.tag[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1784:24 [INFO] [stderr] | [INFO] [stderr] 1784 | assert_eq!(p.tags.tag.get(0).unwrap().content, "tag_content"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&p.tags.tag[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1785:24 [INFO] [stderr] | [INFO] [stderr] 1785 | assert_eq!(p.tags.tag.get(0).unwrap().machine_tag, 999); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&p.tags.tag[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1786:24 [INFO] [stderr] | [INFO] [stderr] 1786 | assert_eq!(p.urls.url.get(0).unwrap().r#type, "photopage"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&p.urls.url[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1787:24 [INFO] [stderr] | [INFO] [stderr] 1787 | assert_eq!(p.urls.url.get(0).unwrap().content, "http://abc.cde"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&p.urls.url[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1841:24 [INFO] [stderr] | [INFO] [stderr] 1841 | assert_eq!(photos.photo.get(0).unwrap().id, "photo_1_id"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1842:24 [INFO] [stderr] | [INFO] [stderr] 1842 | assert_eq!(photos.photo.get(0).unwrap().owner, "photo_1_owner"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1843:24 [INFO] [stderr] | [INFO] [stderr] 1843 | assert_eq!(photos.photo.get(0).unwrap().secret, "photo_1_secret"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1844:24 [INFO] [stderr] | [INFO] [stderr] 1844 | assert_eq!(photos.photo.get(0).unwrap().server, "photo_1_server"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1845:24 [INFO] [stderr] | [INFO] [stderr] 1845 | assert_eq!(photos.photo.get(0).unwrap().farm, 4); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1846:24 [INFO] [stderr] | [INFO] [stderr] 1846 | assert_eq!(photos.photo.get(0).unwrap().title, "photo_1_title"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1847:24 [INFO] [stderr] | [INFO] [stderr] 1847 | assert_eq!(photos.photo.get(0).unwrap().ispublic, true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1848:24 [INFO] [stderr] | [INFO] [stderr] 1848 | assert_eq!(photos.photo.get(0).unwrap().isfriend, true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1849:24 [INFO] [stderr] | [INFO] [stderr] 1849 | assert_eq!(photos.photo.get(0).unwrap().isfamily, true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1850:24 [INFO] [stderr] | [INFO] [stderr] 1850 | assert_eq!(photos.photo.get(1).unwrap().id, "photo_2_id"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1851:24 [INFO] [stderr] | [INFO] [stderr] 1851 | assert_eq!(photos.photo.get(1).unwrap().ispublic, false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1852:24 [INFO] [stderr] | [INFO] [stderr] 1852 | assert_eq!(photos.photo.get(1).unwrap().isfriend, false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1853:24 [INFO] [stderr] | [INFO] [stderr] 1853 | assert_eq!(photos.photo.get(1).unwrap().isfamily, false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1939:24 [INFO] [stderr] | [INFO] [stderr] 1939 | assert_eq!(photos.photo.get(0).unwrap().id, "photo_1_id"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1940:24 [INFO] [stderr] | [INFO] [stderr] 1940 | assert_eq!(photos.photo.get(0).unwrap().owner, "photo_1_owner"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1941:24 [INFO] [stderr] | [INFO] [stderr] 1941 | assert_eq!(photos.photo.get(0).unwrap().secret, "photo_1_secret"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1942:24 [INFO] [stderr] | [INFO] [stderr] 1942 | assert_eq!(photos.photo.get(0).unwrap().server, "photo_1_server"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1943:24 [INFO] [stderr] | [INFO] [stderr] 1943 | assert_eq!(photos.photo.get(0).unwrap().farm, 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1944:24 [INFO] [stderr] | [INFO] [stderr] 1944 | assert_eq!(photos.photo.get(0).unwrap().title, "photo_1_title"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1945:24 [INFO] [stderr] | [INFO] [stderr] 1945 | assert_eq!(photos.photo.get(0).unwrap().ispublic, true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1946:24 [INFO] [stderr] | [INFO] [stderr] 1946 | assert_eq!(photos.photo.get(0).unwrap().isfriend, true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1947:24 [INFO] [stderr] | [INFO] [stderr] 1947 | assert_eq!(photos.photo.get(0).unwrap().isfamily, true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1948:24 [INFO] [stderr] | [INFO] [stderr] 1948 | assert_eq!(photos.photo.get(1).unwrap().id, "photo_2_id"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1949:24 [INFO] [stderr] | [INFO] [stderr] 1949 | assert_eq!(photos.photo.get(1).unwrap().ispublic, false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1950:24 [INFO] [stderr] | [INFO] [stderr] 1950 | assert_eq!(photos.photo.get(1).unwrap().isfriend, false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1951:24 [INFO] [stderr] | [INFO] [stderr] 1951 | assert_eq!(photos.photo.get(1).unwrap().isfamily, false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1996:24 [INFO] [stderr] | [INFO] [stderr] 1996 | assert_eq!(sizes.size.get(0).unwrap().label, "Square"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&sizes.size[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1997:24 [INFO] [stderr] | [INFO] [stderr] 1997 | assert_eq!(sizes.size.get(0).unwrap().width, 75); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&sizes.size[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1998:24 [INFO] [stderr] | [INFO] [stderr] 1998 | assert_eq!(sizes.size.get(0).unwrap().height, 75); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&sizes.size[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:1999:24 [INFO] [stderr] | [INFO] [stderr] 1999 | assert_eq!(sizes.size.get(0).unwrap().source, "https://123456"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&sizes.size[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:2000:24 [INFO] [stderr] | [INFO] [stderr] 2000 | assert_eq!(sizes.size.get(0).unwrap().url, "https://7890"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&sizes.size[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:2001:24 [INFO] [stderr] | [INFO] [stderr] 2001 | assert_eq!(sizes.size.get(0).unwrap().media, "photo"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&sizes.size[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:2002:24 [INFO] [stderr] | [INFO] [stderr] 2002 | assert_eq!(sizes.size.get(1).unwrap().label, "Square"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&sizes.size[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:2003:24 [INFO] [stderr] | [INFO] [stderr] 2003 | assert_eq!(sizes.size.get(1).unwrap().width, 75); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&sizes.size[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:2004:24 [INFO] [stderr] | [INFO] [stderr] 2004 | assert_eq!(sizes.size.get(1).unwrap().height, 75); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&sizes.size[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:2005:24 [INFO] [stderr] | [INFO] [stderr] 2005 | assert_eq!(sizes.size.get(1).unwrap().source, "https://1234567"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&sizes.size[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:2006:24 [INFO] [stderr] | [INFO] [stderr] 2006 | assert_eq!(sizes.size.get(1).unwrap().url, "https://78901"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&sizes.size[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:2007:24 [INFO] [stderr] | [INFO] [stderr] 2007 | assert_eq!(sizes.size.get(1).unwrap().media, "photo"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&sizes.size[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:2060:24 [INFO] [stderr] | [INFO] [stderr] 2060 | assert_eq!(photos.photo.get(0).unwrap().id, "photo_1_id"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:2061:24 [INFO] [stderr] | [INFO] [stderr] 2061 | assert_eq!(photos.photo.get(0).unwrap().owner, "photo_1_owner"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:2062:24 [INFO] [stderr] | [INFO] [stderr] 2062 | assert_eq!(photos.photo.get(0).unwrap().secret, "photo_1_secret"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:2063:24 [INFO] [stderr] | [INFO] [stderr] 2063 | assert_eq!(photos.photo.get(0).unwrap().server, "photo_1_server"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:2064:24 [INFO] [stderr] | [INFO] [stderr] 2064 | assert_eq!(photos.photo.get(0).unwrap().farm, 4); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:2065:24 [INFO] [stderr] | [INFO] [stderr] 2065 | assert_eq!(photos.photo.get(0).unwrap().title, "photo_1_title"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:2066:24 [INFO] [stderr] | [INFO] [stderr] 2066 | assert_eq!(photos.photo.get(0).unwrap().ispublic, true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:2067:24 [INFO] [stderr] | [INFO] [stderr] 2067 | assert_eq!(photos.photo.get(0).unwrap().isfriend, true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:2068:24 [INFO] [stderr] | [INFO] [stderr] 2068 | assert_eq!(photos.photo.get(0).unwrap().isfamily, true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:2069:24 [INFO] [stderr] | [INFO] [stderr] 2069 | assert_eq!(photos.photo.get(1).unwrap().id, "photo_2_id"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:2070:24 [INFO] [stderr] | [INFO] [stderr] 2070 | assert_eq!(photos.photo.get(1).unwrap().ispublic, false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:2071:24 [INFO] [stderr] | [INFO] [stderr] 2071 | assert_eq!(photos.photo.get(1).unwrap().isfriend, false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:2072:24 [INFO] [stderr] | [INFO] [stderr] 2072 | assert_eq!(photos.photo.get(1).unwrap().isfamily, false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:2125:24 [INFO] [stderr] | [INFO] [stderr] 2125 | assert_eq!(photos.photo.get(0).unwrap().id, "photo_1_id"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:2126:24 [INFO] [stderr] | [INFO] [stderr] 2126 | assert_eq!(photos.photo.get(0).unwrap().owner, "photo_1_owner"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:2127:24 [INFO] [stderr] | [INFO] [stderr] 2127 | assert_eq!(photos.photo.get(0).unwrap().secret, "photo_1_secret"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:2128:24 [INFO] [stderr] | [INFO] [stderr] 2128 | assert_eq!(photos.photo.get(0).unwrap().server, "photo_1_server"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:2129:24 [INFO] [stderr] | [INFO] [stderr] 2129 | assert_eq!(photos.photo.get(0).unwrap().farm, 4); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:2130:24 [INFO] [stderr] | [INFO] [stderr] 2130 | assert_eq!(photos.photo.get(0).unwrap().title, "photo_1_title"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:2131:24 [INFO] [stderr] | [INFO] [stderr] 2131 | assert_eq!(photos.photo.get(0).unwrap().ispublic, true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:2132:24 [INFO] [stderr] | [INFO] [stderr] 2132 | assert_eq!(photos.photo.get(0).unwrap().isfriend, true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:2133:24 [INFO] [stderr] | [INFO] [stderr] 2133 | assert_eq!(photos.photo.get(0).unwrap().isfamily, true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:2134:24 [INFO] [stderr] | [INFO] [stderr] 2134 | assert_eq!(photos.photo.get(1).unwrap().id, "photo_2_id"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:2135:24 [INFO] [stderr] | [INFO] [stderr] 2135 | assert_eq!(photos.photo.get(1).unwrap().ispublic, false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:2136:24 [INFO] [stderr] | [INFO] [stderr] 2136 | assert_eq!(photos.photo.get(1).unwrap().isfriend, false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:2137:24 [INFO] [stderr] | [INFO] [stderr] 2137 | assert_eq!(photos.photo.get(1).unwrap().isfamily, false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:2190:24 [INFO] [stderr] | [INFO] [stderr] 2190 | assert_eq!(photos.photo.get(0).unwrap().id, "photo_1_id"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:2191:24 [INFO] [stderr] | [INFO] [stderr] 2191 | assert_eq!(photos.photo.get(0).unwrap().owner, "photo_1_owner"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:2192:24 [INFO] [stderr] | [INFO] [stderr] 2192 | assert_eq!(photos.photo.get(0).unwrap().secret, "photo_1_secret"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:2193:24 [INFO] [stderr] | [INFO] [stderr] 2193 | assert_eq!(photos.photo.get(0).unwrap().server, "photo_1_server"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:2194:24 [INFO] [stderr] | [INFO] [stderr] 2194 | assert_eq!(photos.photo.get(0).unwrap().farm, 4); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:2195:24 [INFO] [stderr] | [INFO] [stderr] 2195 | assert_eq!(photos.photo.get(0).unwrap().title, "photo_1_title"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:2196:24 [INFO] [stderr] | [INFO] [stderr] 2196 | assert_eq!(photos.photo.get(0).unwrap().ispublic, true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:2197:24 [INFO] [stderr] | [INFO] [stderr] 2197 | assert_eq!(photos.photo.get(0).unwrap().isfriend, true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:2198:24 [INFO] [stderr] | [INFO] [stderr] 2198 | assert_eq!(photos.photo.get(0).unwrap().isfamily, true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:2199:24 [INFO] [stderr] | [INFO] [stderr] 2199 | assert_eq!(photos.photo.get(1).unwrap().id, "photo_2_id"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:2200:24 [INFO] [stderr] | [INFO] [stderr] 2200 | assert_eq!(photos.photo.get(1).unwrap().ispublic, false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:2201:24 [INFO] [stderr] | [INFO] [stderr] 2201 | assert_eq!(photos.photo.get(1).unwrap().isfriend, false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:2202:24 [INFO] [stderr] | [INFO] [stderr] 2202 | assert_eq!(photos.photo.get(1).unwrap().isfamily, false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:2255:24 [INFO] [stderr] | [INFO] [stderr] 2255 | assert_eq!(photos.photo.get(0).unwrap().id, "photo_1_id"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:2256:24 [INFO] [stderr] | [INFO] [stderr] 2256 | assert_eq!(photos.photo.get(0).unwrap().owner, "photo_1_owner"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:2257:24 [INFO] [stderr] | [INFO] [stderr] 2257 | assert_eq!(photos.photo.get(0).unwrap().secret, "photo_1_secret"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:2258:24 [INFO] [stderr] | [INFO] [stderr] 2258 | assert_eq!(photos.photo.get(0).unwrap().server, "photo_1_server"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:2259:24 [INFO] [stderr] | [INFO] [stderr] 2259 | assert_eq!(photos.photo.get(0).unwrap().farm, 4); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:2260:24 [INFO] [stderr] | [INFO] [stderr] 2260 | assert_eq!(photos.photo.get(0).unwrap().title, "photo_1_title"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:2261:24 [INFO] [stderr] | [INFO] [stderr] 2261 | assert_eq!(photos.photo.get(0).unwrap().ispublic, true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:2262:24 [INFO] [stderr] | [INFO] [stderr] 2262 | assert_eq!(photos.photo.get(0).unwrap().isfriend, true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:2263:24 [INFO] [stderr] | [INFO] [stderr] 2263 | assert_eq!(photos.photo.get(0).unwrap().isfamily, true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:2264:24 [INFO] [stderr] | [INFO] [stderr] 2264 | assert_eq!(photos.photo.get(1).unwrap().id, "photo_2_id"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:2265:24 [INFO] [stderr] | [INFO] [stderr] 2265 | assert_eq!(photos.photo.get(1).unwrap().ispublic, false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:2266:24 [INFO] [stderr] | [INFO] [stderr] 2266 | assert_eq!(photos.photo.get(1).unwrap().isfriend, false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/methods/photos.rs:2267:24 [INFO] [stderr] | [INFO] [stderr] 2267 | assert_eq!(photos.photo.get(1).unwrap().isfamily, false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&photos.photo[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/methods/proc_tests.rs:53:12 [INFO] [stderr] | [INFO] [stderr] 53 | Ok(s.into()) [INFO] [stderr] | ^^^^^^^^ help: consider removing `.into()`: `s` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/methods/mod.rs:77:34 [INFO] [stderr] | [INFO] [stderr] 77 | Unexpected::Unsigned(other as u64), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(other)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 31 [INFO] [stderr] --> src/lib.rs:135:5 [INFO] [stderr] | [INFO] [stderr] 135 | / fn do_auth(&mut self) -> Result<(), FlickrError> { [INFO] [stderr] 136 | | // From serde point of view this is a better place to set nonce. [INFO] [stderr] 137 | | if self.nonce_suffix == 0 { [INFO] [stderr] 138 | | self.nonce_suffix = (Utc::now().timestamp() as u128) << 64; [INFO] [stderr] ... | [INFO] [stderr] 317 | | return Ok(()); [INFO] [stderr] 318 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:192:21 [INFO] [stderr] | [INFO] [stderr] 192 | / let mut result = HashMap::new(); [INFO] [stderr] 193 | | if content_type == "text/plain" { [INFO] [stderr] 194 | | result = parse_hashmap(&content); [INFO] [stderr] 195 | | } else { [INFO] [stderr] 196 | | return Err(FlickrError::OauthFailed(format!("Unexpected content type: {}", content_type))); [INFO] [stderr] 197 | | } [INFO] [stderr] | |_____________________^ help: it is more idiomatic to write: `let result = if content_type == "text/plain" { parse_hashmap(&content) } else { ..; HashMap::new() };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:203:49 [INFO] [stderr] | [INFO] [stderr] 203 | self.token_secret = result.get("oauth_token_secret").unwrap().to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&result["oauth_token_secret"]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:242:93 [INFO] [stderr] | [INFO] [stderr] 242 | debug!("Got OAUTH verifier: {}", oauth_verifier.clone().unwrap_or("???".into())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "???".into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:316:40 [INFO] [stderr] | [INFO] [stderr] 316 | self.user_nsid.clone().unwrap_or("".into())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:399:39 [INFO] [stderr] | [INFO] [stderr] 399 | let hostname = get_hostname().unwrap_or("localhost".into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "localhost".into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:416:12 [INFO] [stderr] | [INFO] [stderr] 416 | if url_params.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!url_params.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:421:41 [INFO] [stderr] | [INFO] [stderr] 421 | url_params.push_str(&url_encode(params.get(key).unwrap())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `¶ms[key]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lib.rs:444:27 [INFO] [stderr] | [INFO] [stderr] 444 | fn hmac_sha1_digest(text: &String, hmac_key_base64: Option<&str>) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/lib.rs:450:23 [INFO] [stderr] | [INFO] [stderr] 450 | let mut gen = OsRng::new().ok().expect("Failed to get OS random generator"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:515:27 [INFO] [stderr] | [INFO] [stderr] 515 | for line in doc.split("\n") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:516:33 [INFO] [stderr] | [INFO] [stderr] 516 | for field in line.split("&") { [INFO] [stderr] | ^^^ help: try using a char instead: `'&'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/lib.rs:527:12 [INFO] [stderr] | [INFO] [stderr] 527 | if let Some(_) = pair.find(sep) { [INFO] [stderr] | _____- ^^^^^^^ [INFO] [stderr] 528 | | let trimmed: String = { [INFO] [stderr] 529 | | if trim { [INFO] [stderr] 530 | | pair.replace("\n", "").replace("\r", "") [INFO] [stderr] ... | [INFO] [stderr] 542 | | return Err("No separator found to parse a key pair"); [INFO] [stderr] 543 | | } [INFO] [stderr] | |_____- help: try this: `if pair.find(sep).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 16.93s [INFO] running `"docker" "inspect" "11b23871117382719fd667abeeda7ffd05738c6c391ad52eda4bc633be3cdb65"` [INFO] running `"docker" "rm" "-f" "11b23871117382719fd667abeeda7ffd05738c6c391ad52eda4bc633be3cdb65"` [INFO] [stdout] 11b23871117382719fd667abeeda7ffd05738c6c391ad52eda4bc633be3cdb65